remote_syslog_sender 1.2.1 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: cc17b2dbd91abbead6c61c461c5ba7b7556d1303
-  data.tar.gz: 535a792d4ac47f8695aabe9c6bd72f08d169572e
+SHA256:
+  metadata.gz: 67116c7c062c29695d8dbb49e4e64e18d11e09cc2264f98df7068a5bd58526c4
+  data.tar.gz: fbc035c2bbec6efa7a996f1a7346a8ecb85681633cebdadae024dd0d91e54e97
 SHA512:
-  metadata.gz: 77f3853d6c9ce1903e8c6bc4bc7bfd2775bb66a98a1841ec1832982b0631dd2e9cc959a76640afb1f8b61e9024b8aa76f373247381407c445f2fac6083aa26c0
-  data.tar.gz: 35bd18ceafbbc39945b3718a2bc3ac66abf8b4f018abdb03b7d8eeb8da8c452f34d90ed3c697949df12d14e6e9d317befcee1f964e95ac59c724202985699ce5
+  metadata.gz: 8f421c3fe765bd079eb597c62917364405b3903db9a9b644bdcdcd2e7a862ef83e87ad38c9a4a1aa9a67a03a140dbf2807f3110d72dbfaf505c01fe205b13ce6
+  data.tar.gz: 85affc08e19f6126954f5b5bc2fc694360bb069019c3db77b0e6807d013351bedb0f5ecf901fd5450d84763b3a138308350a5da91b3dad1a340818b485e8d62f

data/README.md

@@ -1,6 +1,6 @@
 # Remote Syslog Sender
 
-This gem is syslog sender that is extracted from (papertrail/remote_syslog_logger)[https://github.com/papertrail/remote_syslog_logger]
+This gem is syslog sender that is extracted from [papertrail/remote_syslog_logger](https://github.com/papertrail/remote_syslog_logger)
 
 This can send message to remote syslog server via UDP, TCP, TCP+TLS.
 (Original does not support TCP, TCP+TLS protocol).

data/lib/remote_syslog_sender/tcp_sender.rb

@@ -1,3 +1,4 @@
+require 'ipaddr'
 require 'socket'
 require 'syslog_protocol'
 require 'remote_syslog_sender/sender'
@@ -20,6 +21,8 @@ module RemoteSyslogSender
       @timeout_exception   = !!options[:timeout_exception]
       @exponential_backoff = !!options[:exponential_backoff]
 
+      @remote_hostname_is_ipaddr = IPAddr.new(remote_hostname) rescue false
+
       @mutex = Mutex.new
       @tcp_socket = nil
 
@@ -68,9 +71,12 @@ module RemoteSyslogSender
             context.verify_mode = @verify_mode if @verify_mode
 
             @socket = OpenSSL::SSL::SSLSocket.new(@tcp_socket, context)
+            @socket.hostname = @remote_hostname unless @remote_hostname_is_ipaddr
             @socket.connect
-            @socket.post_connection_check(@remote_hostname)
-            raise "verification error" if @socket.verify_result != OpenSSL::X509::V_OK
+            if @verify_mode != OpenSSL::SSL::VERIFY_NONE
+              @socket.post_connection_check(@remote_hostname)
+              raise "verification error" if @socket.verify_result != OpenSSL::X509::V_OK
+            end
           else
             @socket = @tcp_socket
           end

data/remote_syslog_sender.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name              = 'remote_syslog_sender'
-  s.version           = '1.2.1'
+  s.version           = '1.2.3'
   s.summary     = "Message sender that sends directly to a remote syslog endpoint"
   s.description = "Message sender that sends directly to a remote syslog endpoint (Support UDP, TCP, TCP+TLS)"
 
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency 'syslog_protocol'
 
-  s.add_development_dependency "bundler", "~> 1.6"
+  s.add_development_dependency "bundler", ">= 1.6"
   s.add_development_dependency "rake"
   s.add_development_dependency "test-unit"
 end

data/test/helper.rb

@@ -10,3 +10,4 @@ end
 require 'remote_syslog_sender'
 
 require 'test/unit'
+require 'openssl'

data/test/test_remote_syslog_logger.rb

@@ -64,3 +64,73 @@ class TestRemoteSyslogSender < Test::Unit::TestCase
     assert_match(/This is the second line/, message)
   end
 end
+
+class TestRemoteSyslogTLSSender < Test::Unit::TestCase
+  def setup
+    @key = OpenSSL::PKey::RSA.new(2048)
+    @cert = OpenSSL::X509::Certificate.new
+    @cert.version = 2
+    @cert.serial = 1
+    @cert.subject = OpenSSL::X509::Name.parse("/CN=localhost")
+    @cert.issuer = @cert.subject
+    @cert.public_key = @key.public_key
+    @cert.not_before = Time.now
+    @cert.not_after = Time.now + 3600
+    @cert.sign(@key, OpenSSL::Digest::SHA256.new)
+
+    tcp_server = TCPServer.open('127.0.0.1', 0)
+    @tcp_server_port = tcp_server.addr[1]
+
+    ctx = OpenSSL::SSL::SSLContext.new
+    ctx.cert = @cert
+    ctx.key = @key
+
+    @ssl_server = OpenSSL::SSL::SSLServer.new(tcp_server, ctx)
+
+    @tcp_server_wait_thread = Thread.start do
+      @ssl_server.accept
+    end
+  end
+
+  def teardown
+    @ssl_server.close
+  end
+
+  def test_sender_tls_no_sni
+    @sender = RemoteSyslogSender::TcpSender.new(
+      '127.0.0.1',
+      @tcp_server_port,
+      tls: true,
+      verify_mode: OpenSSL::SSL::VERIFY_NONE
+    )
+
+    @sender.write "This is a test"
+    sock = @tcp_server_wait_thread.value
+
+    message, _ = *sock.read_nonblock(256)
+    assert_match(/This is a test/, message)
+
+    # When remote hostname is an IP address, SNI hostname is not set.
+    socket = @sender.instance_variable_get(:@socket)
+    assert_nil(socket.hostname)
+  end
+
+  def test_sender_tls_sni
+    @sender = RemoteSyslogSender::TcpSender.new(
+      'localhost',
+      @tcp_server_port,
+      tls: true,
+      verify_mode: OpenSSL::SSL::VERIFY_NONE
+    )
+
+    @sender.write "This is a test"
+    sock = @tcp_server_wait_thread.value
+
+    message, _ = *sock.read_nonblock(256)
+    assert_match(/This is a test/, message)
+
+    # When remote hostname is a hostname, SNI hostname is not set.
+    socket = @sender.instance_variable_get(:@socket)
+    assert_equal('localhost', socket.hostname)
+  end
+end

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: remote_syslog_sender
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.3
 platform: ruby
 authors:
 - Tomohiro Hashidate
 - Eric Lindvall
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-15 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: syslog_protocol
@@ -29,14 +28,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
@@ -89,7 +88,6 @@ files:
 homepage: https://github.com/reproio/remote_syslog_logger
 licenses: []
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -104,9 +102,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
-signing_key: 
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Message sender that sends directly to a remote syslog endpoint
 test_files: