remotable 0.6.4 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22d6df302d76f75f9abe3c32936decb50fde62e5c5daafadab330c06f4c1d4d8
-  data.tar.gz: 78c86070eab49ff4a2f9165d25e2a7d7e029d32406efc5486e14734e67d2ef2b
+  metadata.gz: 322b872afa0abda8c2ce3ea8b971e22caf3ebb6df5899c4cd714ff0377277074
+  data.tar.gz: 7e2b9f0c28207accc89f1e61197d95f8812d64d52d05c2d5761b52add73f4334
 SHA512:
-  metadata.gz: 15f59309c923c6ec21ec559852e65be75faeebd1c711eccffe09766451bb692e024b4eaa431614b27c9dc8f37c721213563951f2159030b7ce523865e26b5179
-  data.tar.gz: 6baecf50d8df1c784b82352aed90ec4af6bfb83b0c81e004ccd5e2309d42a0c72f3f2067c17aaf34217fd848223fc0e74f26247de4a0fa97fd5056d8949a1f18
+  metadata.gz: 27cbf3c0b06b7aac4f44a193d2cff1cf7b304e4fb110fb033768c1722537bb37d423e10c8868dab64a70224ca8c73dd93ddf2f7e99385a89f628f451d0637bd6
+  data.tar.gz: e8906f1de4fe996a7a91964194b10bcc39cc05c0ee5aab632806d3f592c0f34057d6c1e8e66aacd9142b8cec159fba8ba1f373825a459792477fc9f86e35b673

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+### 0.7.0
+* **Bugfix** Ensured ActiveRecord models were using Nosync's `ClassMethods` instead of the non-threadsafe `InstanceMethods`
+
 ### 0.6.4
 * **Feature** Added `Remotable.unsafe_nosync!` method to set `nosync` globally using a class variable. As the method name indicates, this is not threadsafe and should only be used for testing or other situations where thread safety is not an issue.
 * **Bugfix** Stopped deferring to `Thread.main` if `nosync` was unset on the current thread; while convenient for tests (see above), it ended up allowing requests to leak state if they were handled on the main thread.

data/lib/remotable/active_record_extender.rb

@@ -17,6 +17,16 @@ module Remotable
 
 
     included do
+      extend Nosync
+
+      # Has to be re-defined _after_ Nosync is extended, which cannot
+      # be done as part of the ClassMethods module
+      def self.nosync?
+        return true if remote_model.nil?
+        return super if nosync_value?
+        Remotable.nosync?
+      end
+
       before_update   :update_remote_resource,  :unless => :nosync?
       before_create   :create_remote_resource,  :unless => :nosync?
       before_destroy  :destroy_remote_resource, :unless => :nosync?
@@ -41,16 +51,10 @@ module Remotable
 
 
     module ClassMethods
-      include Nosync
 
       attr_accessor :_remote_attribute_map, :_local_attribute_routes, :_expires_after,
         :_remote_timeout, :remotable_skip_validation_on_sync
 
-      def nosync?
-        return true if remote_model.nil?
-        return super if nosync_value?
-        Remotable.nosync?
-      end
 
       # Sets the key with which a resource is identified remotely.
       # If no remote key is set, the remote key is assumed to be :id.

data/lib/remotable/version.rb

@@ -1,3 +1,3 @@
 module Remotable
-  VERSION = "0.6.4"
+  VERSION = "0.7.0"
 end

data/test/remotable_test.rb

@@ -170,4 +170,17 @@ class RemotableTest < ActiveSupport::TestCase
   end
 
 
+
+  # ========================================================================= #
+  # ActiveRecordExtender                                                      #
+  # ========================================================================= #
+
+  test "should extend an ActiveRecord subclass with Nosync class methods" do
+    class Example5 < ActiveRecord::Base; self.table_name = "tenants"; end
+    Example5.remote_model BespokeModel.new
+    # Method is _only_ on the class version
+    assert Example5.respond_to?(:unsafe_nosync!)
+  end
+
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: remotable
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.7.0
 platform: ruby
 authors:
 - Robert Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-27 00:00:00.000000000 Z
+date: 2020-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource