remotable 0.6.3 → 0.6.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0bc89a5dd898f5030f0ced00996be9fe97cf9f56f4817b664feff997b45be1eb
-  data.tar.gz: 317441824b1507700cd77f17a8a623a472145ee458a3aa6fc68e820f2a0ae1c9
+  metadata.gz: 22d6df302d76f75f9abe3c32936decb50fde62e5c5daafadab330c06f4c1d4d8
+  data.tar.gz: 78c86070eab49ff4a2f9165d25e2a7d7e029d32406efc5486e14734e67d2ef2b
 SHA512:
-  metadata.gz: 69072c80830b9bad844d0d1e2347875577c9de503edc8c0b5c28898e2f9612d5697e089365bd8e554e4dc53375445ba6a813d3c2d8df4619873c72ae327dc1cf
-  data.tar.gz: 8b5c7e8760947917691c089d19004b8c665f9fa5abaa35873fe9d203247a832f882ee10e7c39059f249aa34133cf8e79140c745aaf3c2bf082e43495d3187583
+  metadata.gz: 15f59309c923c6ec21ec559852e65be75faeebd1c711eccffe09766451bb692e024b4eaa431614b27c9dc8f37c721213563951f2159030b7ce523865e26b5179
+  data.tar.gz: 6baecf50d8df1c784b82352aed90ec4af6bfb83b0c81e004ccd5e2309d42a0c72f3f2067c17aaf34217fd848223fc0e74f26247de4a0fa97fd5056d8949a1f18

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+### 0.6.4
+* **Feature** Added `Remotable.unsafe_nosync!` method to set `nosync` globally using a class variable. As the method name indicates, this is not threadsafe and should only be used for testing or other situations where thread safety is not an issue.
+* **Bugfix** Stopped deferring to `Thread.main` if `nosync` was unset on the current thread; while convenient for tests (see above), it ended up allowing requests to leak state if they were handled on the main thread.
+
+
 ### 0.6.3
 * **Fix** Replaced deprecated calls to URI.escape
 

data/lib/remotable/nosync.rb

@@ -50,8 +50,14 @@ module Remotable
     module ClassMethods
       include InstanceMethods
 
+      def unsafe_nosync!
+        nosync!
+        @_unsafe_nosync = true
+      end
+
       def reset_nosync!
         self.nosync = nil
+        remove_instance_variable :@_unsafe_nosync if instance_variable_defined? :@_unsafe_nosync
       end
 
       def nosync=(val)
@@ -62,7 +68,7 @@ module Remotable
 
       def _nosync
         return Thread.current.thread_variable_get "remotable.nosync.#{self.object_id}" if nosync_defined_on?(Thread.current)
-        return Thread.main.thread_variable_get "remotable.nosync.#{self.object_id}" if nosync_defined_on?(Thread.main)
+        @_unsafe_nosync if instance_variable_defined?(:@_unsafe_nosync)
       end
 
       def _nosync=(value)

data/lib/remotable/version.rb

@@ -1,3 +1,3 @@
 module Remotable
-  VERSION = "0.6.3"
+  VERSION = "0.6.4"
 end

data/test/nosync_test.rb

@@ -48,11 +48,9 @@ class NoSyncTest < ActiveSupport::TestCase
     assert_equal true, Tenant.nosync?
   end
 
-  test "nosync? should defer to the main thread's value if set there but not on the current thread" do
+  test "nosync? should not defer to the main thread's value if set there but not on the current thread" do
     Remotable.nosync!
     subthread = Thread.new do
-      assert Remotable.nosync?
-      Remotable.reset_nosync!
       refute Remotable.nosync?
       Thread.stop
     end
@@ -60,6 +58,16 @@ class NoSyncTest < ActiveSupport::TestCase
     assert Remotable.nosync?
   end
 
+  test "unsafe_nosync! should coerce nosync? to true across threads" do
+    Remotable.unsafe_nosync!
+    subthread = Thread.new do
+      assert Remotable.nosync?
+      Thread.stop
+    end
+    sleep 0.1 while subthread.status != "sleep"
+    assert Remotable.nosync?
+  end
+
 
 
   # ========================================================================= #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: remotable
 version: !ruby/object:Gem::Version
-  version: 0.6.3
+  version: 0.6.4
 platform: ruby
 authors:
 - Robert Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-20 00:00:00.000000000 Z
+date: 2020-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource