remotable 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb1390c1e1b04414cc0c44807a064f1d5d879c891a01988abcd7b919d9d53f37
-  data.tar.gz: 5f5b316b09904143182ba07de7225f1151328bc1dd12b52a3e5797b0b1f8dc03
+  metadata.gz: 137c22fc6804e7a6d4261c63b139287c06aa44020f315318982d9c301cac6676
+  data.tar.gz: caaef13d6e976628e0d94d6dc0a5c615c1a50b14e48b1b66f4d2393e179b2548
 SHA512:
-  metadata.gz: ef0d217377d44f7ea675da8ff0faf6718654502abec68cc2f388bc1d1ab95ecf7325aa20733608575d51842390510e9799326149b7ab31b075bcc8fe9902e188
-  data.tar.gz: 134e43c05eb6da221d66d1ae14bdb93f42d89c22a7b32336d505a81c3ad11e18f63ca5e52ca7838cebb52035221abbd9638473aa32c2bdef310c84bbd39e687c
+  metadata.gz: af3a795753d0f1dd53964c02355cc37845228316f3c2361fc9cca3270baede2355f63d88b997e43a93df320930072d1a3bac8a4038795aa4b9322aaaef9ad921
+  data.tar.gz: 42bb95792ed9035a6b4766b4370852ef27b17ceebce9a24d98bc43aac766057ddd67d493a420e2526f0a12e8022f6efe260a21b64e491a6e0a1ef033ec2b538b

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# Changelog
+
+### 0.5.1
+* **Bugfix** Addressed an issue where `Remotable.with_remote_model` could leave a model with the wrong `remote_model` when used in a multithreaded environment.
+
+***
+
+_TODO: Backfill for previous releases_

data/lib/remotable.rb

@@ -5,6 +5,7 @@ require "remotable/validate_models"
 require "remotable/with_remote_model_proxy"
 require "remotable/errors"
 require "remotable/logger_wrapper"
+require "active_resource/threadsafe_attributes"
 
 
 # Remotable keeps a locally-stored ActiveRecord
@@ -36,6 +37,7 @@ require "remotable/logger_wrapper"
 module Remotable
   extend Nosync
   extend ValidateModels
+  include ThreadsafeAttributes
 
   # By default, Remotable will validate the models you
   # supply it via +remote_model+. You can set validate_models
@@ -53,6 +55,8 @@ module Remotable
     Remotable.log_level = :debug
   end
 
+  threadsafe_attribute :_remote_model, :__remotable_included
+
 
 
   # == remote_model( model [optional] )
@@ -88,17 +92,17 @@ module Remotable
   #
   def remote_model(*args)
     if args.length >= 1
-      @remote_model = args.first
+      self._remote_model = args.first
 
-      @__remotable_included ||= begin
+      self.__remotable_included ||= begin
         require "remotable/active_record_extender"
         include Remotable::ActiveRecordExtender
         true
       end
 
-      extend_remote_model(@remote_model) if @remote_model
+      extend_remote_model(_remote_model) if _remote_model
     end
-    @remote_model
+    _remote_model
   end
 
 

data/lib/remotable/version.rb

@@ -1,3 +1,3 @@
 module Remotable
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

data/test/remotable_test.rb

@@ -1,6 +1,7 @@
 require "test_helper"
 require "remotable"
 require "support/bespoke"
+require "support/concurrently"
 
 
 class RemotableTest < ActiveSupport::TestCase
@@ -57,6 +58,24 @@ class RemotableTest < ActiveSupport::TestCase
     end
   end
 
+  test "should support temporary models in a threaded environment" do
+    first_slug = "404"
+    second_slug = "405"
+
+    afterwards do
+      BespokeTenant.where(slug: [ first_slug, second_slug ]).delete_all
+    end
+
+    concurrently do
+      assert_nil BespokeTenant.find_by_slug(first_slug), "Expected not to find the first model initially"
+      assert_not_nil BespokeTenant.with_remote_model(BespokeModel2.new) {
+        BespokeTenant.find_by_slug(first_slug)
+        sleep rand
+      }, "Expected to find the first model with the temporary tenant"
+      assert_nil BespokeTenant.find_by_slug(second_slug), "Expected not to find the second model when searching with the original model again"
+    end
+  end
+
 
 
   # ========================================================================= #

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: remotable
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Robert Lail
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-04 00:00:00.000000000 Z
+date: 2020-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -232,6 +232,7 @@ files:
 - ".simplecov"
 - ".travis.yml"
 - Appraisals
+- CHANGELOG.md
 - Gemfile
 - MIT-LICENSE
 - README.mdown
@@ -289,7 +290,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Binds an ActiveRecord model to a remote resource and keeps the two synchronized