remocon 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: b4880ea48bc2d1036aaa7ff6a2aecb5559b229e156362a5780c58ccaec9d2e52
-  data.tar.gz: d8362315682a507256267c3127c4f56a152dc66a61bec218af9398e935166c2b
+SHA1:
+  metadata.gz: 58b35965e13809b6a9cb50faf6687db01d97a654
+  data.tar.gz: d08d352a433fb43423893bc481736508e23781c3
 SHA512:
-  metadata.gz: 2197306cb1c04a5e9b5635319a68694a7f8d559744ebb0e2d46e29c977a8f456722f6e1169eea5097919b829777d2c367fbe67bc2823f3d188b8bf8bca790f0e
-  data.tar.gz: 8c538816d4cefe387361ec4e067a6ea5a04c664d994450e6567ad98263cbb93aa7e15fe94c4bbc355653056dc76335bfab232254f615eb65a8494410554d6496
+  metadata.gz: 94a3bdf29de030d03e4e6f63a7a6a61f14695d29cd8e4b82d6f2bf2e4042a92860e663125d152a6bd7bbef8671b891b9a741fa6f5b9511a040d98b5bb417e3c5
+  data.tar.gz: 6438d1ccd13cd73c6fee406c411c8dbc0b2018f5f39b39fbf5af3d02abe1483ae6e86fcf6bdc73e113a5761508bc6f97e27e801830ba2e07f336243c70226a2a

data/.gitignore

@@ -311,3 +311,5 @@ modules.xml
 
 
 # End of https://www.gitignore.io/api/rubymine+all,rubymine+iml
+
+firebase-adminsdk.json

data/.rubocop.yml

@@ -1,70 +1,178 @@
+# Defaults can be found here: https://github.com/bbatsov/rubocop/blob/master/config/default.yml
+
+# If you don't like these settings, just delete this file :)
+
 AllCops:
   Exclude:
-    - '*.gemspec'
     - 'vendor/**/*'
-    - 'Gemfile'
-    - 'Rakefile'
+    - 'spec/fixtures/**/*'
+    - 'tmp/**/*'
+  TargetRubyVersion: 2.3.7
 
-Style/Documentation:
+Metrics/ModuleLength:
   Exclude:
     - 'spec/**/*'
-    - 'test/**/*'
+  Enabled: true
 
-Metrics/LineLength:
-  Max: 150
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+  Enabled: true
+
+# kind_of? is a good way to check a type
+Style/ClassCheck:
+  EnforcedStyle: kind_of?
+
+# It's better to be more explicit about the type
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+# specs sometimes have useless assignments, which is fine
+Lint/UselessAssignment:
   Exclude:
-    - "spec/**/*"
+    - '**/spec/**/*'
+
+# We could potentially enable the 2 below:
+Layout/IndentHash:
+  Enabled: false
+
+Layout/AlignHash:
+  Enabled: false
+
+# HoundCI doesn't like this rule
+Layout/DotPosition:
+  Enabled: false
+
+# We allow !! as it's an easy way to convert ot boolean
+Style/DoubleNegation:
+  Enabled: false
+
+# Cop supports --auto-correct.
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+# We want to allow class Fastlane::Class
+Style/ClassAndModuleChildren:
+  Enabled: false
 
 Metrics/AbcSize:
+  Max: 60
+
+# The %w might be confusing for new users
+Style/WordArray:
+  MinSize: 19
+
+# raise and fail are both okay
+Style/SignalException:
   Enabled: false
 
-Metrics/ClassLength:
+# Better too much 'return' than one missing
+Style/RedundantReturn:
   Enabled: false
 
-Metrics/CyclomaticComplexity:
+# Having if in the same line might not always be good
+Style/IfUnlessModifier:
   Enabled: false
 
-Metrics/MethodLength:
+# and and or is okay
+Style/AndOr:
   Enabled: false
 
-Metrics/ModuleLength:
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 350
+
+Metrics/CyclomaticComplexity:
+  Max: 17
+
+# Configuration parameters: AllowURI, URISchemes.
+Metrics/LineLength:
+  Max: 370
+
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 10
+
+Metrics/PerceivedComplexity:
+  Max: 18
+
+# Sometimes it's easier to read without guards
+Style/GuardClause:
   Enabled: false
 
-Style/BracesAroundHashParameters:
+# something = if something_else
+# that's confusing
+Style/ConditionalAssignment:
   Enabled: false
 
+# Better to have too much self than missing a self
+Style/RedundantSelf:
+  Enabled: false
+
+Metrics/MethodLength:
+  Max: 60
+
+# We're not there yet
 Style/Documentation:
   Enabled: false
 
-Style/EachWithObject:
+# Adds complexity
+Style/IfInsideElse:
   Enabled: false
 
-Style/LineEndConcatenation:
+# danger specific
+
+Style/BlockComments:
   Enabled: false
 
-Style/MutableConstant:
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+
+# FIXME: 25
+Metrics/BlockLength:
+  Max: 345
+  Exclude:
+    - "**/*_spec.rb"
+
+Style/MixinGrouping:
   Enabled: false
 
-Style/NumericLiterals:
+Style/FileName:
   Enabled: false
 
-Style/ParallelAssignment:
+Layout/IndentHeredoc:
   Enabled: false
 
-Style/RedundantSelf:
+Style/SpecialGlobalVars:
   Enabled: false
 
-Style/RegexpLiteral:
-  Enabled: true
+PercentLiteralDelimiters:
+  PreferredDelimiters:
+    "%":  ()
+    "%i": ()
+    "%q": ()
+    "%Q": ()
+    "%r": "{}"
+    "%s": ()
+    "%w": ()
+    "%W": ()
+    "%x": ()
 
-Style/StringLiterals:
+Security/YAMLLoad:
   Enabled: false
 
-Style/SymbolProc:
+Style/TrailingCommaInArguments:
+  Enabled: true
+
+Style/TrailingCommaInArrayLiteral:
   Enabled: false
 
-Style/UnneededPercentQ:
+Style/TrailingCommaInHashLiteral:
   Enabled: false
 
-Style/PerlBackrefs:
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'vendor/**/*'
+    - 'spec/**/*'
+
+Security/Open:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.0
+2.3.7

data/.travis.yml

@@ -1,13 +1,18 @@
 sudo: false
 language: ruby
+
+cache:
+  directories: vendor/bundle
+
 rvm:
-  - 2.5.0
+  - 2.3.7
+  - 2.4.4
+  - 2.5.1
+
 env:
   global:
     - FIREBASE_PROJECT_ID='project_id'
     - REMOTE_CONFIG_ACCESS_TOKEN='token'
 before_install: gem install bundler -v 1.16.1
-install: bundle install --deployment --jobs=4 --retry=3
-cache:
-  directories: vendor/bundle
+install: bundle install --deployment --jobs=4 --retry=3 --path=vendor/bundle
 script: bundle exec rake spec

data/Gemfile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 

data/Gemfile.lock

@@ -1,61 +1,63 @@
 PATH
   remote: .
   specs:
-    remocon (0.1.0)
+    remocon (0.2.0)
       activesupport
       thor
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.1.5)
+    activesupport (5.2.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (~> 0.7)
+      i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     ast (2.4.0)
     coderay (1.1.2)
     concurrent-ruby (1.0.5)
     diff-lcs (1.3)
-    i18n (0.9.5)
+    i18n (1.1.0)
       concurrent-ruby (~> 1.0)
+    jaro_winkler (1.5.1)
     method_source (0.9.0)
     minitest (5.11.3)
     parallel (1.12.1)
-    parser (2.5.0.4)
+    parser (2.5.1.2)
       ast (~> 2.4.0)
-    powerpack (0.1.1)
+    powerpack (0.1.2)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
     rainbow (3.0.0)
     rake (10.5.0)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.0)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
-    rubocop (0.53.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.0)
+    rubocop (0.58.2)
+      jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
-      parser (>= 2.5)
+      parser (>= 2.5, != 2.5.1.1)
       powerpack (~> 0.1)
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.9.0)
+    ruby-progressbar (1.10.0)
     thor (0.20.0)
     thread_safe (0.3.6)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
-    unicode-display_width (1.3.0)
+    unicode-display_width (1.4.0)
 
 PLATFORMS
   ruby
@@ -69,4 +71,4 @@ DEPENDENCIES
   rubocop
 
 BUNDLED WITH
-   1.16.1
+   1.16.3

data/README.md

@@ -7,19 +7,27 @@ Conditions and parameters are managed by YAML files.
 
 ## Usage
 
-You need to get an access token for your firebase project.
+To get an access token, `bin/get_access_token <firebase adminsdk json>` would help you.
+
+### Get the current configs into your local
 
 ```bash
-export FIREBASE_PROJECT_ID='your project id'
-export REMOTE_CONFIG_ACCESS_TOKEN='your access token'
+bundle exec remocon pull --prefix=projects --id=my_project_dev --token=xyz
 ```
 
-### Get the current configs into your local
+Then, you can see `paremeters.yml, conditions.yml, config.json, etag` files in `projects/my_project_dev` directory.  
+If you don't specify `--prefix`, then the command create the files in the working directory
+
+*Environment variables*
+
+Some variables can be injected by environment variables.
 
 ```bash
-bundle exec remocon pull --dest=${path to dir}
+export REMOCON_FIREBASE_PROJECT_ID=<--id>
+export REMOCON_FIREBASE_ACCESS_TOKEN=<--token>
+export REMOCON_PREFIX=<--prefix> # Optional
 
-# you can see ${path to dir}/${FIREBASE_PROJECT_ID}/{paremeters.yml, conditions.yml, config.json, etag}
+FIREBASE_PROJECT_ID and REMOTE_CONFIG_ACCESS_TOKEN are supported but they are deprecated now
 ```
 
 ### Edit configs on your local
@@ -52,7 +60,17 @@ key1: # key name
 ### Update configs on remote
 
 ```bash
-bundle exec remocon push --source=${path to a json file} --etag=${string or path to a file}
+# Create new configs as projects/my_project_dev/config.json
+bundle exec remocon create --prefix=projects --id=my_project_dev
+
+# Upload projects/my_project_dev/config.json by using projects/my_project_dev/etag
+bundle exec remocon push --prefix=projects --id=my_project_dev --token=xyz
+
+# You can use custom paths for config.json and etag
+bundle exec remocon push --source=</path/to/config json> --etag=</path/to/etag>
+
+# Use the fixed etag value
+bundle exec remocon push --raw_etag=<raw etag value>
 ```
 
 ## Installation
@@ -82,6 +100,10 @@ key:
 
 It seems only three fields are supported by Remote Config. They are name, expression and tagColor.
 
+## Supported Ruby Version 
+
+Not EOL versions. ref https://www.ruby-lang.org/en/downloads/branches/
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/jmatsu/remocon .

data/Rakefile

@@ -1,6 +1,19 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
+
+RSpec::Core::RakeTask.new(:specs)
+
+task default: :specs
 
-RSpec::Core::RakeTask.new(:spec)
+task :spec do
+  Rake::Task["specs"].invoke
+  Rake::Task["rubocop"].invoke
+end
 
-task :default => :spec
+desc "Run RuboCop on the lib/specs directory"
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.patterns = ["lib/**/*.rb", "spec/**/*.rb"]
+end

data/bin/console

@@ -1,8 +1,8 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
 
-require 'bundler/setup'
-require 'remocon'
+require "bundler/setup"
+require "remocon"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -11,5 +11,5 @@ require 'remocon'
 # require "pry"
 # Pry.start
 
-require 'irb'
+require "irb"
 IRB.start(__FILE__)