rematch 3.2.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 150055b455fefcd4f49e818c38c57241acc07afb1fa2ce70e22e35c9df9c19b8
-  data.tar.gz: 52eed7dc443edbc90bb932a48d019d7871fce611d07bff83f663c798716066b0
+  metadata.gz: 18b629b32aa8af9d7c9218946f7467630f68e639930942b44a94f5bea4c77f8a
+  data.tar.gz: a49dbb4d655e006ab36147a0b94b6b6d125c436f148e2d4dcf876a621ec6f274
 SHA512:
-  metadata.gz: 62464af5e1e8f5b770f6a33014eda611d2ad6a835321fba1b9f717e9efad38db36dd5ddf2694b50321f6b2695a2bf191655285b2471a038d62765659d51c872a
-  data.tar.gz: bf035d5b5ffa367dded7aedb2177a09825476894498f3ab7f5050b9bc05487365e624fcaecc7d4c78b7f4f45e499594518e76b27192967ce75df4b82d690a41d
+  metadata.gz: 8c80817ea424ed8be19329fb01bb6d13a027eedf6aa5e3d20175fec32b5e6413eb4fb311f1fbae0c7fbe64a28f0ed90a00b2ab45199d064ac703d67f2af25dad
+  data.tar.gz: e2fbe2c78ae7c19f06412256485b14f4511f0c790586943c31aa6cf3a2a1bff7d7da66d1406470069645490a6af0ef89a870896c34fcca02f19774cf815ec509

data/lib/minitest/rematch_plugin.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'rematch'
-require 'minitest/spec'
 
 # Implement the minitest plugin
 module Minitest
@@ -23,50 +22,37 @@ module Minitest
     # Create the rematch object for each test
     def after_setup
       super
-      @rematch = Rematch.new(path: method(name).source_location.first,
-                             id: "#{self.class.name}##{name}")
+      @rematch = Rematch.new(self)
     end
   end
 
   # Reopen the minitest module
   module Assertions
     # Main assertion
-    def assert_rematch(key, actual, *args)
+    def assert_rematch(actual, *args)
       assertion = :assert_equal
       message   = nil
       args.each { |arg| arg.is_a?(Symbol) ? assertion = arg : message = arg }
       if actual.nil?   # use specific assert_nil after deprecation of assert_equal nil
-        assert_nil @rematch.rematch(key, actual), message
+        assert_nil @rematch.rematch(actual), message
       else
-        send assertion, @rematch.rematch(key, actual), actual, message  # assert that the stored value is the same actual value
+        send assertion, @rematch.rematch(actual), actual, message  # assert that the stored value is the same actual value
       end
     end
 
     # Temporarily used to store the actual value, useful for reconciliation of expected changed values
-    def store_assert_rematch(key, actual, *_args)
-      @rematch.rematch(key, actual, overwrite: true)
+    def store_assert_rematch(actual, *_args)
+      @rematch.rematch(actual, overwrite: true)
       # Always fail after storing, forcing the restore of the original assertion/expectation
       raise Minitest::Assertion, '[rematch] the value has been stored: remove the "store_" prefix to pass the test'
     end
   end
-  # Reopen the Minitest::Expectation class for Minitest 6 compatibility
-  # or use infect_an_assertion for Minitest 5
-  require 'minitest/spec'
 
-  if defined?(Expectations) && Expectations.respond_to?(:infect_an_assertion)
-    module Expectations # rubocop:disable Style/Documentation
-      infect_an_assertion :assert_rematch, :must_rematch
-      infect_an_assertion :store_assert_rematch, :store_must_rematch
-    end
-  else
-    class Expectation # rubocop:disable Style/Documentation
-      def must_rematch(key, *)
-        ctx.assert_rematch(key, target, *)
-      end
-
-      def store_must_rematch(key, *)
-        ctx.store_assert_rematch(key, target, *)
-      end
-    end
+  # Register expectations only if minitest/spec is loaded; ensure the right class in 6.0 and < 6.0
+  if (expectation_class = defined?(Spec) && (defined?(Expectation) ? Expectation : Expectations))
+    expectation_class.infect_an_assertion :assert_rematch, :must_rematch, :reverse
+    expectation_class.alias_method :to_rematch, :must_rematch # to use with expect().to_rematch
+    expectation_class.infect_an_assertion :store_assert_rematch, :store_must_rematch, :reverse
+    expectation_class.alias_method :store_to_rematch, :store_must_rematch # to use with expect().store_to_rematch
   end
 end

data/lib/rematch.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
 require 'fileutils'
+require 'digest/sha1'
 require_relative 'rematch/store'
 
 # Handles the key/value store for each test
 class Rematch
-  VERSION = '3.2.1'
+  VERSION = '4.0.0'
   CONFIG  = { ext: '.yaml' }  # rubocop:disable Style/MutableConstant
 
   @rebuild      = false  # rebuild the store?
@@ -26,35 +27,70 @@ class Rematch
   end
 
   # Instantiated at each test, stores the path and the unique id of the test being run
-  def initialize(path:, id:)
-    store_path = "#{path}#{CONFIG[:ext]}"
+  def initialize(test)
+    @path      = test.method(test.name).source_location.first
+    store_path = "#{@path}#{CONFIG[:ext]}"
     self.class.check_rebuild(store_path)
-    @store = Store.new(store_path, true)
-    @id    = id.tr('#: ', '_')       # easier key string for clumsy yaml parsers/highlighters
+    @store     = Store.new(store_path, true)
+    @id        = test_uid(test.class.name, test.name)
   end
 
   # Retrieve the stored value for the current assertion if its key is known; store the value otherwise
-  def rematch(key, value, overwrite: nil)
-    # key = assertion_key(key)
+  def rematch(value, overwrite: nil)
+    key = assertion_key
     @store.transaction do |s|
-      if s.root?(@id)                     # there is the root id
-        if s[@id].key?(key) && !overwrite # there is the key and not overwrite
-          s[@id][key]                     # return it
-        else                              # not such a key
-          s[@id][key] = value             # set it
-          store_warning(key) unless overwrite
-          value
-        end
-      else                                # there is no root yet
-        s[@id] = { key => value }         # the key is the first one
-        store_warning(key)
-        value                             # always return the value
+      if s.root?(key) && !overwrite       # there is the key and not overwrite
+        s[key]                            # return it
+      else                                # no such key or overwrite
+        s[key] = value                    # set it
+        tidy_store(s)                     # sort keys and cleanup orphans
+        store_warning(key) unless overwrite
+        value
       end
     end
   end
 
   def store_warning(key)
-    warn "Rematch stored new value for: #{key.inspect}\n#{@id}\n#{@store.path}\n\n" \
-          unless Rematch.skip_warning
+    warn "Rematch stored new value for: #{key.inspect}\n#{@store.path}\n\n" \
+    unless Rematch.skip_warning
+  end
+
+  protected
+
+  # Generate the unique id for the test (SHA1)
+  def test_uid(class_name, method_name)
+    Digest::SHA1.hexdigest("#{class_name}#{method_name}")
+  end
+
+  private
+
+  # Generate the key based on the line number and test ID
+  def assertion_key
+    line = caller_locations.find { |l| l.path == @path }&.lineno
+    "L#{line} #{@id}"
+  end
+
+  # Ensure the keys are sorted by the order of the tests in the file
+  # and remove keys that do not match any existing test (orphans)
+  def tidy_store(store)
+    # Optimization: only if Minitest is loaded
+    return unless defined?(Minitest::Runnable)
+
+    # Get all valid SHA1s from all runnables in this file
+    valid_ids = []
+    Minitest::Runnable.runnables.each do |runnable|
+      runnable.runnable_methods.each do |method_name|
+        file, = runnable.instance_method(method_name).source_location
+        next unless file == @path # @path is the test file path
+
+        valid_ids << test_uid(runnable.name, method_name)
+      end
+    end
+    # Extract all data
+    data = store.roots.to_h { |key| [key, store.delete(key)] }
+    # Re-add data in the correct order, filter orphans and sort
+    data.select { |key, _| valid_ids.include?(key.split.last) }
+        .sort_by { |key, _| key[/L(\d+)/, 1].to_i }
+        .each { |key, value| store[key] = value }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rematch
 version: !ruby/object:Gem::Version
-  version: 3.2.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Domizio Demichelis
@@ -37,9 +37,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Instead of copying and pasting large outputs or big ruby structures into
-  all the affected test files every time your code change, you can do it the easy
-  way, possibly saving many hours of boring maintenance work!
+description: Rematch declutters your tests by storing large outputs or structures
+  in separate files. It verifies them automatically and enables easy updates when
+  your code changes, eliminating tedious copy-paste maintenance.
 email:
 - dd.nexus@gmail.com
 executables: []
@@ -74,6 +74,5 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 rubygems_version: 3.6.9
 specification_version: 4
-summary: Declutter your test files from large hardcoded data and update them automatically
-  when your code changes
+summary: Declutter your test files and automatically update expected values.
 test_files: []