remark_analytics 1.0.4 → 1.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 004a2633cebf7ce4d2110d7e9d13afe8c4e009d1e14cfdba2496ec5a0b9d98c2
-  data.tar.gz: 3dac747f9515e391fe962f0378757ab3be6d8af489980b7effdfc6a569d52691
+  metadata.gz: 750cd5e3f83a0db4b3b986bf7fbc6e06c91e6731f6816e9f8ace47c6939ce2f6
+  data.tar.gz: 80b15d392b5f6a76431b7d21710c9d98b3312e2d211ac2e3d9c86cb12fa351bf
 SHA512:
-  metadata.gz: dba3317b87fab8e4eb1996b10930fe49fbd3c3318670aecbfca48fdf94cd4d44b69837b29857af6b92cdae15e87a14e48dc978293fcf28935ae235f1e5c973d6
-  data.tar.gz: c7d39cdab0ffc44ed3cdfb3651142f6e2552af67ac0147192f825982d95dd66520504f8fcbb2e33ebf4b92e75b870a2bf24490e2ee8ed070468bdf8695fe8f21
+  metadata.gz: 482cbd18f99aeb9bd309a85a629295e221ee0f0f0241cc516f24085c031853cdbc7e263a31cdcdd3cf3da7a7f5a6600b46640559e0f4cd22d74e458fb3cdf729
+  data.tar.gz: 89dc61dc6f260e5abbb3af19e522a55fcd8a22b6ca6368ddc99902fb930130aa9e8c760281fb8d7f80845e2b8832b352a9ff6b7e614d4c0b5c40d21713eeded5

data/README.md

@@ -27,7 +27,7 @@ Make sure the following keys and their values become available in your applicati
 - **REMARK_ANALYTICS_PASSWORD** (the Basic Authentication user password)
 - **REMARK_ANALYTICS_TENANT_NAME** (the name of the tenant/client)
 
-or suppress Sentry messages by setting just one secret
+or prevent the raise of missing secrets errors by setting just one secret
 
 - **NO_REMARK_ANALYTICS** (any value is good enough; true or yes, foo)
 

data/lib/remark_analytics/errors.rb

@@ -0,0 +1,4 @@
+module RemarkAnalytics
+  class Error < StandardError; end
+  class SecretsMissingError < Error; end
+end

data/lib/remark_analytics/event.rb

@@ -28,7 +28,11 @@ module RemarkAnalytics
 
     def self.post_event(event_params)
       if Rails.env.development? || Rails.env.test?
-        RemarkAnalytics::Jobs::PostEventJob.perform_now(event_params)
+        begin
+          RemarkAnalytics::Jobs::PostEventJob.perform_now(event_params)
+        rescue RemarkAnalytics::SecretsMissingError => _e
+          # to pass tests
+        end
         return
       end
 

data/lib/remark_analytics/jobs/post_event_job.rb

@@ -26,18 +26,15 @@ module RemarkAnalytics
         @events_endpoint = "#{analytics_url}/api/v1/events"
 
         if analytics_url.blank?
-          Sentry.capture_message('REMARK_ANALYTICS_URL not set')
-          return
+          raise RemarkAnalytics::SecretsMissingError.new('REMARK_ANALYTICS_URL not set')
         end
 
         if username.blank?
-          Sentry.capture_message('REMARK_ANALYTICS_USERNAME not set')
-          return
+          raise RemarkAnalytics::SecretsMissingError.new('REMARK_ANALYTICS_USERNAME not set')
         end
 
         if password.blank?
-          Sentry.capture_message('REMARK_ANALYTICS_PASSWORD not set')
-          return
+          raise RemarkAnalytics::SecretsMissingError.new('REMARK_ANALYTICS_PASSWORD not set')
         end
 
         Faraday.new do |conn|

data/lib/remark_analytics/version.rb

@@ -1,3 +1,3 @@
 module RemarkAnalytics
-  VERSION = '1.0.4'.freeze
+  VERSION = '1.0.7'.freeze
 end

data/lib/remark_analytics.rb

@@ -2,6 +2,7 @@
 
 require 'remark_analytics/railtie'
 require 'remark_analytics/version'
+require 'remark_analytics/errors'
 require 'remark_analytics/event'
 
 require 'remark_analytics/jobs/application_job'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: remark_analytics
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.7
 platform: ruby
 authors:
 - Nick Rockx
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-07-05 00:00:00.000000000 Z
+date: 2022-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -36,20 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.4
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.0.4.8
+        version: '6.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.0.4
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 6.0.4.8
+        version: '6.1'
 description: This gem/plugin is used in applications that need to fire events to the
   ReMark Analytics system
 email:
@@ -60,6 +54,7 @@ extra_rdoc_files: []
 files:
 - README.md
 - lib/remark_analytics.rb
+- lib/remark_analytics/errors.rb
 - lib/remark_analytics/event.rb
 - lib/remark_analytics/jobs/application_job.rb
 - lib/remark_analytics/jobs/post_event_job.rb