releasinator 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 514f2117423fc276d733afa1e3ada8409d294c3f
-  data.tar.gz: 518e7c826e1ecb8588fddaed5c21de54709d96d3
+  metadata.gz: 99035e7fd8c9c4f656989abf3691c485f9e68bd8
+  data.tar.gz: 6a473481db9b7a4f66195c70f398e0fbc0b6cc01
 SHA512:
-  metadata.gz: 110da6dcf745e7d20133ae31ba19c6ed6f984bc6447325bb0e00ac8a1331d25220a46f40875950df6967e70b63f98c0b13dad82806f7e91ecd5ea3b156e25392
-  data.tar.gz: 025592dcb88660d3270e0b9aa4dafd97d1b54b7acef72a7e3fa06ac47659b2d4eda94a08a940c01c6935019b69d8183fc20820d81ce2752a324770d99e3bc9f2
+  metadata.gz: cc52ac52529e6437ffae30a61db4395eb2485e81d8d2e9825ea204decb16624dd03f2b5f71697232387639950c5694686417649f2a96bc258fd6cc7f544d2789
+  data.tar.gz: 1383396a3df9378566522756524e3913f736ab582ebdb40382a4219da2c6298921fe61cbf70e298ee12751faa98b81d311cca8aa933bab341dbc694c10526f4a

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 Releasinator release notes
 ==========================
 
+0.6.1
+-----
+* Improve some error messages.
+* Add more filetypes to `validate:eof_newlines`.
+* Disable bullet punctuation detection until multi-line comments can be addressed.
+
 0.6.0
 -----
 * Validate all bulleted items in `CHANGELOG.md` end in punctuation.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    releasinator (0.6.0)
+    releasinator (0.6.1)
       colorize (~> 0.7)
       configatron (~> 4.5)
       json (~> 1.8)
@@ -13,7 +13,7 @@ GEM
   remote: https://rubygems.org/
   specs:
     addressable (2.4.0)
-    colorize (0.8.0)
+    colorize (0.8.1)
     configatron (4.5.0)
     faraday (0.9.2)
       multipart-post (>= 1.2, < 3)

data/lib/git_util.rb

@@ -101,15 +101,24 @@ module Releasinator
     end
 
     def self.get_local_head_sha1
-      CommandProcessor.command("git rev-parse --verify head").strip
+      rev_parse("head")
     end
 
     def self.get_local_branch_sha1(branch_name)
-      CommandProcessor.command("git rev-parse --verify #{branch_name}").strip
+      rev_parse(branch_name)
     end
 
     def self.get_remote_branch_sha1(branch_name)
-      CommandProcessor.command("git rev-parse --verify origin/#{branch_name}").strip
+      rev_parse("origin/#{branch_name}")
+    end
+
+    def self.rev_parse(branch_name)
+      output = CommandProcessor.command("git rev-parse --verify #{branch_name} 2>&1 | cat").strip
+      if output.include? 'fatal: Needed a single revision'
+        puts "error: branch or commit '#{branch_name}' does not exist. You may need to checkout this branch.".red
+        abort()
+      end
+      output
     end
 
     def self.tag(new_tag, changelog)

data/lib/publisher.rb

@@ -5,8 +5,8 @@ require_relative 'printer'
 
 module Releasinator
   class Publisher
-    def initialize(config)
-      @config = config
+    def initialize(releasinator_config)
+      @releasinator_config = releasinator_config
     end
 
     def publish(repo_url, release)
@@ -18,7 +18,7 @@ module Releasinator
           release.version,
           :name => release.version,
           :body => release.changelog
-        puts github_release.inspect if @config[:trace]
+        puts github_release.inspect if @releasinator_config[:trace]
       rescue => error
         #This will fail if the user does not have push permissions.
         Printer.fail(error.inspect)
@@ -46,7 +46,7 @@ module Releasinator
           head,
           "Update #{product_name} to #{release.version}",
           release.changelog
-        puts github_pull_request.inspect if @config[:trace]
+        puts github_pull_request.inspect if @releasinator_config[:trace]
       rescue => error
         #This will fail if there's already a pull request
         Printer.fail(error.inspect)

data/lib/releasinator/version.rb

@@ -1,3 +1,3 @@
 module Releasinator
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

data/lib/validator.rb

@@ -9,6 +9,41 @@ require_relative 'printer'
 require_relative 'validator_changelog'
 require_relative 'releasinator/version'
 
+TEXT_FILE_EXTENSIONS = [
+  ".md",
+  ".txt",
+  ".ini",
+  ".in",
+  ".xml",
+  ".gitignore",
+  ".npmignore",
+  ".html",
+  ".css",
+  ".h",
+  "Gemfile",
+  "Gemfile.lock",
+  ".rspec",
+  ".gemspec",
+  ".podspec",
+  ".rb",
+  ".java",
+  ".php",
+  ".py",
+  ".js",
+  ".yaml",
+  ".json",
+  ".sh",
+  ".groovy",
+  ".gemspec",
+  ".gradle",
+  ".settings",
+  ".properties",
+  "LICENSE",
+  "Rakefile",
+  "Dockerfile"
+  # TODO include C# file types
+]
+
 module Releasinator
   class Validator
 
@@ -33,10 +68,11 @@ module Releasinator
 
     def validate_eof_newlines
       all_git_files = GitUtil.all_files.split
-      text_file_extensions = [".md", ".txt", ".gitignore", "Gemfile", "Gemfile.lock", "LICENSE", "Rakefile", ".rb"]
 
-      important_git_text_files = all_git_files.select{ 
-        |filename| text_file_extensions.any? { |extension| filename.end_with?(extension) }
+      important_git_text_files = all_git_files.select{ |filename|
+        TEXT_FILE_EXTENSIONS.any? { |extension|
+          filename.end_with?(extension)
+        }
       }
 
       important_git_text_files.each do |filename|
@@ -200,7 +236,7 @@ module Releasinator
       
       Dir.chdir(dir) do
         if !GitUtil.exist?(expected_file_name)
-          puts "#{dir}/#{expected_file_name} not found. Searching for similar files.".yellow
+          puts "#{dir}/#{expected_file_name} not found using a case sensitive search within git, searching for similar files...".yellow
         
           # search for files that are somewhat similar to the file being searched, ignoring case
           filename_prefix = expected_file_name[0,5]

data/lib/validator_changelog.rb

@@ -108,7 +108,6 @@ module Releasinator
         if line.match /^\s*\*\s+.*$/ # regex matches bulleted points
           if !line.match /^\s*\*\s+.*[\!,\?:\.]$/ # regex matches bullet points with punctuation
             Printer.fail("'#{line}' is invalid.  Bulleted points should end in punctuation.")
-            abort()
           end
         end
       }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: releasinator
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - PayPal
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-01 00:00:00.000000000 Z
+date: 2016-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler