releasinator 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16d22b79347de442120d0265334c95b5733e8618
-  data.tar.gz: d10c35acd08786cb5051804896872ec9b11ae69c
+  metadata.gz: 13f6f9c34a097f3dcb68bd15c8df1501f190a482
+  data.tar.gz: 6860c893ba8ddf2efe8d1011473afe3309f42e5f
 SHA512:
-  metadata.gz: 877206063b2c70b6ea450ccf2b5952599bf6ae99979deece46664f7383676f414665b13665c39a2f8446d4ddc971d379add10b795d867fdc60f376440d4147d5
-  data.tar.gz: f1ba1a850d323a704a90f018c52e3c4aae812171387da3adf99d554243903050b6668b49ea84761f627233e07a631fe30237fd3f5213a9e3bab849be538ad686
+  metadata.gz: 91891918d99e27b46e1c88d0de701d3d90f312a356c9c910d5d04fda7260efdca1331ae2d1d096406a74e82f392160a6ffd11e127a1984bd614f42d37b6d567e
+  data.tar.gz: bc6aca918ee4cf5a4c5265f706f53a92c8a3910b315198ddfe8b973b8df654d1953b0dad2ab986dd9cfa8b1199be08f2eae436a645c6af2ecaa49f5e963aa36c

data/.releasinator.rb

@@ -56,14 +56,6 @@ def publish_to_package_manager(version)
   end
 end
 
-def say_hello(version)
-  puts "hello #{version}"
-end
-
-configatron.post_push_methods = [
-  method(:say_hello)
-]
-
 # The method that publishes the sdk to the package manager.  Required.
 configatron.publish_to_package_manager_method = method(:publish_to_package_manager)
 

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 Releasinator release notes
 ==========================
 
+0.4.1
+-----
+* `release_to_github` will now create a new release (instead of a draft).
+* Freeze some options after loading to avoid accidental overwrite.
 
 0.4.0
 -----

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    releasinator (0.4.0)
+    releasinator (0.4.1)
       colorize (~> 0.7)
       configatron (~> 4.5)
       json (~> 1.8)

data/LICENSE

@@ -1,156 +1,23 @@
-Apache License
+All files are released under the MIT License:
 
-Version 2.0, January 2004
+    The MIT License (MIT)
 
-http://www.apache.org/licenses/
+    Copyright (c) 2013-2016 PayPal Holdings, Inc.
 
-TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
 
-1. Definitions.
-
-"License" shall mean the terms and conditions for use, reproduction, and
-distribution as defined by Sections 1 through 9 of this document.
-
-"Licensor" shall mean the copyright owner or entity authorized by the copyright
-owner that is granting the License.
-
-"Legal Entity" shall mean the union of the acting entity and all other entities
-that control, are controlled by, or are under common control with that entity.
-For the purposes of this definition, "control" means (i) the power, direct or
-indirect, to cause the direction or management of such entity, whether by
-contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the
-outstanding shares, or (iii) beneficial ownership of such entity.
-
-"You" (or "Your") shall mean an individual or Legal Entity exercising
-permissions granted by this License.
-
-"Source" form shall mean the preferred form for making modifications, including
-but not limited to software source code, documentation source, and
-configuration files.
-
-"Object" form shall mean any form resulting from mechanical transformation or
-translation of a Source form, including but not limited to compiled object
-code, generated documentation, and conversions to other media types.
-
-"Work" shall mean the work of authorship, whether in Source or Object form,
-made available under the License, as indicated by a copyright notice that is
-included in or attached to the work (an example is provided in the Appendix
-below).
-
-"Derivative Works" shall mean any work, whether in Source or Object form, that
-is based on (or derived from) the Work and for which the editorial revisions,
-annotations, elaborations, or other modifications represent, as a whole, an
-original work of authorship. For the purposes of this License, Derivative
-Works shall not include works that remain separable from, or merely link (or
-bind by name) to the interfaces of, the Work and Derivative Works thereof.
-
-"Contribution" shall mean any work of authorship, including the original
-version of the Work and any modifications or additions to that Work or
-Derivative Works thereof, that is intentionally submitted to Licensor for
-inclusion in the Work by the copyright owner or by an individual or Legal
-Entity authorized to submit on behalf of the copyright owner. For the purposes
-of this definition, "submitted" means any form of electronic, verbal, or
-written communication sent to the Licensor or its representatives, including
-but not limited to communication on electronic mailing lists, source code
-control systems, and issue tracking systems that are managed by, or on behalf
-of, the Licensor for the purpose of discussing and improving the Work, but
-excluding communication that is conspicuously marked or otherwise designated in
-writing by the copyright owner as "Not a Contribution."
-
-"Contributor" shall mean Licensor and any individual or Legal Entity on behalf
-of whom a Contribution has been received by Licensor and subsequently
-incorporated within the Work.
-
-2. Grant of Copyright License. Subject to the terms and conditions of this
-License, each Contributor hereby grants to You a perpetual, worldwide, non-
-exclusive, no-charge, royalty-free, irrevocable copyright license to reproduce,
-prepare Derivative Works of, publicly display, publicly perform, sublicense,
-and distribute the Work and such Derivative Works in Source or Object form.
-
-3. Grant of Patent License. Subject to the terms and conditions of this
-License, each Contributor hereby grants to You a perpetual, worldwide, non-
-exclusive, no-charge, royalty-free, irrevocable (except as stated in this
-section) patent license to make, have made, use, offer to sell, sell, import,
-and otherwise transfer the Work, where such license applies only to those
-patent claims licensable by such Contributor that are necessarily infringed by
-their Contribution(s) alone or by combination of their Contribution(s) with the
-Work to which such Contribution(s) was submitted. If You institute patent
-litigation against any entity (including a cross-claim or counterclaim in a
-lawsuit) alleging that the Work or a Contribution incorporated within the Work
-constitutes direct or contributory patent infringement, then any patent
-licenses granted to You under this License for that Work shall terminate as of
-the date such litigation is filed.
-
-4. Redistribution. You may reproduce and distribute copies of the Work or
-Derivative Works thereof in any medium, with or without modifications, and in
-Source or Object form, provided that You meet the following conditions:
-
-You must give any other recipients of the Work or Derivative Works a copy of
-this License; and You must cause any modified files to carry prominent notices
-stating that You changed the files; and You must retain, in the Source form of
-any Derivative Works that You distribute, all copyright, patent, trademark, and
-attribution notices from the Source form of the Work, excluding those notices
-that do not pertain to any part of the Derivative Works; and If the Work
-includes a "NOTICE" text file as part of its distribution, then any Derivative
-Works that You distribute must include a readable copy of the attribution
-notices contained within such NOTICE file, excluding those notices that do not
-pertain to any part of the Derivative Works, in at least one of the following
-places: within a NOTICE text file distributed as part of the Derivative Works;
-within the Source form or documentation, if provided along with the Derivative
-Works; or, within a display generated by the Derivative Works, if and wherever
-such third-party notices normally appear. The contents of the NOTICE file are
-for informational purposes only and do not modify the License. You may add Your
-own attribution notices within Derivative Works that You distribute, alongside
-or as an addendum to the NOTICE text from the Work, provided that such
-additional attribution notices cannot be construed as modifying the License.
-
-You may add Your own copyright statement to Your modifications and may provide
-additional or different license terms and conditions for use, reproduction, or
-distribution of Your modifications, or for any such Derivative Works as a
-whole, provided Your use, reproduction, and distribution of the Work otherwise
-complies with the conditions stated in this License.
-
-5. Submission of Contributions. Unless You explicitly state otherwise, any
-Contribution intentionally submitted for inclusion in the Work by You to the
-Licensor shall be under the terms and conditions of this License, without any
-additional terms or conditions. Notwithstanding the above, nothing herein shall
-supersede or modify the terms of any separate license agreement you may have
-executed with Licensor regarding such Contributions.
-
-6. Trademarks. This License does not grant permission to use the trade names,
-trademarks, service marks, or product names of the Licensor, except as required
-for reasonable and customary use in describing the origin of the Work and
-reproducing the content of the NOTICE file.
-
-7. Disclaimer of Warranty. Unless required by applicable law or agreed to in
-writing, Licensor provides the Work (and each Contributor provides its
-Contributions) on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied, including, without limitation, any warranties
-or conditions of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
-PARTICULAR PURPOSE. You are solely responsible for determining the
-appropriateness of using or redistributing the Work and assume any risks
-associated with Your exercise of permissions under this License.
-
-8. Limitation of Liability. In no event and under no legal theory, whether in
-tort (including negligence), contract, or otherwise, unless required by
-applicable law (such as deliberate and grossly negligent acts) or agreed to in
-writing, shall any Contributor be liable to You for damages, including any
-direct, indirect, special, incidental, or consequential damages of any
-character arising as a result of this License or out of the use or inability
-to use the Work (including but not limited to damages for loss of goodwill,
-work stoppage, computer failure or malfunction, or any and all other commercial
-damages or losses), even if such Contributor has been advised of the
-possibility of such damages.
-
-9. Accepting Warranty or Additional Liability. While redistributing the Work or
-Derivative Works thereof, You may choose to offer, and charge a fee for,
-acceptance of support, warranty, indemnity, or other liability obligations
-and/or rights consistent with this License. However, in accepting such
-obligations, You may act only on Your own behalf and on Your sole
-responsibility, not on behalf of any other Contributor, and only if You agree
-to indemnify, defend, and hold each Contributor harmless for any liability
-incurred by, or claims asserted against, such Contributor by reason of your
-accepting any such warranty or additional liability.
-
-END OF TERMS AND CONDITIONS
+    The above copyright notice and this permission notice shall be included in
+    all copies or substantial portions of the Software.
 
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+    THE SOFTWARE.

data/README.md

@@ -10,21 +10,13 @@ When automating an SDK release process, many teams and languages have different
 
 The releasinator corrects this by enforcing standard must-have release files, being configurable where necessary, and reducing the ramp-up hurdle.
 
-## Making it work
-
-### Install
-
-1. Clone this repo
-2. Run `bundle install` from terminal. It should download dependencies.
-
-### Setup
-
-1. Set the environment variable `GITHUB_TOKEN` with a [generated personal access token](https://github.com/settings/tokens) with `repo` scope.
+## Getting started
 
 ### Usage
 
-1. Add releasinator dependency to `Gemfile` or `.gemspec`
-2. add a `Rakefile` with the following contents:
+1. Install ruby & rubygems.
+1. Add releasinator dependency to `Gemfile` or `.gemspec`.
+2. Add or append a `Rakefile` with the following contents:
 
     ```ruby
     spec = Gem::Specification.find_by_name 'releasinator'
@@ -83,10 +75,33 @@ release
 
 ```
 
+### Config
+
+A default config file is created when running any releasinator rake task for the first time.  This file includes placeholders for all the mandatory config items.  Below is the full list of config options.
+
+#### Required `.releasinator.rb` config options:
+
+1. `configatron.product_name`: The name of the sdk for usage in various commit statements.
+2. `configatron.prerelease_checklist_items`: List of items to confirm from the person releasing.
+3. `configatron.build_method`: The command that builds the sdk.
+4. `configatron.publish_to_package_manager_method`: The method that publishes the sdk to the package manager.
+5. `configatron.wait_for_package_manager_method`: The method that waits for the package manager to be done.
+6. `configatron.release_to_github`: True if publishing the root repo to GitHub.
+
+#### Optional `.releasinator.rb` config options:
+
+1. `configatron.use_git_flow`: True if the root repo's git branching strategy follows git flow (develop/release/master).
+2. `configatron.base_docs_dir`: The directory where all distributed docs are found.  If not specified, the default is `.`.
+3. `configatron.custom_validation_methods`: List of methods that are run as a step within `validate:all`.
+4. `configatron.downstream_repos`: List of downstream repos to push updates to.  Please see documentation on the `DownstreamRepo` class.
+5. `configatron.doc_build_method`: The method that builds the docs.
+6. `configatron.doc_target_dir`: The directory where to run all git commands when publishing the docs.  If not specified, the default is `.`.  Generally useful if the docs are only applicable on a downstream release, rather than on the source itself.
+7. `configatron.doc_files_to_copy`: List of CopyFile objects for copying built docs into a targeted location.  Please see documentation on the `CopyFile` class.
+
 
 ## Conventions
 
-The releasinator enforces certain conventions.  If a filename doesn't exactly match the convention, it is renamed to match, and automatically committed.  The conventions are documented below:
+The releasinator enforces certain conventions.  If a filename closely matches the convention, it is renamed and automatically committed.  The conventions are documented below:
 
 1. `README.md`
 2. `LICENSE`: See [here](http://stackoverflow.com/questions/5678462/should-i-provide-a-license-txt-or-copying-txt-file-in-my-project) for a relevant StackOverflow post on this discussion.  This project has chosen to exclude the `.txt` extension to match other popular projects, and GitHub defaults.
@@ -116,7 +131,7 @@ The releasinator enforces certain conventions.  If a filename doesn't exactly ma
 1. ✓ Validate all files are committed to git (`git ls-files --others --exclude-standard`).
 1. ✓ Validate user has valid access_tokens as environment variables for all repos (public & enterprise).  Public github requires `GITHUB_TOKEN`, while enterprise tokens add a modified version of their domain as a prefix.  For example, github.example.com requires `GITHUB_EXAMPLE_COM_GITHUB_TOKEN`.
 1. ✓ Validate user has permissions to push to repo, and downstream repos. 
-1. ✓ Validate anything as defined by the configuration.  Examples:
+1. ✓ Validate anything as defined by the config.  Examples:
     * Compiling with the right version of the platform.
     * Upstream library dependencies are the latest available.
 

data/lib/config_hash.rb

@@ -46,5 +46,14 @@ module Releasinator
       false
     end
 
+    def base_dir
+      return self[:base_docs_dir] if self.has_key?(:base_docs_dir)
+      '.'
+    end
+
+    def doc_target_dir 
+      return self[:doc_target_dir] if self.has_key?(:doc_target_dir)
+      '.'
+    end
   end
 end

data/lib/copy_file.rb

@@ -2,9 +2,12 @@ module Releasinator
   class CopyFile
     attr_reader :source_file, :target_name, :target_dir
     def initialize(source_file, target_name, target_dir)
-      @source_file = source_file
-      @target_name = target_name
-      @target_dir = target_dir
+      @source_file = source_file # The source file or directory name, including directory.
+      @source_file.freeze
+      @target_name = target_name # The target file or directory name, excluding directory.
+      @target_name.freeze
+      @target_dir = target_dir # The target directory name.
+      @target_dir.freeze
     end
   end
 end

data/lib/current_release.rb

@@ -3,7 +3,9 @@ module Releasinator
     attr_reader :version, :changelog
     def initialize(version, changelog)
       @version = version
+      @version.freeze
       @changelog = changelog
+      @changelog.freeze
     end
   end
 end

data/lib/default_config.rb

@@ -4,7 +4,7 @@ DEFAULT_CONFIG = %(configatron.product_name = "test product"
 configatron.prerelease_checklist_items = [
 ]
 
-# The directory where all distributed docs are.  Default is '.'
+# The directory where all distributed docs are.  If not specified, the default is `.`.
 # configatron.base_docs_dir = '.'
 
 def build_method
@@ -25,9 +25,9 @@ configatron.publish_to_package_manager_method = method(:publish_to_package_manag
 def wait_for_package_manager(version)
 end
 
-# The method that waits for the package manager to be done.  Required
+# The method that waits for the package manager to be done.  Required.
 configatron.wait_for_package_manager_method = method(:wait_for_package_manager)
 
-# Whether to publish the root repo to GitHub.  Required.
+# True if publishing the root repo to GitHub.  Required.
 configatron.release_to_github = true
 )

data/lib/downstream.rb

@@ -24,13 +24,13 @@ module Releasinator
     end
 
     def reset(args)
-      if @releasinator_config.has_key?(:downstream_repos)      
+      if @releasinator_config.has_key?(:downstream_repos)
         get_downstream_repos(args[:downstream_repo_index]).each do |downstream_repo, index|
           puts "resetting downstream_repo[#{index}]: #{downstream_repo.url}" if @releasinator_config[:verbose]
           Dir.mkdir(DOWNSTREAM_REPOS) unless File.exist?(DOWNSTREAM_REPOS)
           Dir.chdir(DOWNSTREAM_REPOS) do
             CommandProcessor.command("git clone --origin origin #{downstream_repo.url} #{downstream_repo.name}") unless File.exist?(downstream_repo.name)
-            
+
             Dir.chdir(downstream_repo.name) do
               GitUtil.reset_repo(downstream_repo.branch)
 
@@ -53,7 +53,7 @@ module Releasinator
           puts "preparing downstream_repo[#{index}]: #{downstream_repo.url}" if @releasinator_config[:verbose]
 
           root_dir = Dir.pwd.strip
-          copy_from_dir = root_dir + "/" + get_base_dir()
+          copy_from_dir = root_dir + "/" + @releasinator_config.base_dir
 
           Dir.chdir(DOWNSTREAM_REPOS) do
             Dir.chdir(downstream_repo.name) do
@@ -158,7 +158,7 @@ module Releasinator
               else
                 GitUtil.push_branch("master")
                 GitUtil.push_tag(@current_release.version)
-                Publisher.new(@releasinator_config).publish_draft(downstream_repo.url, @current_release) unless ! downstream_repo.release_to_github
+                Publisher.new(@releasinator_config).publish(downstream_repo.url, @current_release) unless ! downstream_repo.release_to_github
               end
             end
           end
@@ -198,4 +198,4 @@ module Releasinator
       repos_to_iterate_over
     end
   end
-end
+end

data/lib/downstream_repo.rb

@@ -2,17 +2,20 @@ module Releasinator
   class DownstreamRepo
     attr_reader :name, :url, :branch, :options
     def initialize(name, url, branch, options={})
-      @name = name
-      @url = url
-      @branch = branch
-      @options = options
-      # options are:
-      #  :new_branch_name (if set, ignores :release_to_github)
-      #  :release_to_github
-      #  :files_to_copy
-      #  :full_file_sync
-      #  :post_copy_methods
-      #  :build_methods
+      @name = name # The desired name of the repo. This is only used for the directory in the `downstream_repos` folder.
+      @name.freeze
+      @url = url # The GitHub repo location.
+      @url.freeze
+      @branch = branch # The git branch on which to base new changes.
+      @branch.freeze
+      @options = options # hash of any of the following options:
+      @options.freeze
+      #  :new_branch_name  # The name of the new branch to create.  If this is set, :release_to_github is ignored.
+      #  :release_to_github  # True if publishing the root repo to GitHub.
+      #  :files_to_copy # List of CopyFile objects for copying files into downstream.  Please see documentation on the `CopyFile` class.
+      #  :full_file_sync # True if the downstream repo should just be a straight copy of source.  Setting this to true removes all files before replacing them all with those specified in base_docs_dir.
+      #  :post_copy_methods # List of methods to run immediately after copying all files.
+      #  :build_methods # List of methods to run immediately after copying files.  Useful to test whether the new downstream changes now compile.
     end
 
     def full_file_sync

data/lib/github_repo.rb

@@ -25,6 +25,11 @@ module Releasinator
         @repo = slash_split.last.split(".git").first
       end
 
+      @url.freeze
+      @org.freeze
+      @repo.freeze
+      @domain.freeze
+
       if @domain == "github.com"
         check_token("GITHUB_TOKEN")
         @client = Octokit::Client.new(:access_token => ENV["GITHUB_TOKEN"])

data/lib/publisher.rb

@@ -9,7 +9,7 @@ module Releasinator
       @config = config
     end
 
-    def publish_draft(repo_url, release)
+    def publish(repo_url, release)
       github_repo = GitHubRepo.new(repo_url)
 
       begin
@@ -17,9 +17,7 @@ module Releasinator
         github_release = github_repo.client.create_release "#{github_repo.org}/#{github_repo.repo}",
           release.version,
           :name => release.version,
-          :body => release.changelog,
-          :draft => true,
-          :prerelease => false
+          :body => release.changelog
         puts github_release.inspect if @config[:trace]
       rescue => error
         #This will fail if the user does not have push permissions.

data/lib/releasinator/version.rb

@@ -1,3 +1,3 @@
 module Releasinator
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/lib/tasks/releasinator.rake

@@ -16,28 +16,24 @@ include Releasinator
 
 DOWNSTREAM_REPOS = "downstream_repos"
 
-def get_base_dir
-  if @releasinator_config.has_key?(:base_docs_dir)
-    @releasinator_config[:base_docs_dir]
-  else
-    '.'
-  end
-end
-
 desc "read and validate the config, adding one if not found"
 task :config do
   @releasinator_config = ConfigHash.new(verbose == true, Rake.application.options.trace == true)
+  @releasinator_config.freeze
   @validator = Validator.new(@releasinator_config)
+  @validator.freeze
   @validator.validate_config
 end
 
 namespace :validate do
   desc "validate the presence, formatting, and semver sequence of CHANGELOG.md"
   task :changelog => :config do
-    @current_release = @validator.validate_changelog(get_base_dir(), DOWNSTREAM_REPOS)
+    @current_release = @validator.validate_changelog(DOWNSTREAM_REPOS)
+    @current_release.freeze
     @downstream = Downstream.new(@releasinator_config, @validator, @current_release)
+    @downstream.freeze
   end
-  
+
   desc "validate that git is the correct version"
   task :releasinator_version => :config do
     @validator.validate_releasinator_version
@@ -66,31 +62,31 @@ namespace :validate do
 
   desc "validate the presence of README.md, renaming a similar file if found"
   task :readme => :config do
-    @validator.validate_exist(".", "README.md", DOWNSTREAM_REPOS)
-    @validator.validate_exist(get_base_dir(), ".gitignore", DOWNSTREAM_REPOS) if '.' != get_base_dir()
+    @validator.validate_exist('.', "README.md", DOWNSTREAM_REPOS)
+    @validator.validate_exist(@releasinator_config.base_dir, "README.md", DOWNSTREAM_REPOS) if '.' != @releasinator_config.base_dir
   end
 
   desc "validate the presence of LICENSE, renaming a similar file if found - also validates that its referenced from README.md"
   task :license => :config do
-    @validator.validate_exist(get_base_dir(), "LICENSE", DOWNSTREAM_REPOS)
-    @validator.validate_referenced_in_readme(get_base_dir(), "LICENSE")
+    @validator.validate_exist(@releasinator_config.base_dir, "LICENSE", DOWNSTREAM_REPOS)
+    @validator.validate_referenced_in_readme("LICENSE")
   end
 
   desc "validate the presence of CONTRIBUTING.md, renaming a similar file if found - also validates that its referenced from README.md"
   task :contributing => :config do
-    @validator.validate_exist(get_base_dir(), "CONTRIBUTING.md", DOWNSTREAM_REPOS)
-    @validator.validate_referenced_in_readme(get_base_dir(), "CONTRIBUTING.md")
+    @validator.validate_exist(@releasinator_config.base_dir, "CONTRIBUTING.md", DOWNSTREAM_REPOS)
+    @validator.validate_referenced_in_readme("CONTRIBUTING.md")
   end
 
   desc "validate the presence of .github/ISSUE_TEMPLATE.md"
   task :issue_template => :config do
-    @validator.validate_exist(get_base_dir(), ".github/ISSUE_TEMPLATE.md", DOWNSTREAM_REPOS)
+    @validator.validate_exist(@releasinator_config.base_dir, ".github/ISSUE_TEMPLATE.md", DOWNSTREAM_REPOS)
   end
 
   desc "validate the presence of .gitignore, adding any appropriate releasinator lines if necessary"
   task :gitignore => :config do
     @validator.validate_exist('.', ".gitignore", DOWNSTREAM_REPOS)
-    @validator.validate_exist(get_base_dir(), ".gitignore", DOWNSTREAM_REPOS) if '.' != get_base_dir()
+    @validator.validate_exist(@releasinator_config.base_dir, ".gitignore", DOWNSTREAM_REPOS) if '.' != @releasinator_config.base_dir
     if @releasinator_config.has_key?(:downstream_repos)
       @validator.validate_gitignore_contents("#{DOWNSTREAM_REPOS}/")
     end
@@ -124,8 +120,8 @@ namespace :validate do
   end
 
   desc "validate all"
-  task :all => 
-    [ 
+  task :all =>
+    [
       :paths,
       :git_version,
       :gitignore,
@@ -165,7 +161,7 @@ namespace :local do
   end
 
   desc "tag the local repo"
-  task :tag => [:config, :"validate:changelog"] do 
+  task :tag => [:config, :"validate:changelog"] do
     GitUtil.tag(@current_release.version, @current_release.changelog)
   end
 
@@ -206,7 +202,9 @@ namespace :local do
     end
     GitUtil.push_tag(@current_release.version)
     if @releasinator_config[:release_to_github]
-      Publisher.new(@releasinator_config).publish_draft(GitUtil.repo_url, @current_release)
+      # TODO - check that the tag exists
+      CommandProcessor.command("sleep 5")
+      Publisher.new(@releasinator_config).publish(GitUtil.repo_url, @current_release)
     end
 
     if @releasinator_config.has_key? :post_push_methods
@@ -296,10 +294,7 @@ namespace :docs do
     if @releasinator_config.has_key?(:doc_files_to_copy)
       root_dir = Dir.pwd.strip
 
-      doc_target_dir = "."
-      doc_target_dir = @releasinator_config[:doc_target_dir] if @releasinator_config.has_key?(:doc_target_dir)
-
-      Dir.chdir(doc_target_dir) do
+      Dir.chdir(@releasinator_config.doc_target_dir) do
         current_branch = GitUtil.get_current_branch()
 
         GitUtil.init_gh_pages()
@@ -323,14 +318,11 @@ namespace :docs do
   desc "push gh-pages branch"
   task :push => [:config] do
     if @releasinator_config.has_key?(:doc_build_method)
-      doc_target_dir = "."
-      doc_target_dir = @releasinator_config[:doc_target_dir] if @releasinator_config.has_key?(:doc_target_dir)
-
-      Dir.chdir(doc_target_dir) do
+      Dir.chdir(@releasinator_config.doc_target_dir) do
         current_branch = GitUtil.get_current_branch()
         CommandProcessor.command("git checkout gh-pages")
         GitUtil.push_branch("gh-pages")
-        # switch back to previous branch 
+        # switch back to previous branch
         CommandProcessor.command("git checkout #{current_branch}")
       end
       Printer.success("Docs pushed.")

data/lib/validator.rb

@@ -54,11 +54,11 @@ module Releasinator
       end
     end
 
-    def validate_changelog(base_dir, downstream_dir)
-      validate_base_dir base_dir
-      validate_exist(base_dir, "CHANGELOG.md", downstream_dir, ["release_notes.md"])
+    def validate_changelog(downstream_dir)
+      validate_base_dir
+      validate_exist(@releasinator_config.base_dir, "CHANGELOG.md", downstream_dir, ["release_notes.md"])
 
-      changelog_contents = get_changelog_contents(base_dir)
+      changelog_contents = get_changelog_contents
       ValidatorChangelog.new(@releasinator_config).validate_changelog_contents(changelog_contents)
     end
 
@@ -166,27 +166,31 @@ module Releasinator
       false
     end
 
-    def validate_referenced_in_readme(base_dir, filename)
-      validate_base_dir base_dir
-      Dir.chdir(base_dir) do
+    def validate_referenced_in_readme(filename)
+      validate_base_dir
+      Dir.chdir(@releasinator_config.base_dir) do
         File.open("README.md", "r") do |f|
           f.each_line do |line|
             if line.include? "(#{filename})"
-              Printer.success("#{filename} referenced in #{base_dir}/README.md")
+              Printer.success("#{filename} referenced in #{@releasinator_config.base_dir}/README.md")
               return
             end
           end
         end
       end
-      Printer.fail("Please link to the #{filename} file somewhere in #{base_dir}/README.md.")
+      Printer.fail("Please link to the #{filename} file somewhere in #{@releasinator_config.base_dir}/README.md.")
       abort()
     end
 
-    def validate_exist(base_dir, expected_file_name, downstream_dir, alternate_names=[])
-      validate_base_dir base_dir
-      Dir.chdir(base_dir) do
+    def validate_exist(dir, expected_file_name, downstream_dir, alternate_names=[])
+      if !File.exist? dir
+        Printer.fail("Directory #{dir} not found.")
+        abort()
+      end
+      
+      Dir.chdir(dir) do
         if !File.exist?(expected_file_name)
-          puts "#{base_dir}/#{expected_file_name} not found. Searching for similar files.".yellow
+          puts "#{dir}/#{expected_file_name} not found. Searching for similar files.".yellow
         
           # search for files that are somewhat similar to the file being searched, ignoring case
           filename_prefix = expected_file_name[0,5]
@@ -194,23 +198,23 @@ module Releasinator
           num_similar_files = similar_files.split.count
           puts similar_files
           if num_similar_files == 1
-            Printer.check_proceed("Found a single similar file: #{similar_files}.  Do you want to rename this to the expected #{expected_file_name}?","Please place #{base_dir}/#{expected_file_name}")
+            Printer.check_proceed("Found a single similar file: #{similar_files}.  Do you want to rename this to the expected #{expected_file_name}?","Please place #{dir}/#{expected_file_name}")
             rename_file(similar_files, expected_file_name)
           elsif num_similar_files > 1
             Printer.fail("Found more than 1 file similar to #{expected_file_name}.  Please rename one, and optionally remove the others to not confuse users.")
             abort()
           elsif !rename_alternate_name(expected_file_name, alternate_names)
-            Printer.fail("Please place #{base_dir}/#{expected_file_name}.") 
+            Printer.fail("Please place #{dir}/#{expected_file_name}.") 
             abort()
           end
         end
-        Printer.success("#{base_dir}/#{expected_file_name} found.")
+        Printer.success("#{dir}/#{expected_file_name} found.")
       end
     end
 
-    def validate_base_dir(base_dir)
-      if !File.exist? base_dir
-        Printer.fail("Directory specified by base_docs_dir '#{base_dir}' not found.  Please fix the config, or add this directory.")
+    def validate_base_dir()
+      if !File.exist? @releasinator_config.base_dir
+        Printer.fail("Directory specified by base_docs_dir '#{@releasinator_config.base_dir}' not found.  Please fix the config, or add this directory.")
         abort()
       end
     end
@@ -371,9 +375,9 @@ module Releasinator
       false
     end
 
-    def get_changelog_contents(base_dir)
-      validate_base_dir base_dir
-      Dir.chdir(base_dir) do
+    def get_changelog_contents()
+      validate_base_dir
+      Dir.chdir(@releasinator_config.base_dir) do
         open('CHANGELOG.md').read
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: releasinator
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - PayPal
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-13 00:00:00.000000000 Z
+date: 2016-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler