releaf-core 1.1.22 → 2.0.0

data/spec/builders/releaf/builders/collection_spec.rb

@@ -10,7 +10,7 @@ describe Releaf::Builders::Collection, type: :module do
   end
 
   it "it assigns template collection instance variable to instance 'collection' accessor on initialization" do
-    template = CollectionTestHelper.new
+    template = CollectionTestHelper.new(ActionView::LookupContext.new(nil), {}, nil)
     template.instance_variable_set("@collection", "x")
     subject = CollectionIncluder.new(template)
     expect(subject.collection).to eq("x")

data/spec/builders/releaf/builders/confirm_destroy_dialog_builder_spec.rb

@@ -19,7 +19,7 @@ describe Releaf::Builders::ConfirmDestroyDialogBuilder, type: :class do
     end
   end
 
-  let(:template){ ConfirmDestroyDialogTestHelper.new }
+  let(:template){ ConfirmDestroyDialogTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new(id: 99, title: "book title") }
   let(:subject){ described_class.new(template) }
 

data/spec/builders/releaf/builders/confirm_dialog_builder_spec.rb

@@ -27,7 +27,7 @@ describe Releaf::Builders::ConfirmDialogBuilder, type: :class do
     def confirm_method; end
   end
 
-  let(:template){ ConfirmDestroyDialogTestHelper.new }
+  let(:template){ ConfirmDestroyDialogTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new(id: 99, title: "book title") }
   let(:subject){ ConfirmDialogBuilderInheriter.new(template) }
 

data/spec/builders/releaf/builders/edit_builder_spec.rb

@@ -9,7 +9,7 @@ describe Releaf::Builders::EditBuilder, type: :class do
     def protect_against_forgery?
       true
     end
-    def form_authenticity_token
+    def form_authenticity_token(_)
       "xxx"
     end
 
@@ -18,7 +18,7 @@ describe Releaf::Builders::EditBuilder, type: :class do
     end
   end
 
-  let(:template){ TranslationsEditBuilderTestHelper.new }
+  let(:template){ TranslationsEditBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:subject){ described_class.new(template) }
   let(:controller){ Releaf::ActionController.new }
   let(:resource){ Book.new }
@@ -38,7 +38,7 @@ describe Releaf::Builders::EditBuilder, type: :class do
     end
 
     it "returns section with index url preserver and section blocks" do
-      expect(subject.section_content).to eq('<form class="new_book" id="new_book" action="xxx" accept-charset="UTF-8" method="post"><input name="utf8" type="hidden" value="&#x2713;" /><input type="hidden" name="yyy" value="xxx" />_index_path__section__blocks_</form>')
+      expect(subject.section_content).to eq('<form class="new_book" id="new_book" action="xxx" accept-charset="UTF-8" method="post"><input type="hidden" name="yyy" value="xxx" />_index_path__section__blocks_</form>')
     end
 
     it "assigns form instance to builder" do
@@ -127,7 +127,7 @@ describe Releaf::Builders::EditBuilder, type: :class do
 
   describe "#create_another_available?" do
     context "when editing an existing record" do
-      let(:resource){ FactoryGirl.create(:book) }
+      let(:resource){ FactoryBot.create(:book) }
 
       context "when controller has create_another feature enabled" do
         it "returns false" do

data/spec/builders/releaf/builders/form_builder/associations_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::FormBuilder::Associations, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new }
   let(:subject){ Releaf::Builders::FormBuilder.new(:book, object, template, {}) }
 

data/spec/builders/releaf/builders/form_builder/date_fields_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::FormBuilder::DateFields, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new }
   let(:subject){ Releaf::Builders::FormBuilder.new(:book, object, template, {}) }
 

data/spec/builders/releaf/builders/form_builder/i18n_fields_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::FormBuilder::I18nFields, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new }
   let(:subject){ Releaf::Builders::FormBuilder.new(:book, object, template, {}) }
 

data/spec/builders/releaf/builders/form_builder/label_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::FormBuilder::Label, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new }
   let(:subject){ Releaf::Builders::FormBuilder.new(:book, object, template, {}) }
 

data/spec/builders/releaf/builders/form_builder/number_fields_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::FormBuilder::NumberFields, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new }
   let(:subject){ Releaf::Builders::FormBuilder.new(:book, object, template, {}) }
 

data/spec/builders/releaf/builders/form_builder_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::FormBuilder, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:object){ Book.new }
   let(:subject){ described_class.new(:book, object, template, {}) }
   let(:normalized_fields){

data/spec/builders/releaf/builders/index_builder_spec.rb

@@ -10,7 +10,7 @@ describe Releaf::Builders::IndexBuilder, type: :class do
     end
   end
 
-  let(:template){ TranslationsIndexBuilderTestHelper.new }
+  let(:template){ TranslationsIndexBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:subject){ described_class.new(template) }
   let(:collection){ Book.page(1).per_page(2) }
 

data/spec/builders/releaf/builders/page/header_builder_spec.rb

@@ -19,7 +19,7 @@ describe Releaf::Builders::Page::HeaderBuilder, type: :class do
   end
 
   subject { described_class.new(template) }
-  let(:template){ PageHeaderBuilderTestHelper.new }
+  let(:template){ PageHeaderBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
 
   describe "#output" do
     it "returns safely joined items" do
@@ -40,7 +40,8 @@ describe Releaf::Builders::Page::HeaderBuilder, type: :class do
       allow(subject).to receive(:home_url).and_return("www.xxx")
       allow(subject).to receive(:home_text).and_return("Rrr")
       allow(subject).to receive(:home_image_path).and_return("releaf/foo.png")
-      content = '<a class="home" href="www.xxx"><img alt="Rrr" src="/images/releaf/foo.png" /></a>'
+      allow(subject).to receive(:image_tag).with("releaf/foo.png", alt: "Rrr").and_return('IMG')
+      content = '<a class="home" href="www.xxx">IMG</a>'
       expect(subject.home_link).to eq(content)
     end
   end

data/spec/builders/releaf/builders/page/layout_builder_spec.rb

@@ -32,7 +32,7 @@ describe Releaf::Builders::Page::LayoutBuilder, type: :class do
   end
 
   subject { described_class.new(template) }
-  let(:template){ PageHeaderBuilderTestHelper.new }
+  let(:template){ PageHeaderBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
 
   describe "#controller_classes" do
     it "returns array of ignorable ancester classes" do

data/spec/builders/releaf/builders/page/menu_builder_spec.rb

@@ -6,7 +6,7 @@ describe Releaf::Builders::Page::MenuBuilder, type: :class do
   end
 
   let(:controller){ Releaf::ActionController.new }
-  let(:template){ MenuBuilderTestHelper.new }
+  let(:template){ MenuBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:group_item){ Releaf::ControllerGroupDefinition.new(name: "_group_name", items: []) }
   let(:controller_item){ Releaf::ControllerDefinition.new(name: "y", controller: "_controller_") }
   subject { described_class.new(template) }

data/spec/builders/releaf/builders/pagination_builder_spec.rb

@@ -8,12 +8,12 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
     include FontAwesome::Rails::IconHelper
   end
 
-  let(:template){ PaginationTestView.new }
+  let(:template){ PaginationTestView.new(ActionView::LookupContext.new(nil), {}, nil) }
 
   let(:items_per_page) { 3 }
   let(:current_page_number) { 1 }
   let(:collection){ Book.page(current_page_number).per_page(items_per_page) }
-  let(:params){ { search: "xxx"} }
+  let(:params){ ActionController::Parameters.new(search: "xxx") }
   let(:subject){ described_class.new(template, collection: collection, params: params ) }
 
   before do |example|
@@ -50,7 +50,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
 
     context "when collection has less entries than allowed on one page" do
       before do
-        FactoryGirl.create( :book )
+        create( :book )
       end
 
       it "returns nil" do
@@ -63,7 +63,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
     context "when collection has exactly the number of entries that fits on one page" do
       before do
         items_per_page.times do
-          FactoryGirl.create( :book )
+          create( :book )
         end
       end
 
@@ -78,7 +78,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
     context "when collection has more than one page" do
       before do
         (items_per_page + 1).times do
-          FactoryGirl.create( :book )
+          create( :book )
         end
       end
 
@@ -108,7 +108,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
     it "returns pagination buttons and select with options" do
 
       14.times do
-        FactoryGirl.create :book
+        create :book
       end
 
       expect(subject.pagination_block).to match_html %Q[
@@ -183,7 +183,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
       it "returns a button with correct class and rel attributes and a href pointing to the offset page" do
 
         5.times do
-          FactoryGirl.create(:book)
+          create(:book)
         end
 
         expect(subject.page_button( 1, 'foo', 'foo-icon' )).to match_html %Q[
@@ -277,7 +277,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
   describe "#page_url", stub_url_for: false do
 
     it "calls url_for on template with added page number param" do
-      expect(template).to receive(:url_for).with( search: "xxx", page: 3).and_return("ok")
+      expect(template).to receive(:url_for).with(ActionController::Parameters.new(search: "xxx", page: 3).permit!).and_return("ok")
       expect(subject.page_url(3)).to eq "ok"
     end
 
@@ -317,7 +317,7 @@ describe Releaf::Builders::PaginationBuilder, type: :class do
   describe "#page_label" do
 
     before do
-      14.times { FactoryGirl.create :book }
+      14.times { create :book }
     end
 
     it "returns a string with the numbers of first and last items in page" do

data/spec/builders/releaf/builders/resource_dialog_spec.rb

@@ -11,7 +11,7 @@ describe Releaf::Builders::ResourceDialog, type: :class do
   end
 
   subject { UnitTestDialogBuilder.new(template) }
-  let(:template){ DialogTestHelper.new }
+  let(:template){ DialogTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
 
   describe "#dialog?" do
     it "always returns true" do

data/spec/builders/releaf/builders/resource_view_spec.rb

@@ -10,7 +10,7 @@ describe Releaf::Builders::ResourceView, type: :class do
   end
 
   let(:described_class){ ResourceViewIncluder }
-  let(:template){ ResourceViewTestHelper.new }
+  let(:template){ ResourceViewTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:subject){ described_class.new(template) }
   let(:controller){ Releaf::ActionController.new }
   let(:resource){ Book.new }

data/spec/builders/releaf/builders/table_builder_spec.rb

@@ -13,7 +13,7 @@ describe Releaf::Builders::TableBuilder, type: :class do
     def custom_title(resource); end
   end
 
-  let(:template){ TableBuilderTestHelper.new }
+  let(:template){ TableBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:resource_class){ Book }
   let(:resource){ resource_class.new(id: 77, title: "Life of Brian") }
   let(:collection){ Book.all }

data/spec/builders/releaf/builders/toolbox_builder_spec.rb

@@ -7,7 +7,7 @@ describe Releaf::Builders::ToolboxBuilder, type: :class do
   end
 
   subject { described_class.new(template) }
-  let(:template){ ToolboxBuilderTestHelper.new }
+  let(:template){ ToolboxBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
 
   it "includes Releaf::Builders::Base" do
     expect(described_class.ancestors).to include(Releaf::Builders::Base)

data/spec/builders/releaf/builders/toolbox_spec.rb

@@ -11,7 +11,7 @@ describe Releaf::Builders::Toolbox, type: :class do
   end
 
   subject { UnitTestToolboxBuilder.new(template) }
-  let(:template){ ToolboxTestTemplate.new }
+  let(:template){ ToolboxTestTemplate.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:resource){ Releaf::Permissions::User.new }
 
   describe "#toolbox" do

data/spec/builders/releaf/builders/view_spec.rb

@@ -12,7 +12,7 @@ describe Releaf::Builders::View, type: :class do
   end
 
   subject { ViewTestIncluder.new(template) }
-  let(:template){ ViewTestHelper.new }
+  let(:template){ ViewTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
 
   it "includes Releaf::Builders::Base" do
     expect(described_class.ancestors).to include(Releaf::Builders::Base)

data/spec/builders/releaf/builders_spec.rb

@@ -125,6 +125,16 @@ describe Releaf::Builders, type: :class do
     end
   end
 
+  describe ".constant_name_error?" do
+    it "returns true when error matches given mapping" do
+        expect(described_class.constant_name_error?("Caused by NameError: uninitialized constant #<Class:0x00007fc1b79e8448>::AnotherFormBuilder", "Releaf::Builders::AnotherFormBuilder")).to be true
+    end
+
+    it "returns fales when error doesnt match given mapping" do
+        expect(described_class.constant_name_error?("Caused by NameError: uninitialized something", "Releaf::Builders::AnotherFormBuilder")).to be false
+    end
+  end
+
   describe ".inherited_builder_scopes" do
     it "returns inherited classes except Object and BasicObject" do
       expect(described_class.inherited_builder_scopes).to eq(["Releaf::Builders"])

data/spec/builders/releaf/settings/form_builder_spec.rb

@@ -3,7 +3,7 @@ require "rails_helper"
 describe Releaf::Settings::FormBuilder, type: :class do
   class FormBuilderTestHelper < ActionView::Base; end
   let(:resource){ Releaf::Settings.new }
-  let(:template){ FormBuilderTestHelper.new }
+  let(:template){ FormBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:subject){ described_class.new(:resource, resource, template, {}) }
 
   describe "#field_names" do

data/spec/builders/releaf/settings/table_builder_spec.rb

@@ -2,7 +2,7 @@ require "rails_helper"
 
 describe Releaf::Settings::TableBuilder, type: :class do
   class TableBuilderTestHelper < ActionView::Base; end
-  let(:template){ TableBuilderTestHelper.new }
+  let(:template){ TableBuilderTestHelper.new(ActionView::LookupContext.new(nil), {}, nil) }
   let(:resource_class){ Releaf::Settings }
   let(:subject){ described_class.new([], resource_class, template, {}) }
 

data/spec/controllers/concerns/releaf/richtext_attachments_spec.rb

@@ -10,14 +10,14 @@ describe Admin::NodesController, type: :controller do
 
     context "when file is uploaded" do
       it "renders 'create_releaf_richtext_attachment'" do
-        post :create_releaf_richtext_attachment, upload: file
+        post :create_releaf_richtext_attachment, params: {upload: file}
         expect( response ).to be_successful
         expect( response ).to render_template('create_releaf_richtext_attachment')
       end
 
       it "creates attachment" do
         expect do
-          post :create_releaf_richtext_attachment, upload: file
+          post :create_releaf_richtext_attachment, params: {upload: file}
         end.to change { Releaf::RichtextAttachment.count }.by(1)
       end
     end

data/spec/controllers/releaf/action_controller_spec.rb

@@ -58,7 +58,7 @@ describe Releaf::ActionController do
 
   describe "#page_title" do
     before do
-      allow(Rails.application.class).to receive(:parent_name).and_return("DummyApp")
+      allow(Rails.application.class).to receive(:module_parent_name).and_return("DummyApp")
     end
 
     context "when controller definition exists" do
@@ -169,14 +169,14 @@ end
 # have no extra methods or overrides
 describe Admin::AuthorsController do
   before do
-    sign_in FactoryGirl.create(:user)
+    sign_in FactoryBot.create(:user)
   end
 
   describe "#index_path" do
     context "when action is other than :index" do
       context "when params have valid `index_path` value" do
         it "returns params 'index_path'" do
-          get :new, index_path: "xxxxxxxx"
+          get :new, params: {index_path: "xxxxxxxx"}
           allow(subject).to receive(:valid_index_path?).with("xxxxxxxx").and_return(true)
           expect(subject.index_path).to eq("xxxxxxxx")
         end
@@ -184,7 +184,7 @@ describe Admin::AuthorsController do
 
       context "when params have invalid `index_path` value" do
         it "returns index action path" do
-          get :new, index_path: "xxxxxxxx"
+          get :new, params: {index_path: "xxxxxxxx"}
           allow(subject).to receive(:valid_index_path?).with("xxxxxxxx").and_return(false)
           expect(subject.index_path).to eq("/admin/authors")
         end
@@ -228,7 +228,7 @@ describe Admin::AuthorsController do
 
   describe "#current_path" do
     it "returns current url without `ajax` param" do
-      get :index, ajax: 1, search: "something", page: 1
+      get :index, params: {ajax: 1, search: "something", page: 1}
       expect(subject.current_path).to eq("/admin/authors?page=1&search=something")
     end
 
@@ -271,15 +271,15 @@ describe Admin::AuthorsController do
 
     context "when `ajax` params exists within params" do
       it "assigns `true` to @_ajax instance variable" do
-        expect{ get :index, ajax: 1 }.to change{ subject.instance_variable_get("@_ajax") }.from(nil).to(true)
+        expect{ get :index, params: {ajax: 1} }.to change{ subject.instance_variable_get("@_ajax") }.from(nil).to(true)
       end
 
       it "removes ajax from `params`" do
-        expect{ get :index, ajax: 1 }.to_not change{ subject.params[:ajax] }.from(nil)
+        expect{ get :index, params: {ajax: 1} }.to_not change{ subject.params[:ajax] }.from(nil)
       end
 
       it "removes ajax from `request.query_parameters`" do
-        expect{ get :index, ajax: 1 }.to_not change{ subject.request.query_parameters[:ajax] }.from(nil)
+        expect{ get :index, params: {ajax: 1} }.to_not change{ subject.request.query_parameters[:ajax] }.from(nil)
       end
     end
   end
@@ -290,7 +290,7 @@ describe Admin::AuthorsController do
     context "when show feature is available" do
       it "assigns all resources to @collection" do
         allow(subject).to receive(:feature_available?).with(:show).and_return(true)
-        get :show, id: author
+        get :show, params: {id: author}
         expect(assigns(:resource)).to eq(author)
       end
     end
@@ -299,7 +299,7 @@ describe Admin::AuthorsController do
       it "does assign resource" do
         allow(subject).to receive(:feature_available?).and_call_original
         allow(subject).to receive(:feature_available?).with(:show).and_return(false)
-        get :show, id: author
+        get :show, params: {id: author}
         expect(assigns(:resource)).to be nil
       end
     end
@@ -308,13 +308,13 @@ describe Admin::AuthorsController do
   describe "GET index" do
     before do
       21.times do |i|
-        FactoryGirl.create(:author)
+        FactoryBot.create(:author)
       end
     end
 
     context "when resources_per_page is nil" do
       it "assigns all resources to @collection" do
-        get :index, show_all: 1
+        get :index, params: {show_all: 1}
         expect(assigns(:collection).is_a?(ActiveRecord::Relation)).to be true
         expect(assigns(:collection).size).to eq(21)
       end
@@ -331,13 +331,13 @@ describe Admin::AuthorsController do
 
   describe "DELETE #destroy" do
     before do
-      @author = FactoryGirl.create(:author)
-      FactoryGirl.create(:book, title: "The book", author: @author)
-      FactoryGirl.create(:book, title: "Almost the book", author: @author)
+      @author = FactoryBot.create(:author)
+      FactoryBot.create(:book, title: "The book", author: @author)
+      FactoryBot.create(:book, title: "Almost the book", author: @author)
     end
 
     it "creates flash error with message" do
-      delete :destroy, id: @author
+      delete :destroy, params: {id: @author}
       expect(flash["error"]).to eq({"id" => "resource_status", "message" => "Cant destroy, because relations exists"})
     end
   end
@@ -345,7 +345,7 @@ end
 
 describe Admin::BooksController do
   before do
-    sign_in FactoryGirl.create(:user)
+    sign_in FactoryBot.create(:user)
     @breadcrumbs_base = [
       {name: I18n.t('admin/books'), url: admin_books_path}
     ]
@@ -353,28 +353,28 @@ describe Admin::BooksController do
 
   describe "GET #index" do
     before do
-      FactoryGirl.create(:book, title: "great one")
-      FactoryGirl.create(:book, title: "bad one")
-      FactoryGirl.create(:book, title: "average third")
+      FactoryBot.create(:book, title: "great one")
+      FactoryBot.create(:book, title: "bad one")
+      FactoryBot.create(:book, title: "average third")
     end
 
     context "when empty search string given" do
       it "shows all records" do
-        get :index, search: ""
+        get :index, params: {search: ""}
         expect(assigns(:collection).count).to eq(3)
       end
     end
 
     context "when search string with multiple words given" do
       it "searches by given string" do
-        get :index, search: "one grea"
+        get :index, params: {search: "one grea"}
         expect(assigns(:collection).count).to eq(1)
       end
     end
 
     context "when search string given" do
       it "searches by given string" do
-        get :index, search: "great"
+        get :index, params: {search: "great"}
         expect(assigns(:collection).count).to eq(1)
       end
     end
@@ -407,14 +407,14 @@ describe Admin::BooksController do
     end
 
     it "assigns the requested record to @resource" do
-      get :edit, id: @resource
+      get :edit, params: {id: @resource}
 
       expect(assigns(:resource)).to eq(@resource)
     end
 
     it "assigns breadcrumb for resource" do
       allow(Releaf::ResourceBase).to receive(:title).with(@resource).and_return("xxx")
-      get :edit, id: @resource
+      get :edit, params: {id: @resource}
       breadcrumbs = @breadcrumbs_base + [{name: "xxx", url: edit_admin_book_path(@resource.id)}]
 
       expect(assigns(:breadcrumbs)).to eq(breadcrumbs)