releaf-core 0.2.1

data/spec/controllers/releaf/core/settings_controller_spec.rb

@@ -0,0 +1,31 @@
+require 'rails_helper'
+
+describe Releaf::Core::SettingsController do
+  login_as_user :user
+
+  describe "GET index" do
+    login_as_user :user
+    it "lists only settings that not scoped to any object and exists within `Releaf::Settings.registry`" do
+      Releaf::Settings.destroy_all
+      Releaf::Settings.registry = {}
+
+      Releaf::Settings.create(var: "a", value: "1")
+      Releaf::Settings.create(var: "b", value: "2")
+      Releaf::Settings.create(var: "c", value: "2")
+      Releaf::Settings.create(var: "a", value: "3", thing_type: "User", thing_id: "1")
+
+      Releaf::Settings.register(key: "a", default: "x", description: "some setting")
+      Releaf::Settings.register(key: "b", default: "xxxx", description: "some other setting")
+
+      get :index
+      expect(assigns(:collection).size).to eq(2)
+    end
+  end
+
+  describe "GET new" do
+    it "creation of new records is disabled" do
+      get :new
+      expect(response.status).to eq(403)
+    end
+  end
+end

data/spec/features/ajaxbox_spec.rb

@@ -0,0 +1,111 @@
+require 'rails_helper'
+feature "Ajaxbox", js: true do
+  background do
+    auth_as_user
+  end
+
+  scenario "Close ajaxbox with footer 'cancel' button without reloading page" do
+    user = Releaf::Permissions::User.last
+    visit releaf_permissions_users_path
+    click_link user.name
+    expect(page).to have_header(text: user.to_text)
+
+    open_toolbox_dialog "Delete"
+    within_dialog{ click_link "No" }
+    expect(page).to_not have_css(".dialog")
+    expect(current_path).to eq(edit_releaf_permissions_user_path(user))
+  end
+
+  scenario "Close ajaxbox with footer 'cancel' button (wrapped within form) without reloading page" do
+    node = create(:home_page_node, name: "MyNode")
+    node_path = edit_releaf_content_node_path(node)
+    visit node_path
+    open_toolbox_dialog "Move"
+    within_dialog{ click_link "Cancel" }
+    expect(page).to_not have_css(".dialog")
+    expect(current_path).to eq(node_path)
+  end
+
+  scenario "Close ajaxbox with header 'close' button without reloading page" do
+    node = create(:home_page_node, name: "MyNode")
+    node_path = edit_releaf_content_node_path(node)
+    visit node_path
+    open_toolbox_dialog "Add child"
+    within_dialog{ find("button.close").click }
+    expect(page).to_not have_css(".dialog")
+    expect(current_path).to eq(node_path)
+  end
+
+  scenario "Drag ajaxbox within header" do
+    node = create(:home_page_node, name: "MyNode")
+    node_path = edit_releaf_content_node_path(node)
+    visit node_path
+    open_toolbox_dialog "Add child"
+    header = find(".dialog > header")
+    target = find("body > header a.home")
+
+    start_position = page.driver.evaluate_script <<-EOS
+      function() {
+        var ele  = jQuery(".dialog")[0];
+        var rect = ele.getBoundingClientRect();
+        return [rect.left, rect.top];
+      }();
+    EOS
+    header.drag_to(target)
+
+    end_position = page.driver.evaluate_script <<-EOS
+      function() {
+        var ele  = jQuery(".dialog")[0];
+        var rect = ele.getBoundingClientRect();
+        return [rect.left, rect.top];
+      }();
+    EOS
+
+    expect(start_position).to_not eq(end_position)
+  end
+
+  scenario "Ajaxbox without modality (background is clickable)" do
+    node = create(:home_page_node, name: "MyNode")
+    node_path = edit_releaf_content_node_path(node)
+    visit node_path
+    open_toolbox_dialog "Add child"
+
+    expect(page).to have_css(".mfp-bg")
+    page.driver.click(10, 10)
+    expect(page).to_not have_css(".mfp-bg")
+  end
+
+  scenario "Ajaxbox with modality (background is not clickable)" do
+    user = Releaf::Permissions::User.last
+    visit releaf_permissions_users_path
+    click_link user.name
+    expect(page).to have_header(text: user.to_text)
+    open_toolbox_dialog "Delete"
+
+    expect(page).to have_css(".mfp-bg")
+    page.driver.click(10, 10)
+    expect(page).to have_css(".mfp-bg")
+    expect(find(".mfp-bg")).to be_visible
+  end
+
+  scenario "Ajaxbox single image view" do
+    image = Rack::Test::UploadedFile.new(File.expand_path('../../spec/fixtures/unicorn.jpg', __dir__), "image/jpg")
+    book = create(:book, cover_image: image)
+    visit edit_admin_book_path(book)
+
+    find(".field[data-name='cover_image'] .value-preview img").click
+    expect(page).to have_css(".mfp-bg")
+    page.driver.click(10, 10)
+    expect(page).to_not have_css(".mfp-bg")
+
+    find(".field[data-name='cover_image'] .value-preview img").click
+
+    image_url = find(".field[data-name='cover_image'] .value-preview a.ajaxbox")["href"] + "&ajax=1"
+    ajaxbox_image_selector = '.ajaxbox-inner img.mfp-img'
+    expect(find(ajaxbox_image_selector)['src']).to eq image_url
+
+    find(".ajaxbox-inner button.close").click
+    expect(page).to have_no_css(".mfp-bg")
+    expect(page).to have_no_css(ajaxbox_image_selector)
+  end
+end

data/spec/features/authorization_spec.rb

@@ -0,0 +1,50 @@
+require 'rails_helper'
+feature "Authorization" do
+  let(:user){ create(:user) }
+
+  scenario "Url preserving after authorization" do
+    current_unauthorized_url = new_admin_book_url
+    visit current_unauthorized_url
+
+    within("form") do
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Sign in'
+    end
+
+    expect(current_url).to eq current_unauthorized_url
+  end
+
+  scenario "Redirection to role default controller after authorization" do
+    visit releaf_root_url
+    within("form.login") do
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Sign in'
+    end
+
+    expect(current_url).to eq url_for(action: 'index', controller: '/' + user.role.default_controller)
+  end
+
+  scenario "Redirection to role :redirect_to GET parameter after authorization when parameter value is relative url" do
+    visit new_releaf_permissions_user_session_url(redirect_to: new_admin_book_path)
+    within("form.login") do
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Sign in'
+    end
+
+    expect(current_url).to eq new_admin_book_url
+  end
+
+  scenario "Redirection to role default controller after authorization when :redirect_to GET parameter is absolute url" do
+    visit new_releaf_permissions_user_session_url(redirect_to: new_admin_book_url)
+    within("form.login") do
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+      click_button 'Sign in'
+    end
+
+    expect(current_url).to eq url_for(action: 'index', controller: '/' + user.role.default_controller)
+  end
+end

data/spec/features/dragonfly_integration_spec.rb

@@ -0,0 +1,24 @@
+require 'rails_helper'
+feature "Dragonfly integration", js: true do
+  background do
+    auth_as_user
+  end
+
+  scenario "Upload, view and remove image" do
+    visit new_admin_book_path
+    create_resource do
+      fill_in "Title", with: "xx"
+      attach_file "Cover image", File.expand_path('../fixtures/cs.png', __dir__)
+    end
+
+    find(".field[data-name='cover_image'] a.ajaxbox" ).click
+    expect(page).to have_css(".ajaxbox-inner img.mfp-img")
+    find(".ajaxbox-inner button.close" ).click
+    expect(page).to have_no_css(".ajaxbox-inner img.mfp-img")
+
+    update_resource do
+      check "Remove"
+    end
+    expect(page).to have_no_css(".field[data-name='cover_image'] a.ajaxbox")
+  end
+end

data/spec/features/edit_actions_spec.rb

@@ -0,0 +1,142 @@
+require 'rails_helper'
+feature "Base controller edit", js: true do
+  background do
+    auth_as_user
+    @author = FactoryGirl.create(:author)
+    @good_book = FactoryGirl.create(:book, title: "good book", author: @author, price: 12.34, description_lv: "in lv", description_en: "in en")
+    FactoryGirl.create(:book, title: "bad book", author: @author)
+  end
+
+  scenario "creation of new resources" do
+
+    # normal save button redirects to edit view of the newly created resource
+    visit admin_books_path
+    click_link "Create new resource"
+    wait_for_all_richtexts
+    fill_in "Title", with: "Lorem ipsum"
+    click_button 'Save'
+    expect(page).to have_css('body > .notifications .notification[data-id="resource_status"][data-type="success"]', text: "Create succeeded")
+    wait_for_all_richtexts
+    expect(page).to have_css('header h1', text: 'Lorem ipsum')
+
+    # "save and create another" button redirects to new resource view
+    visit new_admin_book_path
+    wait_for_all_richtexts
+    fill_in "Title", with: "Other ipsum"
+    click_button "Save and create another"
+    expect(page).to have_css('body > .notifications .notification[data-id="resource_status"][data-type="success"]', text: "Create succeeded")
+    wait_for_all_richtexts
+    expect(current_path).to eq new_admin_book_path
+    expect(page).to have_css('header h1', text: 'Create new resource')
+
+    # ENTER key in a field defaults to "save and create another"
+    visit new_admin_book_path
+    wait_for_all_richtexts
+    fill_in "Title", with: "Another ipsum"
+    find('#resource_title').native.send_key(:Enter)
+    expect(page).to have_css('body > .notifications .notification[data-id="resource_status"][data-type="success"]', text: "Create succeeded")
+    expect(page).to have_css('header h1', text: 'Create new resource')
+
+  end
+
+  scenario "keeps search params after deleting record from edit view" do
+    visit admin_books_path(search: "good")
+    click_link("good book")
+    open_toolbox_dialog("Delete")
+    click_button("Yes")
+    expect(page).to have_number_of_resources(0)
+  end
+
+  scenario "when deleting item with restrict relation" do
+    visit edit_admin_author_path @author
+    open_toolbox_dialog("Delete")
+
+    within_dialog do
+      expect(page).to have_css('.restricted-relations .relations li', count: 2)
+    end
+  end
+
+  scenario "drag and drop nested items with ckeditors" do
+      skip "implement drag and drop test"
+  end
+
+  scenario "when clicking on delete restriction relation, it opens edit for related object" do
+    visit edit_admin_author_path @author
+    open_toolbox_dialog("Delete")
+
+    within_dialog do
+      find('.restricted-relations .relations li a', text: "good book").click
+    end
+    expect(page).to have_header(text: "good book")
+  end
+
+  scenario "remember last active locale for localized fields" do
+    visit admin_book_path(id: @good_book.id)
+    within(".localization-switch") do
+      click_button "en"
+    end
+
+    within(".localization-menu-items") do
+      click_button "Lv"
+    end
+    wait_for_all_richtexts
+
+    visit admin_book_path(id: @good_book.id)
+    expect(page).to have_css('#resource_description_lv[value="in lv"]')
+  end
+
+  scenario "editing book uses Book#price instead of Book[:price] (issue #95)" do
+    visit admin_book_path(id: @good_book.id)
+    expect(page).to have_css('#resource_price[value="12.34"]')
+  end
+
+  scenario "do not show 'Back to list' url when no index url passed" do
+    visit admin_books_path(search: "good")
+    click_link("good book")
+    expect(page).to have_link("Back to list")
+    wait_for_all_richtexts
+
+    visit admin_book_path(Book.first)
+    expect(page).to_not have_link("Back to list")
+  end
+
+  scenario "editing nested object with allow_destroy: false" do
+    visit admin_book_path(id: @good_book.id)
+    expect(page).to_not have_css('.remove-nested-item')
+
+    update_resource do
+      find('.nested[data-name="chapters"] .add-nested-item').click
+      expect(page).to have_css('.remove-nested-item')
+      fill_in 'resource_chapters_attributes_0_title', with: 'Chapter 1'
+      fill_in 'resource_chapters_attributes_0_text', with: 'todo'
+      fill_in_richtext 'Sample', with: "xx"
+    end
+
+    expect(page).to_not have_css('.remove-nested-item')
+    expect(page).to have_css('#resource_chapters_attributes_0_title[value="Chapter 1"]')
+  end
+
+  scenario "adding nested objects" do
+    visit new_admin_book_path
+
+    create_resource do
+      fill_in "Title", with: "Master and Margarita"
+      within "[data-name='chapters']" do
+
+        # verify that there are no visible inputs
+        expect( page ).to have_no_selector('input', visible: true)
+        expect( page ).to have_no_selector('textarea', visible: true)
+
+        click_button "Add item"
+
+        fill_in "Title", with: "Chapter 1"
+        fill_in "Text", with: "some text"
+        fill_in_richtext 'Sample', with: "xx"
+      end
+    end
+
+    new_book = Book.where(title: "Master and Margarita").first
+    expect( new_book.chapters.count ).to eq 1
+    expect( new_book.chapters.first.title ).to eq "Chapter 1"
+  end
+end

data/spec/features/errors_spec.rb

@@ -0,0 +1,29 @@
+require 'rails_helper'
+describe "Errors feature" do
+  before do
+    auth_as_user
+  end
+
+  it "returns 404 status code and generic error page for nonexistent rotues" do
+    visit(releaf_root_path + "/asdassd")
+
+    expect(page.status_code).to eq(404)
+    expect(page.body).to match(/not found/)
+  end
+
+  it "returns 403 status code and generic error page for disabled feature" do
+    allow_any_instance_of(Releaf::Permissions::RolesController).to receive(:verify_feature_availability!).and_raise(Releaf::FeatureDisabled, "edit")
+    visit releaf_permissions_roles_path
+
+    expect(page.status_code).to eq(403)
+    expect(page.body).to match(/edit feature disabled for roles/i)
+  end
+
+  it "returns 403 status code and generic error page for restricted content" do
+    allow_any_instance_of(Releaf::Permissions::AccessControl).to receive(:controller_permitted?).and_return(false)
+    visit releaf_permissions_roles_path
+
+    expect(page.status_code).to eq(403)
+    expect(page.body).to match(/you are not authorized to access roles/i)
+  end
+end

data/spec/features/index_actions_spec.rb

@@ -0,0 +1,85 @@
+require 'rails_helper'
+feature "Base controller index", js: true do
+  background do
+    auth_as_user
+    author = FactoryGirl.create(:author)
+    good_book = FactoryGirl.create(:book, title: "good book", author: author, published_at: Date.parse("2015-12-12"))
+    FactoryGirl.create(:chapter, title: 'Scary night', text: 'Once upon a time...', book: good_book)
+    FactoryGirl.create(:book, title: "bad book", author: author)
+  end
+
+  scenario "shows resource count" do
+    visit admin_books_path
+    expect(page).to have_number_of_resources(2)
+  end
+
+  scenario "search resources dynamically" do
+    visit admin_books_path
+    search "good"
+    expect(page).to have_number_of_resources(1)
+
+    check "Only active"
+    expect(page).to have_number_of_resources(0)
+
+    uncheck "Only active"
+    expect(page).to have_number_of_resources(1)
+
+    fill_in "Published between", with: "2015-11-11"
+    click_button "Filter"
+
+    expect(page).to have_number_of_resources(1)
+  end
+
+  scenario "search by 2nd level nested fields" do
+    visit admin_authors_path
+    search "upon"
+    expect(page).to have_number_of_resources(1)
+  end
+
+  scenario "search nonexisting stuff" do
+    visit admin_authors_path
+    search "bunnyrabit"
+    expect(page).to have_number_of_resources(0)
+  end
+
+  scenario "no row urls when :edit feature is not available" do
+    visit admin_books_path
+    expect(page).to have_link("good book")
+
+    allow_any_instance_of(Admin::BooksController).to receive(:feature_available?).with(:edit).and_return(false)
+    visit admin_books_path
+    expect(page).to_not have_link("good book")
+  end
+
+  scenario "keeps search parameters when navigating to edit and back" do
+    visit admin_books_path(search: "good")
+    click_link("good book")
+    wait_for_all_richtexts
+    click_link("Back to list")
+    expect(page).to have_number_of_resources(1)
+  end
+
+  scenario "keeps search parameters after delete" do
+    visit admin_books_path(search: "good")
+    open_toolbox_dialog('Delete', Book.first)
+    click_button("Yes")
+    expect(page).to have_number_of_resources(0)
+  end
+
+  scenario "when deleting item in edit" do
+    visit admin_books_path(search: "good")
+    click_link("good book")
+    open_toolbox_dialog('Delete')
+    click_button("Yes")
+    expect(page).to have_number_of_resources(0)
+  end
+
+  scenario "when deleting item with restrict relation" do
+    visit admin_authors_path
+    open_toolbox_dialog('Delete', Author.first)
+
+    within_dialog do
+      expect(page).to have_css('.restricted-relations .relations li', count: 2)
+    end
+  end
+end