releaf-content 2.0.0 → 2.0.1

data/spec/services/releaf/content/node/service_spec.rb

@@ -1,19 +0,0 @@
-require "rails_helper"
-
-describe Releaf::Content::Node::Service do
-  class DummyNodeServiceIncluder
-    include Releaf::Content::Node::Service
-  end
-
-  let(:node){ Node.new }
-  subject{ DummyNodeServiceIncluder.new(node: node) }
-
-  describe "#add_error_and_raise" do
-    it "adds errors to base and raise validation error" do
-      expect{ subject.add_error_and_raise("shit happen") }.to raise_error do |exception|
-        expect(exception).to be_instance_of ActiveRecord::RecordInvalid
-        expect(exception.record.errors[:base]).to eq(["shit happen"])
-      end
-    end
-  end
-end

data/spec/validators/content/node/parent_validator_spec.rb

@@ -1,56 +0,0 @@
-require 'rails_helper'
-
-describe Releaf::Content::Node::ParentValidator do
-  let!(:root_node) { FactoryBot.create(:node, content_type: 'HomePage') }
-
-  class DummyNodeParentValidatorModel < ActiveRecord::Base
-    acts_as_node
-    self.table_name = 'texts'
-  end
-
-  class DummyNodeParentValidator1Controller < ActionController::Base
-    acts_as_node
-  end
-
-  class DummyNodeParentValidator2Controller < ActionController::Base
-    acts_as_node
-  end
-
-
-  class DummyNodeParentValidatorNode < ActiveRecord::Base
-    self.table_name = 'nodes'
-    include Releaf::Content::Node
-    validates_with Releaf::Content::Node::ParentValidator, for: DummyNodeParentValidatorModel, under: DummyNodeParentValidator1Controller
-  end
-
-  context "when parent is valid" do
-    it "doesn't add error" do
-      parent = DummyNodeParentValidatorNode.create!( FactoryBot.attributes_for(:node, content_type: 'DummyNodeParentValidator1Controller') )
-      child  = DummyNodeParentValidatorNode.new( FactoryBot.attributes_for(:node, content_type: 'DummyNodeParentValidatorModel', parent_id: parent.id) )
-
-      expect( child ).to be_valid
-    end
-  end
-
-  context "when parent is invalid" do
-    it "adds error on content_type" do
-      parent = DummyNodeParentValidatorNode.create!( FactoryBot.attributes_for(:node, content_type: 'DummyNodeParentValidator2Controller') )
-      child  = DummyNodeParentValidatorNode.new( FactoryBot.attributes_for(:node, content_type: 'DummyNodeParentValidatorModel', parent_id: parent.id) )
-
-      expect( child ).to be_invalid
-      expect( child.errors[:content_type].size ).to eq(1)
-      expect( child.errors[:content_type] ).to include("invalid parent node")
-    end
-
-  end
-
-  context "when content_type is not in child list" do
-    it "doesn't add error" do
-      parent = DummyNodeParentValidatorNode.create!( FactoryBot.attributes_for(:node, content_type: 'DummyNodeParentValidator1Controller') )
-      child  = DummyNodeParentValidatorNode.new( FactoryBot.attributes_for(:node, content_type: 'DummyNodeParentValidator2Controller', parent_id: parent.id) )
-
-      expect( child ).to be_valid
-    end
-  end
-
-end

data/spec/validators/content/node/root_validator_spec.rb

@@ -1,69 +0,0 @@
-require 'rails_helper'
-
-describe Releaf::Content::Node::RootValidator do
-
-
-  class DummyRootValidatorController < ActionController::Base
-    acts_as_node
-  end
-
-  class DummyRootValidator2Controller < ActionController::Base
-    acts_as_node
-  end
-
-  class DummyRootValidatorNode < ActiveRecord::Base
-    self.table_name = 'nodes'
-    include Releaf::Content::Node
-    validates_with Releaf::Content::Node::RootValidator, allow: DummyRootValidatorController
-  end
-
-
-  def create_node *params
-    DummyRootValidatorNode.create!( FactoryBot.attributes_for(:node, *params) )
-  end
-
-  def build_node *params
-    DummyRootValidatorNode.new( FactoryBot.attributes_for(:node, *params) )
-  end
-
-  context "when node is allowed to be root node" do
-    context "when node is a root node" do
-      it "doesn't add an error" do
-        root_node = build_node(content_type: 'DummyRootValidatorController')
-        expect( root_node ).to be_valid
-      end
-    end
-
-    context "when node is not a root node" do
-      it "adds an error" do
-        root_node = create_node(content_type: 'DummyRootValidatorController')
-        subnode = build_node(content_type: 'DummyRootValidatorController', parent: root_node)
-        expect( subnode ).to be_invalid
-        expect( subnode.errors[:content_type].size ).to eq(1)
-        expect( subnode.errors[:content_type] ).to include("can't be subnode")
-      end
-    end
-  end
-
-  context "when node is not allowed to be a root node" do
-    context "when node is a root node" do
-      it "adds an error" do
-        root_node = build_node(content_type: 'DummyRootValidator2Controller')
-        expect( root_node ).to be_invalid
-        expect( root_node.errors[:content_type].size ).to eq(1)
-        expect( root_node.errors[:content_type] ).to include("can't be root node")
-      end
-    end
-
-    context "when node is not a root node" do
-      it "doesn't add an error" do
-        root_node = create_node(content_type: 'DummyRootValidatorController')
-        subnode = build_node(content_type: 'DummyRootValidator2Controller', parent: root_node)
-
-        expect( subnode ).to be_valid
-      end
-    end
-  end
-
-
-end

data/spec/validators/content/node/singleness_validator_spec.rb

@@ -1,145 +0,0 @@
-require 'rails_helper'
-
-describe Releaf::Content::Node::SinglenessValidator do
-
-
-  class DummySinglenessValidatorModel < ActiveRecord::Base
-    acts_as_node
-    self.table_name = 'text_pages'
-  end
-
-  class DummySinglenessValidator2Model < ActiveRecord::Base
-    acts_as_node
-    self.table_name = 'text_pages'
-  end
-
-  class DummySinglenessValidatorController < ActionController::Base
-    acts_as_node
-  end
-
-  class DummySinglenessValidator2Controller < ActionController::Base
-    acts_as_node
-  end
-
-  class DummySinglenessValidatorNode < ActiveRecord::Base
-    self.table_name = 'nodes'
-    include Releaf::Content::Node
-    validates_with Releaf::Content::Node::SinglenessValidator, for: DummySinglenessValidatorModel
-    validates_with Releaf::Content::Node::SinglenessValidator, for: DummySinglenessValidator2Controller, under: TextPage
-  end
-
-
-  def create_node *params
-    DummySinglenessValidatorNode.create!( FactoryBot.attributes_for(:node, *params) )
-  end
-
-  def build_node *params
-    DummySinglenessValidatorNode.new( FactoryBot.attributes_for(:node, *params) )
-  end
-
-  let!(:root_node) { create_node(content_type: 'HomePage') }
-
-
-  context "when scope is entire page" do
-
-    context "When node not mentioned in list" do
-      it "doesn't add error" do
-        node = build_node(content_type: 'DummySinglenessValidatorController', parent_id: root_node.id)
-        expect( node ).to be_valid
-      end
-    end
-
-
-    context "when node with given content doesn't exist in tree" do
-      it "doesn't add error" do
-        node = build_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
-        expect( node ).to be_valid
-      end
-    end
-
-    context "when node with given content exists in tree" do
-      before do
-        create_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
-      end
-
-      it "adds error to #content_type" do
-        node = build_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
-        expect( node ).to be_invalid
-        expect( node.errors[:content_type].size ).to eq(1)
-        expect( node.errors[:content_type] ).to include("node exists")
-      end
-
-    end
-
-    context "when node is saved, and is only one in the tree" do
-      it "doesn't add error" do
-        node = create_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
-        expect( node ).to be_valid
-      end
-    end
-  end
-
-  context "when scope is subtree" do
-    context "when has ancestor in :under list" do
-      let!(:grand_parent_node) { create_node(content_type: 'TextPage', parent_id: root_node.id) }
-      let!(:parent_node) { create_node(content_type: 'DummySinglenessValidator2Model', parent_id: grand_parent_node.id) }
-
-      context "when node with given content doesn't exist in subtree" do
-        it "doesn't add error" do
-          node = build_node(content_type: 'DummySinglenessValidator2Controller', parent_id: parent_node.id)
-          expect( node ).to be_valid
-        end
-      end
-
-      context "when node with given content exists in subtree" do
-        before do
-          create_node(content_type: 'DummySinglenessValidator2Controller', parent_id: grand_parent_node.id)
-        end
-
-        it "adds error to #content_type" do
-          node = build_node(content_type: 'DummySinglenessValidator2Controller', parent_id: parent_node.id)
-          expect( node ).to be_invalid
-          expect( node.errors[:content_type].size ).to eq(1)
-          expect( node.errors[:content_type] ).to include("node exists")
-        end
-
-      end
-
-      context "when node is saved, and is only one in subtree" do
-        it "doesn't add error" do
-          node = create_node(content_type: 'DummySinglenessValidator2Controller', parent_id: parent_node.id)
-          expect( node ).to be_valid
-        end
-      end
-
-
-    end
-
-    context "when node has no ancestor in :under list" do
-      it "doesn't add error" do
-        node = create_node(content_type: 'DummySinglenessValidator2Controller', parent_id: root_node.id)
-        expect( node ).to be_valid
-      end
-    end
-  end
-
-  context "regression tests" do
-    context "@node.parent.self_and_ancestors bug" do
-      it "works correctly / is worked around" do
-        # for details see Releaf::Content::Node::SinglenessValidator#base_relation_for_subtree
-        @node1 = create_node(content_type: 'TextPage', locale: 'en')
-        @node2 = create_node(content_type: 'TextPage', locale: 'lv')
-        @node3 = create_node(content_type: 'TextPage', locale: 'ru')
-        @node4 = create_node(content_type: 'TextPage', locale: 'sp')
-
-        @node1_1 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node1)
-        expect do
-          @node1_2 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node2)
-          @node1_3 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node3)
-          @node1_4 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node4)
-        end.to_not raise_error
-      end
-    end
-  end
-
-end