releaf-content 0.2.1 → 1.0.3

data/lib/releaf/content/node_mapper.rb

@@ -1,9 +1,35 @@
 module Releaf::Content
   module NodeMapper
-    def releaf_routes_for(node_class, controller: Releaf::Content::Route.node_class_default_controller(node_class), &block)
-      Releaf::Content::Route.for(node_class, controller).each do |route|
+    attr_accessor :default_node_class
+
+    def node_routes_for(
+      node_content_class,
+      controller: Releaf::Content::Route.default_controller(node_content_class),
+      node_class: default_node_class || Releaf::Content.default_model,
+      &block
+    )
+      Releaf::Content::Route.for(node_class, node_content_class, controller).each do |route|
         Releaf::Content::RouterProxy.new(self, route).draw(&block)
       end
     end
+
+    def for_node_class( node_class )
+      previous_node_class = self.default_node_class
+      self.default_node_class = node_class
+      yield if block_given?
+      self.default_node_class = previous_node_class
+    end
+
+    # expects Releaf::Content.routing hash or a subset of it as an argument
+    def node_routing( routing )
+      routing.each_pair do | node_class_name, node_class_routing |
+        constraints node_class_routing[:constraints] do
+          for_node_class(node_class_name.constantize) do
+            yield
+          end
+        end
+      end
+    end
+
   end
 end

data/lib/releaf/content/route.rb

@@ -1,17 +1,12 @@
 module Releaf::Content
   class Route
-    attr_accessor :path, :node, :locale, :node_id, :default_controller
+    attr_accessor :path, :node, :locale, :node_class, :node_id, :default_controller, :site
 
-    def self.node_class
-      # TODO model should be configurable
-      ::Node
-    end
-
-    def self.node_class_default_controller(node_class)
-      if node_class <= ActionController::Base
-        node_class.name.underscore.sub(/_controller$/, '')
+    def self.default_controller(node_content_class)
+      if node_content_class <= ActionController::Base
+        node_content_class.name.underscore.sub(/_controller$/, '')
       else
-        node_class.name.pluralize.underscore
+        node_content_class.name.pluralize.underscore
       end
     end
 
@@ -22,29 +17,47 @@ module Releaf::Content
     # @return [Hash] route options. Will return at least node "node_id" and "locale" keys.
     def params(method_or_path, options = {})
       method_or_path = method_or_path.to_s
-      action_path = path_for(method_or_path, options)
-      options[:to] = controller_and_action_for(method_or_path, options)
+      [
+        path_for(method_or_path, options),
+        options_for(method_or_path, options)
+      ]
+    end
 
+    def options_for( method_or_path, options )
       route_options = options.merge({
-        node_id: node_id.to_s,
-        locale: locale,
+        to:         controller_and_action_for(method_or_path, options),
+        node_class: node_class.name,
+        node_id:    node_id.to_s,
+        locale:     locale
       })
 
-      # normalize as with locale
-      if locale.present? && route_options[:as].present?
-        route_options[:as] = "#{locale}_#{route_options[:as]}"
-      end
+      route_options[:site] = site if site.present?
+      route_options[:as] = name( route_options )
 
-      [action_path, route_options]
+      route_options
+    end
+
+    def name( route_options )
+      return nil unless route_options[:as].present?
+
+      # prepend :as with locale and site to prevent duplicate route names
+      name_parts = [ route_options[:as] ]
+
+      name_parts.unshift( route_options[:locale] ) if route_options[:locale].present?
+      name_parts.unshift( route_options[:site] ) if route_options[:site].present?
+
+      name_parts.join('_')
     end
 
     # Return routes for given class that implement ActsAsNode
     #
-    # @param class_name [Class] class name to load related nodes
+    # @param node_class [Class] class name to load related nodes
+    # @param node_content_class [Class] class name to load related nodes
     # @param default_controller [String]
     # @return [Array] array of Content::Route objects
-    def self.for(content_type, default_controller)
-      node_class.where(content_type: content_type).each.inject([]) do |routes, node|
+    def self.for(node_class, node_content_class, default_controller)
+      node_class = node_class.constantize if node_class.is_a? String
+      node_class.where(content_type: node_content_class).each.inject([]) do |routes, node|
         routes << build_route_object(node, default_controller) if node.available?
         routes
       end
@@ -55,16 +68,15 @@ module Releaf::Content
     # Build Content::Route from Node object
     def self.build_route_object(node, default_controller)
       route = new
+      route.node_class = node.class
       route.node_id = node.id.to_s
       route.path = node.path
       route.locale = node.root.locale
       route.default_controller = default_controller
-
+      route.site = Releaf::Content.routing[node.class.name][:site]
       route
     end
 
-    private
-
     def path_for(method_or_path, options)
       if method_or_path.include?('#')
         path

data/spec/builders/content/nodes/action_dialog_spec.rb

@@ -0,0 +1,39 @@
+require "rails_helper"
+
+describe Releaf::Content::Builders::ActionDialog, type: :class do
+  class ConfirmDestroyDialogTestHelper < ActionView::Base
+    include Releaf::ApplicationHelper
+  end
+
+  class ActionDialogIncluder
+    include Releaf::Content::Builders::ActionDialog
+    def action; end
+  end
+
+  let(:template){ ConfirmDestroyDialogTestHelper.new }
+  let(:object){ Book.new }
+  let(:subject){ ActionDialogIncluder.new(template) }
+
+  describe "#confirm_button_text" do
+    it "returns translation for humanized builder action" do
+      allow(subject).to receive(:action).and_return(:move_to_the_right)
+      allow(subject).to receive(:t).with("Move to the right").and_return("to the left")
+      expect(subject.confirm_button_text).to eq("to the left")
+    end
+  end
+
+  describe "#confirm_button_attributes" do
+    it "returns hash with confirm button attributes" do
+      expect(subject.confirm_button_attributes).to be_instance_of Hash
+    end
+  end
+
+  describe "#confirm_button" do
+    it "returns confirm button" do
+      allow(subject).to receive(:confirm_button_text).and_return("Yess")
+      allow(subject).to receive(:confirm_button_attributes).and_return(a: "b")
+      allow(subject).to receive(:button).with("Yess", "check", a: "b").and_return("x")
+      expect(subject.confirm_button).to eq("x")
+    end
+  end
+end

data/spec/builders/content/nodes/form_builder_spec.rb

@@ -159,12 +159,56 @@ describe Releaf::Content::Nodes::FormBuilder, type: :class do
     end
   end
 
+  describe "#slug_base_url" do
+    before do
+      request = double(:request, protocol: "http:://", host_with_port: "somehost:8080")
+      allow(subject).to receive(:request).and_return(request)
+      allow(object).to receive(:parent).and_return(Node.new)
+    end
+
+    context "when trailing slash for path enabled" do
+      it "returns absolute url without extra slash added" do
+        allow(object).to receive(:trailing_slash_for_path?).and_return(true)
+        allow(object.parent).to receive(:path).and_return("/parent/path/")
+        expect(subject.slug_base_url).to eq("http:://somehost:8080/parent/path/")
+      end
+    end
+
+    context "when trailing slash for path disabled" do
+      it "returns absolute url with extra slash added" do
+        allow(object).to receive(:trailing_slash_for_path?).and_return(false)
+        allow(object.parent).to receive(:path).and_return("/parent/path")
+        expect(subject.slug_base_url).to eq("http:://somehost:8080/parent/path/")
+      end
+    end
+  end
+
+  describe "#slug_link" do
+    before do
+      allow(subject).to receive(:slug_base_url).and_return("http://some.host/parent/path/")
+    end
+
+    context "when trailing slash for path enabled" do
+      it "returns absolute url without extra slash added" do
+        allow(object).to receive(:trailing_slash_for_path?).and_return(true)
+        expect(subject.slug_link).to eq('<a href="/a/b/">http://some.host/parent/path/<span>b</span>/</a>')
+      end
+    end
+
+    context "when trailing slash for path disabled" do
+      it "returns absolute url with extra slash added" do
+        allow(object).to receive(:trailing_slash_for_path?).and_return(false)
+        expect(subject.slug_link).to eq('<a href="/a/b">http://some.host/parent/path/<span>b</span></a>')
+      end
+    end
+  end
+
   describe "#render_slug" do
     it "renders customized field" do
-      controller = Releaf::BaseController.new
+      controller = Admin::NodesController.new
       allow(subject).to receive(:controller).and_return(controller)
       allow(subject).to receive(:slug_base_url).and_return("http://localhost/parent")
-      allow(subject).to receive(:url_for).with(controller: "/releaf/content/nodes", action: "generate_url", parent_id: 1, id: 2)
+      allow(subject).to receive(:url_for).with(controller: "admin/nodes", action: "generate_url", parent_id: 1, id: 2)
         .and_return("http://localhost/slug-generation-url")
 
       content = '
@@ -178,7 +222,7 @@ describe Releaf::Content::Nodes::FormBuilder, type: :class do
                       <i class="fa fa-keyboard-o"></i>
                   </button>
                   <div class="link">
-                      <a href="/a/b">http://localhost/parent<span>b</span>/</a>
+                      <a href="/a/b">http://localhost/parent<span>b</span></a>
                   </div>
              </div>
          </div>

data/spec/builders/content/nodes/toolbox_builder_spec.rb

@@ -27,7 +27,6 @@ describe Releaf::Content::Nodes::ToolboxBuilder, type: :class do
     before do
       allow(subject).to receive(:params).and_return({})
       allow(subject).to receive(:add_child_button).and_return( :add_child_item )
-      allow(subject).to receive(:go_to_button).and_return( :go_to_item )
       allow(subject).to receive(:copy_button).and_return( :copy_item )
       allow(subject).to receive(:move_button).and_return( :move_item )
     end
@@ -41,26 +40,6 @@ describe Releaf::Content::Nodes::ToolboxBuilder, type: :class do
 
     end
 
-    context "when applied to an existing record" do
-
-      before do
-        allow(node).to receive(:new_record?).and_return false
-      end
-
-      it "prepends add child, go to, copy and move items to the list returned by parent class" do
-        expect(subject.items).to eq([ :add_child_item, :go_to_item, :copy_item, :move_item, :super_item ])
-      end
-
-      context "when in index context" do
-
-        it "does not include go_to_item" do
-          allow(subject).to receive(:params).and_return({ context: "index" })
-          expect(subject.items).to eq([ :add_child_item, :copy_item, :move_item, :super_item ])
-        end
-      end
-
-    end
-
   end
 
   describe "item methods" do
@@ -74,16 +53,6 @@ describe Releaf::Content::Nodes::ToolboxBuilder, type: :class do
       end
     end
 
-    describe "#go_to_button" do
-      it "returns an ajaxbox link to go to dialog" do
-        allow(subject).to receive(:t).with('Go to').and_return('gotoxx')
-        allow(subject).to receive(:url_for).with(action: 'go_to_dialog').and_return('dialogurl')
-        html = '<a class="button ajaxbox" title="gotoxx" href="dialogurl">gotoxx</a>'
-        expect(subject.go_to_button).to eq(html)
-      end
-    end
-
-
     describe "#copy_button" do
       it "returns an ajaxbox link to copy dialog" do
         allow(subject).to receive(:t).with('Copy').and_return('copyxx')
@@ -105,4 +74,4 @@ describe Releaf::Content::Nodes::ToolboxBuilder, type: :class do
 
   end
 
-end
+end

data/spec/controllers/releaf/content/nodes_controller_spec.rb

@@ -1,21 +1,52 @@
 require 'rails_helper'
 
 describe Releaf::Content::NodesController do
-  describe "#builder_scopes" do
-    it "adds node builder scope as first scope before default builder scopes" do
-      allow(subject).to receive(:application_scope).and_return("Admin")
-      allow(subject).to receive(:node_builder_scope).and_return("xx")
-      expect(subject.builder_scopes).to eq(["xx", "Releaf::Content::Nodes", "Admin::Builders"])
+
+  describe "#features"do
+    it "excludes `create another` and `search` features" do
+      expect(subject.features).to_not include(:create_another, :search)
     end
   end
 
-  describe "#node_builder_scope" do
-    it "returns node builder scope within releaf mount location scope" do
-      allow(subject).to receive(:application_scope).and_return("Admin")
-      expect(subject.node_builder_scope).to eq("Admin::Nodes")
+  describe "#ancestor_nodes" do
+    let(:node){ Node.new }
+    let(:ancestors){ Node.where(id: 1212) }
+
+    before do
+      allow(ancestors).to receive(:reorder).with(:depth).and_return(["depth_ordered_ancestors"])
+    end
+
+    context "when new node" do
+      context "when node has parent" do
+        it "returns parent ancestors ordered by depth alongside parent ancestor" do
+          parent_node = Node.new
+          node.parent = parent_node
+          allow(parent_node).to receive(:ancestors).and_return(ancestors)
+          expect(subject.ancestor_nodes(node)).to eq(["depth_ordered_ancestors", parent_node])
+        end
+      end
+
+      context "when node has no parent" do
+        it "returns empty array" do
+          expect(subject.ancestor_nodes(node)).to eq([])
+        end
+      end
+    end
+
+    context "when persisted node" do
+      it "returns resource ancestors ordered by depth" do
+        allow(node).to receive(:persisted?).and_return(true)
+        allow(node).to receive(:ancestors).and_return(ancestors)
+        expect(subject.ancestor_nodes(node)).to eq(["depth_ordered_ancestors"])
+      end
+    end
+  end
 
-      allow(subject).to receive(:application_scope).and_return(nil)
-      expect(subject.node_builder_scope).to eq("Nodes")
+  describe ".resource_class" do
+    it "looks up node class in releaf content resource configuration" do
+      config = { 'OtherSite::OtherNode' => { controller: 'Releaf::Content::NodesController' } }
+      allow( Releaf::Content ).to receive(:resources).and_return(config)
+      expect( described_class.resource_class ).to be OtherSite::OtherNode
     end
   end
 end

data/spec/features/nodes_services_spec.rb

@@ -0,0 +1,207 @@
+require 'rails_helper'
+describe "Nodes services (copy, move)" do
+
+  describe "Moving" do
+    before do
+      @home_page_node = create(:home_page_node, locale: "lv")
+      @home_page_node_2 = create(:home_page_node, locale: "en")
+      @text_page_node_3 = create(:text_page_node, parent_id: @home_page_node_2.id)
+      @text_page_node_4 = create(:text_page_node, parent_id: @text_page_node_3.id)
+
+      # it is important to reload nodes, otherwise associations will return empty set
+      @home_page_node.reload
+      @home_page_node_2.reload
+      @text_page_node_3.reload
+      @text_page_node_4.reload
+    end
+
+    context "when one of children becomes invalid" do
+      before do
+        @text_page_node_4.name = nil
+        @text_page_node_4.save(validate: false)
+      end
+
+      it "raises ActiveRecord::RecordInvalid" do
+        expect { @text_page_node_3.move(@home_page_node.id) }.to raise_error ActiveRecord::RecordInvalid
+      end
+
+      it "raises error on node being moved, even tought descendant has error" do
+        begin
+          @text_page_node_3.move(@home_page_node.id)
+        rescue ActiveRecord::RecordInvalid => e
+          expect( e.record ).to eq @text_page_node_3
+        end
+
+        expect(@text_page_node_3.errors.messages).to eq(name: [], base: ["descendant invalid"])
+      end
+    end
+
+    context "when moving existing node to other nodes child's position" do
+      it "changes parent_id" do
+        expect{ @text_page_node_3.move(@home_page_node.id) }.to change{ Node.find(@text_page_node_3.id).parent_id }.from(@home_page_node_2.id).to(@home_page_node.id)
+      end
+    end
+
+    context "when moving to self child's position" do
+      it "raises ActiveRecord::RecordInvalid" do
+        expect{ @text_page_node_3.move(@text_page_node_3.id) }.to raise_error(ActiveRecord::RecordInvalid)
+      end
+    end
+
+    context "when passing nil as target node" do
+      it "updates parent_id" do
+        allow_any_instance_of(Releaf::Content::Node::RootValidator).to receive(:validate)
+        @home_page_node.destroy
+        expect{ @text_page_node_3.move(nil) }.to change { Node.find(@text_page_node_3.id).parent_id }.to(nil)
+      end
+    end
+
+    context "when passing nonexistent target node's id" do
+      it "raises ActiveRecord::RecordInvalid" do
+        expect{ @text_page_node_3.move(998123) }.to raise_error(ActiveRecord::RecordInvalid)
+      end
+    end
+
+  end
+
+  describe "Copying", create_nodes: true do
+    before create_nodes: true do
+      @home_page_node = create(:home_page_node, locale: "lv")
+      @home_page_node_2 = create(:home_page_node, locale: "en")
+      @text_page_node_3 = create(:text_page_node, parent_id: @home_page_node_2.id)
+      @text_page_node_4 = create(:text_page_node, parent_id: @text_page_node_3.id)
+      @text_page_node_5 = create(:text_page_node, parent_id: @text_page_node_4.id)
+
+      # it is important to reload nodes, otherwise associations will return empty set
+      @home_page_node.reload
+      @home_page_node_2.reload
+      @text_page_node_3.reload
+      @text_page_node_4.reload
+    end
+
+    context "when one of children becomes invalid" do
+      before do
+        @text_page_node_4.name = nil
+        @text_page_node_4.save(validate: false)
+      end
+
+      it "raises ActiveRecord::RecordInvalid" do
+        expect { @text_page_node_3.copy(@home_page_node.id) }.to raise_error ActiveRecord::RecordInvalid
+      end
+
+      it "raises error on node being copied" do
+        begin
+          @text_page_node_3.copy(@home_page_node.id)
+        rescue ActiveRecord::RecordInvalid => e
+          expect( e.record ).to eq @text_page_node_3
+        end
+        expect(@text_page_node_3.errors.messages).to eq(base: ["descendant invalid"])
+      end
+
+      it "doesn't create any new nodes" do
+        expect do
+          begin
+            @text_page_node_3.copy(@home_page_node.id)
+          rescue ActiveRecord::RecordInvalid
+          end
+        end.to_not change { Node.count }
+      end
+
+      it "doesn't update settings timestamp" do
+        expect( Node ).to_not receive(:updated)
+        begin
+          @text_page_node_3.copy(@home_page_node.id)
+        rescue ActiveRecord::RecordInvalid
+        end
+      end
+
+    end
+
+
+    context "with corect parent_id" do
+      it "creates node along with descendant nodes" do
+        expect{ @text_page_node_3.copy(@home_page_node.id) }.to change{ Node.count }.by( @text_page_node_3.descendants.size + 1 )
+      end
+
+      it "correctly copies attributes" do
+        allow( @text_page_node_3 ).to receive(:children).and_return([@text_page_node_4])
+        allow( @text_page_node_4 ).to receive(:children).and_return([@text_page_node_5])
+
+        @text_page_node_3.update_attribute(:active, false)
+        @text_page_node_4.update_attribute(:active, false)
+
+        allow( @text_page_node_3 ).to receive(:attributes_to_copy).and_return(["name", "parent_id", "content_type"])
+
+        @text_page_node_3.copy(@home_page_node.id)
+
+        @node_2_copy = @home_page_node.children.first
+        @node_3_copy = @node_2_copy.children.first
+        @node_4_copy = @node_3_copy.children.first
+
+        # new nodes by default are active, however we stubbed
+        # #attributes_to_copy of @test_node_2 to not return active attribute
+        # Also we updated @test_node_2#active to be false.
+        # However copy is active, because active attribute wasn't copied
+        expect( @node_2_copy ).to be_active
+        # for copy of @text_page_node_3 active attribute was copied however, as it
+        # should have been
+        expect( @node_3_copy ).to_not be_active
+        expect( @node_4_copy ).to be_active
+
+        expect( @node_2_copy.name ).to eq @text_page_node_3.name
+        expect( @node_3_copy.name ).to eq @text_page_node_4.name
+        expect( @node_4_copy.name ).to eq @text_page_node_5.name
+      end
+
+      it "updates settings timestamp only once" do
+        expect( Node ).to receive(:updated).once.and_call_original
+        @text_page_node_3.copy(@home_page_node.id)
+      end
+
+      context "when parent_id is nil" do
+        it "creates new node" do
+          allow_any_instance_of(Releaf::Content::Node::RootValidator).to receive(:validate)
+          expect{ @text_page_node_3.copy(nil) }.to change{ Node.count }.by(3)
+        end
+      end
+
+      context "when copying root nodes", create_nodes: false do
+        context "when root locale uniqueness is validated" do
+          it "resets locale to nil" do
+            @text_page_node = create(:home_page_node, locale: 'en')
+            allow_any_instance_of(Node).to receive(:validate_root_locale_uniqueness?).and_return(true)
+            @text_page_node.copy(nil)
+            expect( Node.last.locale ).to eq nil
+          end
+        end
+
+        context "when root locale uniqueness is not validated" do
+          it "doesn't reset locale to nil" do
+            @text_page_node = create(:home_page_node, locale: 'en')
+            allow_any_instance_of(Node).to receive(:validate_root_locale_uniqueness?).and_return(false)
+            @text_page_node.copy(nil)
+            expect( Node.last.locale ).to eq 'en'
+          end
+        end
+      end
+    end
+
+    context "with nonexistent parent_id" do
+      it "raises ActiveRecord::RecordInvalid" do
+        expect { @text_page_node_3.copy(99991) }.to raise_error(ActiveRecord::RecordInvalid)
+      end
+    end
+
+    context "with same parent_id as node.id" do
+      it "raises ActiveRecord::RecordInvalid" do
+        expect{ @text_page_node_3.copy(@text_page_node_3.id) }.to raise_error(ActiveRecord::RecordInvalid)
+      end
+    end
+
+    context "when copying to child node" do
+      it "raises ActiveRecord::RecordInvalid" do
+        expect{ @text_page_node_3.copy(@text_page_node_4.id) }.to raise_error(ActiveRecord::RecordInvalid)
+      end
+    end
+  end
+end