releaf-content 0.2.1

data/spec/lib/releaf/content/route_spec.rb

@@ -0,0 +1,85 @@
+require "rails_helper"
+
+describe Releaf::Content::Route do
+  let(:node_route) { FactoryGirl.build(:node_route, node_id: 12, locale: "en", path: "/en") }
+
+  describe ".node_class" do
+    it "returns ::Node" do
+      expect( described_class.node_class ).to eq ::Node
+    end
+  end
+
+  describe ".node_class_default_controller" do
+    context "when given node class inherits `ActionController::Base`" do
+      it "returns undercored, stripped down controller class" do
+        expect(described_class.node_class_default_controller(HomePagesController)).to eq("home_pages")
+      end
+    end
+
+    context "when given node class does not inherit `ActionController::Base`" do
+      it "returns pluralized, underscorized class" do
+        expect(described_class.node_class_default_controller(TextPage)).to eq("text_pages")
+      end
+    end
+  end
+
+  describe ".for" do
+    before do
+      create(:home_page_node)
+    end
+
+    it "returns an array" do
+      expect(described_class.for(HomePage, 'foo').class).to eq(Array)
+    end
+
+    context "when databse doesn't exists" do
+      it "returns an empty array" do
+        allow(described_class.node_class).to receive(:where).and_raise(ActiveRecord::NoDatabaseError.new("xxx"))
+        expect(described_class.for(HomePage, 'foo')).to eq([])
+      end
+    end
+
+    context "when releaf_nodes table doesn't exists" do
+      it "returns an empty array" do
+        allow(described_class.node_class).to receive(:where).and_raise(ActiveRecord::StatementInvalid.new("xxx"))
+        expect(described_class.for(HomePage, 'foo')).to eq([])
+      end
+    end
+
+    context "when releaf_nodes table exists" do
+      it "returns an array of Node::Route objects" do
+        result = described_class.for(HomePage, 'foo')
+        expect(result.count).to eq(1)
+        expect(result.first.class).to eq(described_class)
+      end
+
+      context "when node is not available" do
+        it "does not include it in return" do
+          allow_any_instance_of(Node).to receive(:available?).and_return(false)
+          expect(described_class.for(HomePage, 'foo')).to eq([])
+        end
+      end
+    end
+  end
+
+  describe '#params' do
+    it "returns params for router method" do
+      expect(node_route.params("home#index")).to eq ['/en', {:node_id=>"12", :locale=>"en", :to=>"home#index"}]
+    end
+
+    context "when :as given in args" do
+      context "when node has a locale" do
+        it "prepends locale to :as" do
+          expect(node_route.params("home#index", as: "home").last).to match hash_including(as: "en_home")
+        end
+      end
+
+      context "when node does not have a locale" do
+        it "doesn't modify :as option" do
+          node_route.locale = nil
+          expect(node_route.params("home#index", as: "home").last).to match hash_including(as: "home")
+        end
+      end
+    end
+  end
+end

data/spec/middleware/routes_reloader_spec.rb

@@ -0,0 +1,48 @@
+require "rails_helper"
+
+describe Releaf::Content::RoutesReloader do
+  let(:app) { ->(env) { [200, env, "app"] } }
+
+  let :request do
+    described_class.new(app).call(Rack::MockRequest.env_for('http://example.com'))
+  end
+
+  describe "on application startup" do
+    it "sets routes loading time" do
+      expect(described_class.routes_loaded).to_not be_nil
+    end
+  end
+
+  describe "on each request" do
+    it "compares latest updates" do
+      expect(described_class).to receive(:reload_if_expired)
+      request
+    end
+  end
+
+  describe ".reload_if_expired" do
+    context "when no nodes exists" do
+      it "does not reload routes" do
+        allow(Node).to receive(:updated_at).and_return(nil)
+        expect(Rails.application).to_not receive(:reload_routes!)
+        described_class.reload_if_expired
+      end
+    end
+
+    context "when routes is up to date" do
+      it "does not reload routes" do
+        allow(Node).to receive(:updated_at).and_return(Time.parse("1991-01-01"))
+        expect(Rails.application).to_not receive(:reload_routes!)
+        described_class.reload_if_expired
+      end
+    end
+
+    context "when routes is outdated" do
+      it "reloads routes" do
+        allow(Node).to receive(:updated_at).and_return(Time.now)
+        expect(Rails.application).to receive(:reload_routes!)
+        described_class.reload_if_expired
+      end
+    end
+  end
+end

data/spec/routing/node_mapper_spec.rb

@@ -0,0 +1,142 @@
+require "rails_helper"
+
+describe Releaf::Content::NodeMapper do
+  after(:all) do
+    # reset dummy app routes
+    Dummy::Application.reload_routes!
+  end
+
+  before do
+    Dummy::Application.reload_routes!
+    @text_page = FactoryGirl.create(:text_page)
+    @lv_root = create(:home_page_node, name: "lv", locale: "lv", slug: 'lv')
+    @node = FactoryGirl.create(:node, slug: 'test-page', content: @text_page, parent: @lv_root)
+  end
+
+  describe "#releaf_routes_for" do
+
+    describe "using current node path" do
+      example "using default controller " do
+        routes.draw do
+          releaf_routes_for(TextPage) do |route|
+            get 'show'
+            delete :destroy
+          end
+        end
+
+        expect(get: '/lv/test-page').to route_to(
+          "controller" => "text_pages",
+          "action" => "show",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv'
+        )
+
+        expect(delete: '/lv/test-page').to route_to(
+          "controller" => "text_pages",
+          "action" => "destroy",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv'
+        )
+      end
+
+      example "overriding default controller" do
+        routes.draw do
+          releaf_routes_for(TextPage, controller: 'home_pages') do |route|
+            get 'show'
+            delete :destroy
+          end
+        end
+
+        expect(get: '/lv/test-page').to route_to(
+          "controller" => "home_pages",
+          "action" => "show",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv'
+        )
+      end
+
+      example "specifying different than default controller for route" do
+        routes.draw do
+          releaf_routes_for(TextPage, controller: 'doesnt_matter') do |route|
+            get 'home_pages#hide'
+          end
+        end
+
+        expect(get: '/lv/test-page').to route_to(
+          "controller" => "home_pages",
+          "action" => "hide",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv'
+        )
+      end
+    end
+
+    describe "adding uri parts to node path" do
+      example "speciffying custom controller and action" do
+        routes.draw do
+          releaf_routes_for(TextPage) do |route|
+            get ':my_id/list', to: 'home_pages#list'
+          end
+        end
+
+        expect(get: '/lv/test-page/8888/list').to route_to(
+          "controller" => "home_pages",
+          "action" => "list",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv',
+          "my_id" => '8888'
+        )
+      end
+
+      example "speciffying action" do
+        routes.draw do
+          releaf_routes_for(TextPage) do |route|
+            get ':my_id/list', to: '#list'
+          end
+        end
+
+        expect(get: '/lv/test-page/8888/list').to route_to(
+          "controller" => "text_pages",
+          "action" => "list",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv',
+          "my_id" => '8888'
+        )
+      end
+
+      example "speciffying action and overriding default controller" do
+        routes.draw do
+          releaf_routes_for(TextPage, controller: 'home_pages') do |route|
+            get ':my_id/list', to: '#list'
+          end
+        end
+
+        expect(get: '/lv/test-page/8888/list').to route_to(
+          "controller" => "home_pages",
+          "action" => "list",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv',
+          "my_id" => '8888'
+        )
+      end
+
+      example "speciffying custom path" do
+        routes.draw do
+          releaf_routes_for(TextPage) do |route|
+            get 'home_pages#show', path: "#{route.path}/abc/:my_id"
+          end
+        end
+
+        expect(get: '/lv/test-page/abc/333').to route_to(
+          "controller" => "home_pages",
+          "action" => "show",
+          "node_id" => @node.id.to_s,
+          "locale" => 'lv',
+          "my_id" => '333'
+        )
+      end
+
+    end
+
+  end
+end

data/spec/validators/content/node/parent_validator_spec.rb

@@ -0,0 +1,56 @@
+require 'rails_helper'
+
+describe Releaf::Content::Node::ParentValidator do
+  let!(:root_node) { FactoryGirl.create(:node, content_type: 'HomePage') }
+
+  class DummyNodeParentValidatorModel < ActiveRecord::Base
+    acts_as_node
+    self.table_name = 'texts'
+  end
+
+  class DummyNodeParentValidator1Controller < ActionController::Base
+    acts_as_node
+  end
+
+  class DummyNodeParentValidator2Controller < ActionController::Base
+    acts_as_node
+  end
+
+
+  class DummyNodeParentValidatorNode < ActiveRecord::Base
+    self.table_name = 'nodes'
+    include Releaf::Content::Node
+    validates_with Releaf::Content::Node::ParentValidator, for: DummyNodeParentValidatorModel, under: DummyNodeParentValidator1Controller
+  end
+
+  context "when parent is valid" do
+    it "doesn't add error" do
+      parent = DummyNodeParentValidatorNode.create!( FactoryGirl.attributes_for(:node, content_type: 'DummyNodeParentValidator1Controller') )
+      child  = DummyNodeParentValidatorNode.new( FactoryGirl.attributes_for(:node, content_type: 'DummyNodeParentValidatorModel', parent_id: parent.id) )
+
+      expect( child ).to be_valid
+    end
+  end
+
+  context "when parent is invalid" do
+    it "adds error on content_type" do
+      parent = DummyNodeParentValidatorNode.create!( FactoryGirl.attributes_for(:node, content_type: 'DummyNodeParentValidator2Controller') )
+      child  = DummyNodeParentValidatorNode.new( FactoryGirl.attributes_for(:node, content_type: 'DummyNodeParentValidatorModel', parent_id: parent.id) )
+
+      expect( child ).to be_invalid
+      expect( child.errors[:content_type].size ).to eq(1)
+      expect( child.errors[:content_type] ).to include("invalid parent node")
+    end
+
+  end
+
+  context "when content_type is not in child list" do
+    it "doesn't add error" do
+      parent = DummyNodeParentValidatorNode.create!( FactoryGirl.attributes_for(:node, content_type: 'DummyNodeParentValidator1Controller') )
+      child  = DummyNodeParentValidatorNode.new( FactoryGirl.attributes_for(:node, content_type: 'DummyNodeParentValidator2Controller', parent_id: parent.id) )
+
+      expect( child ).to be_valid
+    end
+  end
+
+end

data/spec/validators/content/node/root_validator_spec.rb

@@ -0,0 +1,69 @@
+require 'rails_helper'
+
+describe Releaf::Content::Node::RootValidator do
+
+
+  class DummyRootValidatorController < ActionController::Base
+    acts_as_node
+  end
+
+  class DummyRootValidator2Controller < ActionController::Base
+    acts_as_node
+  end
+
+  class DummyRootValidatorNode < ActiveRecord::Base
+    self.table_name = 'nodes'
+    include Releaf::Content::Node
+    validates_with Releaf::Content::Node::RootValidator, allow: DummyRootValidatorController
+  end
+
+
+  def create_node *params
+    DummyRootValidatorNode.create!( FactoryGirl.attributes_for(:node, *params) )
+  end
+
+  def build_node *params
+    DummyRootValidatorNode.new( FactoryGirl.attributes_for(:node, *params) )
+  end
+
+  context "when node is allowed to be root node" do
+    context "when node is a root node" do
+      it "doesn't add an error" do
+        root_node = build_node(content_type: 'DummyRootValidatorController')
+        expect( root_node ).to be_valid
+      end
+    end
+
+    context "when node is not a root node" do
+      it "adds an error" do
+        root_node = create_node(content_type: 'DummyRootValidatorController')
+        subnode = build_node(content_type: 'DummyRootValidatorController', parent: root_node)
+        expect( subnode ).to be_invalid
+        expect( subnode.errors[:content_type].size ).to eq(1)
+        expect( subnode.errors[:content_type] ).to include("can't be subnode")
+      end
+    end
+  end
+
+  context "when node is not allowed to be a root node" do
+    context "when node is a root node" do
+      it "adds an error" do
+        root_node = build_node(content_type: 'DummyRootValidator2Controller')
+        expect( root_node ).to be_invalid
+        expect( root_node.errors[:content_type].size ).to eq(1)
+        expect( root_node.errors[:content_type] ).to include("can't be root node")
+      end
+    end
+
+    context "when node is not a root node" do
+      it "doesn't add an error" do
+        root_node = create_node(content_type: 'DummyRootValidatorController')
+        subnode = build_node(content_type: 'DummyRootValidator2Controller', parent: root_node)
+
+        expect( subnode ).to be_valid
+      end
+    end
+  end
+
+
+end

data/spec/validators/content/node/singleness_validator_spec.rb

@@ -0,0 +1,145 @@
+require 'rails_helper'
+
+describe Releaf::Content::Node::SinglenessValidator do
+
+
+  class DummySinglenessValidatorModel < ActiveRecord::Base
+    acts_as_node
+    self.table_name = 'text_pages'
+  end
+
+  class DummySinglenessValidator2Model < ActiveRecord::Base
+    acts_as_node
+    self.table_name = 'text_pages'
+  end
+
+  class DummySinglenessValidatorController < ActionController::Base
+    acts_as_node
+  end
+
+  class DummySinglenessValidator2Controller < ActionController::Base
+    acts_as_node
+  end
+
+  class DummySinglenessValidatorNode < ActiveRecord::Base
+    self.table_name = 'nodes'
+    include Releaf::Content::Node
+    validates_with Releaf::Content::Node::SinglenessValidator, for: DummySinglenessValidatorModel
+    validates_with Releaf::Content::Node::SinglenessValidator, for: DummySinglenessValidator2Controller, under: TextPage
+  end
+
+
+  def create_node *params
+    DummySinglenessValidatorNode.create!( FactoryGirl.attributes_for(:node, *params) )
+  end
+
+  def build_node *params
+    DummySinglenessValidatorNode.new( FactoryGirl.attributes_for(:node, *params) )
+  end
+
+  let!(:root_node) { create_node(content_type: 'HomePage') }
+
+
+  context "when scope is entire page" do
+
+    context "When node not mentioned in list" do
+      it "doesn't add error" do
+        node = build_node(content_type: 'DummySinglenessValidatorController', parent_id: root_node.id)
+        expect( node ).to be_valid
+      end
+    end
+
+
+    context "when node with given content doesn't exist in tree" do
+      it "doesn't add error" do
+        node = build_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
+        expect( node ).to be_valid
+      end
+    end
+
+    context "when node with given content exists in tree" do
+      before do
+        create_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
+      end
+
+      it "adds error to #content_type" do
+        node = build_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
+        expect( node ).to be_invalid
+        expect( node.errors[:content_type].size ).to eq(1)
+        expect( node.errors[:content_type] ).to include("node exists")
+      end
+
+    end
+
+    context "when node is saved, and is only one in the tree" do
+      it "doesn't add error" do
+        node = create_node(content_type: 'DummySinglenessValidatorModel', parent_id: root_node.id)
+        expect( node ).to be_valid
+      end
+    end
+  end
+
+  context "when scope is subtree" do
+    context "when has ancestor in :under list" do
+      let!(:grand_parent_node) { create_node(content_type: 'TextPage', parent_id: root_node.id) }
+      let!(:parent_node) { create_node(content_type: 'DummySinglenessValidator2Model', parent_id: grand_parent_node.id) }
+
+      context "when node with given content doesn't exist in subtree" do
+        it "doesn't add error" do
+          node = build_node(content_type: 'DummySinglenessValidator2Controller', parent_id: parent_node.id)
+          expect( node ).to be_valid
+        end
+      end
+
+      context "when node with given content exists in subtree" do
+        before do
+          create_node(content_type: 'DummySinglenessValidator2Controller', parent_id: grand_parent_node.id)
+        end
+
+        it "adds error to #content_type" do
+          node = build_node(content_type: 'DummySinglenessValidator2Controller', parent_id: parent_node.id)
+          expect( node ).to be_invalid
+          expect( node.errors[:content_type].size ).to eq(1)
+          expect( node.errors[:content_type] ).to include("node exists")
+        end
+
+      end
+
+      context "when node is saved, and is only one in subtree" do
+        it "doesn't add error" do
+          node = create_node(content_type: 'DummySinglenessValidator2Controller', parent_id: parent_node.id)
+          expect( node ).to be_valid
+        end
+      end
+
+
+    end
+
+    context "when node has no ancestor in :under list" do
+      it "doesn't add error" do
+        node = create_node(content_type: 'DummySinglenessValidator2Controller', parent_id: root_node.id)
+        expect( node ).to be_valid
+      end
+    end
+  end
+
+  context "regression tests" do
+    context "@node.parent.self_and_ancestors bug" do
+      it "works correctly / is worked around" do
+        # for details see Releaf::Content::Node::SinglenessValidator#base_relation_for_subtree
+        @node1 = create_node(content_type: 'TextPage', locale: 'en')
+        @node2 = create_node(content_type: 'TextPage', locale: 'lv')
+        @node3 = create_node(content_type: 'TextPage', locale: 'ru')
+        @node4 = create_node(content_type: 'TextPage', locale: 'sp')
+
+        @node1_1 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node1)
+        expect do
+          @node1_2 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node2)
+          @node1_3 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node3)
+          @node1_4 = create_node(content_type: 'DummySinglenessValidator2Controller',  parent: @node4)
+        end.to_not raise_error
+      end
+    end
+  end
+
+end