relaton-nist 0.5.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 84efea59e2f35758f44b21e42574ebc3bfbda66f95d7d1c905ae645d42d55711
-  data.tar.gz: c58d8aa8f2bc6da70c04793d196f90b4b5a0ab7868b97f7ef17fc3df3ff5f17b
+  metadata.gz: 805836254764292ed3a420817f46d40e53514dcea92ce8f806aa2b0723332da8
+  data.tar.gz: 31d8735c928d99d28ea3c09802beb22553848d74fd111c616d8b530eff695629
 SHA512:
-  metadata.gz: 22d62f0a3a04d03efa7ca6bf2f8d2dda988da7346fac312ac58d43998a712f9bd35bf2481f2a6aebfd4507dcc4b6e8d9f75bc10de0fd51e5e2e9f22edeeecad2
-  data.tar.gz: 8193871dba1c5c64ba39839ed38eb34632c653ef55daf4e6850a5d4fe73446af64d27fd7eb2170ed73d0b79efb96ddbb8fee37871b986422b4ea0c1586157b7d
+  metadata.gz: 9395ced7ec09e9fdb1d7d4474af0f10bde4da961f0152ff5321403a04358062698363a3ecdf3b16e2986cc25ab99a0df1f047c0277a6d33d40f1fda9edd8a98a
+  data.tar.gz: 16fbec11a1da3c7deb5bd87428456c43d9ed77001b3a52aa376315c58898181c7fbcc10acfedac46e1651790e17ac64c66aca0e9c454715185e747a0ebf21a5d

data/.github/workflows/macos.yml

@@ -1,14 +1,19 @@
-# Auto-generated !!! Do not edit it manually
-# use ci-master https://github.com/metanorma/metanorma-build-scripts
+# Auto-generated by Cimas: Do not edit it manually!
+# See https://github.com/metanorma/cimas
 name: macos
 
-on: [push]
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ '**' ]
 
 jobs:
   test-macos:
     name: Test on Ruby ${{ matrix.ruby }} macOS
     runs-on: macos-latest
     strategy:
+      fail-fast: false
       matrix:
         ruby: [ '2.6', '2.5', '2.4' ]
     steps:
@@ -20,7 +25,7 @@ jobs:
           architecture: 'x64'
       - name: Update gems
         run: |
-          sudo gem install bundler -v "~> 2" --force
+          sudo gem install bundler --force
           bundle install --jobs 4 --retry 3
       - name: Run specs
         run: |

data/.github/workflows/ubuntu.yml

@@ -1,14 +1,19 @@
-# Auto-generated !!! Do not edit it manually
-# use ci-master https://github.com/metanorma/metanorma-build-scripts
+# Auto-generated by Cimas: Do not edit it manually!
+# See https://github.com/metanorma/cimas
 name: ubuntu
 
-on: [push]
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ '**' ]
 
 jobs:
   test-linux:
     name: Test on Ruby ${{ matrix.ruby }} Ubuntu
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       matrix:
         ruby: [ '2.6', '2.5', '2.4' ]
     steps:
@@ -20,7 +25,7 @@ jobs:
           architecture: 'x64'
       - name: Update gems
         run: |
-          gem install bundler -v "~> 2"
+          gem install bundler
           bundle install --jobs 4 --retry 3
       - name: Run specs
         run: |

data/.github/workflows/windows.yml

@@ -1,14 +1,19 @@
-# Auto-generated !!! Do not edit it manually
-# use ci-master https://github.com/metanorma/metanorma-build-scripts
+# Auto-generated by Cimas: Do not edit it manually!
+# See https://github.com/metanorma/cimas
 name: windows
 
-on: [push]
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ '**' ]
 
 jobs:
   test-windows:
     name: Test on Ruby ${{ matrix.ruby }} Windows
     runs-on: windows-latest
     strategy:
+      fail-fast: false
       matrix:
         ruby: [ '2.6', '2.5', '2.4' ]
     steps:
@@ -21,7 +26,7 @@ jobs:
       - name: Update gems
         shell: pwsh
         run: |
-          gem install bundler -v "~> 2"
+          gem install bundler
           bundle config --local path vendor/bundle
           bundle update
           bundle install --jobs 4 --retry 3

data/lib/relaton_nist/hash_converter.rb

@@ -9,17 +9,12 @@ module RelatonNist
         ret = super
         return if ret.nil?
 
-        keyword_hash_to_bib(ret)
         commentperiod_hash_to_bib(ret)
         ret
       end
 
       private
 
-      def keyword_hash_to_bib(ret)
-        ret[:keyword]&.map! { |kw| Keyword.new kw }
-      end
-
       def commentperiod_hash_to_bib(ret)
         return unless ret[:commentperiod]
 

data/lib/relaton_nist/hit.rb

@@ -3,9 +3,6 @@
 module RelatonNist
   # Hit.
   class Hit < RelatonBib::Hit
-    # @return [RelatonNist::HitCollection]
-    attr_reader :hit_collection
-
     # Parse page.
     # @return [RelatonNist::NistBliographicItem]
     def fetch
@@ -16,17 +13,18 @@ module RelatonNist
     def sort_value
       @sort_value ||= begin
         sort_phrase = [hit[:serie], hit[:code], hit[:title]].join " "
-        corr = hit_collection.text.split.map do |w|
+        corr = hit_collection&.text&.split&.map do |w|
           if w =~ /\w+/ &&
               sort_phrase =~ Regexp.new(Regexp.escape(w), Regexp::IGNORECASE)
             1
           else 0
           end
-        end.sum
+        end&.sum.to_i
         corr + case hit[:status]
-               when "final" then 3
-               when "withdrawn" then 2
-               when "draft (withdrawn)" then 1
+               when "final" then 4
+               when "withdrawn" then 3
+               when "draft" then 2
+               when "draft (obsolete)" then 1
                else 0
                end
       end

data/lib/relaton_nist/hit_collection.rb

@@ -13,30 +13,24 @@ module RelatonNist
     DATAFILEDIR = File.expand_path ".relaton/nist", Dir.home
     DATAFILE = File.expand_path "pubs-export.zip", DATAFILEDIR
 
-    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-
     # @param ref_nbr [String]
     # @param year [String]
     # @param opts [Hash]
     # @option opts [String] :stage
     def initialize(ref_nbr, year = nil, opts = {})
-      @text = ref_nbr
-      @year = year
+      super ref_nbr, year
 
       /(?<docid>(SP|FIPS)\s[0-9-]+)/ =~ text
-      hits = docid ? from_json(docid, **opts) : from_csrc(**opts)
+      @array = docid ? from_json(docid, **opts) : from_csrc(**opts)
 
-      hits.sort! do |a, b|
+      @array.sort! do |a, b|
         if a.sort_value != b.sort_value
           b.sort_value - a.sort_value
         else
           (b.hit[:release_date] - a.hit[:release_date]).to_i
         end
       end
-      concat hits
-      @fetched = false
     end
-    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
     private
 
@@ -66,12 +60,12 @@ module RelatonNist
         serie = h.at("td[1]").text.strip
         code  = h.at("td[2]").text.strip
         title = link.text
-        url   = DOMAIN + link[:href]
+        doc_url   = DOMAIN + link[:href]
         status = h.at("td[4]").text.strip.downcase
         release_date = Date.strptime h.at("td[5]").text.strip, "%m/%d/%Y"
         Hit.new(
           {
-            code: code, serie: serie, title: title, url: url, status: status,
+            code: code, serie: serie, title: title, url: doc_url, status: status,
             release_date: release_date
           }, self
         )

data/lib/relaton_nist/nist_bibliographic_item.rb

@@ -4,7 +4,7 @@ module RelatonNist
     attr_reader :doctype
 
     # @return [Array<RelatonNist::Keyword>]
-    attr_reader :keyword
+    # attr_reader :keyword
 
     # @return [RelatonNist::CommentPeriod, NilClass]
     attr_reader :commentperiod
@@ -57,7 +57,7 @@ module RelatonNist
     # @option relation [Array<RelatonBib::BibItemLocality>] :bib_locality
     def initialize(**args)
       @doctype = args.delete(:doctype) || "standard"
-      @keyword = args.delete(:keyword) || []
+      # @keyword = args.delete(:keyword) || []
       @commentperiod = args.delete :commentperiod
       super
     end
@@ -78,7 +78,7 @@ module RelatonNist
     # @return [Hash]
     def to_hash
       hash = super
-      hash["keyword"] = single_element_array(keyword) if keyword&.any?
+      # hash["keyword"] = single_element_array(keyword) if keyword&.any?
       hash["commentperiod"] = commentperiod.to_hash if commentperiod
       hash
     end

data/lib/relaton_nist/nist_bibliography.rb

@@ -3,7 +3,6 @@ require "relaton_nist/nist_bibliographic_item"
 require "relaton_nist/scrapper"
 require "relaton_nist/hit_collection"
 require "relaton_nist/xml_parser"
-require "relaton_nist/keyword"
 require "relaton_nist/comment_period"
 require "relaton_nist/document_status"
 require "relaton_nist/hash_converter"

data/lib/relaton_nist/scrapper.rb

@@ -134,7 +134,7 @@ module RelatonNist
           iter = doc["iteration"] == "initial" ? 1 : doc["iteration"]
         else
           case status
-          when "draft (withdrawn)"
+          when "draft (obsolete)"
             stage = "draft-public"
             subst = "withdrawn"
           when "retired draft"
@@ -445,7 +445,7 @@ module RelatonNist
               else
                 doc.xpath "//span[@id='pub-keywords-container']/span"
               end
-        kws.map { |kw| Keyword.new kw.is_a?(String) ? kw : kw.text }
+        kws.map { |kw| kw.is_a?(String) ? kw : kw.text }
       end
 
       # @param doc [Nokogiri::HTML::Document]

data/lib/relaton_nist/version.rb

@@ -1,3 +1,3 @@
 module RelatonNist
-  VERSION = "0.5.1".freeze
+  VERSION = "0.8.2".freeze
 end

data/lib/relaton_nist/xml_parser.rb

@@ -3,8 +3,13 @@ module RelatonNist
     class << self
       def from_xml(xml)
         doc = Nokogiri::XML xml
+        doc.remove_namespaces!
         nistitem = doc.at("/bibitem|/bibdata")
-        NistBibliographicItem.new(item_data(nistitem))
+        if nistitem
+          NistBibliographicItem.new(item_data(nistitem))
+        elsif
+          warn "[relaton-nist] can't find bibitem or bibdata element in the XML"
+        end
       end
 
       private
@@ -14,7 +19,6 @@ module RelatonNist
         ext = nistitem.at "./ext"
         return data unless ext
 
-        data[:keyword] = fetch_keyword(ext)
         data[:commentperiod] = fetch_commentperiod(ext)
         data
       end
@@ -39,12 +43,6 @@ module RelatonNist
           extended: cp.at("extended")&.text
         )
       end
-
-      def fetch_keyword(item)
-        item.xpath("./keyword").map do |kw|
-          Keyword.new kw.children.first.to_xml
-        end
-      end
     end
   end
 end

data/relaton_nist.gemspec

@@ -23,7 +23,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
   spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
 
-  spec.add_development_dependency "byebug"
   spec.add_development_dependency "debase"
   spec.add_development_dependency "equivalent-xml", "~> 0.6"
   spec.add_development_dependency "pry-byebug"
@@ -35,6 +34,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "ruby-jing"
 
-  spec.add_dependency "relaton-bib", "~> 0.5.0"
+  spec.add_dependency "relaton-bib", "~> 0.8.0"
   spec.add_dependency "rubyzip"
 end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: relaton-nist
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-01-16 00:00:00.000000000 Z
+date: 2020-03-24 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: debase
   requirement: !ruby/object:Gem::Requirement
@@ -170,14 +156,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
@@ -223,7 +209,6 @@ files:
 - lib/relaton_nist/hash_converter.rb
 - lib/relaton_nist/hit.rb
 - lib/relaton_nist/hit_collection.rb
-- lib/relaton_nist/keyword.rb
 - lib/relaton_nist/nist_bibliographic_item.rb
 - lib/relaton_nist/nist_bibliography.rb
 - lib/relaton_nist/processor.rb

data/lib/relaton_nist/keyword.rb

@@ -1,23 +0,0 @@
-module RelatonNist
-  class Keyword
-    include RelatonBib
-
-    # @return [Nokogiri::XML::DocumentFragment]
-    attr_reader :element
-
-    # @param element [String]
-    def initialize(element)
-      @element = Nokogiri::XML.fragment element
-    end
-
-    # @param builder [Nokogiri::XML::Builder]
-    def to_xml(builder)
-      builder.keyword element.to_xml
-    end
-
-    # @return [String]
-    def to_hash
-      element.text
-    end
-  end
-end