relaton-bib 1.9.18 → 1.9.22

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 974c021271bddc8c3ab783eae039697f62010c33f035e24b2bb96051a6138b8a
-  data.tar.gz: 71157a9ac56ec96549886354db9b6a301ead662e43ec8abefea1bdc27ec8539c
+  metadata.gz: d003dbfecade683b1474dfc3923c2210997574d956f3c96ef0b7b0f113100d66
+  data.tar.gz: 6829735611e2ad3807ecb8014b6dddc115f8a2b8799328a11a7b7a229174a49c
 SHA512:
-  metadata.gz: fec9fcd2fad29d5128b739fb478b0198bdeeb1a6ab2b9806d8dc73c51290ddcea19fe3481fdc5f104369c34f26fd6e7661a02d5927cf3eed7416b58516cbd915
-  data.tar.gz: 85890cd5bde2fee2e9fefe9188f4a892019b92414b235bbde5e91453b878b6bbe31d5d8d364939ec6662859c0ec0f9362836d938447ac0b2921fd2ce7863a40c
+  metadata.gz: fbb7e6611505b14b7b321893dd4c1941e91b0d52cd2de4ea4f6fe083e1e2378c6f8c34a6fe3c39bb9d028ee81e5548ba435a893483c6e42e16f01030dd230eaa
+  data.tar.gz: 01aef015aefc3a321442118ccafd9ae310e9fccab9f57bce7d4e3e2c8c0abf70b9b5d4a1ad3877866daabc2054f572fec72be93311e7d66446c77f119b4ce781

data/lib/relaton_bib/bibliographic_date.rb

@@ -29,14 +29,22 @@ module RelatonBib
 
     # @param part [Symbol] :year, :month, :day, :date
     # @return [String, Date, nil]
-    def from(part = nil)
+    def from(part = nil) # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       d = instance_variable_get "@#{__callee__}".to_sym
       return d unless part && d
 
-      date = parse_date(d)
-      return date if part == :date
+      # date = parse_date(d)
+      # return date if part == :date
 
-      date.is_a?(Date) ? date.send(part) : date
+      parts = d.split "-"
+      case part
+      when :year then parts[0]&.to_i
+      when :month then parts[1]&.to_i
+      when :day then parts[2]&.to_i
+      else parse_date(d)
+      end
+
+      # date.is_a?(Date) ? date.send(part) : date
     end
 
     alias_method :to, :from
@@ -71,7 +79,7 @@ module RelatonBib
     # @param count [Integer] number of dates
     # @return [String]
     def to_asciibib(prefix = "", count = 1)
-      pref = prefix.empty? ? prefix : prefix + "."
+      pref = prefix.empty? ? prefix : "#{prefix}."
       out = count > 1 ? "#{pref}date::\n" : ""
       out += "#{pref}date.type:: #{type}\n"
       out += "#{pref}date.on:: #{on}\n" if on

data/lib/relaton_bib/bibliographic_item.rb

@@ -165,8 +165,8 @@ module RelatonBib
     # @option date [String, nil] :to
     # @option date [String, nil] :on required if :from is nil
     #
-    # @param contributor [Array<Hash>]
-    # @option contributor [RealtonBib::Organization, RelatonBib::Person]
+    # @param contributor [Array<Hash, RelatonBib::ContributionInfo>]
+    # @option contributor [RealtonBib::Organization, RelatonBib::Person] :entity
     # @option contributor [String] :type
     # @option contributor [String] :from
     # @option contributor [String] :to
@@ -766,8 +766,8 @@ module RelatonBib
     # @param [Nokogiri::XML::Builder] builder
     #
     def render_bibxml(builder)
-      target = link.detect { |l| l.type == "src" } ||
-        link.detect { |l| l.type == "doi" }
+      target = link.detect { |l| l.type.casecmp("src").zero? } ||
+        link.detect { |l| l.type.casecmp("doi").zero? }
       bxml = if docnumber&.match(/^BCP/) || docidentifier[0].id.include?("BCP")
                render_bibxml_refgroup(builder)
              else
@@ -860,9 +860,9 @@ module RelatonBib
           builder.seriesInfo(name: di.type, value: di.id)
         end
       end
-      di_types = docidentifier.map(&:type)
+      # di_types = docidentifier.map(&:type)
       series.select do |s|
-        s.title && !di_types.include?(s.title.title.to_s) &&
+        s.title && # !di_types.include?(s.title.title.to_s) &&
           !BibXMLParser::SERIESINFONAMES.include?(s.title.title.to_s)
       end.uniq { |s| s.title.title.to_s }.each do |s|
         si = builder.seriesInfo(name: s.title.title.to_s)
@@ -920,13 +920,22 @@ module RelatonBib
     def render_person(builder, person)
       render_organization builder, person.affiliation.first&.organization
       if person.name.completename
-        builder.parent[:fullname] = person.name.completename
+        builder.parent[:fullname] = person.name.completename.content
+      elsif person.name.forename.any?
+        builder.parent[:fullname] = person.name.forename.map(&:content).join
       end
       if person.name.initial.any?
         builder.parent[:initials] = person.name.initial.map(&:content).join
+      elsif person.name.forename.any?
+        builder.parent[:initials] = person.name.forename.map do |f|
+          "#{f.content[0]}."
+        end.join
       end
       if person.name.surname
-        builder.parent[:surname] = person.name.surname
+        if person.name.forename.any?
+          builder.parent[:fullname] += " #{person.name.surname}"
+        end
+        builder.parent[:surname] = person.name.surname.content
       end
     end
 
@@ -937,10 +946,8 @@ module RelatonBib
 
       ab = org.abbreviation&.content
       on = org.name.first&.content
-      orgname = if ab == "IEEE" || on == "Istitute of Electrical and Electronics Engineers"
-                  "IEEE"
-                elsif ab == "W3C" || on == "World Wide Web Consortium" then "W3C"
-                else on || ab
+      orgname = if BibXMLParser::ORGNAMES.key?(ab) then ab
+                else BibXMLParser::ORGNAMES.key(on) || on || ab
                 end
       o = builder.organization orgname
       o[:abbrev] = ab if ab

data/lib/relaton_bib/bibxml_parser.rb

@@ -1,8 +1,15 @@
 module RelatonBib
   module BibXMLParser
+    # SeriesInfo what should be saved as docidentifiers in the Relaton model.
     SERIESINFONAMES = ["DOI", "Internet-Draft"].freeze
+
     FLAVOR = nil
 
+    ORGNAMES = {
+      "IEEE" => "Istitute of Electrical and Electronics Engineers",
+      "W3C" => "World Wide Web Consortium",
+    }.freeze
+
     def parse(bibxml, url: nil, is_relation: false, ver: nil)
       doc = Nokogiri::XML bibxml
       fetch_rfc doc.at("/referencegroup", "/reference"), url: url, is_relation: is_relation, ver: ver
@@ -209,7 +216,8 @@ module RelatonBib
       #   "front/author[not(@surname)][not(@fullname)]/organization",
       # ).map do |org|
       org = contrib.at("./organization")
-      { entity: new_org(org.text, org[:abbrev]), role: [contributor_role(contrib)] }
+      name = ORGNAMES[org.text] || org.text
+      { entity: new_org(name, org[:abbrev]), role: [contributor_role(contrib)] }
       # end
     end
 
@@ -307,13 +315,15 @@ module RelatonBib
     # @return [Array<RelatonBib::BibliographicDate>] published data.
     #
     def dates(reference)
-      return unless (date = reference.at "./front/date")
-
-      d = [date[:year], month(date[:month]), (date[:day] || 1)].compact.join "-"
-      date = Time.parse(d).strftime "%Y-%m-%d"
-      [BibliographicDate.new(type: "published", on: date)]
-    rescue ArgumentError
-      []
+      return [] unless (date = reference.at "./front/date")
+
+      d = date[:year]
+      d += "-#{month(date[:month])}" if date[:month] && !date[:month].empty?
+      d += "-#{date[:day]}" if date[:day]
+      # date = Time.parse(d).strftime "%Y-%m-%d"
+      [BibliographicDate.new(type: "published", on: d)]
+    # rescue ArgumentError
+    #   []
     end
 
     # @param reference [Nokogiri::XML::Element]
@@ -333,10 +343,10 @@ module RelatonBib
     end
 
     def month(mon)
-      return 1 if !mon || mon.empty?
+      # return 1 if !mon || mon.empty?
       return mon if /^\d+$/.match? mon
 
-      Date::MONTHNAMES.index(mon)
+      Date::MONTHNAMES.index(mon).to_s.rjust 2, "0"
     end
 
     #
@@ -347,7 +357,7 @@ module RelatonBib
     #
     def series(reference)
       reference.xpath("./seriesInfo", "./front/seriesInfo").map do |si|
-        next if si[:name] == "DOI" || si[:stream] || si[:status]
+        next if SERIESINFONAMES.include?(si[:name]) || si[:stream] || si[:status]
 
         t = TypedTitleString.new(
           content: si[:name], language: language(reference), script: "Latn",

data/lib/relaton_bib/contributor.rb

@@ -25,7 +25,7 @@ module RelatonBib
     # @param state [String]
     # @param country [String]
     # @param postcode [String]
-    def initialize(street:, city:, state: nil, country:, postcode: nil)
+    def initialize(street:, city:, country:, state: nil, postcode: nil)
       @street   = street
       @city     = city
       @state    = state
@@ -45,7 +45,7 @@ module RelatonBib
     end
 
     # @return [Hash]
-    def to_hash
+    def to_hash # rubocop:disable Metrics/AbcSize
       hash = {}
       hash["street"] = street if street&.any?
       hash["city"] = city
@@ -59,7 +59,7 @@ module RelatonBib
     # @param count [Integer] number of addresses
     # @return [String]
     def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize
-      pref = prefix.empty? ? "address" : prefix + ".address"
+      pref = prefix.empty? ? "address" : "#{prefix}.address"
       out = count > 1 ? "#{pref}::\n" : ""
       street.each { |st| out += "#{pref}.street:: #{st}\n" }
       out += "#{pref}.city:: #{city}\n"
@@ -99,7 +99,7 @@ module RelatonBib
     # @param count [Integer] number of contacts
     # @return [string]
     def to_asciibib(prefix = "", count = 1)
-      pref = prefix.empty? ? prefix : prefix + "."
+      pref = prefix.empty? ? prefix : "#{prefix}."
       out = count > 1 ? "#{pref}contact::\n" : ""
       out += "#{pref}contact.type:: #{type}\n"
       out += "#{pref}contact.value:: #{value}\n"
@@ -156,7 +156,7 @@ module RelatonBib
     # @param count [Integer]
     # @return [String]
     def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize
-      pref = prefix.empty? ? prefix : prefix + "."
+      pref = prefix.empty? ? prefix : "#{prefix}."
       out = count > 1 ? "#{pref}affiliation::\n" : ""
       out += name.to_asciibib "#{pref}affiliation.name" if name
       description.each do |d|
@@ -206,7 +206,7 @@ module RelatonBib
     # @param prefix [String]
     # @return [String]
     def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
-      pref = prefix.empty? ? prefix : prefix + "."
+      pref = prefix.empty? ? prefix : "#{prefix}."
       out = ""
       out += "#{pref}url:: #{uri}\n" if uri
       addr = contact.select { |c| c.is_a? RelatonBib::Address }

data/lib/relaton_bib/organization.rb

@@ -39,7 +39,7 @@ module RelatonBib
     # @param count [Integer]
     # @return [String]
     def to_asciibib(prefix = "", count = 1)
-      pref = prefix.empty? ? prefix : prefix + "."
+      pref = prefix.empty? ? prefix : "#{prefix}."
       out = count > 1 ? "#{pref}identifier::\n" : ""
       out += "#{pref}identifier.type:: #{type}\n"
       out += "#{pref}identifier.value:: #{value}\n"
@@ -118,7 +118,7 @@ module RelatonBib
     # @param count [Integer]
     # @return [String]
     def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength
-      pref = prefix.sub /\*$/, "organization"
+      pref = prefix.sub(/\*$/, "organization")
       out = count > 1 ? "#{pref}::\n" : ""
       name.each { |n| out += n.to_asciibib "#{pref}.name", name.size }
       out += abbreviation.to_asciibib "#{pref}.abbreviation" if abbreviation
@@ -136,10 +136,11 @@ module RelatonBib
     # @param arg [String, Hash, RelatoBib::LocalizedString]
     # @return [RelatoBib::LocalizedString]
     def localized_string(arg)
-      if arg.is_a?(String) then LocalizedString.new(arg)
-      elsif arg.is_a?(Hash)
+      case arg
+      when String then LocalizedString.new(arg)
+      when Hash
         LocalizedString.new(arg[:content], arg[:language], arg[:script])
-      elsif arg.is_a? LocalizedString then arg
+      when LocalizedString then arg
       end
     end
   end

data/lib/relaton_bib/series.rb

@@ -13,7 +13,7 @@ module RelatonBib
     # @return [RelatonBib::FormattedRef, NilClass]
     attr_reader :formattedref
 
-    # @return [RelatonBib::FormattedString, NilClass] title
+    # @return [RelatonBib::TypedTitleString, NilClass] title
     attr_reader :title
 
     # @return [String, NilClass]
@@ -39,10 +39,10 @@ module RelatonBib
 
     # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
 
-    # @param type [String, NilClass] title or formattedref argument should be
-    #   passed
+    # @param type [String, NilClass]
     # @param formattedref [RelatonBib::FormattedRef, NilClass]
-    # @param title [RelatonBib::TypedTitleString, NilClass]
+    # @param title [RelatonBib::TypedTitleString, NilClass] title or
+    #   formattedref argument should be passed
     # @param place [String, NilClass]
     # @param orgaization [String, NilClass]
     # @param abbreviation [RelatonBib::LocalizedString, NilClass]

data/lib/relaton_bib/version.rb

@@ -1,3 +1,3 @@
 module RelatonBib
-  VERSION = "1.9.18".freeze
+  VERSION = "1.9.22".freeze
 end

data/lib/relaton_bib/xml_parser.rb

@@ -238,11 +238,12 @@ module RelatonBib
           OrgIdentifier.new(i[:type], i.text)
         end
         subdiv = org.xpath("subdivision").map &:text
-        Organization.new(name: names,
-                         abbreviation: org.at("abbreviation")&.text,
-                         subdivision: subdiv,
-                         url: org.at("uri")&.text,
-                         identifier: identifier)
+        contact = parse_contact org
+        Organization.new(
+          name: names, abbreviation: org.at("abbreviation")&.text,
+          subdivision: subdiv, # url: org.at("uri")&.text,
+          identifier: identifier, contact: contact
+        )
       end
 
       def get_person(person) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
@@ -255,21 +256,7 @@ module RelatonBib
           Affiliation.new organization: get_org(org), description: desc
         end
 
-        contact = person.xpath("./address|./phone|./email|./uri").map do |c|
-          if c.name == "address"
-            streets = c.xpath("./street").map(&:text)
-            Address.new(
-              street: streets,
-              city: c.at("./city")&.text,
-              state: c.at("./state")&.text,
-              country: c.at("./country")&.text,
-              postcode: c.at("./postcode")&.text,
-            )
-          else
-            Contact.new(type: c.name, value: c.text)
-          end
-        end
-
+        contact = parse_contact person
         identifier = person.xpath("./identifier").map do |pi|
           PersonIdentifier.new pi[:type], pi.text
         end
@@ -295,6 +282,23 @@ module RelatonBib
         )
       end
 
+      def parse_contact(contrib) # rubocop:disable Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength,Metrics/AbcSize
+        contrib.xpath("./address|./phone|./email|./uri").map do |c|
+          if c.name == "address"
+            streets = c.xpath("./street").map(&:text)
+            Address.new(
+              street: streets,
+              city: c.at("./city")&.text,
+              state: c.at("./state")&.text,
+              country: c.at("./country")&.text,
+              postcode: c.at("./postcode")&.text,
+            )
+          else
+            Contact.new(type: c.name, value: c.text)
+          end
+        end
+      end
+
       def name_part(person, part)
         person.xpath("./name/#{part}").map do |np|
           LocalizedString.new np.text, np[:language], np[:script]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relaton-bib
 version: !ruby/object:Gem::Version
-  version: 1.9.18
+  version: 1.9.22
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-01-09 00:00:00.000000000 Z
+date: 2022-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug