relaton-bib 1.19.2 → 1.19.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9d25f7a3197e13a268ac65f498dd9122c89bdbcbb270f999773ce77898fb0df
-  data.tar.gz: ef52d177ebc581ec707f97e34f7af095a4ed97bc99aa9095b58e8bc360bcfca3
+  metadata.gz: f30aba03119323515ec5e39d4a257a15a4de1a83148eb6e45f1b21ba63e42e14
+  data.tar.gz: e2588577b331caa08e3396689fa76af66770961e5e76809765a4af3733eb41f5
 SHA512:
-  metadata.gz: 9c4b66e2a97ef5dc7e4ada16c2e49bb3d9d0e30bfc1c00565451cfa90124475c2134dd1adfef17f71eec091ef338e781472d9ea72c602dff125c8e79dbe4047a
-  data.tar.gz: 16e83196283dc4cdf84282786ea72c2649cfdb1dbfe2e49c0f5dcb2511fc74f43d5455188b44fdb06d3497ae8bd01dc9892e2b3586b715c37e44d422e89288a9
+  metadata.gz: b20b0ad0f1677bb3ef51adadd220d37fb3a22d8791f20f8f442c0b9cf7235fd933d833f9a8958f911b577f096c2b350c94c0c3748543df078ac8ab7485686e29
+  data.tar.gz: 88fa4fdaf09a61417e022a6893d8d998247b49aad4454ad3b4182991b80a41e0cb0e911e01d1fb74463d1418499d3d97c99b2c2893759af9cbf79b0c58130197

data/lib/relaton_bib/image.rb

@@ -1,32 +1,29 @@
 module RelatonBib
   class Image
     # @return [String]
-    attr_reader :id, :src, :mimetype, :filename, :width, :height, :alt, :title, :longdesc
+    attr_accessor :src, :mimetype
+
+    # @return [String, nil]
+    attr_accessor :id, :filename, :width, :height, :alt, :title, :longdesc
 
     #
     # Initializes a new Image object.
     #
-    # @param id [String] the ID of the image
     # @param src [String] the source URL of the image
     # @param mimetype [String] the MIME type of the image
     # @param args [Hash] additional arguments
-    # @option args [String] :filename the filename of the image
-    # @option args [String] :width the width of the image
-    # @option args [String] :height the height of the image
-    # @option args [String] :alt the alternative text for the image
-    # @option args [String] :title the title of the image
-    # @option args [String] :longdesc the long description of the image
+    # @option id [String, nil] the ID of the image
+    # @option args [String, nil] :filename the filename of the image
+    # @option args [String, nil] :width the width of the image
+    # @option args [String, nil] :height the height of the image
+    # @option args [String, nil] :alt the alternative text for the image
+    # @option args [String, nil] :title the title of the image
+    # @option args [String, nil] :longdesc the long description of the image
     #
-    def initialize(id:, src:, mimetype:, **args)
-      @id = id
+    def initialize(src:, mimetype:, **args)
       @src = src
       @mimetype = mimetype
-      @filename = args[:filename]
-      @width = args[:width]
-      @height = args[:height]
-      @alt = args[:alt]
-      @title = args[:title]
-      @longdesc = args[:longdesc]
+      args.each { |k, v| send "#{k}=", v }
     end
 
     def ==(other)
@@ -44,7 +41,7 @@ module RelatonBib
     #
     def to_xml(builder) # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/MethodLength
       builder.image do
-        builder.parent[:id] = id
+        builder.parent[:id] = id if id
         builder.parent[:src] = src
         builder.parent[:mimetype] = mimetype
         builder.parent[:filename] = filename if filename
@@ -62,7 +59,8 @@ module RelatonBib
     # @return [Hash] The hash representation of the Image object.
     #
     def to_hash # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity
-      hash = { "image" => { "id" => id, "src" => src, "mimetype" => mimetype } }
+      hash = { "image" => { "src" => src, "mimetype" => mimetype } }
+      hash["image"]["id"] = id if id
       hash["image"]["filename"] = filename if filename
       hash["image"]["width"] = width if width
       hash["image"]["height"] = height if height
@@ -81,7 +79,8 @@ module RelatonBib
     #
     def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity,Metrics/MethodLength
       pref = prefix.empty? ? "image." : "#{prefix}.image."
-      out = "#{pref}id:: #{id}\n"
+      out = ""
+      out += "#{pref}id:: #{id}\n" if id
       out += "#{pref}src:: #{src}\n"
       out += "#{pref}mimetype:: #{mimetype}\n"
       out += "#{pref}filename:: #{filename}\n" if filename

data/lib/relaton_bib/localized_string.rb

@@ -81,7 +81,7 @@ module RelatonBib
     #
     # @return [String] encoded content
     #
-    def encode(cnt) # rubocop:disable Metrics/MethodLength
+    def encode(cnt)
       escp cnt
     end
 

data/lib/relaton_bib/version.rb

@@ -1,3 +1,3 @@
 module RelatonBib
-  VERSION = "1.19.2".freeze
+  VERSION = "1.19.4".freeze
 end

data/lib/relaton_bib/xml_parser.rb

@@ -289,13 +289,17 @@ module RelatonBib
       # @return [Array<RelatonBib::DocumentIdentifier>]
       def fetch_docid(item)
         item.xpath("./docidentifier").map do |id|
-          did = id.to_h.transform_keys(&:to_sym)
-          did[:id] = id.text
-          did[:primary] = id[:primary] == "true" ? true : nil
-          DocumentIdentifier.new(**did)
+          args = id.to_h.transform_keys(&:to_sym)
+          args[:id] = id.text
+          args[:primary] = id[:primary] == "true" ? true : nil
+          create_docid(**args)
         end
       end
 
+      def create_docid(**args)
+        DocumentIdentifier.new(**args)
+      end
+
       # @param item [Nokogiri::XML::Element]
       # @return [RelatonBib::TypedTitleStringCollection]
       def fetch_titles(item)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relaton-bib
 version: !ruby/object:Gem::Version
-  version: 1.19.2
+  version: 1.19.4
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-07-12 00:00:00.000000000 Z
+date: 2024-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable