relativity 0.0.3 → 0.0.4

data/Changelog.rdoc

@@ -1,3 +1,10 @@
+0.0.4 2012-01-17:
+
+* Revert seconds_since_start to seconds_since_midnight
+  ("start" was arbitrary; "midnight" is a real world reference)
+
+* Added an Relativity::Exception class
+
 0.0.3 2012-01-12
 
 * Change RelativeTime into DayTime

data/README.rdoc

@@ -14,7 +14,7 @@ be built on top, so the ranges of opening hours can be represented.
   closes_at = DayTime.new(18,30) #=> 18:30:00
 
   dt = DayTime.new #=> 21:17:40
-  dt.seconds_since_start #=> #<BigDecimal:9d35d48,'0.7666056825 7238E5',18(45)>
+  dt.seconds_since_midnight #=> #<BigDecimal:9d35d48,'0.7666056825 7238E5',18(45)>
   dt.hours #=> 21
   dt.minutes #=> 17
   dt.seconds #=> 40

data/TODO

@@ -1,7 +1,3 @@
-Refactoring:
-
-* make an Exception class
-
 Features to be implemented:
 
 week_time = WeekTime.new

data/lib/relativity/day_time.rb

@@ -2,7 +2,7 @@ class DayTime
 
   require 'bigdecimal'
 
-  attr_reader :seconds_since_start
+  attr_reader :seconds_since_midnight
 
   def initialize(hours = nil, minutes = nil, seconds = nil, nano_seconds = nil)
     super()
@@ -18,25 +18,25 @@ class DayTime
       ss = t.sec
       nn = t.nsec
     end
-    @seconds_since_start = ((hh * 3600) + (mm * 60) + ss + BigDecimal(nn)/BigDecimal(1000000000))%(24*3600)
+    @seconds_since_midnight = ((hh * 3600) + (mm * 60) + ss + BigDecimal(nn)/BigDecimal(1000000000))%(24*3600)
   end
 
   def hours
-    hours = Integer(@seconds_since_start/(3600)).tap do |h|
-      raise "Internal ERROR in DayTime; hours is #{h}" if (h < 0 || h > 23)
+    hours = Integer(@seconds_since_midnight/3600).tap do |h|
+      raise Relativity::InternalError, "hours is out of bound : #{h}" if (h < 0 || h > 23)
     end
   end
 
   def minutes
-    Integer(@seconds_since_start / 60) % 60
+    Integer(@seconds_since_midnight / 60) % 60
   end
 
   def seconds
-    Integer(@seconds_since_start) % 60
+    Integer(@seconds_since_midnight) % 60
   end
 
   def nano_seconds
-    Integer((@seconds_since_start % 1) * 1000000000)
+    Integer((@seconds_since_midnight % 1) * 1000000000)
   end
 
   def to_s

data/lib/relativity/exception.rb

@@ -0,0 +1,4 @@
+module Relativity
+  class InternalError < StandardError
+  end
+end

data/lib/relativity/version.rb

@@ -1,3 +1,3 @@
 module Relativity
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/relativity.rb

@@ -1,3 +1,4 @@
 require 'relativity/version'
+require 'relativity/exception'
 require 'relativity/day_time'
 require 'relativity/day_time_range'

data/spec/day_time/day_time_spec.rb

@@ -6,14 +6,14 @@ describe DayTime do
     lambda { subject }.should_not raise_error
   end
 
-  it "seconds_since_start" do
-    lambda { subject.seconds_since_start }.should_not raise_error
+  it "seconds_since_midnight" do
+    lambda { subject.seconds_since_midnight }.should_not raise_error
   end
 
   it "new creates a DayTime close to now" do
-    rt_s = subject.seconds_since_start
+    rt_s = subject.seconds_since_midnight
     t = Time.new
-    t_s = (t.hour*60 + t.min)*60 + t.sec + t.nsec/1E9 # seconds_since_start from Time
+    t_s = (t.hour*60 + t.min)*60 + t.sec + t.nsec/1E9 # seconds_since_midnight from Time
     (((t_s-rt_s).abs+2)%(24*60*60)).should be <= 4
   end
 
@@ -29,8 +29,8 @@ describe DayTime do
     (((subject.seconds - Time.new.sec).abs+2)%60).should be <= 4
   end
 
-  it "seconds_since_start should be BigDecimal" do
-    subject.seconds_since_start.should be_kind_of(BigDecimal)
+  it "seconds_since_midnight should be BigDecimal" do
+    subject.seconds_since_midnight.should be_kind_of(BigDecimal)
   end
 
   it "hours should be Integer" do

data/spec/day_time/exception_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe Relativity::InternalError do
+
+  it "inherits from StandardError" do
+    subject.should be_a(StandardError)
+  end
+
+  it "raised for hours out of bound" do
+    day_time = DayTime.new
+    day_time.instance_variable_set(:@seconds_since_midnight, -100_000)
+    lambda { day_time.hours }.should raise_error(Relativity::InternalError, 'hours is out of bound : -28')
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: relativity
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-12 00:00:00.000000000 Z
+date: 2012-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &68449760 !ruby/object:Gem::Requirement
+  requirement: &81174410 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.7'
   type: :development
   prerelease: false
-  version_requirements: *68449760
+  version_requirements: *81174410
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &68449150 !ruby/object:Gem::Requirement
+  requirement: &81173310 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0.5'
   type: :development
   prerelease: false
-  version_requirements: *68449150
+  version_requirements: *81173310
 - !ruby/object:Gem::Dependency
   name: rb-inotify
-  requirement: &68448230 !ruby/object:Gem::Requirement
+  requirement: &81171830 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *68448230
+  version_requirements: *81171830
 - !ruby/object:Gem::Dependency
   name: libnotify
-  requirement: &68447520 !ruby/object:Gem::Requirement
+  requirement: &81170730 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *68447520
+  version_requirements: *81170730
 description: time and time_ranges relative to day, week, month, quarter etc.
 email:
 - peter@vandenabeele.com
@@ -74,9 +74,11 @@ files:
 - lib/relativity.rb
 - lib/relativity/day_time.rb
 - lib/relativity/day_time_range.rb
+- lib/relativity/exception.rb
 - lib/relativity/version.rb
 - relativity.gemspec
 - spec/day_time/day_time_spec.rb
+- spec/day_time/exception_spec.rb
 - spec/day_time/output_spec.rb
 - spec/day_time/overflow_spec.rb
 - spec/day_time_range/day_time_range_spec.rb