relation_to_struct 1.6.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d1ffdbfc2950c798cd223660370ca62ee6a8128b
-  data.tar.gz: 246947abe7a8f85d6c2558a3b33a0b027547ada4
+SHA256:
+  metadata.gz: 7bb8b931d89b6d73791900b6e8103442856413d8bead16b0f006b28163765ae9
+  data.tar.gz: '01867db9481ad85af27892312f23a5f9ceb7687bc7b3232e1c952324be98ab81'
 SHA512:
-  metadata.gz: 25ef491ea1f470beea129c8e1d5f92308773092ef470afaadedd56ec9046ad1950d4192e1e61efa816966ecf0dc5eafe40c23bc33ed0572424d0c82368d6cbdf
-  data.tar.gz: 8a8f2eebe3192ae4d3947a309adfd476e903af1bc754496d1f53f03d8040afb8ad12f12f640a4f69dcc54179b015b02399a19b2d712420b0dabed21fff561c2a
+  metadata.gz: 6a9aa775119c2e6de109e000591b7dcdd149d5caccc5e3dc145cab69f7e22bc1d142a83bcbb47ccf55f0d2ea9109d44973a7ea6f87226ae46d300b6b6f87e49b
+  data.tar.gz: 701affeecbfbce06009babd6d48f6b98622f7de98d7fce6bb3a701c0587845940057ded3661c6e0574a7b7a46ff8003c0f0b7837705263f1377725dae44dd553

data/.github/workflows/ci.yml

@@ -0,0 +1,66 @@
+name: CI
+on: [push, pull_request]
+jobs:
+  test_postgres:
+    strategy:
+      matrix:
+        pg:
+          - 11
+          - 12
+          - 13
+          - 14
+          - 15
+          - 16
+        ruby:
+          - "3.0"
+          - "3.1"
+          - "3.2"
+        gemfile:
+          - rails_6_1
+          - rails_7_0
+          - rails_7_1
+    name: PostgreSQL ${{ matrix.pg }} - Ruby ${{ matrix.ruby }} - ${{ matrix.gemfile }}
+    runs-on: ubuntu-latest
+    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
+      ImageOS: ubuntu20
+    steps:
+      - uses: actions/checkout@v3
+      - name: Start the postgres container
+        run: docker-compose up -d
+        env:
+          PGVERSION: ${{ matrix.pg }}
+      - name: Setup Ruby using .ruby-version file
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - run: bundle exec rake spec
+        env:
+          DATABASE: postgresql
+  test_sqlite:
+    strategy:
+      matrix:
+        ruby:
+          - "3.0"
+          - "3.1"
+          - "3.2"
+        gemfile:
+          - rails_6_1
+          - rails_7_0
+          - rails_7_1
+    name: SQLite - Ruby ${{ matrix.ruby }} - ${{ matrix.gemfile }}
+    runs-on: ubuntu-latest
+    env: # $BUNDLE_GEMFILE must be set at the job level, so it is set for all steps
+      BUNDLE_GEMFILE: gemfiles/${{ matrix.gemfile }}.gemfile
+      ImageOS: ubuntu20
+    steps:
+      - uses: actions/checkout@v3
+      - name: Setup Ruby using .ruby-version file
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - run: bundle exec rake spec
+        env:
+          DATABASE: sqlite

data/Appraisals

@@ -1,10 +1,5 @@
-%w(5.0 5.1 5.2 6.0).each do |version|
+%w(6.1 7.0 7.1).each do |version|
   appraise "rails-#{version.gsub(/\./, "-")}" do
     gem "rails", "~> #{version}.0"
-    if version[0] == '6'
-      gem "sqlite3", "~> 1.4.0"
-    else
-      gem "sqlite3", "~> 1.3.0"
-    end
   end
 end

data/README.md

@@ -110,4 +110,4 @@ For this reason, **all methods added to `ActiveRecord::Base` explicitly disable
 
 1. Bump version in `lib/relation_to_struct/version.rb` and commit.
 2. Run `rake build` to build the `*.gem` file.
-3. Run `rake release` to publish the gem to Rubygems.
+3. Run `rake release` to publish the gem to Rubygems. Note: if while releasing the gem you get the error ``Your rubygems.org credentials aren't set. Run `gem push` to set them.`` you can more simply run `gem signin`.

data/bin/setup

@@ -0,0 +1,12 @@
+#!/usr/bin/env bash
+set -euo pipefail
+IFS=$'\n\t'
+set -vx
+
+bundle install
+bundle exec appraisal install
+
+# Do any other automated setup that you need to do here
+
+# Launch a blank postgres image
+docker-compose up -d

data/docker-compose.yml

@@ -0,0 +1,8 @@
+version: "3.3"
+services:
+  db:
+    image: postgres:${PGVERSION:-16}
+    ports:
+      - "5432:5432"
+    environment:
+      - POSTGRES_PASSWORD=${PGPASSWORD:-postgres}

data/gemfiles/{rails_5_0.gemfile → rails_6_1.gemfile}

@@ -2,7 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "~> 5.0.0"
-gem "sqlite3", "~> 1.3.0"
+gem "rails", "~> 6.1.0"
 
 gemspec path: "../"

data/gemfiles/{rails_5_1.gemfile → rails_7_0.gemfile}

@@ -2,7 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "~> 5.1.0"
-gem "sqlite3", "~> 1.3.0"
+gem "rails", "~> 7.0.0"
 
 gemspec path: "../"

data/gemfiles/{rails_5_2.gemfile → rails_7_1.gemfile}

@@ -2,7 +2,6 @@
 
 source "https://rubygems.org"
 
-gem "rails", "~> 5.2.0"
-gem "sqlite3", "~> 1.3.0"
+gem "rails", "~> 7.1.0"
 
 gemspec path: "../"

data/lib/relation_to_struct/active_record_base_extension.rb

@@ -1,9 +1,5 @@
 module RelationToStruct::ActiveRecordBaseExtension
   module ClassMethods
-    def _sanitize_sql_for_relation_to_struct(sql)
-      sanitized_sql = ActiveRecord::VERSION::MAJOR >= 5 ? sanitize_sql(sql) : sanitize_sql(sql, nil)
-    end
-
     delegate(
       :structs_from_sql,
       :pluck_from_sql,
@@ -15,4 +11,4 @@ module RelationToStruct::ActiveRecordBaseExtension
   end
 end
 
-::ActiveRecord::Base.singleton_class.send(:prepend, RelationToStruct::ActiveRecordBaseExtension::ClassMethods)
+::ActiveRecord::Base.singleton_class.prepend(RelationToStruct::ActiveRecordBaseExtension::ClassMethods)

data/lib/relation_to_struct/active_record_connection_adapter_extension.rb

@@ -1,6 +1,6 @@
 module RelationToStruct::ActiveRecordConnectionAdapterExtension
   def structs_from_sql(struct_class, sql, binds=[])
-    sanitized_sql = ActiveRecord::Base._sanitize_sql_for_relation_to_struct(sql)
+    sanitized_sql = ActiveRecord::Base.sanitize_sql(sql)
     result = ActiveRecord::Base.uncached do
       select_all(sanitized_sql, "Structs SQL Load", binds)
     end
@@ -25,7 +25,7 @@ module RelationToStruct::ActiveRecordConnectionAdapterExtension
   end
 
   def pluck_from_sql(sql, binds=[])
-    sanitized_sql = ActiveRecord::Base._sanitize_sql_for_relation_to_struct(sql)
+    sanitized_sql = ActiveRecord::Base.sanitize_sql(sql)
     result = ActiveRecord::Base.uncached do
       select_all(sanitized_sql, "Pluck SQL Load", binds)
     end
@@ -33,7 +33,7 @@ module RelationToStruct::ActiveRecordConnectionAdapterExtension
   end
 
   def value_from_sql(sql, binds=[])
-    sanitized_sql = ActiveRecord::Base._sanitize_sql_for_relation_to_struct(sql)
+    sanitized_sql = ActiveRecord::Base.sanitize_sql(sql)
     result = ActiveRecord::Base.uncached do
       select_all(sanitized_sql, "Value SQL Load", binds)
     end
@@ -51,7 +51,7 @@ module RelationToStruct::ActiveRecordConnectionAdapterExtension
   end
 
   def tuple_from_sql(sql, binds=[])
-    sanitized_sql = ActiveRecord::Base._sanitize_sql_for_relation_to_struct(sql)
+    sanitized_sql = ActiveRecord::Base.sanitize_sql(sql)
     result = ActiveRecord::Base.uncached do
       select_all(sanitized_sql, "Value SQL Load", binds)
     end
@@ -68,7 +68,7 @@ module RelationToStruct::ActiveRecordConnectionAdapterExtension
   end
 
   def run_sql(sql, binds=[])
-    sanitized_sql = ActiveRecord::Base._sanitize_sql_for_relation_to_struct(sql)
+    sanitized_sql = ActiveRecord::Base.sanitize_sql(sql)
     # We don't need to build a result set unnecessarily; using
     # interface this also ensures we're clearing the result set
     # for manually memory managed object (e.g., when using the
@@ -77,4 +77,4 @@ module RelationToStruct::ActiveRecordConnectionAdapterExtension
   end
 end
 
-::ActiveRecord::ConnectionAdapters::AbstractAdapter.send(:prepend, RelationToStruct::ActiveRecordConnectionAdapterExtension)
+::ActiveRecord::ConnectionAdapters::AbstractAdapter.prepend(RelationToStruct::ActiveRecordConnectionAdapterExtension)

data/lib/relation_to_struct/active_record_relation_extension.rb

@@ -6,12 +6,7 @@ module RelationToStruct::ActiveRecordRelationExtension
 
     # See the definition of #pluck in:
     # activerecord/lib/active_record/relation/calculations.rb
-    result = nil
-    if ActiveRecord::VERSION::MAJOR == 5 && ActiveRecord::VERSION::MINOR < 2
-      result = klass.connection.select_all(relation.arel, nil, bound_attributes)
-    else
-      result = klass.connection.select_all(relation.arel)
-    end
+    result = klass.connection.select_all(relation.arel)
 
     if result.columns.size != struct_class.members.size
       raise ArgumentError, 'Expected struct fields and columns lengths to be equal'
@@ -35,4 +30,4 @@ module RelationToStruct::ActiveRecordRelationExtension
   end
 end
 
-::ActiveRecord::Relation.send(:prepend, RelationToStruct::ActiveRecordRelationExtension)
+::ActiveRecord::Relation.prepend(RelationToStruct::ActiveRecordRelationExtension)

data/lib/relation_to_struct/version.rb

@@ -1,3 +1,3 @@
 module RelationToStruct
-  VERSION = "1.6.0"
+  VERSION = "1.9.0"
 end

data/lib/relation_to_struct.rb

@@ -2,6 +2,3 @@ require "relation_to_struct/version"
 require "relation_to_struct/active_record_connection_adapter_extension"
 require "relation_to_struct/active_record_base_extension"
 require "relation_to_struct/active_record_relation_extension"
-
-module RelationToStruct
-end

data/relation_to_struct.gemspec

@@ -21,11 +21,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "appraisal", ">= 2.1"
   spec.add_development_dependency "bundler", ">= 1.7"
   spec.add_development_dependency "rake", ">= 10.0"
-  spec.add_development_dependency "sqlite3", ">= 1.3"
+  spec.add_development_dependency "sqlite3", ">= 1.4"
   spec.add_development_dependency "rspec", ">= 3.2"
   spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "pg"
 
-  spec.add_dependency "activerecord", ">= 5.0", "< 7"
-  spec.add_dependency "activesupport", ">= 5.0", "< 7"
+  spec.add_dependency "activerecord", ">= 6.1", "< 7.2"
+  spec.add_dependency "activesupport", ">= 6.1", "< 7.2"
 end

data/spec/active_record_helper/setup.rb

@@ -4,8 +4,8 @@ ActiveRecord::Base.configurations = {
     "host" => 'localhost',
     "database" => 'relation_to_struct_tests',
     "encoding" => 'utf8',
-    "username" => ENV["DATABASE_POSTGRESQL_USERNAME"] || `whoami`.strip,
-    "password" => ENV["DATABASE_POSTGRESQL_PASSWORD"],
+    "username" => ENV["PGUSER"] || 'postgres',
+    "password" => ENV["PGPASSWORD"] || 'postgres',
   },
   "sqlite" => {
     "adapter"  => "sqlite3",
@@ -14,7 +14,7 @@ ActiveRecord::Base.configurations = {
 }
 
 env = ENV['DATABASE'] ||= 'sqlite'
-config = ActiveRecord::Base.configurations[env]
+config = ActiveRecord::Base.configurations.configs_for(env_name: env).first
 
 case env
 when 'postgresql'

data/spec/active_record_relation_spec.rb

@@ -57,7 +57,7 @@ describe ActiveRecord::Relation do
     it 'properly casts values from arbitrary calculated columns' do
       hayek = Economist.create!(name: 'F.A. Hayek')
       scope = Economist.all
-      pluck_results = scope.pluck("date('now')")
+      pluck_results = scope.pluck(Arel.sql("date('now')"))
       pluck_column_klass = pluck_results.first.class
 
       date_struct = Struct.new(:date)

data/spec/spec_helper.rb

@@ -14,7 +14,7 @@ def active_record_supports_arrays?
       Economist.create!(name: 'F.A. Hayek')
       Economist.create!(name: 'Ludwig von Mises')
 
-      pluck_results = Economist.select('name').order('id').limit(1).pluck('array[name]') rescue nil
+      pluck_results = Economist.select('name').order('id').limit(1).pluck(Arel.sql('array[name]'))  rescue nil
       if pluck_results
         raise StandardError, "Unexpected array query results" unless pluck_results == [['F.A. Hayek']] # Verify ActiveRecord interface.
         supports_arrays = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relation_to_struct
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.9.0
 platform: ruby
 authors:
 - James Coleman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-12 00:00:00.000000000 Z
+date: 2023-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -114,47 +114,49 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '6.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '7.2'
 description: ''
 email:
 - jtc331@gmail.com
-executables: []
+executables:
+- setup
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - Appraisals
@@ -162,10 +164,11 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemfiles/rails_5_0.gemfile
-- gemfiles/rails_5_1.gemfile
-- gemfiles/rails_5_2.gemfile
-- gemfiles/rails_6_0.gemfile
+- bin/setup
+- docker-compose.yml
+- gemfiles/rails_6_1.gemfile
+- gemfiles/rails_7_0.gemfile
+- gemfiles/rails_7_1.gemfile
 - lib/relation_to_struct.rb
 - lib/relation_to_struct/active_record_base_extension.rb
 - lib/relation_to_struct/active_record_connection_adapter_extension.rb
@@ -200,8 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Return struct results from ActiveRecord relation queries

data/gemfiles/rails_6_0.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 6.0.0"
-gem "sqlite3", "~> 1.4.0"
-
-gemspec path: "../"