relation_to_struct 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4917a1af7ed5ef3d71c3f31314f67cf7150f2903
-  data.tar.gz: d1e99802577449b4b789a7b52476a4a7333b6b36
+  metadata.gz: f14569badb2ed3049d91f233ebc208c09bef0251
+  data.tar.gz: 3513ef3efd8d057645db818927a1939338e75f17
 SHA512:
-  metadata.gz: 8bf5ac98b2a2945701453e84c48576ba6257a2be03109d5efa32dd1e4d1bb1d23abc57bb21f570798e8d919d19707ca8e71c2374aa53d3ea139e09a1a3804cbf
-  data.tar.gz: d4cdf8c1d1d0de0b9cc9e3b40112888a5b20f6053a7c5e7faca2895cd4db7d14a8d3b769246fe112ab7516ebe88e3a1d9d7df121acfeef4b62a98540cc1c4c35
+  metadata.gz: 87b088344c4b07d36ef607bd145a6a4480b6397e07c47b3495e40462d7bf9a4ac564e4590d4addd01deae8353c7abd757ac60fbdd5ded1b2a22e3e71355fa37e
+  data.tar.gz: 70b3761d903aee08b8a36a3fd16dc53b8bfb416b23dc8445e26421d38ec289d9e6cc548f1dcda139fba0be407f12a4d90aaccb1632d142394a83954d3815818b

data/lib/relation_to_struct/active_record_base_extension.rb

@@ -9,6 +9,10 @@ module RelationToStruct::ActiveRecordBaseExtension
         raise ArgumentError, 'Expected struct fields and columns lengths to be equal'
       end
 
+      if result.columns.size != result.column_types.size
+        raise ArgumentError, 'Expected unique column names count and column count to be equal'
+      end
+
       if result.columns.size == 1
         result.cast_values().map do |tuple|
           struct_class.new(tuple)

data/lib/relation_to_struct/active_record_relation_extension.rb

@@ -11,6 +11,10 @@ module RelationToStruct::ActiveRecordRelationExtension
       raise ArgumentError, 'Expected struct fields and columns lengths to be equal'
     end
 
+    if result.columns.size != result.column_types.size
+      raise ArgumentError, 'Expected unique column names count and column count to be equal'
+    end
+
     result.cast_values(klass.column_types)
 
     if result.columns.size == 1

data/lib/relation_to_struct/version.rb

@@ -1,3 +1,3 @@
 module RelationToStruct
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/relation_to_struct_spec.rb

@@ -42,7 +42,7 @@ describe RelationToStruct do
       expect(
         Economist
           .joins(:economic_school)
-          .select('economists.name', 'economic_schools.name')
+          .select('economists.name', 'economic_schools.name as school_name')
           .to_structs(test_struct)
       ).to eq([test_struct.new(hayek.name, austrian.name)])
     end
@@ -81,6 +81,13 @@ describe RelationToStruct do
         Economist.select('id, name').to_structs(test_struct)
       end.to raise_error(ArgumentError, 'Expected struct fields and columns lengths to be equal')
     end
+
+    it '#to_structs should raise an error when column_type count does not match the column count' do
+      expect do
+        test_struct = Struct.new(:id, :id2)
+        Economist.select('id, id').to_structs(test_struct)
+      end.to raise_error(ArgumentError, 'Expected unique column names count and column count to be equal')
+    end
   end
 
   describe 'non-model specific querying' do
@@ -126,5 +133,12 @@ describe RelationToStruct do
         ActiveRecord::Base.structs_from_sql(test_struct, 'SELECT id, name FROM economists')
       end.to raise_error(ArgumentError, 'Expected struct fields and columns lengths to be equal')
     end
+
+    it 'structs_from_sql should raise an error when column_type count does not match the column count' do
+      expect do
+        test_struct = Struct.new(:id, :id2)
+        ActiveRecord::Base.structs_from_sql(test_struct, 'SELECT id, id FROM economists')
+      end.to raise_error(ArgumentError, 'Expected unique column names count and column count to be equal')
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: relation_to_struct
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - James Coleman