relation 0.3.7 → 0.4.2

data/lib/relation/engine.rb

@@ -1,26 +1,4 @@
-# rubocop: disable all
-
 module ModRelation
-  class Engine < Rails::Engine
-    isolate_namespace ModRelation
-
-    # # https://github.com/rails/rails/issues/22261
-    #     initializer :append_migrations do |app|
-    #       config.paths['db/migrate'].expanded.each do |path|
-    #         app.config.paths['db/migrate'] << path
-    #         ActiveRecord::Migrator.migrations_paths << path
-    #       end
-    #     end
-
-    # # https://github.com/rails/rails/issues/22261
-    # module ActiveRecord
-    # #module ActiveRecord::Current
-    #   class Schema < Migration
-    #     def migrations_paths
-    #       (ActiveRecord::Migrator.migrations_paths +
-    #        Rails.application.paths['db/migrate'].to_a).uniq
-    #     end
-    #   end
-    # end
+  class Engine < ::Rails::Engine
   end
 end

data/lib/relation/version.rb

@@ -1,12 +1,16 @@
 # rubocop: disable all
 
 module ModRelation
-  VERSION = '0.3.7'  # 2020-07-14
-# VERSION = '0.3.6'  # 2020-04-27
-# VERSION = '0.3.5'  # 2020-03-03
-# VERSION = '0.3.4'  # 2019-10-04
-# VERSION = '0.3.3'  # 2019-03-23
-# VERSION = '0.3.2'  # 2019-03-05
-# VERSION = '0.3.1'  # 2018-08-05
-# VERSION = '0.3.0'  #
+  VERSION = "0.4.2"  # 2023-01-19
+  # VERSION = "0.4.1"  # 2023-01-18
+  # VERSION = "0.4.0"  # 2023-01-12
+  # VERSION = "0.3.8"  # 2021-06-22
+  # VERSION = "0.3.7"  # 2020-07-14
+  # VERSION = "0.3.6"  # 2020-04-27
+  # VERSION = "0.3.5"  # 2020-03-03
+  # VERSION = "0.3.4"  # 2019-10-04
+  # VERSION = "0.3.3"  # 2019-03-23
+  # VERSION = "0.3.2"  # 2019-03-05
+  # VERSION = "0.3.1"  # 2018-08-05
+  # VERSION = "0.3.0"  #
 end

data/lib/relation.rb

@@ -1,6 +1,3 @@
-# rubocop: disable all
-
-require 'relation/engine.rb'
-require 'models/relation.rb'
-require 'models/relation_ext.rb'
-require 'models/dangling.rb'
+require "models/relation"
+require "models/relation_ext"
+require "models/dangling"

data/relation.gemspec

@@ -1,33 +1,29 @@
-$:.push File.expand_path('../lib', __FILE__)
-require 'relation/version'
+require_relative "lib/relation/version"
 
 Gem::Specification.new do |s|
-  s.name        = 'relation'
-  s.version     = ModRelation::VERSION
-  s.summary     = <<-'END'
-    Provides a simple directed relationship between active_record models.
+  s.name = "relation"
+  s.version = ModRelation::VERSION
+  s.summary = <<-'END'
+    Rails gem adding relationships between ActiveRecord models.
   END
   s.description = <<-'END'
     A Rails gem that adds simple support for organizing ActiveRecord models.
+    Relationships are stored in one additional database table.
   END
-  s.authors     = ['Dittmar Krall']
-  s.email       = ['dittmar.krall@matique.de']
-  s.homepage    = 'https://github.com/matique/relation'
+  s.authors = ["Dittmar Krall"]
+  s.email = ["dittmar.krall@matiq.com"]
+  s.homepage = "https://matiq.com"
+  s.license = "MIT"
+  s.platform = Gem::Platform::RUBY
 
-  s.license     = 'MIT'
-  s.platform    = Gem::Platform::RUBY
+  s.metadata["source_code_uri"] = "https://github.com/matique/relation"
 
-  s.files         = `git ls-files`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.test_files    = `git ls-files -- {test,features}/*`.split("\n")
-  s.require_paths = ['lib', 'app']
+  s.files = `git ls-files`.split("\n")
+  s.require_paths = ["lib", "app"]
 
-  s.add_dependency 'activerecord', '~>6'
-
-  s.add_development_dependency 'bundler', '~>1'
-  s.add_development_dependency 'rake', '~>13'
-  s.add_development_dependency 'appraisal', '~>2'
-
-  s.add_development_dependency 'minitest', '~>5'
-  s.add_development_dependency 'sqlite3', '~>1'
+  s.add_development_dependency "bundler"
+  s.add_development_dependency "combustion"
+  s.add_development_dependency "minitest"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "sqlite3"
 end

data/test/dangling_test.rb

@@ -1,40 +1,35 @@
-require 'test_helper'
+require "test_helper"
 
 describe Relation do
-  let(:user)   { User.create! name: 'user' }
-  let(:user2)  { User.create! name: 'user2' }
-  let(:order)  { Order.create! name: 'order' }
-  let(:order2) { Order.create! name: 'order2' }
+  let(:user) { User.create! email: "info@sample.com" }
+  let(:user2) { User.create! email: "info2@sample.com" }
+  let(:order) { Order.create! name: "order" }
+  let(:order2) { Order.create! name: "order2" }
 
   def setup
-    DB.setup
-
-    Relation.add user,  order
+    Relation.delete_all
+    Relation.add user, order
     Relation.add user2, order
     Relation.add user2, order2
   end
 
-  def teardown
-    DB.teardown
-  end
-
   it "test remove dangling #1" do
-    hsh = { 'User' => [user.id] }
-    assert_difference('Relation.count', -1) do
+    hsh = {"User" => [user.id]}
+    assert_difference("Relation.count", -1) do
       Relation.remove_dangling(hsh)
     end
   end
 
   it "test remove dangling #2" do
-    hsh = { 'User' => [user2.id] }
-    assert_difference('Relation.count', -2) do
+    hsh = {"User" => [user2.id]}
+    assert_difference("Relation.count", -2) do
       Relation.remove_dangling(hsh)
     end
   end
 
   it "test remove dangling #3" do
-    hsh = { 'Order' => [order.id] }
-    assert_difference('Relation.count', -2) do
+    hsh = {"Order" => [order.id]}
+    assert_difference("Relation.count", -2) do
       Relation.remove_dangling(hsh)
     end
   end
@@ -42,12 +37,11 @@ describe Relation do
   it "test dangling" do
     assert_equal({}, Relation.dangling)
     user.destroy
-    assert_equal({"User"=>[user.id]}, Relation.dangling)
+    assert_equal({"User" => [user.id]}, Relation.dangling)
     user2.destroy
-    assert_equal({"User"=>[user.id, user2.id]}, Relation.dangling)
+    assert_equal({"User" => [user.id, user2.id]}, Relation.dangling)
     order.destroy
-    assert_equal({"User"=>[user.id, user2.id].sort, "Order"=>[order.id]},
-		Relation.dangling)
+    assert_equal({"User" => [user.id, user2.id].sort, "Order" => [order.id]},
+      Relation.dangling)
   end
-
 end

data/test/internal/app/models/order.rb

@@ -0,0 +1,2 @@
+class Order < ActiveRecord::Base
+end

data/test/internal/app/models/user.rb

@@ -0,0 +1,2 @@
+class User < ActiveRecord::Base
+end

data/test/internal/config/database.yml

@@ -0,0 +1,3 @@
+test:
+  adapter:  sqlite3
+  database: db/test.sqlite3

data/test/internal/db/schema.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+ActiveRecord::Schema.define(version: 202208) do
+  create_table :relations, force: true, id: false do |t|
+    t.string     :name
+    t.references :from, null: false
+    t.references :to, null: false
+    t.timestamps
+
+    t.index :name
+  end
+
+  create_table "orders", force: true do |t|
+    t.string :name
+    t.string :category
+    t.text :bag
+
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+  create_table "users", force: true do |t|
+    t.string :email
+
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+end

data/test/relation_ext_test.rb

@@ -1,63 +1,56 @@
-require 'test_helper'
+require "test_helper"
 
 describe Relation do
-  let(:user)   { User.create! name: 'user' }
-  let(:user2)  { User.create! name: 'user2' }
-  let(:order)  { Order.create! name: 'order' }
-  let(:order2) { Order.create! name: 'order2' }
+  let(:user) { User.create! email: "info@sample.com" }
+  let(:user2) { User.create! email: "info2@sample.com" }
+  let(:order) { Order.create! name: "order" }
+  let(:order2) { Order.create! name: "order2" }
 
   def setup
-    DB.setup
-
-    Relation.add user,  order
+    Relation.add user, order
     Relation.add user2, order
     Relation.add user2, order2
   end
 
-  def teardown
-    DB.teardown
-  end
-
   it "should add a connection" do
-    assert_difference('Relation.count') do
+    assert_difference("Relation.count") do
       Relation.add user2, user
     end
   end
 
   it "should delete a connection" do
     Relation.add user2, user
-    assert_difference('Relation.count', -1) do
+    assert_difference("Relation.count", -1) do
       Relation.delete user2, user
     end
   end
 
   it "should return references (using class name)" do
-    arr = Relation.references(user, 'Order')
+    arr = Relation.references(user, "Order")
     assert_equal [order].sort, arr.sort
 
-    arr = Relation.references(user2, 'Order')
+    arr = Relation.references(user2, "Order")
     assert_equal [order, order2].sort, arr.sort
   end
 
   it "should return followers (using class name)" do
-    arr = Relation.followers('User', order)
+    arr = Relation.followers("User", order)
     assert_equal [user, user2].sort, arr.sort
 
-    arr = Relation.followers('User', order2)
+    arr = Relation.followers("User", order2)
     assert_equal [user2].sort, arr.sort
   end
 
   it "should not add twice the same connection" do
-    assert_difference('Relation.count') do
+    assert_difference("Relation.count") do
       Relation.add user2, user
       Relation.add user2, user
     end
   end
 
   it "should handle unexistent connection" do
-    assert_difference('Relation.count', 0) do
+    assert_difference("Relation.count", 0) do
       Relation.delete user2, user
     end
   end
-
 end

data/test/relation_test.rb

@@ -1,34 +1,28 @@
-require 'test_helper'
+require "test_helper"
 
 # testing raw/basic relations
 describe Relation do
-  let(:u_id)   { User.create!(name: 'user').id }
-  let(:u2_id)  { User.create!(name: 'user2').id }
-  let(:o_id)   { Order.create!(name: 'order').id }
-  let(:o2_id)  { Order.create!(name: 'order2').id }
-  let(:unknown_id)  { 123456 }
+  let(:u_id) { User.create!(email: "info@sample.com").id }
+  let(:u2_id) { User.create!(email: "info2@sample.com").id }
+  let(:o_id) { Order.create!(name: "order").id }
+  let(:o2_id) { Order.create!(name: "order2").id }
+  let(:unknown_id) { 123456 }
 
   def setup
-    DB.setup
-
     Relation.add_raw :rel, u_id, o_id
     Relation.add_raw :rel, u2_id, o_id
     Relation.add_raw :rel, u2_id, o2_id
   end
 
-  def teardown
-    DB.teardown
-  end
-
   it "should add a relation" do
-    assert_difference('Relation.count') do
+    assert_difference("Relation.count") do
       Relation.add_raw :raw, u2_id, u_id
     end
   end
 
   it "should delete a relation" do
     Relation.add_raw :raw, u2_id, u_id
-    assert_difference('Relation.count', -1) do
+    assert_difference("Relation.count", -1) do
       Relation.delete_raw :raw, u2_id, u_id
     end
   end
@@ -50,16 +44,15 @@ describe Relation do
   end
 
   it "should not add twice the same connection" do
-    assert_difference('Relation.count') do
+    assert_difference("Relation.count") do
       Relation.add_raw :rel, u2_id, unknown_id
       Relation.add_raw :rel, u2_id, unknown_id
     end
   end
 
   it "should handle unexistent connection" do
-    assert_difference('Relation.count', 0) do
+    assert_difference("Relation.count", 0) do
       Relation.delete_raw :rel, u2_id, unknown_id
     end
   end
-
 end

data/test/test_helper.rb

@@ -1,17 +1,16 @@
-if ENV['COVERAGE']
-  require 'simplecov'
+if ENV["COVERAGE"]
+  require "simplecov"
   SimpleCov.start do
-    add_filter '/test/'
+    add_filter "/test/"
   end
 end
 
-require 'active_record'
-require 'minitest/autorun'
-
-# Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
-
-class Minitest::Test
-  require 'active_support/testing/assertions'
-  include ActiveSupport::Testing::Assertions
+require "combustion"
+Combustion.path = "test/internal"
+Combustion.initialize! :active_record do
+  config.active_record.yaml_column_permitted_classes = [Symbol, Time, Date]
 end
+
+require "rails/test_help"
+require "minitest/autorun"
+require "minitest/benchmark"

metadata

@@ -1,114 +1,98 @@
 --- !ruby/object:Gem::Specification
 name: relation
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.4.2
 platform: ruby
 authors:
 - Dittmar Krall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-14 00:00:00.000000000 Z
+date: 2023-01-19 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: activerecord
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: combustion
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '13'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1'
-description: "    A Rails gem that adds simple support for organizing ActiveRecord
-  models.\n"
+        version: '0'
+description: |2
+      A Rails gem that adds simple support for organizing ActiveRecord models.
+      Relationships are stored in one additional database table.
 email:
-- dittmar.krall@matique.de
+- dittmar.krall@matiq.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rake.yml"
 - ".gitignore"
-- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
-- ".travis.yml"
-- ".watchr"
-- Appraisals
 - Gemfile
 - Gemfile.lock
 - MIT-LICENSE
@@ -117,22 +101,24 @@ files:
 - app/models/dangling.rb
 - app/models/relation.rb
 - app/models/relation_ext.rb
-- db/migrate/20150810152808_relation.rb
-- gemfiles/rails_5.2.gemfile
-- gemfiles/rails_6.0.gemfile
+- db/migrate/003_create_relations.rb
 - lib/relation.rb
 - lib/relation/engine.rb
 - lib/relation/version.rb
 - relation.gemspec
 - test/dangling_test.rb
+- test/internal/app/models/order.rb
+- test/internal/app/models/user.rb
+- test/internal/config/database.yml
+- test/internal/db/schema.rb
 - test/relation_ext_test.rb
 - test/relation_test.rb
-- test/support/database.rb
 - test/test_helper.rb
-homepage: https://github.com/matique/relation
+homepage: https://matiq.com
 licenses:
 - MIT
-metadata: {}
+metadata:
+  source_code_uri: https://github.com/matique/relation
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -149,8 +135,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.4.1
 signing_key: 
 specification_version: 4
-summary: Provides a simple directed relationship between active_record models.
+summary: Rails gem adding relationships between ActiveRecord models.
 test_files: []

data/.rubocop.yml

@@ -1,8 +0,0 @@
-inherit_from:
-  - ~/configs/.rubocop.yml
-
-AllCops:
-  Include:
-    - 'lib/**/*.rb'
-  Exclude:
-    - 'test/**/*'

data/.travis.yml

@@ -1,43 +0,0 @@
-language: ruby
-sudo: false
-
-## speeding up
-#env:
-#  - TEST_SUITE=units
-#  - TEST_SUITE=integration
-#
-#script: "bundle exec rake test:$TEST_SUITE"
-
-#bundler_args: --without test
-bundler_args: --without production
-#bundler_args: --without development
-
-rvm:
-  - 2.6.6  # 2020-07-14
-#  - 2.6.5  # 2019-10-29
-#  - 2.6.4  # 2019-10-04
-#  - 2.6.3  # 2019-06-21
-#  - 2.6.1  # 2019-03-05
-#  - 2.5.1  # 2018-04-27
-#  - 2.5.0  # 2018-02-22
-#  - 2.4.1  # tested: working for Rails 5
-#  - 2.3.1  # tested: working for Rails 5
-#  - 2.2.7  # tested: working for Rails 5
-#  - 2.2.0  # tested: failing for Rails 5
-
-gemfile:
-  - gemfiles/rails_6.0.gemfile
-#  - gemfiles/rails_5.2.gemfile
-#  - gemfiles/rails_5.1.gemfile
-#  - gemfiles/rails_5.0.gemfile
-#  - gemfiles/rails_4.gemfile
-
-notifications:
-  email: false
-
-matrix:
-#  allow_failures:
-#    - gemfile: gemfiles/rails_5.0.gemfile
-#      rvm: 2.2.0
-#    - gemfile: gemfiles/rails_5.1.gemfile
-#      rvm: 2.2.0