relation 0.3.1 → 0.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef978d1ab357140ef5d176fdd9c0cfc1f07ce437fb34ef43f343c3178c009761
-  data.tar.gz: 799baed24420ccec09763e5fcf6af16ce1c7d4378517aa57f348a09febf5b8c0
+  metadata.gz: 853bc18cefd0604f0b9292840ea11d6ba76ec7375bf0d9802cf078f61c7b4823
+  data.tar.gz: 82bb8714278faf2abe55bcae1387443783e1fec691dc54c1bc0585991b2d90f2
 SHA512:
-  metadata.gz: 6dc5d7c0d65fec6a3d348e05693ee5ec79457c910969b99bd953124fb74d18abd4c0fff6432f5beed7bf623fbe1d0e2f3f4efd7301c4c4f727cc55c60f7bc151
-  data.tar.gz: 75bc4c1fc38d77a977714b70392cbf36a6d9985129f157ab1b33a92cea08033501e1ffa3a8246253bd63db84770e6a5fd05a88254f4a83e98f40bd342e05a625
+  metadata.gz: 5b25cebb6364b1978bcc3c447adb9407d31d191483c26adc3da12eae5dda385d00ab250476de1775bb9101ea1b60a41c79b9f6aad03f6512f6ed812c0292a722
+  data.tar.gz: 5f2f0501587bb4b3cdba3b9190759ed6ed0fedc4da7938dcba4f0693eab3d5a989c32ede95accf0d59b2224cf215e38d6f8cb9252ba4396d3341f9f58b48a2d3

data/.gitignore

@@ -1,14 +1,11 @@
-*.gem
-.bundle
-Gemfile.lock
-gemfiles/*.lock
-coverage/*
-pkg/*
-
-# Ignore the default SQLite database.
-/db/*.sqlite3
-/db/*.sqlite3-journal
+.bundle/
+coverage/
 
-# Ignore all logfiles and tempfiles.
-log
-tmp
+*.gem
+*.log
+*.lock
+*.sqlite3
+**/*.gem
+**/*.log
+**/*.lock
+**/*.sqlite3

data/.rubocop.yml

@@ -0,0 +1,8 @@
+inherit_from:
+  - ~/configs/.rubocop.yml
+
+AllCops:
+  Include:
+    - 'lib/**/*.rb'
+  Exclude:
+    - 'test/**/*'

data/.ruby-gemset

@@ -1 +1 @@
-rails-5.2
+rails-6.0

data/.ruby-version

@@ -1 +1 @@
-ruby-2.5.1
+ruby-2.6.6

data/.travis.yml

@@ -13,25 +13,31 @@ bundler_args: --without production
 #bundler_args: --without development
 
 rvm:
-  - 2.5.1  # 2018-04-27
-  - 2.5.0  # 2018-02-22
+  - 2.6.6  # 2020-07-14
+#  - 2.6.5  # 2019-10-29
+#  - 2.6.4  # 2019-10-04
+#  - 2.6.3  # 2019-06-21
+#  - 2.6.1  # 2019-03-05
+#  - 2.5.1  # 2018-04-27
+#  - 2.5.0  # 2018-02-22
 #  - 2.4.1  # tested: working for Rails 5
 #  - 2.3.1  # tested: working for Rails 5
 #  - 2.2.7  # tested: working for Rails 5
 #  - 2.2.0  # tested: failing for Rails 5
 
 gemfile:
-  - gemfiles/rails_5.2.gemfile
-  - gemfiles/rails_5.1.gemfile
-  - gemfiles/rails_5.0.gemfile
+  - gemfiles/rails_6.0.gemfile
+#  - gemfiles/rails_5.2.gemfile
+#  - gemfiles/rails_5.1.gemfile
+#  - gemfiles/rails_5.0.gemfile
 #  - gemfiles/rails_4.gemfile
 
 notifications:
   email: false
 
 matrix:
-  allow_failures:
-    - gemfile: gemfiles/rails_5.0.gemfile
-      rvm: 2.2.0
-    - gemfile: gemfiles/rails_5.1.gemfile
-      rvm: 2.2.0
+#  allow_failures:
+#    - gemfile: gemfiles/rails_5.0.gemfile
+#      rvm: 2.2.0
+#    - gemfile: gemfiles/rails_5.1.gemfile
+#      rvm: 2.2.0

data/.watchr

@@ -16,36 +16,30 @@ end
 
 def run_it(type, file)
   case type
-  when 'test';  run %Q{ruby -I test #{file}}
-#  when 'spec';  run %Q{spring rspec -X #{file}}
+  when 'test';  run %(ruby -I test #{file})
+#  when 'spec';  run %(rspec -X #{file})
   else;         puts "#{H} unknown type: #{type}, file: #{file}"
   end
 end
 
 def run_all_tests
   puts "\n#{HH} Running all tests #{HH}\n"
-#  %w{test spec}.each { |dir| run "spring rake #{dir} RAILS_ENV=test"  if  File.exists?(dir) }
-#  %w{test}.each { |dir| run "spring rake #{dir} RAILS_ENV=test"  if  File.exists?(dir) }
-  %w{test}.each { |dir| run "rake #{dir} RAILS_ENV=test"  if  File.exists?(dir) }
+  %w[test spec].each { |dir| run "rake #{dir}" if  File.exist?(dir) }
 end
 
 def run_matching_files(base)
   base = base.split('_').first
-  %w{test spec}.each { |type|
+  %w[test spec].each { |type|
     files = Dir["#{type}/**/*.rb"].select { |file| file =~ /#{base}_.*\.rb/ }
     run_it type, files.join(' ')  unless files.empty?
   }
 end
 
-%w{test spec}.each { |type|
+%w[test spec].each { |type|
   watch("#{type}/#{type}_helper\.rb") { run_all_tests }
+  watch('lib/.*\.rb')                 { run_all_tests }
   watch("#{type}/.*/*_#{type}\.rb")   { |match| run_it type, match[0] }
 }
-%w{rb erb haml slim}.each { |type|
-  watch("app/.*/.*\.#{type}") { |m|
-    run_matching_files("#{m[0].split('/').at(2).split('.').first}")
-  }
-}
 
 # Ctrl-\ or ctrl-4
     Signal.trap('QUIT') { run_all_tests }

data/Appraisals

@@ -1,11 +1,15 @@
-appraise 'rails-5.0' do
-  gem 'rails', '~> 5.0.0'
-end
-
-appraise 'rails-5.1' do
-  gem 'rails', '~> 5.1'
+appraise 'rails-6.0' do
+  gem 'rails', '~> 6.0.0'
 end
 
 appraise 'rails-5.2' do
   gem 'rails', '~> 5.2.0'
 end
+
+#appraise 'rails-5.0' do
+#  gem 'rails', '~> 5.0.0'
+#end
+#
+#appraise 'rails-5.1' do
+#  gem 'rails', '~> 5.1'
+#end

data/Gemfile

@@ -1,5 +1,10 @@
 source 'https://rubygems.org'
-ruby '2.5.1'
 gemspec
 
 gem 'rails'
+
+group :test do
+  gem 'observr'
+  gem 'rubocop', require: false
+  gem 'simplecov', require: false
+end

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2015-2018 Dittmar Krall - http://matique.de
+Copyright 2015-2020 Dittmar Krall - www.matique.com
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -2,10 +2,16 @@
 [![Gem Version](https://badge.fury.io/rb/relation.png)](http://badge.fury.io/rb/relation)
 [![Build Status](https://travis-ci.org/matique/relation.png?branch=master)](https://travis-ci.org/matique/relation)
 
-Relation is a Rails gem that adds relationships to
-ActiveRecord items stored in tables.
-The relationship is stored in an additional table;
-no additional column/field is required in the particular tables.
+AFAIK, Relation can replace all kind of relationships in a Rails database.
+The gem stores the relationships in a additional table (named
+"relations") containing
+triples (name of relationship, from:id, to_id).
+No additional column/field is required in a particular tables.
+Adding/removing a relationship do not required a migration.
+
+Is it recommendable? Well, you should know.
+In particular, the automagic of Rails associations is not available
+for this gem.
 
 A habtm (has and belong to many) association of Rails requires an
 additional table containing the id's of the associated records.
@@ -43,7 +49,7 @@ The migration is then done, as usual, by:
 
 ## Usage
 
-In short (order* and user* are ActiveRecords):
+In short (order* and user* are instances of ActiveRecords):
 
     Relation.add order, user
     Relation.add order, user2
@@ -80,9 +86,11 @@ They may be used for relationships which can not be based on the
 class name of the ActiveRecords.
 Keep in mind that dangling relations must be handled by yourself.
 
-## Rails 5
+## Rails 6
+
+This gem is intended for Rails 6.
+Rails 5 should work fine.
 
-This gem is intended for Rails 5.
 Older Rails versions may use "gem 'relation', '= 0.1.1'".
 
 ## License MIT

data/Rakefile

@@ -1,13 +1,11 @@
-# credits to https://github.com/jollygoodcode/jollygoodcode.github.io/issues/21
-require "rubygems"
-require "bundler/setup"
+require 'rake/testtask'
 
-require 'bundler/gem_tasks'
-
-desc "Run the tests."
-task :test do
-  $: << "lib" << "test"
-  Dir["test/*_test.rb"].each { |f| require f[5..-4] }
+desc 'Run the tests.'
+Rake::TestTask.new do |t|
+  t.libs << 'lib'
+  t.libs << 'test'
+  t.pattern = 'test/**/*_test.rb'
+  t.verbose = false
 end
 
-task :default => :test
+task default: :test

data/app/models/dangling.rb

@@ -1,31 +1,28 @@
 # extended Relation: extracts relation from rows
-class Relation < ActiveRecord::Base
 
+class Relation < ActiveRecord::Base
   def self.dangling
     names = Relation.pluck(:name).uniq
     models = []
-    names.each { |name|
-      models |= name.split(' ')
-    }
+    names.each { |name| models |= name.split(' ') }
     hsh = {}
-    models.each { |class_name|
+    models.each do |class_name|
       klass = class_name.constantize
       ids = klass.pluck(:id)
       idx = Relation.where('name like ?', "#{class_name} %").pluck(:from_id)
       idy = Relation.where('name like ?', "% #{class_name}").pluck(:to_id)
       arr = (idx | idy) - ids
-      hsh[class_name] = arr  if arr.length > 0
-    }
+      hsh[class_name] = arr if arr.length.positive?
+    end
     hsh
   end
 
   def self.remove_dangling(hsh)
-    hsh.each { |name, arr|
-      arr.each { |idx|
-	Relation.where(from_id: idx).where('name like ?', "#{name} %").delete_all
-	Relation.where(to_id: idx).where('name like ?', "% #{name}").delete_all
-      }
-    }
+    hsh.each do |name, arr|
+      arr.each do |idx|
+        Relation.where(from_id: idx).where('name like ?', "#{name} %").delete_all
+        Relation.where(to_id: idx).where('name like ?', "% #{name}").delete_all
+      end
+    end
   end
-
 end

data/app/models/relation.rb

@@ -1,8 +1,7 @@
 class Relation < ActiveRecord::Base
-
   def self.add_raw(name, from_id, to_id)
     hsh = { name: name, from_id: from_id, to_id: to_id }
-    Relation.create!(hsh)  if Relation.where(hsh).first == nil
+    Relation.create!(hsh) if Relation.where(hsh).first.nil?
   end
 
   def self.delete_raw(name, from_id, to_id)
@@ -17,5 +16,4 @@ class Relation < ActiveRecord::Base
   def self.followers_raw(name, to_id)
     Relation.where(name: name, to_id: to_id).pluck(:from_id)
   end
-
 end

data/app/models/relation_ext.rb

@@ -1,9 +1,8 @@
 # extended Relation: extracts relation from rows
 class Relation < ActiveRecord::Base
-
   def self.add(row_from, row_to)
     hsh = normalize(row_from, row_to)
-    Relation.create!(hsh)  if Relation.where(hsh).first == nil
+    Relation.create!(hsh) if Relation.where(hsh).first.nil?
   end
 
   def self.delete(row_from, row_to)
@@ -25,9 +24,9 @@ class Relation < ActiveRecord::Base
     klass.where(id: ids)
   end
 
- private
   def self.name_id(resource)
-    raise 'missing resource'  unless resource
+    raise 'missing resource' unless resource
+
     [resource.class.name, resource.id]
   end
 
@@ -40,9 +39,8 @@ class Relation < ActiveRecord::Base
 
   def self.normalize2(kind, row)
     klass = kind
-    klass = kind.constantize  unless klass.kind_of?(Class)
+    klass = kind.constantize unless klass.is_a?(Class)
     name, id = name_id(row)
     [klass, name, id]
   end
-
 end

data/gemfiles/rails_5.2.gemfile

@@ -4,4 +4,8 @@ source "https://rubygems.org"
 
 gem "rails", "~> 5.2.0"
 
+group :test do
+  gem "observr"
+end
+
 gemspec path: "../"

data/gemfiles/{rails_5.0.gemfile → rails_6.0.gemfile}

@@ -2,6 +2,10 @@
 
 source "https://rubygems.org"
 
-gem "rails", "~> 5.0.0"
+gem "rails", "~> 6.0.0"
+
+group :test do
+  gem "observr"
+end
 
 gemspec path: "../"

data/lib/relation.rb

@@ -1,3 +1,5 @@
+# rubocop: disable all
+
 require 'relation/engine.rb'
 require 'models/relation.rb'
 require 'models/relation_ext.rb'

data/lib/relation/engine.rb

@@ -1,25 +1,26 @@
+# rubocop: disable all
+
 module ModRelation
   class Engine < Rails::Engine
     isolate_namespace ModRelation
 
-# # https://github.com/rails/rails/issues/22261
-#     initializer :append_migrations do |app|
-#       config.paths['db/migrate'].expanded.each do |path|
-#         app.config.paths['db/migrate'] << path
-#         ActiveRecord::Migrator.migrations_paths << path
-#       end
-#     end
+    # # https://github.com/rails/rails/issues/22261
+    #     initializer :append_migrations do |app|
+    #       config.paths['db/migrate'].expanded.each do |path|
+    #         app.config.paths['db/migrate'] << path
+    #         ActiveRecord::Migrator.migrations_paths << path
+    #       end
+    #     end
 
+    # # https://github.com/rails/rails/issues/22261
+    # module ActiveRecord
+    # #module ActiveRecord::Current
+    #   class Schema < Migration
+    #     def migrations_paths
+    #       (ActiveRecord::Migrator.migrations_paths +
+    #        Rails.application.paths['db/migrate'].to_a).uniq
+    #     end
+    #   end
+    # end
   end
 end
-
-
-# # https://github.com/rails/rails/issues/22261
-# module ActiveRecord
-# #module ActiveRecord::Current
-#   class Schema < Migration
-#     def migrations_paths
-#       (ActiveRecord::Migrator.migrations_paths + Rails.application.paths['db/migrate'].to_a).uniq
-#     end
-#   end
-# end

data/lib/relation/version.rb

@@ -1,4 +1,12 @@
+# rubocop: disable all
+
 module ModRelation
-  VERSION = '0.3.1'  # 2018-08-05
-#  VERSION = '0.3.0'
+  VERSION = '0.3.7'  # 2020-07-14
+# VERSION = '0.3.6'  # 2020-04-27
+# VERSION = '0.3.5'  # 2020-03-03
+# VERSION = '0.3.4'  # 2019-10-04
+# VERSION = '0.3.3'  # 2019-03-23
+# VERSION = '0.3.2'  # 2019-03-05
+# VERSION = '0.3.1'  # 2018-08-05
+# VERSION = '0.3.0'  #
 end

data/relation.gemspec

@@ -22,13 +22,12 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,features}/*`.split("\n")
   s.require_paths = ['lib', 'app']
 
-  s.add_dependency 'activerecord', '~> 5'
+  s.add_dependency 'activerecord', '~>6'
 
-  s.add_development_dependency 'appraisal'
-  s.add_development_dependency 'bundler'
-  s.add_development_dependency 'rake'
+  s.add_development_dependency 'bundler', '~>1'
+  s.add_development_dependency 'rake', '~>13'
+  s.add_development_dependency 'appraisal', '~>2'
 
-  s.add_development_dependency 'minitest'
-  s.add_development_dependency 'simplecov'
-  s.add_development_dependency 'sqlite3'
+  s.add_development_dependency 'minitest', '~>5'
+  s.add_development_dependency 'sqlite3', '~>1'
 end

data/test/support/database.rb

@@ -1,22 +1,22 @@
 class DB
-  ActiveRecord::Base.establish_connection adapter: "sqlite3",
-		database: ":memory:"
+  ActiveRecord::Base.establish_connection adapter: 'sqlite3',
+                                          database: ':memory:'
 
   def self.setup
     capture_stdout do
       ActiveRecord::Base.logger
       ActiveRecord::Schema.define(version: 1) do
-	create_table :orders do |t|
-	  t.column :name, :string
-	end
-	create_table :users do |t|
-	  t.column :name, :string
-	end
-	create_table :relations, id: false do |t|
-	  t.string     :name
-	  t.references :from, null: false
-	  t.references :to, null: false
-	end
+        create_table :orders do |t|
+          t.column :name, :string
+        end
+        create_table :users do |t|
+          t.column :name, :string
+        end
+        create_table :relations, id: false do |t|
+          t.string     :name
+          t.references :from, null: false
+          t.references :to, null: false
+        end
       end
 
       Order.reset_column_information
@@ -26,17 +26,16 @@ class DB
   def self.teardown
     if ActiveRecord::Base.connection.respond_to?(:data_sources)
       ActiveRecord::Base.connection.data_sources.each do |table|
-	ActiveRecord::Base.connection.drop_table(table)
+        ActiveRecord::Base.connection.drop_table(table)
       end
     else
       ActiveRecord::Base.connection.tables.each do |table|
-	ActiveRecord::Base.connection.drop_table(table)
+        ActiveRecord::Base.connection.drop_table(table)
       end
     end
   end
 
- private
-  def self.capture_stdout(&block)
+  def self.capture_stdout
     real_stdout = $stdout
 
     $stdout = StringIO.new
@@ -45,7 +44,6 @@ class DB
   ensure
     $stdout = real_stdout
   end
-
 end
 
 class Order < ActiveRecord::Base
@@ -54,6 +52,6 @@ end
 class User < ActiveRecord::Base
 end
 
-require_relative ('../../app/models/relation')
-require_relative ('../../app/models/relation_ext')
-require_relative ('../../app/models/dangling')
+require_relative '../../app/models/relation'
+require_relative '../../app/models/relation_ext'
+require_relative '../../app/models/dangling'

data/test/test_helper.rb

@@ -1,14 +1,15 @@
-require 'simplecov'
-SimpleCov.start do
-  add_filter '/test/'
+if ENV['COVERAGE']
+  require 'simplecov'
+  SimpleCov.start do
+    add_filter '/test/'
+  end
 end
 
-ENV["RAILS_ENV"] = "test"
 require 'active_record'
 require 'minitest/autorun'
 
 # Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
 
 class Minitest::Test
   require 'active_support/testing/assertions'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: relation
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.7
 platform: ruby
 authors:
 - Dittmar Krall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-06 00:00:00.000000000 Z
+date: 2020-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,98 +16,84 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
-- !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '13'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1'
 description: "    A Rails gem that adds simple support for organizing ActiveRecord
   models.\n"
 email:
@@ -117,6 +103,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".ruby-gemset"
 - ".ruby-version"
 - ".travis.yml"
@@ -131,9 +118,8 @@ files:
 - app/models/relation.rb
 - app/models/relation_ext.rb
 - db/migrate/20150810152808_relation.rb
-- gemfiles/rails_5.0.gemfile
-- gemfiles/rails_5.1.gemfile
 - gemfiles/rails_5.2.gemfile
+- gemfiles/rails_6.0.gemfile
 - lib/relation.rb
 - lib/relation/engine.rb
 - lib/relation/version.rb
@@ -163,8 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: Provides a simple directed relationship between active_record models.

data/gemfiles/rails_5.1.gemfile

@@ -1,7 +0,0 @@
-# This file was generated by Appraisal
-
-source "https://rubygems.org"
-
-gem "rails", "~> 5.1"
-
-gemspec path: "../"