reji 1.0.0 → 1.1.0

data/spec/spec_helper.rb

@@ -7,7 +7,7 @@ require 'dummy/application'
 
 require 'rspec/rails'
 
-Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }
+Dir[Rails.root.join('spec/support/**/*.rb')].sort.each { |f| require f }
 
 Dummy::Application.initialize!
 
@@ -21,7 +21,7 @@ RSpec.configure do |config|
 
   config.infer_spec_type_from_file_location!
 
-  %i(request).each do |type|
+  %i[request].each do |type|
     config.include(Reji::Test::FeatureHelpers, type: type)
   end
 end

data/spec/support/feature_helpers.rb

@@ -17,23 +17,17 @@ module Reji
 
       sleep(2)
 
-      protected
-
-      def delete_stripe_resource(resource)
-        begin
-          resource.delete
-        rescue Stripe::InvalidRequestError => e
-          #
-        end
+      protected def delete_stripe_resource(resource)
+        resource.delete
+      rescue Stripe::InvalidRequestError => _e
+        #
       end
 
-      def create_customer(description = 'cuong', options = {})
+      protected def create_customer(description = 'cuong', options = {})
         User.create({
-          :email => "#{description}@reji-test.com",
+          email: "#{description}@reji-test.com",
         }.merge(options))
       end
     end
   end
 end
-
-

data/spec/unit/customer_spec.rb

@@ -3,52 +3,52 @@
 require 'spec_helper'
 
 describe 'customer', type: :unit do
-  it 'test_customer_can_be_put_on_a_generic_trial' do
+  it 'can_be_put_on_a_generic_trial' do
     user = User.new
 
     expect(user.on_generic_trial).to be false
 
-    user.trial_ends_at = Time.now + 1.day
+    user.trial_ends_at = Time.current + 1.day
 
     expect(user.on_generic_trial).to be true
 
-    user.trial_ends_at = Time.now - 5.days
+    user.trial_ends_at = Time.current - 5.days
 
     expect(user.on_generic_trial).to be false
   end
 
-  it 'test_we_can_determine_if_it_has_a_payment_method' do
+  it 'can_determine_if_the_user_has_a_default_payment_method' do
     user = User.new
 
     user.card_brand = 'visa'
 
-    expect(user.has_default_payment_method).to be true
+    expect(user.default_payment_method?).to be true
 
     user = User.new
 
-    expect(user.has_default_payment_method).to be false
+    expect(user.default_payment_method?).to be false
   end
 
-  it 'test_default_payment_method_returns_nil_when_the_user_is_not_a_customer_yet' do
+  it 'returns_nil_default_payment_method_when_the_user_is_not_a_customer_yet' do
     user = User.new
 
     expect(user.default_payment_method).to be_nil
   end
 
-  it 'test_stripe_customer_method_throws_exception_when_stripe_id_is_not_set' do
+  it 'cannot_return_stripe_customer_when_stripe_id_is_not_set' do
     user = User.new
 
-    expect {
+    expect do
       user.as_stripe_customer
-    }.to raise_error(Reji::InvalidCustomerError)
+    end.to raise_error(Reji::InvalidCustomerError)
   end
 
-  it 'test_stripe_customer_cannot_be_created_when_stripe_id_is_already_set' do
+  it 'cannot_create_stripe_customer_when_stripe_id_is_already_set' do
     user = User.new
     user.stripe_id = 'foo'
 
-    expect {
+    expect do
       user.create_as_stripe_customer
-    }.to raise_error(Reji::CustomerAlreadyCreatedError)
+    end.to raise_error(Reji::CustomerAlreadyCreatedError)
   end
 end

data/spec/unit/invoice_line_item_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Reji::InvoiceLineItem, type: :unit do
+describe 'invoice line item' do
   it 'can_calculate_the_inclusive_tax_percentage' do
     customer = User.new
     customer.stripe_id = 'foo'
@@ -15,9 +15,9 @@ describe Reji::InvoiceLineItem, type: :unit do
 
     stripe_invoice_line_item = Stripe::InvoiceLineItem.new
     stripe_invoice_line_item.tax_amounts = [
-      {:inclusive => true, :tax_rate => self.inclusive_tax_rate(5.0)},
-      {:inclusive => true, :tax_rate => self.inclusive_tax_rate(15.0)},
-      {:inclusive => false, :tax_rate => self.inclusive_tax_rate(21.0)},
+      { inclusive: true, tax_rate: inclusive_tax_rate(5.0) },
+      { inclusive: true, tax_rate: inclusive_tax_rate(15.0) },
+      { inclusive: false, tax_rate: inclusive_tax_rate(21.0) },
     ]
 
     item = Reji::InvoiceLineItem.new(invoice, stripe_invoice_line_item)
@@ -37,9 +37,9 @@ describe Reji::InvoiceLineItem, type: :unit do
 
     stripe_invoice_line_item = Stripe::InvoiceLineItem.new
     stripe_invoice_line_item.tax_amounts = [
-      {:inclusive => true, :tax_rate => self.inclusive_tax_rate(5.0)},
-      {:inclusive => false, :tax_rate => self.exclusive_tax_rate(15.0)},
-      {:inclusive => false, :tax_rate => self.exclusive_tax_rate(21.0)},
+      { inclusive: true, tax_rate: inclusive_tax_rate(5.0) },
+      { inclusive: false, tax_rate: exclusive_tax_rate(15.0) },
+      { inclusive: false, tax_rate: exclusive_tax_rate(21.0) },
     ]
 
     item = Reji::InvoiceLineItem.new(invoice, stripe_invoice_line_item)
@@ -49,20 +49,18 @@ describe Reji::InvoiceLineItem, type: :unit do
     expect(result).to eq(36)
   end
 
-  protected
-
   # Get a test inclusive Tax Rate.
-  def inclusive_tax_rate(percentage)
-    self.tax_rate(percentage)
+  protected def inclusive_tax_rate(percentage)
+    tax_rate(percentage)
   end
 
   # Get a test exclusive Tax Rate.
-  def exclusive_tax_rate(percentage)
-    self.tax_rate(percentage, false)
+  protected def exclusive_tax_rate(percentage)
+    tax_rate(percentage, false)
   end
 
   # Get a test exclusive Tax Rate.
-  def tax_rate(percentage, inclusive = true)
+  protected def tax_rate(percentage, inclusive = true)
     inclusive_tax_rate = Stripe::TaxRate.new
     inclusive_tax_rate.inclusive = inclusive
     inclusive_tax_rate.percentage = percentage

data/spec/unit/invoice_spec.rb

@@ -2,20 +2,18 @@
 
 require 'spec_helper'
 
-describe 'invoice', type: :unit do
+describe 'invoice' do
   it 'can_return_the_invoice_date' do
     stripe_invoice = Stripe::Invoice.new
     stripe_invoice.customer = 'foo'
-    stripe_invoice.created = 1560541724
+    stripe_invoice.created = 1_560_541_724
 
     user = User.new
     user.stripe_id = 'foo'
 
     invoice = Reji::Invoice.new(user, stripe_invoice)
 
-    date = invoice.date
-
-    expect(invoice.date.to_i).to eq(1560541724)
+    expect(invoice.date.to_i).to eq(1_560_541_724)
   end
 
   it 'can_return_its_total' do
@@ -85,7 +83,7 @@ describe 'invoice', type: :unit do
 
     invoice = Reji::Invoice.new(user, stripe_invoice)
 
-    expect(invoice.has_starting_balance).to be true
+    expect(invoice.starting_balance?).to be true
   end
 
   it 'can_determine_when_the_customer_does_not_have_a_starting_balance' do
@@ -98,7 +96,7 @@ describe 'invoice', type: :unit do
 
     invoice = Reji::Invoice.new(user, stripe_invoice)
 
-    expect(invoice.has_starting_balance).to be false
+    expect(invoice.starting_balance?).to be false
   end
 
   it 'can_return_its_starting_balance' do
@@ -147,7 +145,7 @@ describe 'invoice', type: :unit do
 
     invoice = Reji::Invoice.new(user, stripe_invoice)
 
-    expect(invoice.has_discount).to be true
+    expect(invoice.discount?).to be true
   end
 
   it 'can_return_its_tax' do
@@ -174,7 +172,7 @@ describe 'invoice', type: :unit do
 
     invoice = Reji::Invoice.new(user, stripe_invoice)
 
-    expect(invoice.is_tax_exempt).to be true
+    expect(invoice.tax_exempt?).to be true
   end
 
   it 'can_determine_if_reverse_charge_applies' do

data/spec/unit/payment_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe 'payment', type: :unit do
+describe 'payment' do
   it 'can_return_its_requires_payment_method_status' do
     payment_intent = Stripe::PaymentIntent.new
     payment_intent.status = 'requires_payment_method'
@@ -21,13 +21,13 @@ describe 'payment', type: :unit do
     payment_intent = Stripe::PaymentIntent.new
     payment_intent.status = 'canceled'
     payment = Reji::Payment.new(payment_intent)
-    expect(payment.is_cancelled).to be true
+    expect(payment.cancelled?).to be true
   end
 
   it 'can_return_its_succeeded_status' do
     payment_intent = Stripe::PaymentIntent.new
     payment_intent.status = 'succeeded'
     payment = Reji::Payment.new(payment_intent)
-    expect(payment.is_succeeded).to be true
+    expect(payment.succeeded?).to be true
   end
 end

data/spec/unit/subscription_spec.rb

@@ -2,8 +2,8 @@
 
 require 'spec_helper'
 
-describe 'subscription', type: :unit do
-  it 'can_check_if_a_subscription_is_incomplete' do
+describe 'subscription' do
+  it 'can_determine_if_it_is_incomplete' do
     subscription = Reji::Subscription.new(stripe_status: 'incomplete')
 
     expect(subscription.incomplete).to be true
@@ -11,15 +11,14 @@ describe 'subscription', type: :unit do
     expect(subscription.active).to be false
   end
 
-  it 'can_check_if_a_subscription_is_past_due' do
+  it 'can_determine_if_it_is_past_due' do
     subscription = Reji::Subscription.new(stripe_status: 'past_due')
-
     expect(subscription.incomplete).to be false
     expect(subscription.past_due).to be true
     expect(subscription.active).to be false
   end
 
-  it 'can_check_if_a_subscription_is_active' do
+  it 'can_determine_if_it_is_active' do
     subscription = Reji::Subscription.new(stripe_status: 'active')
 
     expect(subscription.incomplete).to be false
@@ -27,77 +26,77 @@ describe 'subscription', type: :unit do
     expect(subscription.active).to be true
   end
 
-  it 'can_check_if_an_incomplete_subscription_is_not_valid' do
+  it 'is_not_valid_when_status_is_incomplete' do
     subscription = Reji::Subscription.new(stripe_status: 'incomplete')
 
     expect(subscription.valid).to be false
   end
 
-  it 'can_check_if_a_past_due_subscription_is_not_valid' do
+  it 'is_not_valid_when_status_is_past_due' do
     subscription = Reji::Subscription.new(stripe_status: 'past_due')
 
     expect(subscription.valid).to be false
   end
 
-  it 'can_check_if_an_active_subscription_is_valid' do
+  it 'is_valid_when_status_is_active' do
     subscription = Reji::Subscription.new(stripe_status: 'active')
 
     expect(subscription.valid).to be true
   end
 
-  it 'test_payment_is_incomplete_when_status_is_incomplete' do
+  it 'has_incomplete_payment_when_status_is_incomplete' do
     subscription = Reji::Subscription.new(stripe_status: 'incomplete')
 
-    expect(subscription.has_incomplete_payment).to be true
+    expect(subscription.incomplete_payment?).to be true
   end
 
-  it 'test_payment_is_incomplete_when_status_is_past_due' do
+  it 'has_incomplete_payment_when_status_is_past_due' do
     subscription = Reji::Subscription.new(stripe_status: 'past_due')
 
-    expect(subscription.has_incomplete_payment).to be true
+    expect(subscription.incomplete_payment?).to be true
   end
 
-  it 'test_payment_is_not_incomplete_when_status_is_active' do
+  it 'has_not_incomplete_payment_when_status_is_active' do
     subscription = Reji::Subscription.new(stripe_status: 'active')
 
-    expect(subscription.has_incomplete_payment).to be false
+    expect(subscription.incomplete_payment?).to be false
   end
 
-  it 'test_incomplete_subscriptions_cannot_be_swapped' do
+  it 'cannot_swap_when_it_is_incomplete' do
     subscription = Reji::Subscription.new(stripe_status: 'incomplete')
 
-    expect {
+    expect do
       subscription.swap('premium_plan')
-    }.to raise_error(Reji::SubscriptionUpdateFailureError)
+    end.to raise_error(Reji::SubscriptionUpdateFailureError)
   end
 
-  it 'test_incomplete_subscriptions_cannot_update_their_quantity' do
+  it 'cannot_update_their_quantity_when_it_is_incomplete' do
     subscription = Reji::Subscription.new(stripe_status: 'incomplete')
 
-    expect {
+    expect do
       subscription.update_quantity(5)
-    }.to raise_error(Reji::SubscriptionUpdateFailureError)
+    end.to raise_error(Reji::SubscriptionUpdateFailureError)
   end
 
-  it 'test_extending_a_trial_requires_a_date_in_the_future' do
+  it 'requires_a_date_in_the_future_when_extending_a_trial' do
     subscription = Reji::Subscription.new
 
-    expect {
-      subscription.extend_trial(Time.now - 1.day)
-    }.to raise_error(ArgumentError)
+    expect do
+      subscription.extend_trial(Time.current - 1.day)
+    end.to raise_error(ArgumentError)
   end
 
-  it 'can_check_if_it_has_a_single_plan' do
+  it 'can_determine_if_it_has_a_single_plan' do
     subscription = Reji::Subscription.new(stripe_plan: 'foo')
 
-    expect(subscription.has_single_plan).to be true
-    expect(subscription.has_multiple_plans).to be false
+    expect(subscription.single_plan?).to be true
+    expect(subscription.multiple_plans?).to be false
   end
 
-  it 'can_check_if_it_has_multiple_plans' do
+  it 'can_determine_if_it_has_multiple_plans' do
     subscription = Reji::Subscription.new(stripe_plan: nil)
 
-    expect(subscription.has_single_plan).to be false
-    expect(subscription.has_multiple_plans).to be true
+    expect(subscription.single_plan?).to be false
+    expect(subscription.multiple_plans?).to be true
   end
 end

metadata

@@ -1,17 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: reji
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Cuong Giang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-09 00:00:00.000000000 Z
+date: 2020-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: stripe
+  name: actionmailer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: stripe
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,21 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
-  name: actionmailer
+  name: wicked_pdf
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: wicked_pdf
+  name: wkhtmltopdf-binary
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,13 +109,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: wkhtmltopdf-binary
+  name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -147,10 +161,11 @@ files:
 - ".editorconfig"
 - ".gitattributes"
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - Appraisals
 - Gemfile
-- Gemfile.lock
 - LICENSE
 - README.md
 - Rakefile