refworks 0.0.7 → 0.0.8

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YzU5NzhjZDUyNzFkMmQ4ZDFkNGYyNTM1N2IwNjM3MzEzMjE3OTExNg==
+    NmU5OGMyYTczZTdiMjM0NTE4ZjM1OGFhYmZiNjM5NDhjM2ExZGYwYg==
   data.tar.gz: !binary |-
-    ZGQyODU2NWVjOTlmM2Y2N2UxYTViZTA1MzY5ZGE0NzIyMjgxZDg0Ng==
+    NDNiMDQwMmRkYWYyZTRjMWM3NDRiNTMyNTRkNDI5YWJmZWJjNjRjZQ==
 SHA512:
   metadata.gz: !binary |-
-    NzcxNDE0ZDM3YTk5YWI5ZWM4YTdiNzA1NTVmYzczNWUyNjQxODgyNjY3MGM3
-    N2ZhNWQyODhlMThjNGNiNjA5MGI0Y2FkYjdjMmYyZDc5YTBlYWIxN2IzNjNj
-    ZWQ2MGFmZWVmNDg3ZDM2NjIyNjRkNjI0MGVjODJkMTBiYTNiNTA=
+    OWMwYmRlODc5M2Y5OTUxMzZlMTgxM2YwZTVkMzQxOTM4ZDg3YTFjYzIxMjFj
+    MjM3ZDA2ZWYzNjEyYjRhNjdkOTAyZDQxZjgxODhhYjgxZmY3MTVlM2VhNzVh
+    M2M3NzRlZWJjODQzZTU1ZDQ0YTliNGY4Zjc1NDY0OWJkNjUzMjM=
   data.tar.gz: !binary |-
-    YWVlMDk5NWU0ZDJlOTVkYWY0OGU5MWYwNDllZjQzMmIzOTZmODMwMGFjZGQ1
-    MzUyZmU1NDRlOWViYjMzNzUzMWFkNzljODg0ZWM2ZWYyZDlmYmI4MTYxMmE0
-    MjJjOWU0NzcyYThkNWMyNmIyN2Q1Y2ZlYWUyYWVhOGI5ZWI3MzQ=
+    YmJkOTllZWJjMmZlYTUxN2NlMzIxZDAwNjI1MjY4NDlmOGFmNDI2MDE0ZTY4
+    OGQyNTQwN2Q4ZDQ4NmFjMzNiMDZkNDBlZDg1NWViYmNiMDg2MzY5NThiZjVj
+    OWEyMmM1YjZkMDIwNjViM2Y5ZGY2NjU3ZDA2ODY1ODhlMjk3NzU=

data/lib/refworks.rb

@@ -18,6 +18,7 @@ class Refworks
   include HTTParty
 
   attr_reader :api_url, :access_key, :secret_key, :login_name, :password, :group_code, :id, :sess
+  attr_writer :sess
 
   # Create a new Refworks client instance.
   # @example
@@ -55,28 +56,32 @@ class Refworks
 
     # probably should check here that I have the minimal set of required attributes to continue
 
-    # Can't do much without a session, so get one now
-    # May need to refactor this - there are parts of the API that don't strictly need a session
-    if (@group_code)
-      response = request('authentication', 'newsess',
-                         {
-                            :login_name => @login_name,
-                            :group_code => @group_code,
-                            :password => @password,
-                         }
-      )
+    # Can't do much without a session, so get one now if one wasn't passed in
+    if params[:sess]
+      @sess = params[:sess]
     else
-      response = request('authentication', 'newsess',
-                         {
-                             :login_name => @login_name,
-                             :id => @id,
-                             :password => @password,
-                         }
-      )
-    end
+      # May need to refactor this - there are parts of the API that don't strictly need a session
+      if (@group_code)
+        response = request('authentication', 'newsess',
+                           {
+                              :login_name => @login_name,
+                              :group_code => @group_code,
+                              :password => @password,
+                           }
+        )
+      else
+        response = request('authentication', 'newsess',
+                           {
+                               :login_name => @login_name,
+                               :id => @id,
+                               :password => @password,
+                           }
+        )
+      end
 
-    # Grab the session string.
-    @sess = response.sess
+      # Grab the session string.
+      @sess = response.sess
+    end
 
     # Need some error checking here
   end

data/lib/refworks/response.rb

@@ -3,6 +3,17 @@ class Response
   attr_reader :body, :parsed_response, :result_code, :result_msg, :process_time
 
   def initialize(raw_response)
+    # The RefWorks API emits invalid XML.  Specifically, when the session is invalid, the ResultMsg field
+    # which comes back contains some illegal raw characters.  This is the only set of transformations I
+    # could find which completely eliminate the junk characters.
+
+    p raw_response.body
+
+    raw_response.body.encode!('UTF-8', 'binary', :invalid => :replace, :undef => :replace, :replace => '?')
+    raw_response.body.gsub!(/[\u0001-\u0019]/,'?')
+
+    p raw_response.body
+
     @body = raw_response.body
     @parsed_response = raw_response.parsed_response
     @result_code = parsed_response["refworks"]["RWResult"]["result"]

data/lib/refworks/version.rb

@@ -1,3 +1,3 @@
 class Refworks
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: refworks
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Fran Fabrizio