reform 2.3.0.rc2 → 2.6.0

data/test/validation/result_test.rb

@@ -11,10 +11,10 @@ class ErrorsResultTest < Minitest::Spec
     let(:failed) { MyResult.new(false) }
     let(:succeeded) { MyResult.new(true) }
 
-    it { Reform::Contract::Result.new([failed, failed]).success?.must_equal false }
-    it { Reform::Contract::Result.new([succeeded, failed]).success?.must_equal false }
-    it { Reform::Contract::Result.new([failed, succeeded]).success?.must_equal false }
-    it { Reform::Contract::Result.new([succeeded, succeeded]).success?.must_equal true }
+    it { assert_equal Reform::Contract::Result.new([failed, failed]).success?, false }
+    it { assert_equal Reform::Contract::Result.new([succeeded, failed]).success?, false }
+    it { assert_equal Reform::Contract::Result.new([failed, succeeded]).success?, false }
+    it { assert Reform::Contract::Result.new([succeeded, succeeded]).success? }
   end
 
   describe "Contract::Result#errors" do
@@ -27,7 +27,7 @@ class ErrorsResultTest < Minitest::Spec
       ]
     end
 
-    it { Reform::Contract::Result.new(results).errors.must_equal({title: ["must be filled", "something more"], length: ["no Int"]}) }
+    it { assert_equal Reform::Contract::Result.new(results).errors, {title: ["must be filled", "something more"], length: ["no Int"]} }
   end
 
   describe "Result::Pointer" do
@@ -44,24 +44,24 @@ class ErrorsResultTest < Minitest::Spec
     end
 
     let(:top) { Reform::Contract::Result::Pointer.new(MyResult.new(false, errors), []) }
-    it { top.success?.must_equal false }
-    it { top.errors.must_equal errors }
+    it { assert_equal top.success?, false }
+    it { assert_equal top.errors, errors }
 
     let(:artist) { Reform::Contract::Result::Pointer.new(MyResult.new(false, errors), [:artist]) }
-    it { artist.success?.must_equal false }
-    it { artist.errors.must_equal({age: ["too old"], bands: {0 => {name: "too new school"}, 1 => {name: "too boring"}}}) }
+    it { assert_equal artist.success?, false }
+    it { assert_equal artist.errors,({age: ["too old"], bands: {0 => {name: "too new school"}, 1 => {name: "too boring"}}}) }
 
     let(:band) { Reform::Contract::Result::Pointer.new(MyResult.new(false, errors), [:artist, :bands, 1]) }
-    it { band.success?.must_equal false }
-    it { band.errors.must_equal({name: "too boring"}) }
+    it { assert_equal band.success?, false }
+    it { assert_equal band.errors,({name: "too boring"}) }
 
     describe "advance" do
       let(:advanced) { artist.advance(:bands, 1) }
 
-      it { advanced.success?.must_equal false }
-      it { advanced.errors.must_equal({name: "too boring"}) }
+      it { assert_equal advanced.success?, false }
+      it { assert_equal advanced.errors,({name: "too boring"}) }
 
-      it { artist.advance(%i[absolute nonsense]).must_be_nil }
+      it { assert_nil artist.advance(%i[absolute nonsense]) }
     end
   end
 end

data/test/virtual_test.rb

@@ -13,8 +13,8 @@ class VirtualTest < MiniTest::Spec
   it {
     form.validate(credit_card_number: "123", transactions: [id: 1])
 
-    form.credit_card_number.must_equal "123" # this is still readable in the UI.
-    form.transactions.first.id.must_equal 1 # this is still readable in the UI.
+    assert_equal form.credit_card_number, "123" # this is still readable in the UI.
+    assert_equal form.transactions.first.id, 1 # this is still readable in the UI.
 
     form.sync
 
@@ -23,7 +23,7 @@ class VirtualTest < MiniTest::Spec
       hash = nested
     end
 
-    hash.must_equal("credit_card_number" => "123", "transactions" => ["id" => 1])
+    assert_equal hash, "credit_card_number" => "123", "transactions" => ["id" => 1]
   }
 end
 
@@ -49,16 +49,16 @@ class VirtualAndDefaultTest < MiniTest::Spec
     form = CreditCardForm.new(Object.new)
     form.validate({})
 
-    hash(form).must_equal("credit_card_number" => "123", "transactions" => ["id" => 2])
+    assert_equal hash(form), "credit_card_number" => "123", "transactions" => ["id" => 2]
 
     form = CreditCardForm.new(Object.new)
     form.validate(credit_card_number: "123", transactions: [id: 1])
 
-    form.credit_card_number.must_equal "123" # this is still readable in the UI.
-    form.transactions.first.id.must_equal 1 # this is still readable in the UI.
+    assert_equal form.credit_card_number,  "123" # this is still readable in the UI.
+    assert_equal form.transactions.first.id,  1 # this is still readable in the UI.
 
     form.sync
 
-    hash(form).must_equal("credit_card_number" => "123", "transactions" => ["id" => 1])
+    assert_equal hash(form), "credit_card_number" => "123", "transactions" => ["id" => 1]
   }
 end

data/test/writeable_test.rb

@@ -11,20 +11,20 @@ class WriteableTest < MiniTest::Spec
   let(:form) { LocationForm.new(loc) }
 
   it do
-    form.country.must_equal "Australia"
+    assert_equal form.country, "Australia"
 
     form.validate("country" => "Germany") # this usually won't change when submitting.
-    form.country.must_equal "Germany"
+    assert_equal form.country, "Germany"
 
     form.sync
-    loc.country.must_equal "Australia" # the writer wasn't called.
+    assert_equal loc.country, "Australia" # the writer wasn't called.
 
     hash = {}
     form.save do |nested|
       hash = nested
     end
 
-    hash.must_equal("country" => "Germany")
+    assert_equal hash, "country" => "Germany"
   end
 end
 
@@ -40,19 +40,19 @@ class WritableTest < MiniTest::Spec
   let(:form) { LocationForm.new(loc) }
 
   it do
-    form.country.must_equal "Australia"
+    assert_equal form.country, "Australia"
 
     form.validate("country" => "Germany") # this usually won't change when submitting.
-    form.country.must_equal "Germany"
+    assert_equal form.country, "Germany"
 
     form.sync
-    loc.country.must_equal "Australia" # the writer wasn't called.
+    assert_equal loc.country, "Australia" # the writer wasn't called.
 
     hash = {}
     form.save do |nested|
       hash = nested
     end
 
-    hash.must_equal("country" => "Germany")
+    assert_equal hash, "country" => "Germany"
   end
 end

metadata

@@ -1,34 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 2.3.0.rc2
+  version: 2.6.0
 platform: ruby
 authors:
 - Nick Sutterer
 - Fran Worley
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-11-05 00:00:00.000000000 Z
+date: 2021-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: disposable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.4.2
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.4.2
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.0
 - !ruby/object:Gem::Dependency
@@ -37,20 +31,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 3.1.1
     - - "<"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 3.1.1
     - - "<"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.2.0
 - !ruby/object:Gem::Dependency
   name: uber
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +102,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: byebug
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -149,20 +143,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Form object decoupled from models.
 email:
 - apotonick@gmail.com
@@ -171,10 +151,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGES.md
 - CONTRIBUTING.md
 - Gemfile
@@ -194,8 +172,6 @@ files:
 - lib/reform/form/composition.rb
 - lib/reform/form/dry.rb
 - lib/reform/form/dry/input_hash.rb
-- lib/reform/form/dry/new_api.rb
-- lib/reform/form/dry/old_api.rb
 - lib/reform/form/module.rb
 - lib/reform/form/populator.rb
 - lib/reform/form/prepopulate.rb
@@ -206,52 +182,38 @@ files:
 - lib/reform/version.rb
 - reform.gemspec
 - test/benchmarking.rb
-- test/call_new_api.rb
-- test/call_old_api.rb
+- test/call_test.rb
 - test/changed_test.rb
 - test/coercion_test.rb
-- test/composition_new_api.rb
-- test/composition_old_api.rb
+- test/composition_test.rb
 - test/contract/custom_error_test.rb
-- test/contract_new_api.rb
-- test/contract_old_api.rb
+- test/contract_test.rb
 - test/default_test.rb
 - test/deserialize_test.rb
-- test/errors_new_api.rb
-- test/errors_old_api.rb
+- test/docs/validation_test.rb
+- test/errors_test.rb
 - test/feature_test.rb
 - test/fixtures/dry_error_messages.yml
-- test/fixtures/dry_new_api_error_messages.yml
-- test/form_new_api.rb
-- test/form_old_api.rb
-- test/form_option_new_api.rb
-- test/form_option_old_api.rb
+- test/form_option_test.rb
+- test/form_test.rb
 - test/from_test.rb
-- test/inherit_new_api.rb
-- test/inherit_old_api.rb
-- test/module_new_api.rb
-- test/module_old_api.rb
+- test/inherit_test.rb
+- test/module_test.rb
 - test/parse_option_test.rb
 - test/parse_pipeline_test.rb
-- test/populate_new_api.rb
-- test/populate_old_api.rb
+- test/populate_test.rb
 - test/populator_skip_test.rb
 - test/prepopulator_test.rb
 - test/read_only_test.rb
 - test/readable_test.rb
-- test/reform_new_api.rb
-- test/reform_old_api.rb
-- test/save_new_api.rb
-- test/save_old_api.rb
+- test/reform_test.rb
+- test/save_test.rb
 - test/setup_test.rb
-- test/skip_if_new_api.rb
-- test/skip_if_old_api.rb
+- test/skip_if_test.rb
 - test/skip_setter_and_getter_test.rb
 - test/test_helper.rb
-- test/validate_new_api.rb
-- test/validate_old_api.rb
-- test/validation/dry_validation_new_api.rb
-- test/validation/dry_validation_old_api.rb
+- test/validate_test.rb
+- test/validation/dry_validation_test.rb
 - test/validation/result_test.rb
 - test/validation_library_provided_test.rb
 - test/virtual_test.rb
@@ -260,7 +222,7 @@ homepage: https://github.com/trailblazer/reform
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -271,63 +233,48 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.3
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: Form object decoupled from models with validation, population and presentation.
 test_files:
 - test/benchmarking.rb
-- test/call_new_api.rb
-- test/call_old_api.rb
+- test/call_test.rb
 - test/changed_test.rb
 - test/coercion_test.rb
-- test/composition_new_api.rb
-- test/composition_old_api.rb
+- test/composition_test.rb
 - test/contract/custom_error_test.rb
-- test/contract_new_api.rb
-- test/contract_old_api.rb
+- test/contract_test.rb
 - test/default_test.rb
 - test/deserialize_test.rb
-- test/errors_new_api.rb
-- test/errors_old_api.rb
+- test/docs/validation_test.rb
+- test/errors_test.rb
 - test/feature_test.rb
 - test/fixtures/dry_error_messages.yml
-- test/fixtures/dry_new_api_error_messages.yml
-- test/form_new_api.rb
-- test/form_old_api.rb
-- test/form_option_new_api.rb
-- test/form_option_old_api.rb
+- test/form_option_test.rb
+- test/form_test.rb
 - test/from_test.rb
-- test/inherit_new_api.rb
-- test/inherit_old_api.rb
-- test/module_new_api.rb
-- test/module_old_api.rb
+- test/inherit_test.rb
+- test/module_test.rb
 - test/parse_option_test.rb
 - test/parse_pipeline_test.rb
-- test/populate_new_api.rb
-- test/populate_old_api.rb
+- test/populate_test.rb
 - test/populator_skip_test.rb
 - test/prepopulator_test.rb
 - test/read_only_test.rb
 - test/readable_test.rb
-- test/reform_new_api.rb
-- test/reform_old_api.rb
-- test/save_new_api.rb
-- test/save_old_api.rb
+- test/reform_test.rb
+- test/save_test.rb
 - test/setup_test.rb
-- test/skip_if_new_api.rb
-- test/skip_if_old_api.rb
+- test/skip_if_test.rb
 - test/skip_setter_and_getter_test.rb
 - test/test_helper.rb
-- test/validate_new_api.rb
-- test/validate_old_api.rb
-- test/validation/dry_validation_new_api.rb
-- test/validation/dry_validation_old_api.rb
+- test/validate_test.rb
+- test/validation/dry_validation_test.rb
 - test/validation/result_test.rb
 - test/validation_library_provided_test.rb
 - test/virtual_test.rb

data/.rubocop.yml

@@ -1,30 +0,0 @@
-AllCops:
-  TargetRubyVersion: '2.3'
-
-inherit_from:
-  - https://raw.githubusercontent.com/trailblazer/meta/master/rubocop.yml
-  - .rubocop_todo.yml
-
-Metrics/ClassLength:
-  Max: 150
-
-Lint/AssignmentInCondition:
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  Enabled: false
-
-Style/OptionHash:
-  Enabled: false
-
-Style/ParallelAssignment:
-  Enabled: false
-
-Style/Send:
-  Enabled: false
-
-Style/SingleLineMethods:
-  Enabled: false
-
-Style/Lambda:
-  EnforcedStyle: literal