reform 2.3.0.rc1 → 2.3.0.rc2

data/test/validation/{dry_validation_test.rb → dry_validation_old_api.rb}

@@ -1,4 +1,3 @@
-# encoding: utf-8
 require "test_helper"
 require "reform/form/dry"
 require "reform/form/coercion"
@@ -41,74 +40,73 @@ class DryValidationErrorsAPITest < Minitest::Spec
 
       validation do
         configure do
-          config.messages_file = 'test/fixtures/dry_error_messages.yml'
+          config.messages_file = "test/fixtures/dry_error_messages.yml"
         end
 
         required(:title).filled
       end
     end
-
   end
 
-  let (:form) { AlbumForm.new(Album.new(nil, Artist.new(nil, Label.new), [Song.new(nil), Song.new(nil)])) }
+  let(:form) { AlbumForm.new(Album.new(nil, Artist.new(nil, Label.new), [Song.new(nil), Song.new(nil)])) }
 
   it "everything wrong" do
-    result = form.({ title: nil, artist: { email: "" }, songs: [{ title: "Clams have feelings too" }, { title: "" }] })
+    result = form.(title: nil, artist: {email: ""}, songs: [{title: "Clams have feelings too"}, {title: ""}])
 
     result.success?.must_equal false
 
     # errors.messages
-    form.errors.messages.must_equal({:title=>["must be filled", "size cannot be less than 2"], :"artist.email"=>["must be filled"], :"artist.label.location"=>["must be filled"], :"songs.title"=>["must be filled"]})
-    form.artist.errors.messages.must_equal({:email=>["must be filled"], :"label.location"=>["must be filled"]})
-    form.artist.label.errors.messages.must_equal({:location=>["must be filled"]})
+    form.errors.messages.must_equal(title: ["must be filled", "size cannot be less than 2"], "artist.email": ["must be filled"], "artist.label.location": ["must be filled"], "songs.title": ["must be filled"])
+    form.artist.errors.messages.must_equal(email: ["must be filled"], "label.location": ["must be filled"])
+    form.artist.label.errors.messages.must_equal(location: ["must be filled"])
     form.songs[0].errors.messages.must_equal({})
-    form.songs[1].errors.messages.must_equal({:title=>["must be filled"]})
+    form.songs[1].errors.messages.must_equal(title: ["must be filled"])
 
     # #errors[]
-    form.errors[:nonsense].must_be_nil
+    form.errors[:nonsense].must_equal []
     form.errors[:title].must_equal ["must be filled", "size cannot be less than 2"]
     form.artist.errors[:email].must_equal ["must be filled"]
     form.artist.label.errors[:location].must_equal ["must be filled"]
-    form.songs[0].errors[:title].must_be_nil
+    form.songs[0].errors[:title].must_equal []
     form.songs[1].errors[:title].must_equal ["must be filled"]
 
     # #to_result
-    form.to_result.errors.must_equal({:title=>["must be filled"]})
-    form.to_result.messages.must_equal({:title=>["must be filled", "size cannot be less than 2"]})
-    form.to_result.hints.must_equal({:title=>["size cannot be less than 2"]})
-    form.artist.to_result.errors.must_equal({:email=>["must be filled"]})
-    form.artist.to_result.messages.must_equal({:email=>["must be filled"]})
-    form.artist.to_result.hints.must_equal({:email=>[]})
-    form.artist.label.to_result.errors.must_equal({:location=>["must be filled"]})
-    form.artist.label.to_result.messages.must_equal({:location=>["must be filled"]})
-    form.artist.label.to_result.hints.must_equal({:location=>[]})
+    form.to_result.errors.must_equal(title: ["must be filled"])
+    form.to_result.messages.must_equal(title: ["must be filled", "size cannot be less than 2"])
+    form.to_result.hints.must_equal(title: ["size cannot be less than 2"])
+    form.artist.to_result.errors.must_equal(email: ["must be filled"])
+    form.artist.to_result.messages.must_equal(email: ["must be filled"])
+    form.artist.to_result.hints.must_equal(email: [])
+    form.artist.label.to_result.errors.must_equal(location: ["must be filled"])
+    form.artist.label.to_result.messages.must_equal(location: ["must be filled"])
+    form.artist.label.to_result.hints.must_equal(location: [])
     form.songs[0].to_result.errors.must_equal({})
     form.songs[0].to_result.messages.must_equal({})
     form.songs[0].to_result.hints.must_equal({})
-    form.songs[1].to_result.errors.must_equal({:title=>["must be filled"]})
-    form.songs[1].to_result.messages.must_equal({:title=>["must be filled"]})
-    form.songs[1].to_result.hints.must_equal({:title=>[]})
-    form.songs[1].to_result.errors(locale: :de).must_equal({:title=>["muss abgefüllt sein"]})
-    form.songs[1].to_result.messages(locale: :de).must_equal({:title=>["muss abgefüllt sein"]})
-    form.songs[1].to_result.hints(locale: :de).must_equal({:title=>[]})
+    form.songs[1].to_result.errors.must_equal(title: ["must be filled"])
+    form.songs[1].to_result.messages.must_equal(title: ["must be filled"])
+    form.songs[1].to_result.hints.must_equal(title: [])
+    form.songs[1].to_result.errors(locale: :de).must_equal(title: ["muss abgefüllt sein"])
+    form.songs[1].to_result.messages(locale: :de).must_equal(title: ["muss abgefüllt sein"])
+    form.songs[1].to_result.hints(locale: :de).must_equal(title: [])
   end
 
   it "only nested property is invalid." do
-    result = form.({ title: "Black Star", artist: { email: "" } })
+    result = form.(title: "Black Star", artist: {email: ""})
 
     result.success?.must_equal false
 
     # errors.messages
-    form.errors.messages.must_equal({:"artist.email"=>["must be filled"], :"artist.label.location"=>["must be filled"], :"songs.title"=>["must be filled"]})
-    form.artist.errors.messages.must_equal({:email=>["must be filled"], :"label.location"=>["must be filled"]})
-    form.artist.label.errors.messages.must_equal({:location=>["must be filled"]})
+    form.errors.messages.must_equal("artist.email": ["must be filled"], "artist.label.location": ["must be filled"], "songs.title": ["must be filled"])
+    form.artist.errors.messages.must_equal(email: ["must be filled"], "label.location": ["must be filled"])
+    form.artist.label.errors.messages.must_equal(location: ["must be filled"])
   end
 
   it "nested collection invalid" do
-    result = form.({ title: "Black Star", artist: { email: "uhm", label: { location: "Hannover" } }, songs: [ { title: "" } ] })
+    result = form.(title: "Black Star", artist: {email: "uhm", label: {location: "Hannover"}}, songs: [{title: ""}])
 
     result.success?.must_equal false
-    form.errors.messages.must_equal({:"songs.title"=>["must be filled"]})
+    form.errors.messages.must_equal("songs.title": ["must be filled"])
   end
 
   #---
@@ -129,11 +127,11 @@ class DryValidationErrorsAPITest < Minitest::Spec
 
   it do
     form = CollectionExternalValidationsForm.new(Album.new(nil, nil, [Song.new, Song.new]))
-    form.validate(songs: [ { title: "Liar"}, { title: ""} ])
+    form.validate(songs: [{title: "Liar"}, {title: ""}])
 
-    form.errors.messages.must_equal({:"songs.title"=>["must be filled"]})
+    form.errors.messages.must_equal("songs.title": ["must be filled"])
     form.songs[0].errors.messages.must_equal({})
-    form.songs[1].errors.messages.must_equal({:title=>["must be filled"]})
+    form.songs[1].errors.messages.must_equal(title: ["must be filled"])
   end
 end
 
@@ -153,7 +151,7 @@ class DryValidationExplicitSchemaTest < Minitest::Spec
     validation schema: SessionSchema
   end
 
-  let (:form) { SessionForm.new(Session.new) }
+  let(:form) { SessionForm.new(Session.new) }
 
   # valid.
   it do
@@ -177,8 +175,8 @@ class DryValidationDefaultGroupTest < Minitest::Spec
     property :email
     property :password
     property :confirm_password
-    property :starts_at, type: Types::Form::DateTime
-    property :active, type: Types::Form::Bool
+    property :starts_at, type: DRY_TYPES_CONSTANT::DateTime
+    property :active, type: DRY_TYPES_CONSTANT::Bool
     property :color
 
     validation do
@@ -192,7 +190,7 @@ class DryValidationDefaultGroupTest < Minitest::Spec
       required(:confirm_password).filled
     end
 
-    validation name: :dynamic_args, with: { form: true } do
+    validation name: :dynamic_args, with: {form: true} do
       configure do
         def colors
           form.colors
@@ -206,7 +204,7 @@ class DryValidationDefaultGroupTest < Minitest::Spec
     end
   end
 
-  let (:form) { SessionForm.new(Session.new) }
+  let(:form) { SessionForm.new(Session.new) }
 
   # valid.
   it do
@@ -214,16 +212,16 @@ class DryValidationDefaultGroupTest < Minitest::Spec
                   email:    "yep",
                   starts_at: "01/01/2000 - 11:00",
                   active: "true",
-                  confirm_password: 'pA55w0rd').must_equal true
+                  confirm_password: "pA55w0rd").must_equal true
     form.errors.messages.inspect.must_equal "{}"
   end
 
   it "invalid" do
     form.validate(username: "Helloween",
                   email:    "yep",
-                  active: 'hello',
+                  active: "hello",
                   starts_at: "01/01/2000 - 11:00",
-                  color: 'purple').must_equal false
+                  color: "purple").must_equal false
     form.errors.messages.inspect.must_equal "{:active=>[\"must be boolean\"], :confirm_password=>[\"must be filled\"], :color=>[\"must be one of: red orange green\"]}"
   end
 end
@@ -231,10 +229,9 @@ end
 class ValidationGroupsTest < MiniTest::Spec
   describe "basic validations" do
     Session = Struct.new(:username, :email, :password, :confirm_password, :special_class)
-    SomeClass= Struct.new(:id)
+    SomeClass = Struct.new(:id)
 
     class SessionForm < TestForm
-
       property :username
       property :email
       property :password
@@ -251,7 +248,7 @@ class ValidationGroupsTest < MiniTest::Spec
         required(:email).filled(min_size?: 3)
       end
 
-      validation name: :nested, if: :default do
+      validation name: :password, if: :email do
         required(:password).filled(min_size?: 2)
       end
 
@@ -260,35 +257,35 @@ class ValidationGroupsTest < MiniTest::Spec
       end
     end
 
-    let (:form) { SessionForm.new(Session.new) }
+    let(:form) { SessionForm.new(Session.new) }
 
     # valid.
     it do
-      form.validate({ username: "Helloween",
-                      special_class: SomeClass.new(id: 15),
-                      email: "yep",
-                      password: "99",
-                      confirm_password: "99" }).must_equal true
+      form.validate(username: "Helloween",
+                    special_class: SomeClass.new(id: 15),
+                    email: "yep",
+                    password: "99",
+                    confirm_password: "99").must_equal true
       form.errors.messages.inspect.must_equal "{}"
     end
 
     # invalid.
     it do
       form.validate({}).must_equal false
-      form.errors.messages.must_equal({:username=>["must be filled"], :email=>["must be filled"], :special_class=>["must be filled", "must be ValidationGroupsTest::SomeClass"]})
+      form.errors.messages.must_equal({username: ["must be filled"], email: ["must be filled"], special_class: ["must be filled", "must be ValidationGroupsTest::SomeClass"]})
     end
 
     # partially invalid.
     # 2nd group fails.
     it do
-      form.validate(username: "Helloween", email: "yo", confirm_password:"9", special_class: SomeClass.new(id: 15)).must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
+      form.validate(username: "Helloween", email: "yo", confirm_password: "9", special_class: SomeClass.new(id: 15)).must_equal false
+      form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"]}"
     end
     # 3rd group fails.
     it do
-      form.validate(username: "Helloween", email: "yo!", confirm_password:"9", special_class: SomeClass.new(id: 15)).must_equal false
+      form.validate(username: "Helloween", email: "yo!", confirm_password: "9", special_class: SomeClass.new(id: 15)).must_equal false
       form.errors.messages.inspect
-      .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
+          .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
     end
     # 4th group with after: fails.
     it do
@@ -303,7 +300,7 @@ class ValidationGroupsTest < MiniTest::Spec
       class SessionForm < TestForm
         property :username
 
-        validation name: :default, with: { user: OpenStruct.new(name: "Nick") } do
+        validation name: :default, with: {user: OpenStruct.new(name: "Nick")} do
           configure do
             def users_name
               user.name
@@ -313,17 +310,17 @@ class ValidationGroupsTest < MiniTest::Spec
         end
       end
 
-      let (:form) { SessionForm.new(Session.new) }
+      let(:form) { SessionForm.new(Session.new) }
 
       # valid.
       it do
-        form.validate({ username: "Nick" }).must_equal true
+        form.validate(username: "Nick").must_equal true
         form.errors.messages.inspect.must_equal "{}"
       end
 
       # invalid.
       it do
-        form.validate({ username: 'Fred'}).must_equal false
+        form.validate(username: "Fred").must_equal false
         form.errors.messages.inspect.must_equal "{:username=>[\"must be equal to Nick\"]}"
       end
     end
@@ -336,15 +333,14 @@ class ValidationGroupsTest < MiniTest::Spec
 
     MySchema = Dry::Validation.Schema do
       configure do
-        config.messages_file = 'test/fixtures/dry_error_messages.yml'
+        config.messages_file = "test/fixtures/dry_error_messages.yml"
 
         def good_musical_taste?(val)
           val.is_a? String
         end
-
       end
 
-      required(:password).filled(:min_size? => 6)
+      required(:password).filled(min_size?: 6)
     end
 
     class Session2Form < TestForm
@@ -358,22 +354,22 @@ class ValidationGroupsTest < MiniTest::Spec
       end
     end
 
-    let (:form) { Session2Form.new(Session2.new) }
+    let(:form) { Session2Form.new(Session2.new) }
 
     # valid.
     it do
-      form.validate({ username: "Helloween", email: "yep", password: "extrasafe" }).must_equal true
+      form.validate(username: "Helloween", email: "yep", password: "extrasafe").must_equal true
       form.errors.messages.inspect.must_equal "{}"
     end
 
     # invalid.
     it do
       form.validate({}).must_equal false
-      form.errors.messages.must_equal({:password=>["must be filled", "size cannot be less than 6"], :username=>["must be filled"], :email=>["must be filled", "you're a bad person"]})
+      form.errors.messages.must_equal(password: ["must be filled", "size cannot be less than 6"], username: ["must be filled"], email: ["must be filled", "you're a bad person"])
     end
 
     it do
-      form.validate({email: 1}).must_equal false
+      form.validate(email: 1).must_equal false
       form.errors.messages.inspect.must_equal "{:password=>[\"must be filled\", \"size cannot be less than 6\"], :username=>[\"must be filled\"], :email=>[\"you're a bad person\"]}"
     end
   end
@@ -416,7 +412,7 @@ class ValidationGroupsTest < MiniTest::Spec
           # message need to be defined on fixtures/dry_error_messages
           # d-v expects you to define your custome messages on the .yml file
           def good_musical_taste?(value)
-            value != 'Nickelback'
+            value != "Nickelback"
           end
         end
 
@@ -434,46 +430,45 @@ class ValidationGroupsTest < MiniTest::Spec
             required(:name).filled
           end
         end
-
       end
     end
 
-    let (:album) do
+    let(:album) do
       OpenStruct.new(
-        :hit    => OpenStruct.new,
-        :songs  => [OpenStruct.new, OpenStruct.new],
-        :band => Struct.new(:name, :label).new("", OpenStruct.new),
-        :producers => [OpenStruct.new, OpenStruct.new, OpenStruct.new],
+        hit: OpenStruct.new,
+        songs: [OpenStruct.new, OpenStruct.new],
+        band: Struct.new(:name, :label).new("", OpenStruct.new),
+        producers: [OpenStruct.new, OpenStruct.new, OpenStruct.new],
       )
     end
 
-    let (:form)  { AlbumForm.new(album) }
+    let(:form) { AlbumForm.new(album) }
 
     it "maps errors to form objects correctly" do
       result = form.validate(
         "title"  => "Nickelback",
-        "songs"  => [ {"title" => ""}, {"title" => ""} ],
+        "songs"  => [{"title" => ""}, {"title" => ""}],
         "band"   => {"size" => "", "label" => {"location" => ""}},
-        "producers" => [{"name" => ''}, {"name" => 'something lovely'}]
+        "producers" => [{"name" => ""}, {"name" => "something lovely"}]
       )
 
       result.must_equal false
       # from nested validation
-      form.errors.messages.must_equal({:title=>["you're a bad person"], :"hit.title"=>["must be filled"], :"songs.title"=>["must be filled"], :"producers.name"=>["must be filled"], :"band.name"=>["must be filled"], :"band.label.location"=>["must be filled"]})
+      form.errors.messages.must_equal(title: ["you're a bad person"], "hit.title": ["must be filled"], "songs.title": ["must be filled"], "producers.name": ["must be filled"], "band.name": ["must be filled"], "band.label.location": ["must be filled"])
 
       # songs have their own validation.
-      form.songs[0].errors.messages.must_equal({:title=>["must be filled"]})
+      form.songs[0].errors.messages.must_equal(title: ["must be filled"])
       # hit got its own validation group.
-      form.hit.errors.messages.must_equal({:title=>["must be filled"]})
+      form.hit.errors.messages.must_equal(title: ["must be filled"])
 
-      form.band.label.errors.messages.must_equal({:location=>["must be filled"]})
-      form.band.errors.messages.must_equal({:name=>["must be filled"], :"label.location"=>["must be filled"]})
-      form.producers[0].errors.messages.must_equal({:name=>["must be filled"]})
+      form.band.label.errors.messages.must_equal(location: ["must be filled"])
+      form.band.errors.messages.must_equal(name: ["must be filled"], "label.location": ["must be filled"])
+      form.producers[0].errors.messages.must_equal(name: ["must be filled"])
 
       # TODO: use the same form structure as the top one and do the same test against messages, errors and hints.
-      form.producers[0].to_result.errors.must_equal({:name=>["must be filled"]})
-      form.producers[0].to_result.messages.must_equal({:name=>["must be filled"]})
-      form.producers[0].to_result.hints.must_equal({:name=>[]})
+      form.producers[0].to_result.errors.must_equal(name: ["must be filled"])
+      form.producers[0].to_result.messages.must_equal(name: ["must be filled"])
+      form.producers[0].to_result.hints.must_equal(name: [])
     end
 
     # FIXME: fix the "must be filled error"
@@ -481,9 +476,9 @@ class ValidationGroupsTest < MiniTest::Spec
     it "renders full messages correctly" do
       result = form.validate(
         "title"  => "",
-        "songs"  => [ {"title" => ""}, {"title" => ""} ],
+        "songs"  => [{"title" => ""}, {"title" => ""}],
         "band"   => {"size" => "", "label" => {"name" => ""}},
-        "producers" => [{"name" => ''}, {"name" => ''}, {"name" => 'something lovely'}]
+        "producers" => [{"name" => ""}, {"name" => ""}, {"name" => "something lovely"}]
       )
 
       result.must_equal false
@@ -505,7 +500,7 @@ class ValidationGroupsTest < MiniTest::Spec
 
         validation do
           configure do
-            config.messages_file = 'test/fixtures/dry_error_messages.yml'
+            config.messages_file = "test/fixtures/dry_error_messages.yml"
           end
 
           required(:title).filled
@@ -519,24 +514,24 @@ class ValidationGroupsTest < MiniTest::Spec
         end
       end
 
-      let (:form)  { AlbumFormWith1NestedVal.new(album) }
+      let(:form) { AlbumFormWith1NestedVal.new(album) }
 
       it "allows to access dry's result semantics per nested form" do
-        result = form.validate(
+        form.validate(
           "title"  => "",
-          "songs"  => [ {"title" => ""}, {"title" => ""} ],
+          "songs"  => [{"title" => ""}, {"title" => ""}],
           "band"   => {"size" => "", "label" => {"name" => ""}},
-          "producers" => [{"name" => ''}, {"name" => ''}, {"name" => 'something lovely'}]
+          "producers" => [{"name" => ""}, {"name" => ""}, {"name" => "something lovely"}]
         )
 
-        form.to_result.errors.must_equal({:title=>["must be filled"]})
-        form.band.to_result.errors.must_equal({:name=>["must be filled"]})
-        form.band.label.to_result.errors.must_equal({:location=>["must be filled"]})
+        form.to_result.errors.must_equal(title: ["must be filled"])
+        form.band.to_result.errors.must_equal(name: ["must be filled"])
+        form.band.label.to_result.errors.must_equal(location: ["must be filled"])
 
         # with locale: "de"
-        form.to_result.errors(locale: :de).must_equal({:title=>["muss abgefüllt sein"]})
-        form.band.to_result.errors(locale: :de).must_equal({:name=>["muss abgefüllt sein"]})
-        form.band.label.to_result.errors(locale: :de).must_equal({:location=>["muss abgefüllt sein"]})
+        form.to_result.errors(locale: :de).must_equal(title: ["muss abgefüllt sein"])
+        form.band.to_result.errors(locale: :de).must_equal(name: ["muss abgefüllt sein"])
+        form.band.label.to_result.errors(locale: :de).must_equal(location: ["muss abgefüllt sein"])
       end
     end
   end
@@ -557,7 +552,7 @@ class ValidationGroupsTest < MiniTest::Spec
   #     end
   #   end
 
-  #   let (:form) { OverwritingForm.new(Session.new) }
+  #   let(:form) { OverwritingForm.new(Session.new) }
 
   #   # valid.
   #   it do
@@ -571,36 +566,41 @@ class ValidationGroupsTest < MiniTest::Spec
   #   end
   # end
 
-
   describe "inherit: true in same group" do
     class InheritSameGroupForm < TestForm
       property :username
       property :email
+      property :full_name, virtual: true
 
-      validation name: :email do
-        required(:email).filled
-      end
+      validation name: :username do
+        configure do
+          config.messages_file = "test/fixtures/dry_error_messages.yml"
+        end
 
-      validation name: :email, inherit: true do # extends the above.
         required(:username).filled
+        required(:full_name).filled
+      end
+
+      validation name: :username, inherit: true do # overrides and extends the above.
+        optional(:username).maybe
+        required(:email).filled
       end
     end
 
-    let (:form) { InheritSameGroupForm.new(Session.new) }
+    let(:form) { InheritSameGroupForm.new(Session.new) }
 
     # valid.
     it do
-      form.validate({username: "Helloween", email: 9}).must_equal true
+      form.validate(full_name: "My name", email: 9).must_equal true
     end
 
     # invalid.
     it do
       form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"must be filled\"], :username=>[\"must be filled\"]}"
+      form.errors.messages.must_equal email: ["must be filled"], full_name: ["must be filled"]
     end
   end
 
-
   describe "if: with lambda" do
     class IfWithLambdaForm < TestForm
       property :username
@@ -612,30 +612,137 @@ class ValidationGroupsTest < MiniTest::Spec
       end
 
       # run this is :email group is true.
-      validation name: :after_email, if: lambda { |results| results[:email].success? } do # extends the above.
+      validation name: :after_email, if: ->(results) { results[:email].success? } do # extends the above.
         required(:username).filled
       end
 
       # block gets evaled in form instance context.
-      validation name: :password, if: lambda { |results| email == "john@trb.org" } do
+      validation name: :password, if: ->(results) { email == "john@trb.org" } do
         required(:password).filled
       end
     end
 
-    let (:form) { IfWithLambdaForm.new(Session.new) }
+    let(:form) { IfWithLambdaForm.new(Session.new) }
 
     # valid.
     it do
-      form.validate({username: "Strung Out", email: 9}).must_equal true
+      form.validate(username: "Strung Out", email: 9).must_equal true
     end
 
     # invalid.
     it do
-      form.validate({email: 9}).must_equal false
+      form.validate(email: 9).must_equal false
       form.errors.messages.inspect.must_equal "{:username=>[\"must be filled\"]}"
     end
   end
 
+  class NestedSchemaValidationTest < MiniTest::Spec
+    AddressSchema = Dry::Validation.Schema do
+      required(:company).filled(:int?)
+    end
+
+    class OrderForm < TestForm
+      property :delivery_address do
+        property :company
+      end
+
+      validation do
+        required(:delivery_address).schema(AddressSchema)
+      end
+    end
+
+    let(:company) { Struct.new(:company) }
+    let(:order) { Struct.new(:delivery_address) }
+    let(:form)  { OrderForm.new(order.new(company.new)) }
+
+    it "has company error" do
+      form.validate(delivery_address: {company: "not int"}).must_equal false
+      form.errors.messages.must_equal(:"delivery_address.company" => ["must be an integer"])
+    end
+  end
+
+  class NestedSchemaValidationWithFormTest < MiniTest::Spec
+    class CompanyForm < TestForm
+      property :company
+
+      validation do
+        required(:company).filled(:int?)
+      end
+    end
+
+    class OrderFormWithForm < TestForm
+      property :delivery_address, form: CompanyForm
+    end
+
+    let(:company) { Struct.new(:company) }
+    let(:order)   { Struct.new(:delivery_address) }
+    let(:form)    { OrderFormWithForm.new(order.new(company.new)) }
+
+    it "has company error" do
+      form.validate(delivery_address: {company: "not int"}).must_equal false
+      form.errors.messages.must_equal(:"delivery_address.company" => ["must be an integer"])
+    end
+  end
+
+  class CollectionPropertyWithCustomRuleTest < MiniTest::Spec
+    Artist = Struct.new(:first_name, :last_name)
+    Song   = Struct.new(:title, :enabled)
+    Album  = Struct.new(:title, :songs, :artist)
+
+    class AlbumForm < TestForm
+      property :title
+
+      collection :songs, virtual: true, populate_if_empty: Song do
+        property :title
+        property :enabled
+
+        validation do
+          required(:title).filled
+        end
+      end
+
+      property :artist, populate_if_empty: Artist do
+        property :first_name
+        property :last_name
+      end
+
+      validation do
+        configure do
+          config.messages_file = "test/fixtures/dry_error_messages.yml"
+
+          def a_song?(value)
+            value.any? { |el| el && el[:enabled] }
+          end
+
+          def with_last_name?(value)
+            !value[:last_name].nil?
+          end
+        end
+
+        required(:songs).filled(:a_song?)
+        required(:artist).filled(:with_last_name?)
+      end
+    end
+
+    it "validates fails and shows the correct errors" do
+      form = AlbumForm.new(Album.new(nil, [], nil))
+      form.validate(
+        "songs" => [
+          {"title" => "One", "enabled" => false},
+          {"title" => nil, "enabled" => false},
+          {"title" => "Three", "enabled" => false}
+        ],
+        "artist" => {"last_name" => nil}
+      ).must_equal false
+      form.songs.size.must_equal 3
+
+      form.errors.messages.must_equal(
+        :songs => ["must have at least one enabled song"],
+        :artist => ["must have last name"],
+        :"songs.title" => ["must be filled"]
+      )
+    end
+  end
 
   # Currenty dry-v don't support that option, it doesn't make sense
   #   I've talked to @solnic and he plans to add a "hint" feature to show
@@ -654,7 +761,7 @@ class ValidationGroupsTest < MiniTest::Spec
   #     end
   #   end
 
-  #   let (:form) { MultipleErrorsForPropertyForm.new(Session.new) }
+  #   let(:form) { MultipleErrorsForPropertyForm.new(Session.new) }
 
   #   # valid.
   #   it do