reform 2.2.4 → 2.3.0.rc1

data/test/save_test.rb

@@ -5,22 +5,22 @@ class SaveTest < BaseTest
   Album = Struct.new(:name, :songs, :artist)
   Artist = Struct.new(:name)
 
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :name
     validation do
-      key(:name).required
+      required(:name).filled
     end
 
     collection :songs do
       property :title
       validation do
-        key(:title).required
+        required(:title).filled
       end
 
       property :composer do
         property :name
         validation do
-          key(:name).required
+          required(:name).filled
         end
       end
     end
@@ -36,7 +36,7 @@ class SaveTest < BaseTest
     end
 
     def saved?
-      @saved
+      defined?(@saved) && @saved
     end
   end
 
@@ -58,7 +58,22 @@ class SaveTest < BaseTest
     album.saved?.must_equal true
     album.songs[0].title.must_equal "Fixed"
     album.songs[0].saved?.must_equal true
-    album.artist.saved?.must_equal nil
+    assert_nil album.artist.saved?
+  end
+
+  describe "#sync with block" do
+    it do
+      form = AlbumForm.new(Album.new("Greatest Hits"))
+
+      form.validate(name: nil) # nil-out the title.
+
+      nested_hash = nil
+      form.sync do |hash|
+        nested_hash = hash
+      end
+
+      nested_hash.must_equal({"name"=>nil, "artist"=>nil})
+    end
   end
 end
 
@@ -68,7 +83,7 @@ end
 #     include Saveable
 #   end
 
-#   class SongForm < Reform::Form
+#   class SongForm < TestForm
 #     property :title#, save: false
 #     property :length, virtual: true
 #   end
@@ -83,7 +98,7 @@ end
 #     form.save(length: lambda { |value, options| form.model.id = "#{value}: #{length_seconds}" })
 
 #     song.title.must_equal "A Poor Man's Memory"
-#     song.length.must_equal nil
+#     assert_nil song.length
 #     song.id.must_equal "10: 120"
 #   end
 # end

data/test/setup_test.rb

@@ -5,7 +5,7 @@ class SetupTest < MiniTest::Spec
   Album = Struct.new(:name, :songs, :artist)
   Artist = Struct.new(:name)
 
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :name
     collection :songs do
       property :title
@@ -33,7 +33,7 @@ class SetupTest < MiniTest::Spec
 
       form.name.must_equal "The Dissent Of Man"
       form.songs[0].title.must_equal "Broken"
-      form.songs[0].composer.must_equal nil
+      assert_nil form.songs[0].composer
       form.songs[1].title.must_equal "Resist Stance"
       form.songs[1].composer.name.must_equal "Greg Graffin"
       form.artist.name.must_equal "Bad Religion"

data/test/skip_if_test.rb

@@ -2,13 +2,13 @@ require 'test_helper'
 
 class SkipIfTest < BaseTest
 
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :title
 
     property :hit, skip_if: lambda { |options| options[:fragment]["title"]=="" } do
       property :title
       validation do
-        key(:title).required
+        required(:title).filled
       end
     end
 
@@ -36,7 +36,7 @@ class SkipIfTest < BaseTest
   it do
     form = AlbumForm.new(Album.new)
     form.validate("hit" => {"title" => ""}).must_equal true
-    form.hit.must_equal nil # hit hasn't been deserialised.
+    assert_nil form.hit # hit hasn't been deserialised.
   end
 
   # skips deserialization when not present.
@@ -50,7 +50,7 @@ end
 
 class SkipIfAllBlankTest < BaseTest
   # skip_if: :all_blank"
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     collection :songs, skip_if: :all_blank, populate_if_empty: BaseTest::Song do
       property :title
       property :length

data/test/skip_setter_and_getter_test.rb

@@ -7,7 +7,7 @@ class SetupSkipSetterAndGetterTest < MiniTest::Spec
   Album = Struct.new(:title, :artist)
   Artist = Struct.new(:name)
 
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :title
 
     def title

data/test/test_helper.rb

@@ -3,9 +3,20 @@ require 'minitest/autorun'
 require "representable/debug"
 require "declarative/testing"
 require "pp"
+require 'byebug'
+
+require "reform/form/dry"
+# setup test classes so we can test without dry being included
+class TestForm < Reform::Form
+  feature Reform::Form::Dry
+end
+
+class TestContract < Reform::Contract
+  feature Reform::Form::Dry
+end
 
 class BaseTest < MiniTest::Spec
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :title
 
     property :hit do
@@ -17,7 +28,7 @@ class BaseTest < MiniTest::Spec
     end
   end
 
-  Song   = Struct.new(:title, :length)
+  Song   = Struct.new(:title, :length, :rating)
   Album  = Struct.new(:title, :hit, :songs, :band)
   Band   = Struct.new(:label)
   Label  = Struct.new(:name)
@@ -39,11 +50,3 @@ MiniTest::Spec.class_eval do
   end
 end
 
-require "reform/form/dry"
-Reform::Contract.class_eval do
-  feature Reform::Form::Dry
-end
-# FIXME!
-Reform::Form.class_eval do
-  feature Reform::Form::Dry
-end

data/test/validate_test.rb

@@ -5,21 +5,21 @@ class ContractValidateTest < MiniTest::Spec
   Album = Struct.new(:name, :songs, :artist)
   Artist = Struct.new(:name)
 
-  class AlbumForm < Reform::Contract
+  class AlbumForm < TestContract
     property :name
     validation do
-      key(:name).required
+      required(:name).filled
     end
 
     collection :songs do
       property :title
       validation do
-        key(:title).required
+        required(:title).filled
       end
 
       property :composer do
         validation do
-          key(:name).required
+          required(:name).filled
         end
         property :name
       end
@@ -50,7 +50,7 @@ class ContractValidateTest < MiniTest::Spec
     album.name = nil
 
     form.validate.must_equal false
-    form.errors.messages.inspect.must_equal "{:name=>[\"is missing\"], :\"songs.composer.name\"=>[\"is missing\"]}"
+    form.errors.messages.inspect.must_equal "{:name=>[\"must be filled\"], :\"songs.composer.name\"=>[\"must be filled\"]}"
   end
 end
 
@@ -61,23 +61,23 @@ class ValidateWithoutConfigurationTest < MiniTest::Spec
   Album = Struct.new(:name, :songs, :artist)
   Artist = Struct.new(:name)
 
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :name
     validation do
-      key(:name).required
+      required(:name).filled
     end
 
     collection :songs do
 
       property :title
       validation do
-        key(:title).required
+        required(:title).filled
       end
 
       property :composer do
         property :name
         validation do
-          key(:name).required
+          required(:name).filled
         end
       end
     end
@@ -160,10 +160,10 @@ class ValidateWithInternalPopulatorOptionTest < MiniTest::Spec
   Album = Struct.new(:name, :songs, :artist)
   Artist = Struct.new(:name)
 
-  class AlbumForm < Reform::Form
+  class AlbumForm < TestForm
     property :name
     validation do
-      key(:name).required
+      required(:name).filled
     end
 
     collection :songs,
@@ -173,13 +173,13 @@ class ValidateWithInternalPopulatorOptionTest < MiniTest::Spec
 
       property :title
       validation do
-        key(:title).required
+        required(:title).filled
       end
 
       property :composer, internal_populator: lambda { |input, options| (item = options[:represented].composer) ? item : Artist.new } do
         property :name
         validation do
-          key(:name).required
+          required(:name).filled
         end
       end
     end
@@ -187,7 +187,7 @@ class ValidateWithInternalPopulatorOptionTest < MiniTest::Spec
     property :artist, internal_populator: lambda { |input, options| (item = options[:represented].artist) ? item : Artist.new } do
       property :name
       validation do
-        key(:name).required
+        required(:name).filled
       end
     end
   end
@@ -268,21 +268,21 @@ class ValidateWithInternalPopulatorOptionTest < MiniTest::Spec
 
 
   # allow writeable: false even in the deserializer.
-  class SongForm < Reform::Form
-    property :title, deserializer: {writeable: false}
+  class SongForm < TestForm
+    property :title, deserializer: { writeable: false }
   end
 
   it do
     form = SongForm.new(song = Song.new)
     form.validate("title" => "Ignore me!")
-    form.title.must_equal nil
+    assert_nil form.title
     form.title = "Unopened"
     form.sync # only the deserializer is marked as not-writeable.
     song.title.must_equal "Unopened"
   end
 end
 
-#   # not sure if we should catch that in Reform or rather do that in disposable. this is https://github.com/apotonick/reform/pull/104
+#   # not sure if we should catch that in Reform or rather do that in disposable. this is https://github.com/trailblazer/reform/pull/104
 #   # describe ":populator with :empty" do
 #   #   let (:form) {
 #   #     Class.new(Reform::Form) do

data/test/validation/dry_validation_test.rb

@@ -1,20 +1,208 @@
+# encoding: utf-8
 require "test_helper"
 require "reform/form/dry"
+require "reform/form/coercion"
+
+#---
+# one "nested" Schema per form.
+class DryValidationErrorsAPITest < Minitest::Spec
+  Album  = Struct.new(:title, :artist, :songs)
+  Song   = Struct.new(:title)
+  Artist = Struct.new(:email, :label)
+  Label  = Struct.new(:location)
+
+  class AlbumForm < TestForm
+    property :title
+
+    validation do
+      # required(:title).filled
+      required(:title).filled(min_size?: 2)
+    end
+
+    property :artist do
+      property :email
+
+      validation do
+        required(:email).filled
+      end
+
+      property :label do
+        property :location
+
+        validation do
+          required(:location).filled
+        end
+      end
+    end
+
+    # note the validation block is *in* the collection block, per item, so to speak.
+    collection :songs do
+      property :title
+
+      validation do
+        configure do
+          config.messages_file = 'test/fixtures/dry_error_messages.yml'
+        end
+
+        required(:title).filled
+      end
+    end
+
+  end
+
+  let (:form) { AlbumForm.new(Album.new(nil, Artist.new(nil, Label.new), [Song.new(nil), Song.new(nil)])) }
+
+  it "everything wrong" do
+    result = form.({ title: nil, artist: { email: "" }, songs: [{ title: "Clams have feelings too" }, { title: "" }] })
+
+    result.success?.must_equal false
+
+    # errors.messages
+    form.errors.messages.must_equal({:title=>["must be filled", "size cannot be less than 2"], :"artist.email"=>["must be filled"], :"artist.label.location"=>["must be filled"], :"songs.title"=>["must be filled"]})
+    form.artist.errors.messages.must_equal({:email=>["must be filled"], :"label.location"=>["must be filled"]})
+    form.artist.label.errors.messages.must_equal({:location=>["must be filled"]})
+    form.songs[0].errors.messages.must_equal({})
+    form.songs[1].errors.messages.must_equal({:title=>["must be filled"]})
+
+    # #errors[]
+    form.errors[:nonsense].must_be_nil
+    form.errors[:title].must_equal ["must be filled", "size cannot be less than 2"]
+    form.artist.errors[:email].must_equal ["must be filled"]
+    form.artist.label.errors[:location].must_equal ["must be filled"]
+    form.songs[0].errors[:title].must_be_nil
+    form.songs[1].errors[:title].must_equal ["must be filled"]
+
+    # #to_result
+    form.to_result.errors.must_equal({:title=>["must be filled"]})
+    form.to_result.messages.must_equal({:title=>["must be filled", "size cannot be less than 2"]})
+    form.to_result.hints.must_equal({:title=>["size cannot be less than 2"]})
+    form.artist.to_result.errors.must_equal({:email=>["must be filled"]})
+    form.artist.to_result.messages.must_equal({:email=>["must be filled"]})
+    form.artist.to_result.hints.must_equal({:email=>[]})
+    form.artist.label.to_result.errors.must_equal({:location=>["must be filled"]})
+    form.artist.label.to_result.messages.must_equal({:location=>["must be filled"]})
+    form.artist.label.to_result.hints.must_equal({:location=>[]})
+    form.songs[0].to_result.errors.must_equal({})
+    form.songs[0].to_result.messages.must_equal({})
+    form.songs[0].to_result.hints.must_equal({})
+    form.songs[1].to_result.errors.must_equal({:title=>["must be filled"]})
+    form.songs[1].to_result.messages.must_equal({:title=>["must be filled"]})
+    form.songs[1].to_result.hints.must_equal({:title=>[]})
+    form.songs[1].to_result.errors(locale: :de).must_equal({:title=>["muss abgefüllt sein"]})
+    form.songs[1].to_result.messages(locale: :de).must_equal({:title=>["muss abgefüllt sein"]})
+    form.songs[1].to_result.hints(locale: :de).must_equal({:title=>[]})
+  end
+
+  it "only nested property is invalid." do
+    result = form.({ title: "Black Star", artist: { email: "" } })
+
+    result.success?.must_equal false
+
+    # errors.messages
+    form.errors.messages.must_equal({:"artist.email"=>["must be filled"], :"artist.label.location"=>["must be filled"], :"songs.title"=>["must be filled"]})
+    form.artist.errors.messages.must_equal({:email=>["must be filled"], :"label.location"=>["must be filled"]})
+    form.artist.label.errors.messages.must_equal({:location=>["must be filled"]})
+  end
+
+  it "nested collection invalid" do
+    result = form.({ title: "Black Star", artist: { email: "uhm", label: { location: "Hannover" } }, songs: [ { title: "" } ] })
+
+    result.success?.must_equal false
+    form.errors.messages.must_equal({:"songs.title"=>["must be filled"]})
+  end
+
+  #---
+  #- validation .each
+  class CollectionExternalValidationsForm < TestForm
+    collection :songs do
+      property :title
+    end
+
+    validation do
+      required(:songs).each do
+        schema do
+          required(:title).filled
+        end
+      end
+    end
+  end
+
+  it do
+    form = CollectionExternalValidationsForm.new(Album.new(nil, nil, [Song.new, Song.new]))
+    form.validate(songs: [ { title: "Liar"}, { title: ""} ])
+
+    form.errors.messages.must_equal({:"songs.title"=>["must be filled"]})
+    form.songs[0].errors.messages.must_equal({})
+    form.songs[1].errors.messages.must_equal({:title=>["must be filled"]})
+  end
+end
+
+class DryValidationExplicitSchemaTest < Minitest::Spec
+  Session = Struct.new(:name, :email)
+  SessionSchema = Dry::Validation.Schema do
+    required(:name).filled
+    required(:email).filled
+  end
+
+  class SessionForm < TestForm
+    include Coercion
+
+    property :name
+    property :email
+
+    validation schema: SessionSchema
+  end
+
+  let (:form) { SessionForm.new(Session.new) }
+
+  # valid.
+  it do
+    form.validate(name: "Helloween", email: "yep").must_equal true
+    form.errors.messages.inspect.must_equal "{}"
+  end
+
+  it "invalid" do
+    form.validate(name: "", email: "yep").must_equal false
+    form.errors.messages.inspect.must_equal "{:name=>[\"must be filled\"]}"
+  end
+end
 
 class DryValidationDefaultGroupTest < Minitest::Spec
-  Session = Struct.new(:username, :email, :password, :confirm_password)
+  Session = Struct.new(:username, :email, :password, :confirm_password, :starts_at, :active, :color)
 
-  class SessionForm < Reform::Form
-    include Reform::Form::Dry
+  class SessionForm < TestForm
+    include Coercion
 
     property :username
     property :email
     property :password
     property :confirm_password
+    property :starts_at, type: Types::Form::DateTime
+    property :active, type: Types::Form::Bool
+    property :color
 
     validation do
-      key(:username).required
-      key(:email).required
+      required(:username).filled
+      required(:email).filled
+      required(:starts_at).filled(:date_time?)
+      required(:active).filled(:bool?)
+    end
+
+    validation name: :another_block do
+      required(:confirm_password).filled
+    end
+
+    validation name: :dynamic_args, with: { form: true } do
+      configure do
+        def colors
+          form.colors
+        end
+      end
+      required(:color).maybe(included_in?: colors)
+    end
+
+    def colors
+      %(red orange green)
     end
   end
 
@@ -23,38 +211,52 @@ class DryValidationDefaultGroupTest < Minitest::Spec
   # valid.
   it do
     form.validate(username: "Helloween",
-                  email:    "yep").must_equal true
+                  email:    "yep",
+                  starts_at: "01/01/2000 - 11:00",
+                  active: "true",
+                  confirm_password: 'pA55w0rd').must_equal true
     form.errors.messages.inspect.must_equal "{}"
   end
+
+  it "invalid" do
+    form.validate(username: "Helloween",
+                  email:    "yep",
+                  active: 'hello',
+                  starts_at: "01/01/2000 - 11:00",
+                  color: 'purple').must_equal false
+    form.errors.messages.inspect.must_equal "{:active=>[\"must be boolean\"], :confirm_password=>[\"must be filled\"], :color=>[\"must be one of: red orange green\"]}"
+  end
 end
 
 class ValidationGroupsTest < MiniTest::Spec
   describe "basic validations" do
-    Session = Struct.new(:username, :email, :password, :confirm_password)
+    Session = Struct.new(:username, :email, :password, :confirm_password, :special_class)
+    SomeClass= Struct.new(:id)
 
-    class SessionForm < Reform::Form
-      include Reform::Form::Dry::Validations
+    class SessionForm < TestForm
 
       property :username
       property :email
       property :password
       property :confirm_password
+      property :special_class
 
-      validation :default do
-        key(:username).required
-        key(:email).required
+      validation do
+        required(:username).filled
+        required(:email).filled
+        required(:special_class).filled(type?: SomeClass)
       end
 
-      validation :email, if: :default do
-        key(:email).required(min_size?: 3)
+      validation name: :email, if: :default do
+        required(:email).filled(min_size?: 3)
       end
 
-      validation :nested, if: :default do
-        key(:password).required(min_size?: 2)
+      validation name: :nested, if: :default do
+        required(:password).filled(min_size?: 2)
       end
 
-      validation :confirm, if: :default, after: :email do
-        key(:confirm_password).required(min_size?: 2)
+      validation name: :confirm, if: :default, after: :email do
+        required(:confirm_password).filled(min_size?: 2)
       end
     end
 
@@ -63,6 +265,7 @@ class ValidationGroupsTest < MiniTest::Spec
     # valid.
     it do
       form.validate({ username: "Helloween",
+                      special_class: SomeClass.new(id: 15),
                       email: "yep",
                       password: "99",
                       confirm_password: "99" }).must_equal true
@@ -72,160 +275,274 @@ class ValidationGroupsTest < MiniTest::Spec
     # invalid.
     it do
       form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"], :email=>[\"is missing\"]}"
+      form.errors.messages.must_equal({:username=>["must be filled"], :email=>["must be filled"], :special_class=>["must be filled", "must be ValidationGroupsTest::SomeClass"]})
     end
 
     # partially invalid.
     # 2nd group fails.
     it do
-      form.validate(username: "Helloween", email: "yo", confirm_password:"9").must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
+      form.validate(username: "Helloween", email: "yo", confirm_password:"9", special_class: SomeClass.new(id: 15)).must_equal false
+      form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
     end
     # 3rd group fails.
     it do
-      form.validate(username: "Helloween", email: "yo!", confirm_password:"9").must_equal false
+      form.validate(username: "Helloween", email: "yo!", confirm_password:"9", special_class: SomeClass.new(id: 15)).must_equal false
       form.errors.messages.inspect
-      .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
+      .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
     end
     # 4th group with after: fails.
     it do
-      form.validate(username: "Helloween", email: "yo!", password: "", confirm_password: "9").must_equal false
-      form.errors.messages.inspect.must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
+      form.validate(username: "Helloween", email: "yo!", password: "1", confirm_password: "9", special_class: SomeClass.new(id: 15)).must_equal false
+      form.errors.messages.inspect.must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"size cannot be less than 2\"]}"
+    end
+  end
+
+  class ValidationWithOptionsTest < MiniTest::Spec
+    describe "basic validations" do
+      Session = Struct.new(:username)
+      class SessionForm < TestForm
+        property :username
+
+        validation name: :default, with: { user: OpenStruct.new(name: "Nick") } do
+          configure do
+            def users_name
+              user.name
+            end
+          end
+          required(:username).filled(eql?: users_name)
+        end
+      end
+
+      let (:form) { SessionForm.new(Session.new) }
+
+      # valid.
+      it do
+        form.validate({ username: "Nick" }).must_equal true
+        form.errors.messages.inspect.must_equal "{}"
+      end
+
+      # invalid.
+      it do
+        form.validate({ username: 'Fred'}).must_equal false
+        form.errors.messages.inspect.must_equal "{:username=>[\"must be equal to Nick\"]}"
+      end
     end
   end
 
-  describe "Nested validations" do
-    class AlbumForm < Reform::Form
-      include Reform::Form::Dry::Validations
+  #---
+  #- validation( schema: MySchema )
+  describe "with custom schema" do
+    Session2 = Struct.new(:username, :email, :password)
+
+    MySchema = Dry::Validation.Schema do
+      configure do
+        config.messages_file = 'test/fixtures/dry_error_messages.yml'
+
+        def good_musical_taste?(val)
+          val.is_a? String
+        end
+
+      end
+
+      required(:password).filled(:min_size? => 6)
+    end
+
+    class Session2Form < TestForm
+      property :username
+      property :email
+      property :password
 
+      validation schema: MySchema do
+        required(:username).filled
+        required(:email).filled(:good_musical_taste?)
+      end
+    end
+
+    let (:form) { Session2Form.new(Session2.new) }
+
+    # valid.
+    it do
+      form.validate({ username: "Helloween", email: "yep", password: "extrasafe" }).must_equal true
+      form.errors.messages.inspect.must_equal "{}"
+    end
+
+    # invalid.
+    it do
+      form.validate({}).must_equal false
+      form.errors.messages.must_equal({:password=>["must be filled", "size cannot be less than 6"], :username=>["must be filled"], :email=>["must be filled", "you're a bad person"]})
+    end
+
+    it do
+      form.validate({email: 1}).must_equal false
+      form.errors.messages.inspect.must_equal "{:password=>[\"must be filled\", \"size cannot be less than 6\"], :username=>[\"must be filled\"], :email=>[\"you're a bad person\"]}"
+    end
+  end
+
+  describe "MIXED nested validations" do
+    class AlbumForm < TestForm
       property :title
 
       property :hit do
         property :title
 
-        # FIX ME: this doesn't work now, @apotonick said he knows why
-        #  The error is that this validation block act as an AM:V instead of the Dry one.
-        # validation :default do
-        #   key(:title, &:filled?)
-        # end
+        validation do
+          required(:title).filled
+        end
       end
 
       collection :songs do
         property :title
+
+        validation do
+          required(:title).filled
+        end
+      end
+
+      # we test this one by running an each / schema dry-v check on the main block
+      collection :producers do
+        property :name
       end
 
       property :band do
         property :name
         property :label do
-          property :name
+          property :location
         end
       end
 
-      validation :default do
-
-        key(:title).required
-
-        key(:band).schema do
-          key(:name).required
-          key(:label).schema do
-            key(:name).required
-          end
-        end
-
+      validation do
         configure do
-          option :form
+          config.messages_file = "test/fixtures/dry_error_messages.yml"
           # message need to be defined on fixtures/dry_error_messages
           # d-v expects you to define your custome messages on the .yml file
           def good_musical_taste?(value)
             value != 'Nickelback'
           end
+        end
+
+        required(:title).filled(:good_musical_taste?)
 
-          def form_access_validation?(value)
-            form.title == 'Reform'
+        required(:band).schema do
+          required(:name).filled
+          required(:label).schema do
+            required(:location).filled
+          end
+        end
+
+        required(:producers).each do
+          schema do
+            required(:name).filled
           end
         end
 
-        key(:title).required(:good_musical_taste?)
-        key(:title).required(:form_access_validation?)
       end
     end
 
     let (:album) do
       OpenStruct.new(
-        :title  => "Blackhawks Over Los Angeles",
-        :hit    => song,
-        :songs  => songs,
-        :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
+        :hit    => OpenStruct.new,
+        :songs  => [OpenStruct.new, OpenStruct.new],
+        :band => Struct.new(:name, :label).new("", OpenStruct.new),
+        :producers => [OpenStruct.new, OpenStruct.new, OpenStruct.new],
       )
     end
-    let (:song)  { OpenStruct.new(:title => "Downtown") }
-    let (:songs) { [ song = OpenStruct.new(:title => "Calling"), song ] }
+
     let (:form)  { AlbumForm.new(album) }
 
-    # correct #validate.
-    it do
+    it "maps errors to form objects correctly" do
       result = form.validate(
-        "title"  => "Reform",
-        "songs"  => [
-          {"title" => "Fallout"},
-          {"title" => "Roxanne", "composer" => {"name" => "Sting"}}
-        ],
-        "band"   => {"label" => {"name" => "Epitaph"}},
+        "title"  => "Nickelback",
+        "songs"  => [ {"title" => ""}, {"title" => ""} ],
+        "band"   => {"size" => "", "label" => {"location" => ""}},
+        "producers" => [{"name" => ''}, {"name" => 'something lovely'}]
       )
 
-      result.must_equal true
-      form.errors.messages.inspect.must_equal "{}"
-    end
-  end
+      result.must_equal false
+      # from nested validation
+      form.errors.messages.must_equal({:title=>["you're a bad person"], :"hit.title"=>["must be filled"], :"songs.title"=>["must be filled"], :"producers.name"=>["must be filled"], :"band.name"=>["must be filled"], :"band.label.location"=>["must be filled"]})
+
+      # songs have their own validation.
+      form.songs[0].errors.messages.must_equal({:title=>["must be filled"]})
+      # hit got its own validation group.
+      form.hit.errors.messages.must_equal({:title=>["must be filled"]})
 
+      form.band.label.errors.messages.must_equal({:location=>["must be filled"]})
+      form.band.errors.messages.must_equal({:name=>["must be filled"], :"label.location"=>["must be filled"]})
+      form.producers[0].errors.messages.must_equal({:name=>["must be filled"]})
+
+      # TODO: use the same form structure as the top one and do the same test against messages, errors and hints.
+      form.producers[0].to_result.errors.must_equal({:name=>["must be filled"]})
+      form.producers[0].to_result.messages.must_equal({:name=>["must be filled"]})
+      form.producers[0].to_result.hints.must_equal({:name=>[]})
+    end
 
-  describe "fails with :validate, :validates and :validates_with" do
+    # FIXME: fix the "must be filled error"
 
-    it "throws a goddamn error" do
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
+    it "renders full messages correctly" do
+      result = form.validate(
+        "title"  => "",
+        "songs"  => [ {"title" => ""}, {"title" => ""} ],
+        "band"   => {"size" => "", "label" => {"name" => ""}},
+        "producers" => [{"name" => ''}, {"name" => ''}, {"name" => 'something lovely'}]
+      )
 
-          property :username
+      result.must_equal false
+      form.band.errors.full_messages.must_equal ["Name must be filled", "Label Location must be filled"]
+      form.band.label.errors.full_messages.must_equal ["Location must be filled"]
+      form.producers.first.errors.full_messages.must_equal ["Name must be filled"]
+      form.errors.full_messages.must_equal ["Title must be filled", "Title you're a bad person", "Hit Title must be filled", "Songs Title must be filled", "Producers Name must be filled", "Band Name must be filled", "Band Label Location must be filled"]
+    end
 
-          validation :email do
-            validates(:email, &:filled?)
+    describe "only 1 nested validation" do
+      class AlbumFormWith1NestedVal < TestForm
+        property :title
+        property :band do
+          property :name
+          property :label do
+            property :location
           end
         end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal 'validates() is not supported by Dry Validation backend.'
 
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
+        validation do
+          configure do
+            config.messages_file = 'test/fixtures/dry_error_messages.yml'
+          end
 
-          property :username
+          required(:title).filled
 
-          validation :email do
-            validate(:email, &:filled?)
+          required(:band).schema do
+            required(:name).filled
+            required(:label).schema do
+              required(:location).filled
+            end
           end
         end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal 'validate() is not supported by Dry Validation backend.'
+      end
 
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
+      let (:form)  { AlbumFormWith1NestedVal.new(album) }
 
-          property :username
+      it "allows to access dry's result semantics per nested form" do
+        result = form.validate(
+          "title"  => "",
+          "songs"  => [ {"title" => ""}, {"title" => ""} ],
+          "band"   => {"size" => "", "label" => {"name" => ""}},
+          "producers" => [{"name" => ''}, {"name" => ''}, {"name" => 'something lovely'}]
+        )
 
-          validation :email do
-            validates_with(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal (NoMethodError)'validates_with() is not supported by Dry Validation backend.'
+        form.to_result.errors.must_equal({:title=>["must be filled"]})
+        form.band.to_result.errors.must_equal({:name=>["must be filled"]})
+        form.band.label.to_result.errors.must_equal({:location=>["must be filled"]})
+
+        # with locale: "de"
+        form.to_result.errors(locale: :de).must_equal({:title=>["muss abgefüllt sein"]})
+        form.band.to_result.errors(locale: :de).must_equal({:name=>["muss abgefüllt sein"]})
+        form.band.label.to_result.errors(locale: :de).must_equal({:location=>["muss abgefüllt sein"]})
+      end
     end
   end
 
-
   # describe "same-named group" do
-  #   class OverwritingForm < Reform::Form
+  #   class OverwritingForm < TestForm
   #     include Reform::Form::Dry::Validations
 
   #     property :username
@@ -256,18 +573,16 @@ class ValidationGroupsTest < MiniTest::Spec
 
 
   describe "inherit: true in same group" do
-    class InheritSameGroupForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
+    class InheritSameGroupForm < TestForm
       property :username
       property :email
 
-      validation :email do
-        key(:email).required
+      validation name: :email do
+        required(:email).filled
       end
 
-      validation :email, inherit: true do # extends the above.
-        key(:username).required
+      validation name: :email, inherit: true do # extends the above.
+        required(:username).filled
       end
     end
 
@@ -281,31 +596,29 @@ class ValidationGroupsTest < MiniTest::Spec
     # invalid.
     it do
       form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"is missing\"], :username=>[\"is missing\"]}"
+      form.errors.messages.inspect.must_equal "{:email=>[\"must be filled\"], :username=>[\"must be filled\"]}"
     end
   end
 
 
   describe "if: with lambda" do
-    class IfWithLambdaForm < Reform::Form
-      include Reform::Form::Dry::Validations # ::build_errors.
-
+    class IfWithLambdaForm < TestForm
       property :username
       property :email
       property :password
 
-      validation :email do
-        key(:email).required
+      validation name: :email do
+        required(:email).filled
       end
 
       # run this is :email group is true.
-      validation :after_email, if: lambda { |results| results[:email]==true } do # extends the above.
-        key(:username).required
+      validation name: :after_email, if: lambda { |results| results[:email].success? } do # extends the above.
+        required(:username).filled
       end
 
       # block gets evaled in form instance context.
-      validation :password, if: lambda { |results| email == "john@trb.org" } do
-        key(:password).required
+      validation name: :password, if: lambda { |results| email == "john@trb.org" } do
+        required(:password).filled
       end
     end
 
@@ -319,7 +632,7 @@ class ValidationGroupsTest < MiniTest::Spec
     # invalid.
     it do
       form.validate({email: 9}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"]}"
+      form.errors.messages.inspect.must_equal "{:username=>[\"must be filled\"]}"
     end
   end
 
@@ -329,7 +642,7 @@ class ValidationGroupsTest < MiniTest::Spec
   #   more errors messages than only those that have failed.
   #
   # describe "multiple errors for property" do
-  #   class MultipleErrorsForPropertyForm < Reform::Form
+  #   class MultipleErrorsForPropertyForm < TestForm
   #     include Reform::Form::Dry::Validations
 
   #     property :username