reform 2.2.3 → 2.3.2

data/gemfiles/Gemfile.disposable-0.3

@@ -1,6 +0,0 @@
-source "http://rubygems.org"
-
-# Specify your gem's dependencies in reform.gemspec
-gemspec :path => '../'
-
-gem 'minitest'

data/lib/reform/contract/errors.rb

@@ -1,43 +0,0 @@
-class Reform::Contract::Errors
-  def initialize(*)
-    @errors = {}
-  end
-
-  module Merge
-    def merge!(errors, prefix)
-      errors.messages.each do |field, msgs|
-        unless field.to_sym == :base
-          field = (prefix+[field]).join(".").to_sym # TODO: why is that a symbol in Rails?
-        end
-
-        msgs.each do |msg|
-          next if messages[field] and messages[field].include?(msg)
-          add(field, msg)
-        end # Forms now contains a plain errors hash. the errors for each item are still available in item.errors.
-      end
-    end
-
-    def to_s
-      messages.inspect
-    end
-  end
-  include Merge
-
-  def add(field, message)
-    @errors[field] ||= []
-    @errors[field] << message
-  end
-
-  def messages
-    @errors
-  end
-
-  def empty?
-    @errors.empty?
-  end
-
-  # needed by Rails form builder.
-  def [](name)
-    @errors[name] || []
-  end
-end

data/lib/reform/form/mongoid.rb

@@ -1,37 +0,0 @@
-module Reform::Form::Mongoid
-  def self.included(base)
-    base.class_eval do
-      register_feature Reform::Form::Mongoid
-      include Reform::Form::ActiveModel
-      include Reform::Form::ORM
-      extend ClassMethods
-    end
-  end
-
-  module ClassMethods
-    def validates_uniqueness_of(attribute, options={})
-      options = options.merge(:attributes => [attribute])
-      validates_with(UniquenessValidator, options)
-    end
-    def i18n_scope
-      :mongoid
-    end
-  end
-
-
-  def self.mongoid_namespace
-    if mongoid_is_4_or_more?
-      'Validatable'
-    else
-      'Validations'
-    end
-  end
-
-  def self.mongoid_is_4_or_more?
-    Mongoid::VERSION.split('.').first.to_i >= 4
-  end
-
-  UniquenessValidator = Class.new("::Mongoid::#{mongoid_namespace}::UniquenessValidator".constantize) do
-    include Reform::Form::ORM::UniquenessValidator
-  end
-end

data/lib/reform/form/orm.rb

@@ -1,26 +0,0 @@
-module Reform::Form::ORM
-  def model_for_property(name)
-    return model unless is_a?(Reform::Form::Composition) # i am too lazy for proper inheritance. there should be a ActiveRecord::Composition that handles this.
-
-    model_name = options_for(name)[:on]
-    model[model_name]
-  end
-
-  module UniquenessValidator
-    # when calling validates it should create the Vali instance already and set @klass there! # TODO: fix this in AM.
-    def validate(form)
-      property = attributes.first
-
-      # here is the thing: why does AM::UniquenessValidator require a filled-out record to work properly? also, why do we need to set
-      # the class? it would be way easier to pass #validate a hash of attributes and get back an errors hash.
-      # the class for the finder could either be infered from the record or set in the validator instance itself in the call to ::validates.
-      record = form.model_for_property(property)
-      record.send("#{property}=", form.send(property))
-
-      @klass = record.class # this is usually done in the super-sucky #setup method.
-      super(record).tap do |res|
-        form.errors.add(property, record.errors.first.last) if record.errors.present?
-      end
-    end
-  end
-end

data/lib/reform/mongoid.rb

@@ -1,4 +0,0 @@
-require 'reform/form/active_model'
-require 'reform/form/orm'
-require 'reform/form/mongoid'
-require 'reform/form/active_model/model_reflections' # only load this in AR context as simple_form currently is bound to AR.

data/test/deprecation_test.rb

@@ -1,27 +0,0 @@
-require "test_helper"
-
-
-class DeprecationRemoveMePopulatorTest < MiniTest::Spec
-  Album = Struct.new(:songs)
-  Song  = Struct.new(:title)
-
-
-  class AlbumForm < Reform::Form
-    collection :songs, populator: ->(fragment, collection, index, *) { return Representable::Pipeline::Stop if fragment[:title]=="Good"
-      songs[index]
-              } do
-      property :title
-    end
-  end
-
-  it do
-    form = AlbumForm.new(Album.new([Song.new, Song.new]))
-    hash = {songs: [{title: "Good"}, {title: "Bad"}]}
-
-    form.validate(hash)
-
-    form.songs.size.must_equal 2
-    form.songs[0].title.must_equal nil
-    form.songs[1].title.must_equal "Bad"
-  end
-end

data/test/errors_test.rb

@@ -1,165 +0,0 @@
-# require "test_helper"
-
-# class ErrorsTest < MiniTest::Spec
-#   class AlbumForm < Reform::Form
-#     property :title
-
-#     property :hit do
-#       property :title
-#       validation do
-#         key(:title).required
-#       end
-#     end
-
-#     collection :songs do
-#       property :title
-#       validation do
-#         key(:title).required
-#       end
-#     end
-
-#     property :band do # yepp, people do crazy stuff like that.
-#       property :name
-#       property :label do
-#         property :name
-#         validation do
-#           key(:name).required
-#         end
-#       end
-#       # TODO: make band a required object.
-
-#       validation do
-#         key(:name).required(:music_taste_ok?)
-
-#         configure do
-#           config.messages_file = "test/validation/errors.yml"
-
-#           def music_taste_ok?(value)
-#             value != "Nickelback"
-#             # errors.add(:base, "You are a bad person") if name == "Nickelback"
-#           end
-#         end
-#       end
-#       # validate :music_taste_ok?
-
-#     # private
-#     #   def music_taste_ok?
-#     #     errors.add(:base, "You are a bad person") if name == "Nickelback"
-#     #   end
-#     end
-
-#     validation do
-#       key(:title).required
-#     end
-#   end
-
-#   let (:album) do
-#     OpenStruct.new(
-#       :title  => "Blackhawks Over Los Angeles",
-#       :hit    => song,
-#       :songs  => songs, # TODO: document this requirement,
-
-#       :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
-#     )
-#   end
-#   let (:song)  { OpenStruct.new(:title => "Downtown") }
-#   let (:songs) { [song=OpenStruct.new(:title => "Calling"), song] }
-#   let (:form)  { AlbumForm.new(album) }
-
-
-#   describe "incorrect #validate" do
-#     before { form.validate(
-#       "hit"   =>{"title" => ""},
-#       "title" => "",
-#       "songs" => [{"title" => ""}, {"title" => ""}]) } # FIXME: what happens if item is missing?
-
-#     it do
-#       form.errors.messages.must_equal({
-#         :title  => ["must be filled"],
-#         :"hit.title"=>["must be filled"],
-#         :"songs.title"=>["must be filled"],
-#         :"band.label.name"=>["is missing"]
-#       })
-#     end
-
-#     it do
-#       #form.errors.must_equal({:title  => ["must be filled"]})
-#       # TODO: this should only contain local errors?
-#     end
-
-#     # nested forms keep their own Errors:
-#     it { form.hit.errors.messages.must_equal({:title=>["must be filled"]}) }
-#     it { form.songs[0].errors.messages.must_equal({:title=>["must be filled"]}) }
-
-#     it do
-#       form.errors.messages.must_equal({
-#         :title        => ["must be filled"],
-#         :"hit.title"  => ["must be filled"],
-#         :"songs.title"=> ["must be filled"],
-#         :"band.label.name"=>["is missing"]
-#       })
-#     end
-#   end
-
-
-#   describe "#validate with main form invalid" do
-#     it do
-#       form.validate("title"=>"", "band"=>{"label"=>{:name => "Fat Wreck"}}).must_equal false
-#       form.errors.messages.must_equal({:title=>["must be filled"]})
-#     end
-#   end
-
-
-#   describe "#validate with middle nested form invalid" do
-#     before { @result = form.validate("hit"=>{"title" => ""}, "band"=>{"label"=>{:name => "Fat Wreck"}}) }
-
-#     it { @result.must_equal false }
-#     it { form.errors.messages.must_equal({:"hit.title"=>["must be filled"]}) }
-#   end
-
-
-#   describe "#validate with collection form invalid" do
-#     before { @result = form.validate("songs"=>[{"title" => ""}], "band"=>{"label"=>{:name => "Fat Wreck"}}) }
-
-#     it { @result.must_equal false }
-#     it { form.errors.messages.must_equal({:"songs.title"=>["must be filled"]}) }
-#   end
-
-
-#   describe "#validate with collection and 2-level-nested invalid" do
-#     before { @result = form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}}) }
-
-#     it { @result.must_equal false }
-#     it { form.errors.messages.must_equal({:"songs.title"=>["must be filled"], :"band.label.name"=>["is missing"]}) }
-#   end
-
-#   describe "#validate with nested form using :base invalid" do
-#     it do
-#       result = form.validate("songs"=>[{"title" => "Someday"}], "band" => {"name" => "Nickelback", "label" => {"name" => "Roadrunner Records"}})
-#       result.must_equal false
-#       form.errors.messages.must_equal({:"band.name"=>["You are a bad person"]})
-#     end
-#   end
-
-#   describe "correct #validate" do
-#     before { @result = form.validate(
-#       "hit"   => {"title" => "Sacrifice"},
-#       "title" => "Second Heat",
-#       "songs" => [{"title"=>"Heart Of A Lion"}],
-#       "band"  => {"label"=>{:name => "Fat Wreck"}}
-#       ) }
-
-#     it { @result.must_equal true }
-#     it { form.hit.title.must_equal "Sacrifice" }
-#     it { form.title.must_equal "Second Heat" }
-#     it { form.songs.first.title.must_equal "Heart Of A Lion" }
-#   end
-
-
-#   describe "Errors#to_s" do
-#     before { form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}}) }
-
-#     # to_s is aliased to messages
-#     it { form.errors.to_s.must_equal "{:\"songs.title\"=>[\"must be filled\"], :\"band.label.name\"=>[\"is missing\"]}" }
-#   end
-# end

data/test/inherit_test.rb

@@ -1,119 +0,0 @@
-require 'test_helper'
-require 'representable/json'
-
-class InheritTest < BaseTest
-  Populator = Reform::Form::Populator
-
-  class AlbumForm < Reform::Form
-    property :title, deserializer: {instance: "Instance"}, skip_if: "skip_if in AlbumForm" # allow direct configuration of :deserializer.
-
-    property :hit, populator: "Populator" do
-      property :title
-    end
-
-    collection :songs, populate_if_empty: lambda {}, skip_if: :all_blank do
-      property :title
-    end
-
-    property :artist, populate_if_empty: lambda {} do
-
-      def artist_id
-        1
-      end
-    end
-  end
-
-  puts
-  puts "inherit"
-
-  class CompilationForm < AlbumForm
-    property :title, inherit: true, skip_if: "skip_if from CompilationForm"
-    puts "[#{options_for(:title)[:deserializer].object_id}] COM@@@@@ #{options_for(:title)[:deserializer].inspect}"
-    # property :hit, :inherit => true do
-    #   property :rating
-    #   validates :title, :rating, :presence => true
-    # end
-
-    # puts representer_class.representable_attrs.
-    #   get(:hit)[:extend].evaluate(nil).new(OpenStruct.new).rating
-
-    # NO collection here, this is entirely inherited.
-    # collection :songs, ..
-
-    property :artist, inherit: true do # inherit everything, but explicitely.
-    end
-
-    # completely override.
-    property :hit, skip_if: "SkipParse" do
-    end
-
-    # override partly.
-  end
-
-  let (:album) { Album.new(nil, OpenStruct.new(:hit => OpenStruct.new()) ) }
-  subject { CompilationForm.new(album) }
-
-
-  # valid.
-  # it {
-  #   subject.validate("hit" => {"title" => "LA Drone", "rating" => 10})
-  #   subject.hit.title.must_equal "LA Drone"
-  #   subject.hit.rating.must_equal 10
-  #   subject.errors.messages.must_equal({})
-  # }
-
-  # it do
-  #   subject.validate({})
-  #   subject.hit.title.must_equal nil
-  #   subject.hit.rating.must_equal nil
-  #   subject.errors.messages.must_equal({:"hit.title"=>["can't be blank"], :"hit.rating"=>["can't be blank"]})
-  # end
-
-require "pp"
-
-  it "xxx" do
-    # sub hashes like :deserializer must be properly cloned when inheriting.
-    AlbumForm.options_for(:title)[:deserializer].object_id.wont_equal CompilationForm.options_for(:title)[:deserializer].object_id
-
-    # don't overwrite direct deserializer: {} configuration.
-    AlbumForm.options_for(:title)[:internal_populator].must_be_instance_of Reform::Form::Populator::Sync
-    AlbumForm.options_for(:title)[:deserializer][:skip_parse].must_equal "skip_if in AlbumForm"
-
-    AlbumForm.options_for(:hit)[:internal_populator].inspect.must_match /Reform::Form::Populator:.+ @user_proc="Populator"/
-    # AlbumForm.options_for(:hit)[:deserializer][:instance].inspect.must_be_instance_with Reform::Form::Populator, user_proc: "Populator"
-
-
-    AlbumForm.options_for(:songs)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-    AlbumForm.options_for(:songs)[:deserializer][:skip_parse].must_be_instance_of Reform::Form::Validate::Skip::AllBlank
-
-    AlbumForm.options_for(:artist)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-
-
-
-    CompilationForm.options_for(:title)[:deserializer][:skip_parse].must_equal "skip_if from CompilationForm"
-    # pp CompilationForm.options_for(:songs)
-    CompilationForm.options_for(:songs)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-
-
-    CompilationForm.options_for(:artist)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-
-    # completely overwrite inherited.
-    CompilationForm.options_for(:hit)[:internal_populator].must_be_instance_of Reform::Form::Populator::Sync # reset to default.
-    CompilationForm.options_for(:hit)[:deserializer][:skip_parse].must_equal "SkipParse"
-
-
-    # inherit: true with block will still inherit the original class.
-    AlbumForm.new(OpenStruct.new(artist: OpenStruct.new)).artist.artist_id.must_equal 1
-    CompilationForm.new(OpenStruct.new(artist: OpenStruct.new)).artist.artist_id.must_equal 1
-  end
-
-
-  class CDForm < AlbumForm
-    # override :artist's original populate_if_empty but with :inherit.
-    property :artist, inherit: true, populator: "CD Populator" do
-
-    end
-  end
-
-  it { CDForm.options_for(:artist)[:internal_populator].instance_variable_get(:@user_proc).must_equal "CD Populator" }
-end

data/test/readonly_test.rb

@@ -1,14 +0,0 @@
-require "test_helper"
-
-class ReadonlyTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    property :artist
-    property :title, writeable: false
-    # TODO: what to do with virtual values?
-  end
-
-  let (:form) { SongForm.new(OpenStruct.new) }
-
-  it { form.readonly?(:artist).must_equal false }
-  it { form.readonly?(:title).must_equal true }
-end