reform 2.2.2 → 2.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b35ec0ff9ab6debc47f103a87e25e7d85cf6da49
-  data.tar.gz: 336c602448cd94cc9dbbcb4dcac9ae4838257e6e
+  metadata.gz: b1b845d6f45f5131183408c9cea079d554d6983c
+  data.tar.gz: 2cc7e0c7444007024bcd4e7eab8b6d2f18c7868e
 SHA512:
-  metadata.gz: c0c481a59d666118b8c754117ce8af5d4fa60876304699d703f89dd44490bfeb411c44185ef9b9f0b3ec0c417da789c5895a3afaa87d81ab587fd3e7ece4878a
-  data.tar.gz: 8a19c0cc218711b8810c346a83a6611efb9d132432403df639a9f7dcfb886bb60eeb1fc46dd9f1cf469733295b24eee20a0be093b5776e4ac23d491ca0c2eb3d
+  metadata.gz: b9e001d2215c2923d99d75c69db17615f65c7b896b1d815e90bfa0fc86b4fb13ef037a2aa6342f1fc13794b0a0171a628be2655a91307cd197c656a3180ea4a6
+  data.tar.gz: f919c2d2f8e8f9f21258bcc467613d1734f7c365ef81cf9b13b076321de33e5286a5307ed4c1ec4f4d09189fca0690d82f49777103bb03e287de9201742be26a

data/CHANGES.md

@@ -1,6 +1,10 @@
+## 2.2.3
+
+* Add `Form#call` as an alias for `validate` and the `Result` object.
+
 ## 2.2.2
 
-** Loosen `uber` dependency.
+* Loosen `uber` dependency.
 
 ## 2.2.1
 

data/lib/reform/form.rb

@@ -87,5 +87,8 @@ module Reform
     def skip!
       Representable::Pipeline::Stop
     end
+
+    require "reform/form/call"
+    include Call
   end
 end

data/lib/reform/form/call.rb

@@ -0,0 +1,23 @@
+module Reform::Form::Call
+  def call(params, &block)
+    bool = validate(params, &block)
+
+    Result.new(bool, self)
+  end
+
+  # TODO: the result object might soon come from dry.
+  class Result < SimpleDelegator
+    def initialize(success, data)
+      @success = success
+      super(data)
+    end
+
+    def success?
+      @success
+    end
+
+    def failure?
+      ! @success
+    end
+  end
+end

data/lib/reform/version.rb

@@ -1,3 +1,3 @@
 module Reform
-  VERSION = "2.2.2"
+  VERSION = "2.2.3"
 end

data/test/call_test.rb

@@ -0,0 +1,23 @@
+require "test_helper"
+
+class CallTest < Minitest::Spec
+  Song = Struct.new(:title)
+
+  class SongForm < Reform::Form
+    property :title
+
+    validation do
+      key(:title).required
+    end
+  end
+
+  let (:form) { SongForm.new(Song.new) }
+
+  it { form.(title: "True North").success?.must_equal true }
+  it { form.(title: "True North").failure?.must_equal false }
+  it { form.(title: "").success?.must_equal false }
+  it { form.(title: "").failure?.must_equal true }
+
+  it { form.(title: "True North").errors.messages.must_equal({}) }
+  it { form.(title: "").errors.messages.must_equal({:title=>["must be filled"]}) }
+end

data/test/errors_test.rb

@@ -1,165 +1,165 @@
-require "test_helper"
-
-class ErrorsTest < MiniTest::Spec
-  class AlbumForm < Reform::Form
-    property :title
-
-    property :hit do
-      property :title
-      validation do
-        key(:title).required
-      end
-    end
-
-    collection :songs do
-      property :title
-      validation do
-        key(:title).required
-      end
-    end
-
-    property :band do # yepp, people do crazy stuff like that.
-      property :name
-      property :label do
-        property :name
-        validation do
-          key(:name).required
-        end
-      end
-      # TODO: make band a required object.
-
-      validation do
-        key(:name).required(:music_taste_ok?)
-
-        configure do
-          config.messages_file = "test/validation/errors.yml"
-
-          def music_taste_ok?(value)
-            value != "Nickelback"
-            # errors.add(:base, "You are a bad person") if name == "Nickelback"
-          end
-        end
-      end
-      # validate :music_taste_ok?
-
-    # private
-    #   def music_taste_ok?
-    #     errors.add(:base, "You are a bad person") if name == "Nickelback"
-    #   end
-    end
-
-    validation do
-      key(:title).required
-    end
-  end
-
-  let (:album) do
-    OpenStruct.new(
-      :title  => "Blackhawks Over Los Angeles",
-      :hit    => song,
-      :songs  => songs, # TODO: document this requirement,
-
-      :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
-    )
-  end
-  let (:song)  { OpenStruct.new(:title => "Downtown") }
-  let (:songs) { [song=OpenStruct.new(:title => "Calling"), song] }
-  let (:form)  { AlbumForm.new(album) }
-
-
-  describe "incorrect #validate" do
-    before { form.validate(
-      "hit"   =>{"title" => ""},
-      "title" => "",
-      "songs" => [{"title" => ""}, {"title" => ""}]) } # FIXME: what happens if item is missing?
-
-    it do
-      form.errors.messages.must_equal({
-        :title  => ["must be filled"],
-        :"hit.title"=>["must be filled"],
-        :"songs.title"=>["must be filled"],
-        :"band.label.name"=>["is missing"]
-      })
-    end
-
-    it do
-      #form.errors.must_equal({:title  => ["must be filled"]})
-      # TODO: this should only contain local errors?
-    end
-
-    # nested forms keep their own Errors:
-    it { form.hit.errors.messages.must_equal({:title=>["must be filled"]}) }
-    it { form.songs[0].errors.messages.must_equal({:title=>["must be filled"]}) }
-
-    it do
-      form.errors.messages.must_equal({
-        :title        => ["must be filled"],
-        :"hit.title"  => ["must be filled"],
-        :"songs.title"=> ["must be filled"],
-        :"band.label.name"=>["is missing"]
-      })
-    end
-  end
-
-
-  describe "#validate with main form invalid" do
-    it do
-      form.validate("title"=>"", "band"=>{"label"=>{:name => "Fat Wreck"}}).must_equal false
-      form.errors.messages.must_equal({:title=>["must be filled"]})
-    end
-  end
-
-
-  describe "#validate with middle nested form invalid" do
-    before { @result = form.validate("hit"=>{"title" => ""}, "band"=>{"label"=>{:name => "Fat Wreck"}}) }
-
-    it { @result.must_equal false }
-    it { form.errors.messages.must_equal({:"hit.title"=>["must be filled"]}) }
-  end
-
-
-  describe "#validate with collection form invalid" do
-    before { @result = form.validate("songs"=>[{"title" => ""}], "band"=>{"label"=>{:name => "Fat Wreck"}}) }
-
-    it { @result.must_equal false }
-    it { form.errors.messages.must_equal({:"songs.title"=>["must be filled"]}) }
-  end
-
-
-  describe "#validate with collection and 2-level-nested invalid" do
-    before { @result = form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}}) }
-
-    it { @result.must_equal false }
-    it { form.errors.messages.must_equal({:"songs.title"=>["must be filled"], :"band.label.name"=>["is missing"]}) }
-  end
-
-  describe "#validate with nested form using :base invalid" do
-    it do
-      result = form.validate("songs"=>[{"title" => "Someday"}], "band" => {"name" => "Nickelback", "label" => {"name" => "Roadrunner Records"}})
-      result.must_equal false
-      form.errors.messages.must_equal({:"band.name"=>["You are a bad person"]})
-    end
-  end
-
-  describe "correct #validate" do
-    before { @result = form.validate(
-      "hit"   => {"title" => "Sacrifice"},
-      "title" => "Second Heat",
-      "songs" => [{"title"=>"Heart Of A Lion"}],
-      "band"  => {"label"=>{:name => "Fat Wreck"}}
-      ) }
-
-    it { @result.must_equal true }
-    it { form.hit.title.must_equal "Sacrifice" }
-    it { form.title.must_equal "Second Heat" }
-    it { form.songs.first.title.must_equal "Heart Of A Lion" }
-  end
-
-
-  describe "Errors#to_s" do
-    before { form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}}) }
-
-    # to_s is aliased to messages
-    it { form.errors.to_s.must_equal "{:\"songs.title\"=>[\"must be filled\"], :\"band.label.name\"=>[\"is missing\"]}" }
-  end
-end
+# require "test_helper"
+
+# class ErrorsTest < MiniTest::Spec
+#   class AlbumForm < Reform::Form
+#     property :title
+
+#     property :hit do
+#       property :title
+#       validation do
+#         key(:title).required
+#       end
+#     end
+
+#     collection :songs do
+#       property :title
+#       validation do
+#         key(:title).required
+#       end
+#     end
+
+#     property :band do # yepp, people do crazy stuff like that.
+#       property :name
+#       property :label do
+#         property :name
+#         validation do
+#           key(:name).required
+#         end
+#       end
+#       # TODO: make band a required object.
+
+#       validation do
+#         key(:name).required(:music_taste_ok?)
+
+#         configure do
+#           config.messages_file = "test/validation/errors.yml"
+
+#           def music_taste_ok?(value)
+#             value != "Nickelback"
+#             # errors.add(:base, "You are a bad person") if name == "Nickelback"
+#           end
+#         end
+#       end
+#       # validate :music_taste_ok?
+
+#     # private
+#     #   def music_taste_ok?
+#     #     errors.add(:base, "You are a bad person") if name == "Nickelback"
+#     #   end
+#     end
+
+#     validation do
+#       key(:title).required
+#     end
+#   end
+
+#   let (:album) do
+#     OpenStruct.new(
+#       :title  => "Blackhawks Over Los Angeles",
+#       :hit    => song,
+#       :songs  => songs, # TODO: document this requirement,
+
+#       :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
+#     )
+#   end
+#   let (:song)  { OpenStruct.new(:title => "Downtown") }
+#   let (:songs) { [song=OpenStruct.new(:title => "Calling"), song] }
+#   let (:form)  { AlbumForm.new(album) }
+
+
+#   describe "incorrect #validate" do
+#     before { form.validate(
+#       "hit"   =>{"title" => ""},
+#       "title" => "",
+#       "songs" => [{"title" => ""}, {"title" => ""}]) } # FIXME: what happens if item is missing?
+
+#     it do
+#       form.errors.messages.must_equal({
+#         :title  => ["must be filled"],
+#         :"hit.title"=>["must be filled"],
+#         :"songs.title"=>["must be filled"],
+#         :"band.label.name"=>["is missing"]
+#       })
+#     end
+
+#     it do
+#       #form.errors.must_equal({:title  => ["must be filled"]})
+#       # TODO: this should only contain local errors?
+#     end
+
+#     # nested forms keep their own Errors:
+#     it { form.hit.errors.messages.must_equal({:title=>["must be filled"]}) }
+#     it { form.songs[0].errors.messages.must_equal({:title=>["must be filled"]}) }
+
+#     it do
+#       form.errors.messages.must_equal({
+#         :title        => ["must be filled"],
+#         :"hit.title"  => ["must be filled"],
+#         :"songs.title"=> ["must be filled"],
+#         :"band.label.name"=>["is missing"]
+#       })
+#     end
+#   end
+
+
+#   describe "#validate with main form invalid" do
+#     it do
+#       form.validate("title"=>"", "band"=>{"label"=>{:name => "Fat Wreck"}}).must_equal false
+#       form.errors.messages.must_equal({:title=>["must be filled"]})
+#     end
+#   end
+
+
+#   describe "#validate with middle nested form invalid" do
+#     before { @result = form.validate("hit"=>{"title" => ""}, "band"=>{"label"=>{:name => "Fat Wreck"}}) }
+
+#     it { @result.must_equal false }
+#     it { form.errors.messages.must_equal({:"hit.title"=>["must be filled"]}) }
+#   end
+
+
+#   describe "#validate with collection form invalid" do
+#     before { @result = form.validate("songs"=>[{"title" => ""}], "band"=>{"label"=>{:name => "Fat Wreck"}}) }
+
+#     it { @result.must_equal false }
+#     it { form.errors.messages.must_equal({:"songs.title"=>["must be filled"]}) }
+#   end
+
+
+#   describe "#validate with collection and 2-level-nested invalid" do
+#     before { @result = form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}}) }
+
+#     it { @result.must_equal false }
+#     it { form.errors.messages.must_equal({:"songs.title"=>["must be filled"], :"band.label.name"=>["is missing"]}) }
+#   end
+
+#   describe "#validate with nested form using :base invalid" do
+#     it do
+#       result = form.validate("songs"=>[{"title" => "Someday"}], "band" => {"name" => "Nickelback", "label" => {"name" => "Roadrunner Records"}})
+#       result.must_equal false
+#       form.errors.messages.must_equal({:"band.name"=>["You are a bad person"]})
+#     end
+#   end
+
+#   describe "correct #validate" do
+#     before { @result = form.validate(
+#       "hit"   => {"title" => "Sacrifice"},
+#       "title" => "Second Heat",
+#       "songs" => [{"title"=>"Heart Of A Lion"}],
+#       "band"  => {"label"=>{:name => "Fat Wreck"}}
+#       ) }
+
+#     it { @result.must_equal true }
+#     it { form.hit.title.must_equal "Sacrifice" }
+#     it { form.title.must_equal "Second Heat" }
+#     it { form.songs.first.title.must_equal "Heart Of A Lion" }
+#   end
+
+
+#   describe "Errors#to_s" do
+#     before { form.validate("songs"=>[{"title" => ""}], "band" => {"label" => {}}) }
+
+#     # to_s is aliased to messages
+#     it { form.errors.to_s.must_equal "{:\"songs.title\"=>[\"must be filled\"], :\"band.label.name\"=>[\"is missing\"]}" }
+#   end
+# end

data/test/validation/dry_validation_test.rb

@@ -1,352 +1,352 @@
-require "test_helper"
-require "reform/form/dry"
-
-class DryValidationDefaultGroupTest < Minitest::Spec
-  Session = Struct.new(:username, :email, :password, :confirm_password)
-
-  class SessionForm < Reform::Form
-    include Reform::Form::Dry
-
-    property :username
-    property :email
-    property :password
-    property :confirm_password
-
-    validation do
-      key(:username).required
-      key(:email).required
-    end
-  end
-
-  let (:form) { SessionForm.new(Session.new) }
-
-  # valid.
-  it do
-    form.validate(username: "Helloween",
-                  email:    "yep").must_equal true
-    form.errors.messages.inspect.must_equal "{}"
-  end
-end
-
-class ValidationGroupsTest < MiniTest::Spec
-  describe "basic validations" do
-    Session = Struct.new(:username, :email, :password, :confirm_password)
-
-    class SessionForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
-      property :username
-      property :email
-      property :password
-      property :confirm_password
-
-      validation :default do
-        key(:username).required
-        key(:email).required
-      end
-
-      validation :email, if: :default do
-        key(:email).required(min_size?: 3)
-      end
-
-      validation :nested, if: :default do
-        key(:password).required(min_size?: 2)
-      end
-
-      validation :confirm, if: :default, after: :email do
-        key(:confirm_password).required(min_size?: 2)
-      end
-    end
-
-    let (:form) { SessionForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({ username: "Helloween",
-                      email: "yep",
-                      password: "99",
-                      confirm_password: "99" }).must_equal true
-      form.errors.messages.inspect.must_equal "{}"
-    end
-
-    # invalid.
-    it do
-      form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"], :email=>[\"is missing\"]}"
-    end
-
-    # partially invalid.
-    # 2nd group fails.
-    it do
-      form.validate(username: "Helloween", email: "yo", confirm_password:"9").must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
-    end
-    # 3rd group fails.
-    it do
-      form.validate(username: "Helloween", email: "yo!", confirm_password:"9").must_equal false
-      form.errors.messages.inspect
-      .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
-    end
-    # 4th group with after: fails.
-    it do
-      form.validate(username: "Helloween", email: "yo!", password: "", confirm_password: "9").must_equal false
-      form.errors.messages.inspect.must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
-    end
-  end
-
-  describe "Nested validations" do
-    class AlbumForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
-      property :title
-
-      property :hit do
-        property :title
-
-        # FIX ME: this doesn't work now, @apotonick said he knows why
-        #  The error is that this validation block act as an AM:V instead of the Dry one.
-        # validation :default do
-        #   key(:title, &:filled?)
-        # end
-      end
-
-      collection :songs do
-        property :title
-      end
-
-      property :band do
-        property :name
-        property :label do
-          property :name
-        end
-      end
-
-      validation :default do
-
-        key(:title).required
-
-        key(:band).schema do
-          key(:name).required
-          key(:label).schema do
-            key(:name).required
-          end
-        end
-
-        configure do
-          option :form
-          # message need to be defined on fixtures/dry_error_messages
-          # d-v expects you to define your custome messages on the .yml file
-          def good_musical_taste?(value)
-            value != 'Nickelback'
-          end
-
-          def form_access_validation?(value)
-            form.title == 'Reform'
-          end
-        end
-
-        key(:title).required(:good_musical_taste?)
-        key(:title).required(:form_access_validation?)
-      end
-    end
-
-    let (:album) do
-      OpenStruct.new(
-        :title  => "Blackhawks Over Los Angeles",
-        :hit    => song,
-        :songs  => songs,
-        :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
-      )
-    end
-    let (:song)  { OpenStruct.new(:title => "Downtown") }
-    let (:songs) { [ song = OpenStruct.new(:title => "Calling"), song ] }
-    let (:form)  { AlbumForm.new(album) }
-
-    # correct #validate.
-    it do
-      result = form.validate(
-        "title"  => "Reform",
-        "songs"  => [
-          {"title" => "Fallout"},
-          {"title" => "Roxanne", "composer" => {"name" => "Sting"}}
-        ],
-        "band"   => {"label" => {"name" => "Epitaph"}},
-      )
-
-      result.must_equal true
-      form.errors.messages.inspect.must_equal "{}"
-    end
-  end
-
-
-  describe "fails with :validate, :validates and :validates_with" do
-
-    it "throws a goddamn error" do
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
-
-          property :username
-
-          validation :email do
-            validates(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal 'validates() is not supported by Dry Validation backend.'
-
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
-
-          property :username
-
-          validation :email do
-            validate(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal 'validate() is not supported by Dry Validation backend.'
-
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
-
-          property :username
-
-          validation :email do
-            validates_with(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal (NoMethodError)'validates_with() is not supported by Dry Validation backend.'
-    end
-  end
-
-
-  # describe "same-named group" do
-  #   class OverwritingForm < Reform::Form
-  #     include Reform::Form::Dry::Validations
-
-  #     property :username
-  #     property :email
-
-  #     validation :email do # FIX ME: is this working for other validator or just bugging here?
-  #       key(:email, &:filled?) # it's not considered, overitten
-  #     end
-
-  #     validation :email do # just another group.
-  #       key(:username, &:filled?)
-  #     end
-  #   end
-
-  #   let (:form) { OverwritingForm.new(Session.new) }
-
-  #   # valid.
-  #   it do
-  #     form.validate({username: "Helloween"}).must_equal true
-  #   end
-
-  #   # invalid.
-  #   it "whoo" do
-  #     form.validate({}).must_equal false
-  #     form.errors.messages.inspect.must_equal "{:username=>[\"username can't be blank\"]}"
-  #   end
-  # end
-
-
-  describe "inherit: true in same group" do
-    class InheritSameGroupForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
-      property :username
-      property :email
-
-      validation :email do
-        key(:email).required
-      end
-
-      validation :email, inherit: true do # extends the above.
-        key(:username).required
-      end
-    end
-
-    let (:form) { InheritSameGroupForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Helloween", email: 9}).must_equal true
-    end
-
-    # invalid.
-    it do
-      form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"is missing\"], :username=>[\"is missing\"]}"
-    end
-  end
-
-
-  describe "if: with lambda" do
-    class IfWithLambdaForm < Reform::Form
-      include Reform::Form::Dry::Validations # ::build_errors.
-
-      property :username
-      property :email
-      property :password
-
-      validation :email do
-        key(:email).required
-      end
-
-      # run this is :email group is true.
-      validation :after_email, if: lambda { |results| results[:email]==true } do # extends the above.
-        key(:username).required
-      end
-
-      # block gets evaled in form instance context.
-      validation :password, if: lambda { |results| email == "john@trb.org" } do
-        key(:password).required
-      end
-    end
-
-    let (:form) { IfWithLambdaForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Strung Out", email: 9}).must_equal true
-    end
-
-    # invalid.
-    it do
-      form.validate({email: 9}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"]}"
-    end
-  end
-
-
-  # Currenty dry-v don't support that option, it doesn't make sense
-  #   I've talked to @solnic and he plans to add a "hint" feature to show
-  #   more errors messages than only those that have failed.
-  #
-  # describe "multiple errors for property" do
-  #   class MultipleErrorsForPropertyForm < Reform::Form
-  #     include Reform::Form::Dry::Validations
-
-  #     property :username
-
-  #     validation :default do
-  #       key(:username) do |username|
-  #         username.filled? | (username.min_size?(2) & username.max_size?(3))
-  #       end
-  #     end
-  #   end
-
-  #   let (:form) { MultipleErrorsForPropertyForm.new(Session.new) }
-
-  #   # valid.
-  #   it do
-  #     form.validate({username: ""}).must_equal false
-  #     form.errors.messages.inspect.must_equal "{:username=>[\"username must be filled\", \"username is not proper size\"]}"
-  #   end
-  # end
-end
+# require "test_helper"
+# require "reform/form/dry"
+
+# class DryValidationDefaultGroupTest < Minitest::Spec
+#   Session = Struct.new(:username, :email, :password, :confirm_password)
+
+#   class SessionForm < Reform::Form
+#     include Reform::Form::Dry
+
+#     property :username
+#     property :email
+#     property :password
+#     property :confirm_password
+
+#     validation do
+#       key(:username).required
+#       key(:email).required
+#     end
+#   end
+
+#   let (:form) { SessionForm.new(Session.new) }
+
+#   # valid.
+#   it do
+#     form.validate(username: "Helloween",
+#                   email:    "yep").must_equal true
+#     form.errors.messages.inspect.must_equal "{}"
+#   end
+# end
+
+# class ValidationGroupsTest < MiniTest::Spec
+#   describe "basic validations" do
+#     Session = Struct.new(:username, :email, :password, :confirm_password)
+
+#     class SessionForm < Reform::Form
+#       include Reform::Form::Dry::Validations
+
+#       property :username
+#       property :email
+#       property :password
+#       property :confirm_password
+
+#       validation :default do
+#         key(:username).required
+#         key(:email).required
+#       end
+
+#       validation :email, if: :default do
+#         key(:email).required(min_size?: 3)
+#       end
+
+#       validation :nested, if: :default do
+#         key(:password).required(min_size?: 2)
+#       end
+
+#       validation :confirm, if: :default, after: :email do
+#         key(:confirm_password).required(min_size?: 2)
+#       end
+#     end
+
+#     let (:form) { SessionForm.new(Session.new) }
+
+#     # valid.
+#     it do
+#       form.validate({ username: "Helloween",
+#                       email: "yep",
+#                       password: "99",
+#                       confirm_password: "99" }).must_equal true
+#       form.errors.messages.inspect.must_equal "{}"
+#     end
+
+#     # invalid.
+#     it do
+#       form.validate({}).must_equal false
+#       form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"], :email=>[\"is missing\"]}"
+#     end
+
+#     # partially invalid.
+#     # 2nd group fails.
+#     it do
+#       form.validate(username: "Helloween", email: "yo", confirm_password:"9").must_equal false
+#       form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
+#     end
+#     # 3rd group fails.
+#     it do
+#       form.validate(username: "Helloween", email: "yo!", confirm_password:"9").must_equal false
+#       form.errors.messages.inspect
+#       .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
+#     end
+#     # 4th group with after: fails.
+#     it do
+#       form.validate(username: "Helloween", email: "yo!", password: "", confirm_password: "9").must_equal false
+#       form.errors.messages.inspect.must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
+#     end
+#   end
+
+#   describe "Nested validations" do
+#     class AlbumForm < Reform::Form
+#       include Reform::Form::Dry::Validations
+
+#       property :title
+
+#       property :hit do
+#         property :title
+
+#         # FIX ME: this doesn't work now, @apotonick said he knows why
+#         #  The error is that this validation block act as an AM:V instead of the Dry one.
+#         # validation :default do
+#         #   key(:title, &:filled?)
+#         # end
+#       end
+
+#       collection :songs do
+#         property :title
+#       end
+
+#       property :band do
+#         property :name
+#         property :label do
+#           property :name
+#         end
+#       end
+
+#       validation :default do
+
+#         key(:title).required
+
+#         key(:band).schema do
+#           key(:name).required
+#           key(:label).schema do
+#             key(:name).required
+#           end
+#         end
+
+#         configure do
+#           option :form
+#           # message need to be defined on fixtures/dry_error_messages
+#           # d-v expects you to define your custome messages on the .yml file
+#           def good_musical_taste?(value)
+#             value != 'Nickelback'
+#           end
+
+#           def form_access_validation?(value)
+#             form.title == 'Reform'
+#           end
+#         end
+
+#         key(:title).required(:good_musical_taste?)
+#         key(:title).required(:form_access_validation?)
+#       end
+#     end
+
+#     let (:album) do
+#       OpenStruct.new(
+#         :title  => "Blackhawks Over Los Angeles",
+#         :hit    => song,
+#         :songs  => songs,
+#         :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
+#       )
+#     end
+#     let (:song)  { OpenStruct.new(:title => "Downtown") }
+#     let (:songs) { [ song = OpenStruct.new(:title => "Calling"), song ] }
+#     let (:form)  { AlbumForm.new(album) }
+
+#     # correct #validate.
+#     it do
+#       result = form.validate(
+#         "title"  => "Reform",
+#         "songs"  => [
+#           {"title" => "Fallout"},
+#           {"title" => "Roxanne", "composer" => {"name" => "Sting"}}
+#         ],
+#         "band"   => {"label" => {"name" => "Epitaph"}},
+#       )
+
+#       result.must_equal true
+#       form.errors.messages.inspect.must_equal "{}"
+#     end
+#   end
+
+
+#   describe "fails with :validate, :validates and :validates_with" do
+
+#     it "throws a goddamn error" do
+#       e = proc do
+#         class FailingForm < Reform::Form
+#           include Reform::Form::Dry::Validations
+
+#           property :username
+
+#           validation :email do
+#             validates(:email, &:filled?)
+#           end
+#         end
+#       end.must_raise(NoMethodError)
+#       # e.message.must_equal 'validates() is not supported by Dry Validation backend.'
+
+#       e = proc do
+#         class FailingForm < Reform::Form
+#           include Reform::Form::Dry::Validations
+
+#           property :username
+
+#           validation :email do
+#             validate(:email, &:filled?)
+#           end
+#         end
+#       end.must_raise(NoMethodError)
+#       # e.message.must_equal 'validate() is not supported by Dry Validation backend.'
+
+#       e = proc do
+#         class FailingForm < Reform::Form
+#           include Reform::Form::Dry::Validations
+
+#           property :username
+
+#           validation :email do
+#             validates_with(:email, &:filled?)
+#           end
+#         end
+#       end.must_raise(NoMethodError)
+#       # e.message.must_equal (NoMethodError)'validates_with() is not supported by Dry Validation backend.'
+#     end
+#   end
+
+
+#   # describe "same-named group" do
+#   #   class OverwritingForm < Reform::Form
+#   #     include Reform::Form::Dry::Validations
+
+#   #     property :username
+#   #     property :email
+
+#   #     validation :email do # FIX ME: is this working for other validator or just bugging here?
+#   #       key(:email, &:filled?) # it's not considered, overitten
+#   #     end
+
+#   #     validation :email do # just another group.
+#   #       key(:username, &:filled?)
+#   #     end
+#   #   end
+
+#   #   let (:form) { OverwritingForm.new(Session.new) }
+
+#   #   # valid.
+#   #   it do
+#   #     form.validate({username: "Helloween"}).must_equal true
+#   #   end
+
+#   #   # invalid.
+#   #   it "whoo" do
+#   #     form.validate({}).must_equal false
+#   #     form.errors.messages.inspect.must_equal "{:username=>[\"username can't be blank\"]}"
+#   #   end
+#   # end
+
+
+#   describe "inherit: true in same group" do
+#     class InheritSameGroupForm < Reform::Form
+#       include Reform::Form::Dry::Validations
+
+#       property :username
+#       property :email
+
+#       validation :email do
+#         key(:email).required
+#       end
+
+#       validation :email, inherit: true do # extends the above.
+#         key(:username).required
+#       end
+#     end
+
+#     let (:form) { InheritSameGroupForm.new(Session.new) }
+
+#     # valid.
+#     it do
+#       form.validate({username: "Helloween", email: 9}).must_equal true
+#     end
+
+#     # invalid.
+#     it do
+#       form.validate({}).must_equal false
+#       form.errors.messages.inspect.must_equal "{:email=>[\"is missing\"], :username=>[\"is missing\"]}"
+#     end
+#   end
+
+
+#   describe "if: with lambda" do
+#     class IfWithLambdaForm < Reform::Form
+#       include Reform::Form::Dry::Validations # ::build_errors.
+
+#       property :username
+#       property :email
+#       property :password
+
+#       validation :email do
+#         key(:email).required
+#       end
+
+#       # run this is :email group is true.
+#       validation :after_email, if: lambda { |results| results[:email]==true } do # extends the above.
+#         key(:username).required
+#       end
+
+#       # block gets evaled in form instance context.
+#       validation :password, if: lambda { |results| email == "john@trb.org" } do
+#         key(:password).required
+#       end
+#     end
+
+#     let (:form) { IfWithLambdaForm.new(Session.new) }
+
+#     # valid.
+#     it do
+#       form.validate({username: "Strung Out", email: 9}).must_equal true
+#     end
+
+#     # invalid.
+#     it do
+#       form.validate({email: 9}).must_equal false
+#       form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"]}"
+#     end
+#   end
+
+
+#   # Currenty dry-v don't support that option, it doesn't make sense
+#   #   I've talked to @solnic and he plans to add a "hint" feature to show
+#   #   more errors messages than only those that have failed.
+#   #
+#   # describe "multiple errors for property" do
+#   #   class MultipleErrorsForPropertyForm < Reform::Form
+#   #     include Reform::Form::Dry::Validations
+
+#   #     property :username
+
+#   #     validation :default do
+#   #       key(:username) do |username|
+#   #         username.filled? | (username.min_size?(2) & username.max_size?(3))
+#   #       end
+#   #     end
+#   #   end
+
+#   #   let (:form) { MultipleErrorsForPropertyForm.new(Session.new) }
+
+#   #   # valid.
+#   #   it do
+#   #     form.validate({username: ""}).must_equal false
+#   #     form.errors.messages.inspect.must_equal "{:username=>[\"username must be filled\", \"username is not proper size\"]}"
+#   #   end
+#   # end
+# end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 2.2.2
+  version: 2.2.3
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-09 00:00:00.000000000 Z
+date: 2016-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: disposable
@@ -177,6 +177,7 @@ files:
 - lib/reform/contract/errors.rb
 - lib/reform/contract/validate.rb
 - lib/reform/form.rb
+- lib/reform/form/call.rb
 - lib/reform/form/coercion.rb
 - lib/reform/form/composition.rb
 - lib/reform/form/dry.rb
@@ -192,6 +193,7 @@ files:
 - lib/reform/version.rb
 - reform.gemspec
 - test/benchmarking.rb
+- test/call_test.rb
 - test/changed_test.rb
 - test/coercion_test.rb
 - test/composition_test.rb
@@ -252,6 +254,7 @@ specification_version: 4
 summary: Form object decoupled from models with validation, population and presentation.
 test_files:
 - test/benchmarking.rb
+- test/call_test.rb
 - test/changed_test.rb
 - test/coercion_test.rb
 - test/composition_test.rb