reform 1.1.1 → 1.2.0.beta1

data/test/skip_unchanged_test.rb

@@ -0,0 +1,86 @@
+require 'test_helper'
+
+class SkipUnchangedTest < MiniTest::Spec
+  class SongForm < Reform::Form
+    include Sync::SkipUnchanged
+    register_feature Sync::SkipUnchanged
+
+    property :id
+    property :title
+    property :image, sync: lambda { |value, *| model.image = "processed via :sync: #{value}" }#, virtual: true
+    property :band do
+      property :name, sync: lambda { |value, *| model.name = "band, processed: #{value}" }
+    end
+  end
+
+  Song = Struct.new(:id, :title, :image, :band) do
+    def id=(v); raise "never call me #{v.inspect}"; end
+  end
+  Band = Struct.new(:name)
+
+  let (:song) { Song.new(1, "Injection", Object, Band.new("Rise Against")) }
+
+  # skips when not present in hash + SkipUnchanged.
+  it("zhz") do
+    form = SongForm.new(song)
+
+    form.validate("title" => "Ready To Fall").must_equal true
+    form.sync
+
+    song.id.must_equal 1 # old
+    song.title.must_equal "Ready To Fall" # new!
+    song.image.must_equal Object # old
+    song.band.name.must_equal "Rise Against" # old
+  end
+
+  # uses :sync when present in params hash.
+  it do
+    form = SongForm.new(song)
+
+    form.validate("title" => "Ready To Fall", "image" => Module, "band" => {"name" => Class})
+    form.sync
+
+    song.id.must_equal 1
+    song.image.must_equal "processed via :sync: Module"
+    # nested works.
+    song.band.name.must_equal "band, processed: Class"
+  end
+end
+
+
+# :virtual is considered with SkipUnchanged
+class SkipUnchangedWithVirtualTest < MiniTest::Spec
+  Song = Struct.new(:title, :image, :band) do
+    def image=(v)
+      raise "i should not be called: #{v}"
+    end
+  end
+  Band = Struct.new(:name) do
+    def name=(v)
+      raise "i should not be called: #{v}"
+    end
+  end
+
+  let (:form) { HitForm.new(song) }
+  let (:song) { Song.new(nil, nil, Band.new) }
+
+  class HitForm < Reform::Form
+    include Sync::SkipUnchanged
+    register_feature Sync::SkipUnchanged
+
+    property :title
+    property :image, virtual: true
+    property :band do
+      property :name, virtual: true
+    end
+  end
+
+  it "hhy" do
+    form.validate("title" => "Full Throttle", "image" => "Funny photo of Steve Harris", "band" => {"name" => "Iron Maiden"}).must_equal true
+
+    form.sync
+    song.title.must_equal "Full Throttle"
+    song.image.must_equal nil
+    song.band.name.must_equal nil
+  end
+end

data/test/sync_option_test.rb

@@ -0,0 +1,83 @@
+require 'test_helper'
+
+class SyncOptionTest < MiniTest::Spec
+  Band = Struct.new(:name)
+  let (:band) { Band.new("Metallica") }
+  let (:form) { BandForm.new(band) }
+
+  # access to :form!
+  describe ":sync allows you conditionals" do
+    class BandForm < Reform::Form
+      property :name, sync: lambda { |value, options| options.user_options[:form].changed?(:name) ? model.name = value : nil } # change if it hasn't changed
+    end
+
+    # don't set name, didn't change.
+    it do
+      band.instance_exec { def name=(*); raise; end }
+      form.validate("name" => "Metallica").must_equal true
+      form.sync
+      band.name.must_equal "Metallica"
+    end
+
+    # update name.
+    it do
+      form.validate("name" => "Iron Maiden").must_equal true
+      form.sync
+      form.name.must_equal "Iron Maiden"
+    end
+  end
+end
+
+
+class SyncWithDynamicOptionsTest < MiniTest::Spec
+  Song = Struct.new(:id, :title, :length)
+
+  class SongForm < Reform::Form
+    property :id
+    property :title, sync: true
+    property :length
+  end
+
+  let (:song) { Song.new }
+  let (:form) { SongForm.new(song) }
+
+  # we have access to original input value and outside parameters.
+  it do
+    form.validate("title" => "A Poor Man's Memory", "length" => 10)
+    length_seconds = 120
+    form.sync(title: lambda { |value, options| form.model.title = "#{value}: #{length_seconds}" })
+
+    song.title.must_equal "A Poor Man's Memory: 120"
+    song.length.must_equal 10
+    song.id.must_equal nil
+  end
+end
+
+
+# :virtual wins over :sync
+# class SyncWithVirtualTest < MiniTest::Spec
+#   Song = Struct.new(:title, :image, :band)
+#   Band = Struct.new(:name)
+
+#   let (:form) { HitForm.new(song) }
+#   let (:song) { Song.new("Injection", Object, Band.new("Rise Against")) }
+
+#   class HitForm < Reform::Form
+#     include Sync::SkipUnchanged
+#     register_feature Sync::SkipUnchanged
+
+#     property :image, sync: lambda { |value, *| model.image = "processed via :sync: #{value}" }
+#     property :band do
+#       property :name, sync: lambda { |value, *| model.name = "band, processed: #{value}" }, virtual: true
+#     end
+#   end
+
+#   it "abc" do
+#     form.validate("image" => "Funny photo of Steve Harris", "band" => {"name" => "Iron Maiden"}).must_equal true
+
+#     form.sync
+#     song.image.must_equal "processed via :sync: Funny photo of Steve Harris"
+#     song.band.name.must_equal "Rise Against"
+#   end
+# end
+

data/test/twin_test.rb

@@ -0,0 +1,23 @@
+require 'test_helper'
+
+require 'test_helper'
+require 'reform/twin'
+
+class TwinTest < MiniTest::Spec
+  class SongForm < Reform::Form
+    class Twin < Disposable::Twin
+      property :title
+      option :is_online # TODO: this should make it read-only in reform!
+    end
+
+    include Reform::Twin
+    twin Twin
+  end
+
+  let (:model) { OpenStruct.new(title: "Kenny") }
+
+  let (:form) { SongForm.new(model, is_online: true) }
+
+  it { form.title.must_equal "Kenny" }
+  it { form.is_online.must_equal true }
+end

data/test/validate_test.rb

@@ -9,8 +9,11 @@ class ValidateTest < BaseTest
         "songs" => [{"title" => "Fallout"}, {"title" => "Roxanne"}]
       }
     }
+    let (:hit) { Song.new }
+    let (:song2) { Song.new }
+    let (:song1) { Song.new }
 
-    subject { AlbumForm.new(Album.new(nil, Song.new, [Song.new, Song.new])) }
+    subject { AlbumForm.new(Album.new(nil, hit, [song1, song2])) }
 
     before { subject.validate(params) }
 
@@ -27,6 +30,11 @@ class ValidateTest < BaseTest
 
     it { subject.songs[1].must_be_kind_of Reform::Form }
     it { subject.songs[1].title.must_equal "Roxanne" }
+
+    # don't touch model.
+    it { hit.title.must_equal nil   }
+    it { song1.title.must_equal nil }
+    it { song2.title.must_equal nil }
   end
 
   # TODO: the following tests go to populate_test.rb

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0.beta1
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-04 00:00:00.000000000 Z
+date: 2014-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: 2.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: 2.1.0
 - !ruby/object:Gem::Dependency
   name: disposable
   requirement: !ruby/object:Gem::Requirement
@@ -101,14 +101,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.4.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.4.1
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -211,26 +211,32 @@ files:
 - lib/reform/form/active_model.rb
 - lib/reform/form/active_model/model_validations.rb
 - lib/reform/form/active_record.rb
+- lib/reform/form/changed.rb
 - lib/reform/form/coercion.rb
 - lib/reform/form/composition.rb
+- lib/reform/form/json.rb
+- lib/reform/form/model_reflections.rb
 - lib/reform/form/module.rb
 - lib/reform/form/multi_parameter_attributes.rb
 - lib/reform/form/save.rb
 - lib/reform/form/scalar.rb
 - lib/reform/form/sync.rb
 - lib/reform/form/validate.rb
-- lib/reform/form/virtual_attributes.rb
 - lib/reform/rails.rb
 - lib/reform/representer.rb
+- lib/reform/schema.rb
+- lib/reform/twin.rb
 - lib/reform/version.rb
 - reform.gemspec
 - test/active_model_test.rb
 - test/active_record_test.rb
 - test/as_test.rb
 - test/builder_test.rb
+- test/changed_test.rb
 - test/coercion_test.rb
 - test/composition_test.rb
 - test/contract_test.rb
+- test/custom_validation_test.rb
 - test/deserialize_test.rb
 - test/dummy/Rakefile
 - test/dummy/app/controllers/albums_controller.rb
@@ -255,19 +261,29 @@ files:
 - test/dummy/db/test.sqlite3
 - test/dummy/log/production.log
 - test/dummy/log/server.log
+- test/empty_test.rb
 - test/errors_test.rb
 - test/feature_test.rb
+- test/fields_test.rb
 - test/form_builder_test.rb
 - test/form_composition_test.rb
+- test/form_test.rb
 - test/inherit_test.rb
+- test/model_reflections_test.rb
 - test/model_validations_test.rb
 - test/nested_form_test.rb
 - test/rails/integration_test.rb
+- test/read_only_test.rb
 - test/reform_test.rb
+- test/representer_test.rb
 - test/save_test.rb
 - test/scalar_test.rb
+- test/skip_if_test.rb
+- test/skip_unchanged_test.rb
+- test/sync_option_test.rb
 - test/sync_test.rb
 - test/test_helper.rb
+- test/twin_test.rb
 - test/validate_test.rb
 homepage: https://github.com/apotonick/reform
 licenses:
@@ -284,9 +300,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2
@@ -299,9 +315,11 @@ test_files:
 - test/active_record_test.rb
 - test/as_test.rb
 - test/builder_test.rb
+- test/changed_test.rb
 - test/coercion_test.rb
 - test/composition_test.rb
 - test/contract_test.rb
+- test/custom_validation_test.rb
 - test/deserialize_test.rb
 - test/dummy/Rakefile
 - test/dummy/app/controllers/albums_controller.rb
@@ -326,17 +344,27 @@ test_files:
 - test/dummy/db/test.sqlite3
 - test/dummy/log/production.log
 - test/dummy/log/server.log
+- test/empty_test.rb
 - test/errors_test.rb
 - test/feature_test.rb
+- test/fields_test.rb
 - test/form_builder_test.rb
 - test/form_composition_test.rb
+- test/form_test.rb
 - test/inherit_test.rb
+- test/model_reflections_test.rb
 - test/model_validations_test.rb
 - test/nested_form_test.rb
 - test/rails/integration_test.rb
+- test/read_only_test.rb
 - test/reform_test.rb
+- test/representer_test.rb
 - test/save_test.rb
 - test/scalar_test.rb
+- test/skip_if_test.rb
+- test/skip_unchanged_test.rb
+- test/sync_option_test.rb
 - test/sync_test.rb
 - test/test_helper.rb
+- test/twin_test.rb
 - test/validate_test.rb

data/lib/reform/form/virtual_attributes.rb

@@ -1,22 +0,0 @@
-class Reform::Form < Reform::Contract
-    # TODO: this should be in Representer namespace.
-    module EmptyAttributesOptions
-      def options
-        empty_fields = representable_attrs.
-          find_all { |d| d[:empty] }.
-          collect  { |d| d.name.to_sym }
-
-        super.exclude!(empty_fields)
-      end
-    end
-
-    module ReadonlyAttributesOptions
-      def options
-        readonly_fields = representable_attrs.
-          find_all { |d| d[:virtual] }.
-          collect  { |d| d.name.to_sym }
-
-        super.exclude!(readonly_fields)
-      end
-    end
-end