reform 1.0.4 → 1.1.0

data/test/active_record_test.rb

@@ -1,65 +1,81 @@
 require 'test_helper'
+require 'reform/active_record'
+
+# ActiveRecord::Schema.define do
+#   create_table :artists do |table|
+#     table.column :name, :string
+#     table.timestamps
+#   end
+#   create_table :songs do |table|
+#     table.column :title, :string
+#     table.column :artist_id, :integer
+#     table.column :album_id, :integer
+#     table.timestamps
+#   end
+#   create_table :albums do |table|
+#     table.column :title, :string
+#     table.timestamps
+#   end
+# end
+# Artist.new(:name => "Racer X").save
+
 
 class ActiveRecordTest < MiniTest::Spec
-  let (:form) do
-    require 'reform/active_record'
-    Class.new(Reform::Form) do
-      include Reform::Form::ActiveRecord
-      model :artist
+  class SongForm < Reform::Form
+    include Reform::Form::ActiveRecord
+    model :song
 
-      property :name
-      property :created_at
+    property :title
+    property :created_at
 
-      validates_uniqueness_of :name
-      validates :created_at, :presence => true # have another property to test if we mix up.
-    end.
-    new(Artist.new)
+    validates_uniqueness_of :title
+    validates :created_at, :presence => true # have another property to test if we mix up.
+
+    property :artist do
+      property :name
+      validates_uniqueness_of :name # this currently also tests if Form::AR is included as a feature.
+    end
   end
 
-  it { form.class.i18n_scope.must_equal :activerecord }
+  let (:form) { SongForm.new(Song.new(:artist => Artist.new)) }
 
-  describe "UniquenessValidator" do
-    #  ActiveRecord::Schema.define do
-    #    create_table :artists do |table|
-    #      table.column :name, :string
-    #      table.timestamps
-    #    end
-    #  end
-    # Artist.new(:name => "Racer X").save
+  it { form.class.i18n_scope.must_equal :activerecord }
 
-    it "allows accessing the database" do
-    end
+  it "allows accessing the database" do
+  end
 
-    it "is valid when name is unique" do
-      form.validate({"name" => "Paul Gilbert", "created_at" => "November 6, 1966"}).must_equal true
-    end
+  # uniqueness
+  it "is valid when name is unique" do
+    form.validate("artist" => {"name" => "Paul Gilbert"}, "title" => "The Gargoyle", "created_at" => "November 6, 1966").must_equal true
+  end
 
-    it "is invalid and shows error when taken" do
-      Artist.create(:name => "Racer X")
+  # nested object taken.
+  it "is invalid and shows error when taken" do
+    Song.delete_all
+    Artist.create(:name => "Racer X")
 
-      form.validate({"name" => "Racer X"}).must_equal false
-      form.errors.messages.must_equal({:name=>["has already been taken"], :created_at => ["can't be blank"]})
-    end
+    form.validate("artist" => {"name" => "Racer X"}, "title" => "Ghost Inside My Skin").must_equal false
+    form.errors.messages.must_equal({:"artist.name"=>["has already been taken"], :created_at => ["can't be blank"]})
+  end
 
-    it "works with Composition" do
-      form = Class.new(Reform::Form) do
-        include Reform::Form::ActiveRecord
-        include Reform::Form::Composition
+  it "works with Composition" do
+    form = Class.new(Reform::Form) do
+      include Reform::Form::ActiveRecord
+      include Reform::Form::Composition
 
-        property :name, :on => :artist
-        validates_uniqueness_of :name
-      end.new(:artist => Artist.new)
+      property :name, :on => :artist
+      validates_uniqueness_of :name
+    end.new(:artist => Artist.new)
 
-      Artist.create(:name => "Bad Religion")
-      form.validate("name" => "Bad Religion").must_equal false
-    end
+    Artist.create(:name => "Bad Religion")
+    form.validate("name" => "Bad Religion").must_equal false
   end
 
   describe "#save" do
     # TODO: test 1-n?
     it "calls model.save" do
       Artist.delete_all
-      form.validate("name" => "Bad Religion")
+      form.validate("artist" => {"name" => "Bad Religion"}, "title" => "Ghost Inside My Skin")
       form.save
       Artist.where(:name => "Bad Religion").size.must_equal 1
     end
@@ -71,4 +87,134 @@ class ActiveRecordTest < MiniTest::Spec
       Artist.where(:name => "Bad Religion").size.must_equal 0
     end
   end
-end
+end
+
+
+class PopulateWithActiveRecordTest < MiniTest::Spec
+  class AlbumForm < Reform::Form
+    property :title
+
+    collection :songs, :populate_if_empty => Song do
+      property :title
+    end
+  end
+
+  let (:album) { Album.new(:songs => []) }
+  it do
+    form = AlbumForm.new(album)
+
+    form.validate("songs" => [{"title" => "Straight From The Jacket"}])
+
+    # form populated.
+    form.songs.size.must_equal 1
+    form.songs[0].model.must_be_kind_of Song
+
+    # model NOT populated.
+    album.songs.must_equal []
+
+
+    form.sync
+
+    # form populated.
+    form.songs.size.must_equal 1
+    form.songs[0].model.must_be_kind_of Song
+
+    # model also populated.
+    song = album.songs[0]
+    album.songs.must_equal [song]
+    song.title.must_equal "Straight From The Jacket"
+
+
+    if ActiveRecord::VERSION::STRING !~ /^3.0/
+      # saving saves association.
+      form.save
+
+      album.reload
+      song = album.songs[0]
+      album.songs.must_equal [song]
+      song.title.must_equal "Straight From The Jacket"
+    end
+  end
+
+
+  describe "modifying 1., adding 2." do
+    let (:song) { Song.new(:title => "Part 2") }
+    let (:album) { Album.create.tap { |a| a.songs << song } }
+
+    it do
+      form = AlbumForm.new(album)
+
+      id = album.songs[0].id
+      assert id > 0
+
+      form.validate("songs" => [{"title" => "Part Two"}, {"title" => "Check For A Pulse"}])
+
+      # form populated.
+      form.songs.size.must_equal 2
+      form.songs[0].model.must_be_kind_of Song
+      form.songs[1].model.must_be_kind_of Song
+
+      # model NOT populated.
+      album.songs.must_equal [song]
+
+
+      form.sync
+
+      # form populated.
+      form.songs.size.must_equal 2
+
+      # model also populated.
+      album.songs.size.must_equal 2
+
+      # corrected title
+      album.songs[0].title.must_equal "Part Two"
+      # ..but same song.
+      album.songs[0].id.must_equal id
+
+      # and a new song.
+      album.songs[1].title.must_equal "Check For A Pulse"
+      album.songs[1].persisted?.must_equal true # TODO: with << strategy, this shouldn't be saved.
+    end
+  end
+
+  # it do
+  #   a=Album.new
+  #   a.songs << Song.new(title: "Old What's His Name") # Song does not get persisted.
+
+  #   a.songs[1] = Song.new(title: "Permanent Rust")
+
+  #   puts "@@@"
+  #   puts a.songs.inspect
+
+  #   puts "---"
+  #   a.save
+  #   puts a.songs.inspect
+
+
+
+  #   b = a.songs.first
+
+  #   a.songs = [Song.new(title:"Biomag")]
+  #   puts "\\\\"
+  #   a.save
+  #   a.reload
+  #   puts a.songs.inspect
+
+  #   b.reload
+  #   puts "#{b.inspect}, #{b.persisted?}"
+
+
+  #   a.songs = [a.songs.first, Song.new(title: "Count Down")]
+  #   b = a.songs.first
+  #   puts ":::::"
+  #   a.save
+  #   a.reload
+  #   puts a.songs.inspect
+
+  #   b.reload
+  #   puts "#{b.inspect}, #{b.persisted?}"
+  # end
+end
+
+
+

data/test/as_test.rb

@@ -65,7 +65,7 @@ class AsTest < BaseTest
     it do
       hash = nil
 
-      subject.save do |f, nested_hash|
+      subject.save do |nested_hash|
         hash = nested_hash
       end
 

data/test/builder_test.rb

@@ -0,0 +1,32 @@
+require 'test_helper'
+
+class BuilderTest < MiniTest::Spec
+  it do
+    Builder.new.checkboxes(:settings, :hash => {"play" => true, "released" => false}).must_equal %{<input name="yo" type="hidden" value="unchecked_value" /><input id="object_name_method" name="yo" type="checkbox" value="checked_value" />
+<input name="yo" type="hidden" value="unchecked_value" /><input id="object_name_method" name="yo" type="checkbox" value="checked_value" />}
+  end
+end
+
+
+require 'action_view/helpers/capture_helper'
+require 'action_view/helpers/tag_helper'
+require 'action_view/helpers/url_helper'
+require 'action_view/helpers/sanitize_helper'
+require 'action_view/helpers/text_helper'
+require 'action_view/helpers/form_tag_helper'
+require 'action_view/helpers/form_helper'
+
+class Builder
+  include ActionView::Helpers::CaptureHelper
+  include ActionView::Helpers::FormHelper
+
+  # {name: value}
+  def checkboxes(name, options)
+    # get property form.to_a ? to_builder_hash or something like that
+    options[:hash].collect do |id, value|
+      ActionView::Helpers::InstanceTag.new(:object_name, :method, self).to_check_box_tag({:name => "yo"}, :checked_value, :unchecked_value)
+
+      # check_box_tag(id, value, checked = false, {})
+    end.join("\n")
+  end
+end

data/test/coercion_test.rb

@@ -2,43 +2,71 @@ require "test_helper"
 require "reform/form/coercion"
 
 class CoercionTest < BaseTest
-  subject do
-    Class.new(Reform::Form) do
-      include Reform::Form::Coercion
+  class Irreversible < Virtus::Attribute
+    def coerce(value)
+      value*2
+    end
+  end
 
-      property :released_at, :type => DateTime
+  class Form < Reform::Form
+    include Coercion
 
-      property :hit do
-        property :length, :type => Integer
-        property :good,   :type => Virtus::Attribute::Boolean
-      end
+    property :released_at, :type => DateTime
+
+    property :hit do
+      # include Coercion
+      property :length, :type => Integer
+      property :good,   :type => Virtus::Attribute::Boolean
+    end
 
-      property :band do
-        property :label do
-          property :value, :type => Float
-        end
+    property :band do
+      include Coercion
+      property :label do
+        include Coercion
+        property :value, :type => Irreversible
       end
-    end.new(OpenStruct.new(
-      :released_at => "31/03/1981",
-      :hit => OpenStruct.new(:length => "312"),
-      :band => Band.new(OpenStruct.new(:value => "9999.99"))
-    ))
+    end
   end
 
-  it { subject.released_at.must_be_kind_of DateTime }
-  it { subject.released_at.must_equal DateTime.parse("Tue, 31 Mar 1981 00:00:00 +0000") }
-  it { subject.hit.length.must_equal 312 }
-  it { subject.band.label.value.must_equal 9999.99 }
+  subject do
+    Form.new(album)
+  end
 
+  let (:album) {
+    OpenStruct.new(
+      :released_at => "31/03/1981",
+      :hit         => OpenStruct.new(:length => "312"),
+      :band        => Band.new(OpenStruct.new(:value => "9999.99"))
+    )
+  }
 
-  it "allows coercion in validate" do
-    form = Class.new(Reform::Form) do
-      include Reform::Form::Coercion
+  # it { subject.released_at.must_be_kind_of DateTime }
+  it { subject.released_at.must_equal "31/03/1981" } # NO coercion in setup.
+  it { subject.hit.length.must_equal "312" }
+  it { subject.band.label.value.must_equal "9999.99" }
 
-      property :id, :type => Integer
-    end.new(OpenStruct.new())
 
-    form.validate("id" => "1")
-    form.id.must_equal 1
+  let (:params) {
+    {
+      :released_at => "30/03/1981",
+      :hit         => {:length => "312"},
+      :band        => {:label => {:value => "9999.99"}}
+    }
+  }
+
+
+  # validate
+  describe "#validate" do
+    before { subject.validate(params) }
+
+    it { subject.released_at.must_equal DateTime.parse("30/03/1981") }
+    it { subject.hit.length.must_equal 312 }
+    it { subject.hit.good.must_equal nil }
+    it { subject.band.label.value.must_equal "9999.999999.99" } # coercion happened once.
   end
+
+  # save
+
+
+
 end

data/test/deserialize_test.rb

@@ -0,0 +1,40 @@
+require 'test_helper'
+require 'representable/json'
+
+class DeserializeTest < BaseTest
+  class AlbumContract < Reform::Form
+    self.representer_class.class_eval do
+      include Representable::JSON
+    end
+    def deserialize_method
+      :from_json
+    end
+
+    property :title
+    validates :title, :presence => true, :length => {:minimum => 3}
+
+    property :hit do
+      property :title
+      validates :title, :presence => true
+    end
+
+    property :band do # yepp, people do crazy stuff like that.
+      validates :label, :presence => true
+
+      property :label do
+        property :name
+        validates :name, :presence => true
+      end
+    end
+  end
+
+  let (:album) { Album.new(nil, Song.new, [Song.new, Song.new], Band.new(Label.new("Fat Wreck")) ) }
+  subject { AlbumContract.new(album) }
+
+  let (:json) { '{"hit":{"title":"Sacrifice"},"title":"Second Heat","songs":[{"title":"Heart Of A Lion"}],"band":{"label":{"name":"Fat Wreck"}}}' }
+
+  it {
+    subject.validate(json)
+    subject.band.label.name.must_equal "Fat Wreck"
+     }
+end

data/test/form_builder_test.rb

@@ -12,7 +12,7 @@ class FormBuilderCompatTest < BaseTest
 
       collection :songs do
         property :title
-        property :release_date
+        property :release_date, :multi_params => true
         validates :title, :presence => true
       end