reform 0.2.7 → 1.0.0

data/test/sync_test.rb

@@ -0,0 +1,39 @@
+require 'test_helper'
+
+class SyncTest < BaseTest
+  describe "populated" do
+    let (:params) {
+      {
+        "title" => "Best Of",
+        "hit"   => {"title" => "Roxanne"},
+        "songs" => [{"title" => "Fallout"}, {"title" => "Roxanne"}],
+        :band  => {:label => {:name => "Polydor"}}
+      }
+    }
+
+    let (:album) { Album.new(nil, hit, [song1, song2], band) }
+    let (:hit) { Song.new }
+    let (:song1) { Song.new }
+    let (:song2) { Song.new }
+    let (:band) { Band.new(label) }
+    let (:label) { Label.new }
+
+    subject { ErrorsTest::AlbumForm.new(album) }
+
+    before do
+      subject.validate(params)
+      subject.sync
+    end
+
+    it { album.title.must_equal "Best Of" }
+    it { album.hit.must_be_kind_of Struct }
+    it { album.songs[0].must_be_kind_of Struct }
+    it { album.songs[1].must_be_kind_of Struct }
+
+    # it { hit.must_be_kind_of Struct }
+    it { hit.title.must_equal "Roxanne" }
+    it { song1.title.must_equal "Fallout" }
+    it { song2.title.must_equal "Roxanne" }
+    it { label.name.must_equal "Polydor" }
+  end
+end

data/test/test_helper.rb

@@ -2,8 +2,8 @@ require 'reform'
 require 'minitest/autorun'
 
 class ReformSpec < MiniTest::Spec
-  let (:duran)  { OpenStruct.new(:name => "Duran Duran") }
-  let (:rio)    { OpenStruct.new(:title => "Rio") }
+  let (:duran)  { Struct.new(:name).new("Duran Duran") }
+  let (:rio)    { Struct.new(:title).new("Rio") }
 end
 
 require 'active_record'
@@ -15,3 +15,37 @@ ActiveRecord::Base.establish_connection(
 )
 
 #Artist.delete_all
+
+class BaseTest < MiniTest::Spec
+  class AlbumForm < Reform::Form
+    property :title
+
+    property :hit do
+      property :title
+    end
+
+    collection :songs do
+      property :title
+    end
+  end
+
+  Song  = Struct.new(:title)
+  Album = Struct.new(:title, :hit, :songs, :band)
+  Band  = Struct.new(:label)
+  Label = Struct.new(:name)
+
+
+  let (:hit) { Song.new("Roxanne") }
+end
+
+MiniTest::Spec.class_eval do
+  module Saveable
+    def save
+      @saved = true
+    end
+
+    def saved?
+      @saved
+    end
+  end
+end

data/test/validate_test.rb

@@ -0,0 +1,191 @@
+require 'test_helper'
+
+class ValidateTest < BaseTest
+  describe "populated" do
+    let (:params) {
+      {
+        "title" => "Best Of",
+        "hit"   => {"title" => "Roxanne"},
+        "songs" => [{"title" => "Fallout"}, {"title" => "Roxanne"}]
+      }
+    }
+
+    subject { AlbumForm.new(Album.new(nil, Song.new, [Song.new, Song.new])) }
+
+    before { subject.validate(params) }
+
+    it { subject.title.must_equal "Best Of" }
+
+    it { subject.hit.must_be_kind_of Reform::Form }
+    it { subject.hit.title.must_equal "Roxanne" }
+
+    it { subject.songs.must_be_kind_of Array }
+    it { subject.songs.size.must_equal 2 }
+
+    it { subject.songs[0].must_be_kind_of Reform::Form }
+    it { subject.songs[0].title.must_equal "Fallout" }
+
+    it { subject.songs[1].must_be_kind_of Reform::Form }
+    it { subject.songs[1].title.must_equal "Roxanne" }
+  end
+
+  # TODO: the following tests go to populate_test.rb
+  describe "manual setup with populator" do
+    let (:form) {
+      Class.new(Reform::Form) do
+        property :hit, :populator => lambda { |fragment, args|
+          puts "******************* #{fragment}"
+
+          hit or self.hit = args.binding[:form].new(Song.new)
+        } do
+          property :title
+        end
+      end
+     }
+
+    let (:params) {
+      {
+        "hit"   => {"title" => "Roxanne"},
+        # "songs" => [{"title" => "Fallout"}, {"title" => "Roxanne"}]
+      }
+    }
+
+    subject { form.new(Album.new) }
+
+    before { subject.validate(params) }
+
+    it { subject.hit.title.must_equal "Roxanne" }
+  end
+
+  describe ":populate_if_empty" do
+    let (:form) {
+      Class.new(Reform::Form) do
+        property :hit, :populate_if_empty => lambda { |fragment, args| Song.new } do
+          property :title
+        end
+
+        collection :songs, :populate_if_empty => lambda { |fragment, args| model.songs.build } do
+          property :title
+        end
+
+        property :band, :populate_if_empty => lambda { |fragment, args| Band.new } do
+          property :label, :populate_if_empty => lambda { |fragment, args| Label.new } do
+            property :name
+          end
+        end
+      end
+     }
+
+    let (:params) {
+      {
+        "hit"   => {"title" => "Roxanne"},
+        "songs" => [{"title" => "Fallout"}, {"title" => "Roxanne"}],
+        "band"  => {"label" => {"name" => "Epitaph"}}
+      }
+    }
+
+    let (:song_collection_proxy) { Class.new(Array) { def build; Song.new; end } }
+    let (:album) { Album.new(nil,nil, song_collection_proxy.new, nil) }
+    subject { form.new(album) } # DISCUSS: require at least an array here? this is provided by all ORMs.
+
+    before { subject.validate(params) }
+
+    it { subject.hit.title.must_equal "Roxanne" }
+    it { subject.songs[0].title.must_equal "Fallout" }
+    it { subject.songs[1].title.must_equal "Roxanne" }
+
+    it { album.hit.must_be_kind_of Struct }
+    it { album.songs.size.must_equal 2 } # #validate must associate items with model.
+
+    it { subject.band.label.name.must_equal "Epitaph" }
+  end
+
+
+  describe "populate_if_empty: Class" do
+    let (:form) {
+      Class.new(Reform::Form) do
+        property :hit, :populate_if_empty => Song do
+          property :title
+        end
+      end
+     }
+
+    let (:params) {
+      {
+        "hit"   => {"title" => "Roxanne"},
+      }
+    }
+
+    let (:album) { Album.new }
+    subject { form.new(album) }
+
+    before { subject.validate(params) }
+
+    it { subject.hit.title.must_equal "Roxanne" }
+  end
+
+
+  # test cardinalities.
+  describe "with empty collection and cardinality" do
+    let (:album) { Album.new }
+
+    subject { Class.new(Reform::Form) do
+      include Reform::Form::ActiveModel
+      model :album
+
+      collection :songs do
+        property :title
+      end
+
+      property :hit do
+        property :title
+      end
+
+      validates :songs, :length => {:minimum => 1}
+      validates :hit, :presence => true
+    end.new(album) }
+
+
+    describe "invalid" do
+      before { subject.validate({}).must_equal false }
+
+      it { subject.errors.messages.must_equal(
+        :songs => ["is too short (minimum is 1 characters)"],
+        :hit   => ["can't be blank"]) }
+    end
+
+
+    describe "valid" do
+      let (:album) { Album.new(nil, Song.new, [Song.new("Urban Myth")]) }
+
+      before {
+        subject.validate({"songs" => [{"title"=>"Daddy, Brother, Lover, Little Boy"}], "hit" => {"title"=>"The Horse"}}).
+          must_equal true
+      }
+
+      it { subject.errors.messages.must_equal({}) }
+    end
+  end
+
+
+  describe "with symbols" do
+    let (:album) { OpenStruct.new(:band => OpenStruct.new(:label => OpenStruct.new(:name => "Epitaph"))) }
+    subject { ErrorsTest::AlbumForm.new(album) }
+    let (:params) { {:band => {:label => {:name => "Stiff"}}, :title => "House Of Fun"} }
+
+    before {
+      subject.validate(params).must_equal true
+    }
+
+    it { subject.band.label.name.must_equal "Stiff" }
+    it { subject.title.must_equal "House Of Fun" }
+  end
+end
+
+# #validate(params)
+#  title=(params[:title])
+#  song.validate(params[:song], errors)
+
+# #sync (assumes that forms already have updated fields)
+#   model.title=
+#   song.sync

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 0.2.7
+  version: 1.0.0
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-07 00:00:00.000000000 Z
+date: 2014-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable
@@ -17,14 +17,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.5
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.5
+        version: 1.8.1
+- !ruby/object:Gem::Dependency
+  name: disposable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.3
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.0.3
 - !ruby/object:Gem::Dependency
   name: uber
   requirement: !ruby/object:Gem::Requirement
@@ -175,12 +189,19 @@ files:
 - lib/reform.rb
 - lib/reform/active_record.rb
 - lib/reform/composition.rb
+- lib/reform/contract.rb
+- lib/reform/contract/errors.rb
+- lib/reform/contract/setup.rb
+- lib/reform/contract/validate.rb
 - lib/reform/form.rb
 - lib/reform/form/active_model.rb
 - lib/reform/form/active_record.rb
 - lib/reform/form/coercion.rb
 - lib/reform/form/composition.rb
 - lib/reform/form/multi_parameter_attributes.rb
+- lib/reform/form/save.rb
+- lib/reform/form/sync.rb
+- lib/reform/form/validate.rb
 - lib/reform/form/virtual_attributes.rb
 - lib/reform/rails.rb
 - lib/reform/representer.rb
@@ -188,8 +209,10 @@ files:
 - reform.gemspec
 - test/active_model_test.rb
 - test/active_record_test.rb
+- test/as_test.rb
 - test/coercion_test.rb
 - test/composition_test.rb
+- test/contract_test.rb
 - test/dummy/Rakefile
 - test/dummy/app/controllers/albums_controller.rb
 - test/dummy/app/controllers/application_controller.rb
@@ -214,11 +237,17 @@ files:
 - test/dummy/log/production.log
 - test/dummy/log/server.log
 - test/errors_test.rb
+- test/feature_test.rb
+- test/form_builder_test.rb
 - test/form_composition_test.rb
 - test/nested_form_test.rb
 - test/rails/integration_test.rb
 - test/reform_test.rb
+- test/save_test.rb
+- test/setup_test.rb
+- test/sync_test.rb
 - test/test_helper.rb
+- test/validate_test.rb
 homepage: ''
 licenses:
 - MIT
@@ -247,8 +276,10 @@ summary: Decouples your models from form by giving you form objects with validat
 test_files:
 - test/active_model_test.rb
 - test/active_record_test.rb
+- test/as_test.rb
 - test/coercion_test.rb
 - test/composition_test.rb
+- test/contract_test.rb
 - test/dummy/Rakefile
 - test/dummy/app/controllers/albums_controller.rb
 - test/dummy/app/controllers/application_controller.rb
@@ -273,8 +304,15 @@ test_files:
 - test/dummy/log/production.log
 - test/dummy/log/server.log
 - test/errors_test.rb
+- test/feature_test.rb
+- test/form_builder_test.rb
 - test/form_composition_test.rb
 - test/nested_form_test.rb
 - test/rails/integration_test.rb
 - test/reform_test.rb
+- test/save_test.rb
+- test/setup_test.rb
+- test/sync_test.rb
 - test/test_helper.rb
+- test/validate_test.rb
+has_rdoc: