reform 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7858098ed982e9c00c56016f1678e26f4c43b9e6
-  data.tar.gz: e518cbde390737b8308ce6aa41d398b6b48b2533
+  metadata.gz: 9ce0b79a877613cd7bcd9cfd868d0a33414c531a
+  data.tar.gz: f0e06d22099e1d335f692e865aff069428e9dc75
 SHA512:
-  metadata.gz: 0d4cb6de758aeb2892ee47bb69c8f9bb061f184b8088b9eac294ed3add2e72d364b5425206b9720c671892b1926be13bff7d9a3d7a3ac818381468c9115db695
-  data.tar.gz: 868a33c66a5a2225da3a12596f7c1f703e10403a1ef7353393d237ae368b6be55148d9eb8a2fe3bdda8e1744100d3e6d668b224226001997e19d029269747d2f
+  metadata.gz: 4f9f35619dea63561e09239ff40ec7765695a9f93638a32f1f5b743f6752aafce757497af1c28e9244fcb03cdaaf19cf07616dccb093881ce7b3b39b0d3f8af1
+  data.tar.gz: 30d28814ca8b99abba0385efb9c3ca391066402a39f81f45cacba4e927d52beb1e74516072fdb42a3946f4964099395bd48b12bd6ceb0aa1c2da0eb019c7927d

data/CHANGES.md

@@ -1,3 +1,8 @@
+## 0.2.3
+
+* `#form_for` now properly recognizes a nested form when declared using `:form` (instead of an inline form).
+* Multiparameter dates as they're constructed from the Rails date helper are now processed automatically. As soon as an incoming attribute name is `property_name(1i)` or the like, it's compiled into a Date. That happens in `MultiParameterAttributes`. If a component (year/month/day) is missing, the date is considered `nil`.
+
 ## 0.2.2
 
 * Fix a bug where `form.save do .. end` would call `model.save` even though a block was given. This no longer happens, if there's a block to `#save`, you have to manually save data (ActiveRecord environment, only).

data/README.md

@@ -455,10 +455,16 @@ class SongForm < Reform::Form
 end
 ```
 
+## Multiparameter Dates
+
+Composed multi-parameter dates as created by the Rails date helper are processed automatically. As soon as Reform detects an incoming `release_date(i1)` or the like it is gonna be converted into a date.
+
+Note that the date will be `nil` when one of the components (year/month/day) is missing.
+
+
 ## Security
 
-By explicitely defining the form layout using `::property` there is no more need for protecting from unwanted input. `strong_parameter` or `
-attr_accessible` become obsolete. Reform will simply ignore undefined incoming parameters.
+By explicitely defining the form layout using `::property` there is no more need for protecting from unwanted input. `strong_parameter` or `attr_accessible` become obsolete. Reform will simply ignore undefined incoming parameters.
 
 
 ## Additional Features

data/lib/reform/form.rb

@@ -36,6 +36,7 @@ module Reform
       end
 
       def setup_form_definition(definition)
+        # TODO: allow Definition.form?
         definition.options[:form] ||= definition.options.delete(:extend)
 
         definition.options[:parse_strategy] = :sync

data/lib/reform/form/active_model.rb

@@ -8,8 +8,8 @@ module Reform::Form::ActiveModel
 
     module ClassMethods
       def property(name, options={})
-        add_nested_attribute_compat(name) if block_given? # TODO: fix that in Rails FB#1832 work.
         super
+        add_nested_attribute_compat(name) if options[:form] # TODO: fix that in Rails FB#1832 work.
       end
 
     private

data/lib/reform/form/multi_parameter_attributes.rb

@@ -21,9 +21,14 @@ class Reform::Form
 
     private
       def params_to_date(year, month, day)
-        day ||= 1 # FIXME: is that really what we want? test.
+        return nil if blank_date_parameter?(year, month, day)
+
         Date.new(year.to_i, month.to_i, day.to_i) # TODO: test fails.
       end
+
+      def blank_date_parameter?(year, month, day)
+        year.blank? || month.blank? || day.blank?
+      end
     end
 
     def validate(params)

data/lib/reform/version.rb

@@ -1,3 +1,3 @@
 module Reform
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/test/active_model_test.rb

@@ -48,12 +48,20 @@ class FormBuilderCompatTest < MiniTest::Spec
         property :release_date
         validates :title, :presence => true
       end
+
+      class LabelForm < Reform::Form
+        property :name
+      end
+
+      property :label, :form => LabelForm
     end
   }
 
   let (:song) { OpenStruct.new }
   let (:form) { form_class.new(OpenStruct.new(
-    :artist => Artist.new(:name => "Propagandhi"), :songs => [song])) }
+    :artist => Artist.new(:name => "Propagandhi"),
+    :songs  => [song],
+    :label  => OpenStruct.new)) }
 
   it "respects _attributes params hash" do
     form.validate("artist_attributes" => {"name" => "Blink 182"},
@@ -75,14 +83,40 @@ class FormBuilderCompatTest < MiniTest::Spec
   it "defines _attributes= setter so Rails' FB works properly" do
     form.must_respond_to("artist_attributes=")
     form.must_respond_to("songs_attributes=")
+    form.must_respond_to("label_attributes=")
   end
 
-  it "accepts deconstructed date parameters" do
-    form.validate("artist_attributes" => {"name" => "Blink 182"},
-      "songs_attributes" => {"0" => {"title" => "Damnit", "release_date(1i)" => "1997",
-        "release_date(2i)" => "9", "release_date(3i)" => "27"}})
+  describe "deconstructed date parameters" do
+    let(:form_attributes) do
+      {
+        "artist_attributes" => {"name" => "Blink 182"},
+        "songs_attributes" => {"0" => {"title" => "Damnit", "release_date(1i)" => release_year,
+          "release_date(2i)" => release_month, "release_date(3i)" => release_day}}
+      }
+    end
+    let(:release_year) { "1997" }
+    let(:release_month) { "9" }
+    let(:release_day) { "27" }
+
+    describe "with valid parameters" do
+      it "creates a date" do
+        form.validate(form_attributes)
 
-    form.songs.first.release_date.must_equal Date.new(1997, 9, 27)
+        form.songs.first.release_date.must_equal Date.new(1997, 9, 27)
+      end
+    end
+
+    %w(year month day).each do |date_attr|
+      describe "when the #{date_attr} is missing" do
+        let(:"release_#{date_attr}") { "" }
+
+        it "rejects the date" do
+          form.validate(form_attributes)
+
+          form.songs.first.release_date.must_be_nil
+        end
+      end
+    end
   end
 
   it "returns flat errors hash" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: reform
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Nick Sutterer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-03 00:00:00.000000000 Z
+date: 2013-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: representable