reform-rails 0.2.6 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e32ac394ac02ea272b9a31655ca20b65253b8a417b0f716c7f1eda516c25981b
-  data.tar.gz: 7e520b5e80f4669f289bccaaa8cb5f3c549123d242e42a31e52f0be6e1f1086f
+  metadata.gz: 11444b229bdc2a6b09fc130b3ce39b799be05f9caf0b6ced962cb9162651de05
+  data.tar.gz: 15b2965904cf1083b20a682feb667fe3a44dee3f5f424235b62ffae4e6297eef
 SHA512:
-  metadata.gz: 7b433bafad6faa28202c8a246c334fa2c7c41c735196b66f98353a9bf614990960278a2dccc87203a9985ad05e09077986795d7007e7d674e9938de3886c683d
-  data.tar.gz: 63f646b6f6bac1062176f84da317f05d0a44e58b0c9f3e9f5bfeb8573ceb25d2e659f84561ff831ee593f4f770494e991f49b046948036a67aa87eb2ab08b472
+  metadata.gz: f405809a0c4e33711233bdff60a14ad6c87b0a8e90b94a71b025a5dbb2025b3c3bea9d0b6c6e4c51f20afd4ad06bb513d8ab0d134f6ee22da2545a8436d8e141
+  data.tar.gz: 6c975e0e7c4d66124e909a1ae73b7415e95886a46fda82164dd55eb6f36603a0d69c8ebc9e39ab8a4793e213c59d14c1c30e9f502b8192e81a33e39cdd776127

data/.github/workflows/ci.yml

@@ -1,28 +1,95 @@
 name: CI
+
 on: [push, pull_request]
+
 jobs:
-  test:
-    strategy:
-      fail-fast: false
-      matrix:
-        # Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
-        ruby: [2.5, 2.6, 2.7, '3.0', head]
-        rails: ['6.1', '6.0', '5.2']
-        mongodb-version: ['4.4']
-        exclude:
-          - ruby: '3.0'
-            rails: 5.2
-          - ruby: head
-            rails: 5.2
+  test-rails5:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-    - uses: supercharge/mongodb-github-action@1.6.0
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
       with:
-        mongodb-version: ${{ matrix.mongodb-version }}
+        mongodb-version: "4.4"
     - uses: ruby/setup-ruby@v1
       with:
-        ruby-version: ${{ matrix.ruby }}
-        # bundler-cache: true # runs 'bundle install' and caches installed gems automatically
-    - run: RAILS_VERSION=${{ matrix.rails }} bundle install
-    - run: RAILS_VERSION=${{ matrix.rails }} bundle exec rake
+        ruby-version: "2.5"
+    - run: BUNDLE_GEMFILE=Gemfile-rails5 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails5 bundle exec rake
+
+  test-rails6_0:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "2.6"
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.0 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.0 bundle exec rake
+
+  test-rails6_1:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.0"
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.1 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.1 bundle exec rake
+
+  test-rails7_0:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.0"
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.0 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.0 bundle exec rake
+
+  test-rails7_1:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.2"
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.1 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.1 bundle exec rake
+
+  test-rails7_2:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.3"
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.2 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.2 bundle exec rake
+
+  test-rails8:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.3"
+    - run: BUNDLE_GEMFILE=Gemfile-rails8 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails8 bundle exec rake

data/.gitignore

@@ -1,6 +1,6 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
+/*.lock
 /_yardoc/
 /coverage/
 /doc/

data/CHANGES.md

@@ -1,3 +1,15 @@
+# 0.3.1
+
+* Fix: ActiveModel acceptance validator wasn't properly monkey patched
+  Now this will work in environments where active model and active record is
+  not loaded by default. In addition, it will work with all the Rails versions
+  we support
+
+# 0.3.0
+
+* Add `conditions` option to Reform Uniqueness validation.
+* ActiveModel acceptance validation works
+
 # 0.2.6
 
 * Allow to override `#persisted?` and friends with modules.

data/Gemfile-rails5

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 2.5'
+
+gem "mongoid", "< 7.0"
+gem "activerecord", "~> 5.2"
+gem "railties", "~> 5.2"
+gem "sqlite3", "~> 1.3", "< 1.4"

data/Gemfile-rails6.0

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 2.6'
+
+gem "activerecord", "~> 6.0.0"
+gem "railties", "~> 6.0.0"
+gem "sqlite3"
+gem "mongoid"

data/Gemfile-rails6.1

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.0'
+
+gem "activerecord", "~> 6.1.0"
+gem "railties", "~> 6.1.0"
+gem "sqlite3", "~> 1.4"
+gem "mongoid"

data/Gemfile-rails7.0

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.0'
+
+gem "activerecord", "~> 7.0.0"
+gem "railties", "~> 7.0.0"
+gem "sqlite3", "~> 1.4"
+gem "mongoid"

data/Gemfile-rails7.1

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.2'
+
+gem "activerecord", "~> 7.1.0"
+gem "railties", "~> 7.1.0"
+gem "sqlite3"
+gem "mongoid"

data/Gemfile-rails7.2

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.3'
+
+gem "activerecord", "~> 7.2.0"
+gem "railties", "~> 7.2.0"
+gem "sqlite3"
+gem "mongoid"

data/Gemfile-rails8

@@ -0,0 +1,9 @@
+ 	source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.2'
+
+gem "activerecord", "~> 8.0.0"
+gem "railties", "~> 8.0.0"
+gem "sqlite3"
+gem "mongoid"

data/README.md

@@ -28,14 +28,15 @@ Reform-rails needs Reform >= 2.3.
 
 ## Contributing
 
-By default your tests will run against rails 6.0.1.
-Please ensure that you test your changes against all supported ruby and rails versions (see .travis.yml)
+Please ensure that you test your changes against all supported ruby and rails versions
 
 You can run tests for a specific version of rails by running the following:
 
-`export RAILS_VERSION=5.0.0; bundle update; bundle exec rake test`
+```shell
+BUNDLE_GEMFILE=Gemfile-rails7.0 bundle install
+BUNDLE_GEMFILE=Gemfile-rails7.0 bundle exec rake test
+```
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-

data/lib/reform/form/active_model/acceptance_validator_patch.rb

@@ -0,0 +1,36 @@
+module Reform::Form::ActiveModel
+  module AcceptanceValidatorPatch
+    def self.apply!
+      return if defined?(::ActiveModel::Validations::ReformAcceptanceValidator)
+
+      klass = Class.new(::ActiveModel::EachValidator) do
+        def initialize(options)
+          super({ allow_nil: true, accept: ["1", true] }.merge!(options))
+        end
+
+        def validate_each(record, attribute, value)
+          unless acceptable_option?(value)
+            if Gem::Version.new(::ActiveModel::VERSION::STRING) >= Gem::Version.new('6.1.0')
+              record.errors.add(attribute, :accepted, **options.except(:accept, :allow_nil))
+            else
+              record.errors.add(attribute, :accepted, options.except(:accept, :allow_nil))
+            end
+          end
+        end
+
+        private
+
+        def acceptable_option?(value)
+          Array(options[:accept]).include?(value)
+        end
+      end
+
+      # Assign the class to a constant for tracking
+      ::ActiveModel::Validations.const_set(:ReformAcceptanceValidator, klass)
+
+      # Override the built-in validator
+      ::ActiveModel::Validations.send(:remove_const, :AcceptanceValidator)
+      ::ActiveModel::Validations.const_set(:AcceptanceValidator, klass)
+    end
+  end
+end

data/lib/reform/form/orm.rb

@@ -20,7 +20,11 @@ module Reform::Form::ORM
       @klass = record.class # this is usually done in the super-sucky #setup method.
       super(record).tap do |res|
         if record.errors.present?
-          error = self.class.name.include?("Mongoid") ? record.errors.first.last : :taken
+          error = if Gem::Version.new(ActiveModel::VERSION::STRING) >= Gem::Version.new('6.1.0')
+                    self.class.name.include?("Mongoid") ? record.errors.first.type : :taken
+                  else
+                    self.class.name.include?("Mongoid") ? record.errors.first.last : :taken
+                  end
           form.errors.add(property, error)
         end
       end

data/lib/reform/form/validation/unique_validator.rb

@@ -14,7 +14,7 @@
 # validates :title, unique: { case_sensitive: false }
 #
 # = Scope
-# A scope can be use to filter the records that need to be compare with the
+# A scope can be used to filter the records that need to be compare with the
 # current value to validate. A scope array can have one to many fields define.
 #
 # A scope can be define the following ways:
@@ -33,6 +33,20 @@
 # This use case is useful if album_id is set to a Song this way:
 # song = album.songs.new
 # album_id is automatically set and can't be change by the operation
+#
+# = Conditions
+# A condition can be passed to filter the records with partial indexes
+#
+# Conditions can be define the following ways:
+# validates :title, unique: { conditions: -> { where(archived_at: nil) } }
+# - This will check that the title is unique for non archived records
+# validates :title, unique: {
+#   conditions: ->(record) {
+#     published_at = record.published_at
+#     where(published_at: published_at.beginning_of_year..published_at.end_of_year)
+#   }
+# }
+#
 
 class Reform::Form::UniqueValidator < ActiveModel::EachValidator
   def validate_each(form, attribute, value)
@@ -57,6 +71,16 @@ class Reform::Form::UniqueValidator < ActiveModel::EachValidator
       query = query.where(field => form.send(field))
     end
 
+    if options[:conditions]
+      conditions = options[:conditions]
+
+      query = if conditions.arity.zero?
+                query.instance_exec(&conditions)
+              else
+                query.instance_exec(form, &conditions)
+              end
+    end
+
     form.errors.add(attribute, :taken) if query.count > 0
   end
 end

data/lib/reform/rails/railtie.rb

@@ -57,6 +57,17 @@ module Reform
           include Reform::Form::Dry
         end
       end
+
+      initializer "reform.patch_acceptance_validator" do
+        require "reform/form/active_model/acceptance_validator_patch"
+
+        if defined?(::ActiveModel::Validations::AcceptanceValidator)
+          Reform::Form::ActiveModel::AcceptanceValidatorPatch.apply!
+        else
+          ActiveSupport.on_load(:active_record) { Reform::Form::ActiveModel::AcceptanceValidatorPatch.apply! }
+          Rails.application.config.to_prepare { Reform::Form::ActiveModel::AcceptanceValidatorPatch.apply! }
+        end
+      end
     end # Railtie
   end
 end

data/lib/reform/rails/version.rb

@@ -1,5 +1,5 @@
 module Reform
   module Rails
-    VERSION = "0.2.6"
+    VERSION = "0.3.1"
   end
 end

data/reform-rails.gemspec

@@ -22,4 +22,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "reform", ">= 2.3.1", "< 3.0.0"
   spec.add_dependency "activemodel", ">= 5.0"
+  spec.add_development_dependency "minitest"
+  spec.add_development_dependency "minitest-line"
+  spec.add_development_dependency "debug"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: reform-rails
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.3.1
 platform: ruby
 authors:
 - Nick Sutterer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-08-11 00:00:00.000000000 Z
+date: 2025-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: reform
@@ -44,6 +44,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest-line
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: debug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Automatically load and include all common Reform features for a standard
   Rails environment.
 email:
@@ -55,12 +97,19 @@ files:
 - ".github/workflows/ci.yml"
 - ".gitignore"
 - CHANGES.md
-- Gemfile
+- Gemfile-rails5
+- Gemfile-rails6.0
+- Gemfile-rails6.1
+- Gemfile-rails7.0
+- Gemfile-rails7.1
+- Gemfile-rails7.2
+- Gemfile-rails8
 - LICENSE.txt
 - README.md
 - Rakefile
 - lib/reform/active_record.rb
 - lib/reform/form/active_model.rb
+- lib/reform/form/active_model/acceptance_validator_patch.rb
 - lib/reform/form/active_model/form_builder_methods.rb
 - lib/reform/form/active_model/model_reflections.rb
 - lib/reform/form/active_model/model_validations.rb
@@ -80,7 +129,7 @@ homepage: https://github.com/trailblazer/reform-rails
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -95,8 +144,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
-signing_key: 
+rubygems_version: 3.3.27
+signing_key:
 specification_version: 4
 summary: Automatically load and include all common Rails form features.
 test_files: []

data/Gemfile

@@ -1,33 +0,0 @@
-git_source(:github) do |repo_name|
-  repo_name = "#{repo_name}/#{repo_name}" unless repo_name.include?("/")
-  "https://github.com/#{repo_name}.git"
-end
-
-source "https://rubygems.org"
-gemspec
-
-# gem 'pry-byebug'
-gem "minitest-line"
-
-case ENV["GEMS_SOURCE"]
-  when "local"
-    gem "reform", path: "../reform"
-  when "github"
-    gem "reform", github: "trailblazer/reform"
-end
-
-rails_version = ENV.fetch("RAILS_VERSION", "6.0.0")
-
-# bored of wrestling with rails...
-
-gem("mongoid", "< 7.0") unless rails_version.to_i >= 6
-
-
-gem "activerecord", "~> #{rails_version}"
-gem "railties", "~> #{rails_version}"
-if rails_version.to_i >= 6
-  gem "sqlite3", "~> 1.4"
-else
-  gem "sqlite3", "~> 1.3", "< 1.4"
-end
-puts "Rails version #{rails_version}"