reform-rails 0.1.7 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ef8e06973cbbd53737de0a7d0afe1250bdba0814
-  data.tar.gz: 986c4d29338ecdc03fb3dea2ab7c75f6c9253ce6
+SHA256:
+  metadata.gz: 11444b229bdc2a6b09fc130b3ce39b799be05f9caf0b6ced962cb9162651de05
+  data.tar.gz: 15b2965904cf1083b20a682feb667fe3a44dee3f5f424235b62ffae4e6297eef
 SHA512:
-  metadata.gz: 314925db393628f4f0d7a2dc32808217c7b2d17d0e27d86d69299b14df875917a1598857c291ea3eec8605bbcfb4e31e1d908c12df66ad3c4dd25a8fae6bc3ce
-  data.tar.gz: 9f8f292731ef5b34f8abe6a046d738d18bd98b9192564ba592e8d922bfef02e0f61ba3feddee77d69cc2e590b4e91310bc925ec749fedbfcbee1b0ba458c0869
+  metadata.gz: f405809a0c4e33711233bdff60a14ad6c87b0a8e90b94a71b025a5dbb2025b3c3bea9d0b6c6e4c51f20afd4ad06bb513d8ab0d134f6ee22da2545a8436d8e141
+  data.tar.gz: 6c975e0e7c4d66124e909a1ae73b7415e95886a46fda82164dd55eb6f36603a0d69c8ebc9e39ab8a4793e213c59d14c1c30e9f502b8192e81a33e39cdd776127

data/.github/workflows/ci.yml

@@ -0,0 +1,95 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test-rails5:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "2.5"
+    - run: BUNDLE_GEMFILE=Gemfile-rails5 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails5 bundle exec rake
+
+  test-rails6_0:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "2.6"
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.0 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.0 bundle exec rake
+
+  test-rails6_1:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.0"
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.1 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails6.1 bundle exec rake
+
+  test-rails7_0:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.0"
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.0 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.0 bundle exec rake
+
+  test-rails7_1:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.2"
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.1 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.1 bundle exec rake
+
+  test-rails7_2:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.3"
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.2 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails7.2 bundle exec rake
+
+  test-rails8:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v5
+    - uses: supercharge/mongodb-github-action@1.12.0
+      with:
+        mongodb-version: "4.4"
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: "3.3"
+    - run: BUNDLE_GEMFILE=Gemfile-rails8 bundle install
+    - run: BUNDLE_GEMFILE=Gemfile-rails8 bundle exec rake

data/.gitignore

@@ -1,6 +1,6 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
+/*.lock
 /_yardoc/
 /coverage/
 /doc/
@@ -8,4 +8,7 @@
 /spec/reports/
 /tmp/
 *.gem
-test/dummy/log/*.log
+*.sqlite3
+.byebug*
+*.log
+.rubocop-https*

data/CHANGES.md

@@ -1,3 +1,58 @@
+# 0.3.1
+
+* Fix: ActiveModel acceptance validator wasn't properly monkey patched
+  Now this will work in environments where active model and active record is
+  not loaded by default. In addition, it will work with all the Rails versions
+  we support
+
+# 0.3.0
+
+* Add `conditions` option to Reform Uniqueness validation.
+* ActiveModel acceptance validation works
+
+# 0.2.6
+
+* Allow to override `#persisted?` and friends with modules.
+
+# 0.2.5
+
+* Fix: Delegating from form object causes ArgumentError with 0.2.4 (https://github.com/trailblazer/reform-rails/issues/99)
+
+# 0.2.4
+
+* Fix keyword argument warning in `method_missing` (https://github.com/trailblazer/reform-rails/pull/97)
+* Internal: Replace Uber::Delegates with Forwardable in Form::ActiveModel
+
+# 0.2.3
+
+* Fix deprecation warning related to `respond_to?`
+
+# 0.2.2
+
+* Support ActiveRecord 6.1
+
+# 0.2.1
+
+* Error's full_message  with translation fixed thanks to [@marcelolx](https://github.com/trailblazer/reform-rails/pull/85)
+
+# 0.2.0
+
+* Needs Reform >= 2.3.0.
+* make the inclusion of ActiveModel form builder modules optional when using dry-validation. This can be controlled via `config.reform.enable_active_model_builder_methods = true`.
+* delegate `validates_each` method and allow it to be called outside a validation block.
+* add `case_sensitive` option to Reform Uniqueness validation. Defaults to true.
+* fix bug in uniqueness validation where form has different attribute name to column
+* improve handling of persisted records in uniqueness validator
+* remove params.merge! as it's deprecated in rails 5
+* update to support reform 2.3, the new API means that `errors.add` is delegated to ActiveModel::Errors to support rails 5
+* Fix nested form validation (#53)
+* Errors supports symbol and string lookup (PR #77)
+* Implement respond_to that delegates to AMV errors (PR #78)
+* Drop support for activemodel before 5.0
+
+# 0.1.8
+* Drop support to mongoid < 4.
+
 # 0.1.7 (0.1.6 Yanked)
 
 * Fix a bug where requiring `form/active_model/validations` in a non-Rails environment wouldn't load all necessary files.
@@ -12,7 +67,7 @@
 
 # 0.1.3
 
-* Introduce a railtie to load either `ActiveModel::Validations` *or* `Dry::Validations`. This can be controller via `config.reform.validations = :dry`.
+* Introduce a railtie to load either `ActiveModel::Validations` *or* `Dry::Validations`. This can be controlled via `config.reform.validations = :dry`.
 
 # 0.1.2
 

data/Gemfile-rails5

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 2.5'
+
+gem "mongoid", "< 7.0"
+gem "activerecord", "~> 5.2"
+gem "railties", "~> 5.2"
+gem "sqlite3", "~> 1.3", "< 1.4"

data/Gemfile-rails6.0

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 2.6'
+
+gem "activerecord", "~> 6.0.0"
+gem "railties", "~> 6.0.0"
+gem "sqlite3"
+gem "mongoid"

data/Gemfile-rails6.1

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.0'
+
+gem "activerecord", "~> 6.1.0"
+gem "railties", "~> 6.1.0"
+gem "sqlite3", "~> 1.4"
+gem "mongoid"

data/Gemfile-rails7.0

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.0'
+
+gem "activerecord", "~> 7.0.0"
+gem "railties", "~> 7.0.0"
+gem "sqlite3", "~> 1.4"
+gem "mongoid"

data/Gemfile-rails7.1

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.2'
+
+gem "activerecord", "~> 7.1.0"
+gem "railties", "~> 7.1.0"
+gem "sqlite3"
+gem "mongoid"

data/Gemfile-rails7.2

@@ -0,0 +1,9 @@
+source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.3'
+
+gem "activerecord", "~> 7.2.0"
+gem "railties", "~> 7.2.0"
+gem "sqlite3"
+gem "mongoid"

data/Gemfile-rails8

@@ -0,0 +1,9 @@
+ 	source "https://rubygems.org"
+gemspec
+
+ruby '~> 3.2'
+
+gem "activerecord", "~> 8.0.0"
+gem "railties", "~> 8.0.0"
+gem "sqlite3"
+gem "mongoid"

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2015 Nick Sutterer
+Copyright (c) 2015-2021 Nick Sutterer
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -14,7 +14,7 @@ Simply don't include this gem if you don't want to use the conventional Reform/R
 
 ## Documentation
 
-The [full documentation](http://trailblazer.to/gems/reform/#reform-rails) can be found on the Trailblazer page.
+The [full documentation](https://trailblazer.to/2.0/gems/reform/rails.html) can be found on the Trailblazer page.
 
 ## Installation
 
@@ -24,9 +24,19 @@ Add this line to your application's Gemfile:
 gem 'reform-rails'
 ```
 
-Reform-rails needs Reform >= 2.2.
+Reform-rails needs Reform >= 2.3.
+
+## Contributing
+
+Please ensure that you test your changes against all supported ruby and rails versions
+
+You can run tests for a specific version of rails by running the following:
+
+```shell
+BUNDLE_GEMFILE=Gemfile-rails7.0 bundle install
+BUNDLE_GEMFILE=Gemfile-rails7.0 bundle exec rake test
+```
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).
-

data/Rakefile

@@ -4,7 +4,9 @@ require "rake/testtask"
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
-  t.test_files = FileList['test/**/*_test.rb']
+  t.test_files = FileList['test/*_test.rb']
+  t.warning = false
+  t.verbose = true
 end
 
 task :default => :test

data/lib/reform/active_record.rb

@@ -1,4 +1,5 @@
-require "reform/form/active_model"
 require "reform/form/orm"
+require "reform/form/active_model"
 require "reform/form/active_record"
 require "reform/form/active_model/model_reflections" # only load this in AR context as simple_form currently is bound to AR.
+require "reform/form/active_model/result"

data/lib/reform/form/active_model/acceptance_validator_patch.rb

@@ -0,0 +1,36 @@
+module Reform::Form::ActiveModel
+  module AcceptanceValidatorPatch
+    def self.apply!
+      return if defined?(::ActiveModel::Validations::ReformAcceptanceValidator)
+
+      klass = Class.new(::ActiveModel::EachValidator) do
+        def initialize(options)
+          super({ allow_nil: true, accept: ["1", true] }.merge!(options))
+        end
+
+        def validate_each(record, attribute, value)
+          unless acceptable_option?(value)
+            if Gem::Version.new(::ActiveModel::VERSION::STRING) >= Gem::Version.new('6.1.0')
+              record.errors.add(attribute, :accepted, **options.except(:accept, :allow_nil))
+            else
+              record.errors.add(attribute, :accepted, options.except(:accept, :allow_nil))
+            end
+          end
+        end
+
+        private
+
+        def acceptable_option?(value)
+          Array(options[:accept]).include?(value)
+        end
+      end
+
+      # Assign the class to a constant for tracking
+      ::ActiveModel::Validations.const_set(:ReformAcceptanceValidator, klass)
+
+      # Override the built-in validator
+      ::ActiveModel::Validations.send(:remove_const, :AcceptanceValidator)
+      ::ActiveModel::Validations.const_set(:AcceptanceValidator, klass)
+    end
+  end
+end

data/lib/reform/form/active_model/result.rb

@@ -0,0 +1,15 @@
+class Reform::Contract::Result  
+  private
+
+  def filter_for(method, *args)
+    @results.collect { |r| r.public_send(method, *args).to_h }
+            .inject({}) { |hah, err| hah.merge(err) { |key, old_v, new_v| (new_v.is_a?(Array) ? (old_v |= new_v) : old_v.merge(new_v)) } }
+            .find_all { |k, v| # filter :nested=>{:something=>["too nested!"]} #DISCUSS: do we want that here?
+              if v.is_a?(Hash)
+                nested_errors = v.select { |attr_key, val| attr_key.is_a?(Integer) && val.is_a?(Array) && val.any? }
+                v = nested_errors.to_a if nested_errors.any?
+              end
+              v.is_a?(Array) || v.class.to_s == "ActiveModel::DeprecationHandlingMessageArray"
+            }.to_h
+  end
+end