reflexive 0.0.6 → 0.1.0

data/spec/rails_integration_spec.rb

@@ -10,6 +10,10 @@ shared_examples_for "fresh Rails app with Reflexive installed" do
     get("/").should include("Welcome aboard")
   end
 
+  it "doesn't respond on not existing path" do
+    proc { get("/not_exist") }.should raise_error
+  end
+
   it "responds for Reflexive paths" do
     constant_reflexion = get("/reflexive/constants/ActiveRecord::Base")
     constant_reflexion.should include("ActiveRecord")
@@ -112,11 +116,14 @@ describe "Integration with" do
                           class Application < Rails::Application
                             config.middleware.insert_after("Rack::Lock", "Reflexive::Application")
           RUBY
+
+          patch_app_file("Gemfile", /\z/, "\ngem 'reflexive'")
         end
 
         it "properly" do
           Dir.chdir($app_dir) do
             IO.read("config/application.rb").should include("Reflexive")
+            IO.read("Gemfile").should include("reflexive")
           end
         end
 

data/spec/rails_integration_spec_helper.rb

@@ -69,25 +69,35 @@ def build_and_install_test_gem
   end
 end
 
+SERVER_STARTUP_TIME = 20
 def spawn_server_and_wait_for_response(cmd)
   $server_pid = spawn(tmp_gemset_env, cmd)
-  puts "Spawned server with #{ $server_pid } PID"
-  tries = 0
-  print "Waiting for server to start..."
-  started = false
-  while (tries += 1) < 10 && !started
-  started = get("/").include?("Welcome aboard") rescue false
-  print "."
-  sleep 1
+  begin
+    trap("CLD") { raise "Failed to start server: server died prematurely" }
+    puts "Spawned server with #{ $server_pid } PID"
+    tries = 0
+    print "Waiting for server to start..."
+    started = false
+    while (tries += 1) < SERVER_STARTUP_TIME && !started
+      started = get("/").include?("Welcome aboard") rescue false
+      print "."
+      sleep 1
+    end
+    print "\n"
+    unless started
+      raise "Failed to start server: server didn't respond in #{ SERVER_STARTUP_TIME } seconds"
+    end
+  rescue Exception => e
+    raise e.exception("Failed to start server: #{ e.message }")
+  ensure
+    trap("CLD", nil)
   end
-  print "\n"
-  abort "Failed to start server" unless started
 end
 
 def terminate_server_blocking
   puts "Terminating server with #{ $server_pid } PID..."
   `kill -9 #{ $server_pid }`
-  Process::waitpid2($server_pid)
+  Process::waitpid2($server_pid) rescue nil
 end
 
 def get(path)

data/spec/reflexive_ripper_spec.rb

@@ -57,7 +57,7 @@ describe Reflexive::ReflexiveRipper do
   describe "injects method call scanner event tags" do
     specify "m!" do
       scanner_events_for("m!").should(have_tags(
-              {:method_call=>{:name=>"m!", :receiver=>[], :scope => []}}
+              {:method_call=>{:name=>"m!", :receiver=>:class, :scope => []}}
       ))
     end
 
@@ -109,7 +109,7 @@ describe Reflexive::ReflexiveRipper do
     specify "1.tap { (dv = 1).tap { puts dv } }" do
       scanner_events_for("1.tap { (dv = 1).tap { puts dv } }").should(have_exact_tags(
               {:local_variable_assignment=>"2:dv"},
-              {:method_call=>{:name=>"puts", :receiver=>[], :scope => []}},
+              {:method_call=>{:name=>"puts", :receiver=>:class, :scope => []}},
               {:local_variable_access=>"2:dv"}
       ))
     end
@@ -123,8 +123,9 @@ describe Reflexive::ReflexiveRipper do
     specify "tv = 1; def m; puts tv; end" do
       scanner_events_for("tv = 1; def m; puts tv; end").should(have_tags(
               {:local_variable_assignment=>"1:tv"},
-              {:method_call=>{:name=>"puts", :receiver=>[:instance], :scope => []}},
-              {:method_call=>{:name=>"tv", :receiver=>[:instance], :scope => []}}))
+              {:method_call=>{:name=>"puts", :receiver=>:instance, :scope => []}},
+              {:method_call=>{:name=>"tv", :receiver=>:instance, :scope => []}}
+      ))
     end
 
   end
@@ -133,44 +134,54 @@ describe Reflexive::ReflexiveRipper do
     describe "for method calls" do
       specify "from top level" do
         scanner_events_for("m()").should(have_tags(
-              {:method_call=>{:name=>"m", :receiver=>[], :scope => []}}))
+              {:method_call=>{:name=>"m", :receiver=>:class, :scope => []}}
+        ))
       end
 
       specify "class definition level" do
         scanner_events_for("class C; cm(); end").should(have_tags(
-              {:method_call=>{:name=>"cm", :receiver=>["C"], :scope => ["C"]}}))
+              {:method_call=>{:name=>"cm", :receiver=>:class, :scope => ["C"]}}
+        ))
         scanner_events_for("module M; cm(); end").should(have_tags(
-              {:method_call=>{:name=>"cm", :receiver=>["M"], :scope => ["M"]}}))
+              {:method_call=>{:name=>"cm", :receiver=>:class, :scope => ["M"]}}
+        ))
       end
 
       specify "class instance level" do
         scanner_events_for("class C; def im1; im2; end end").should(have_tags(
-              {:method_call=>{:name=>"im2", :receiver=>["C", :instance], :scope => ["C"]}}))
+              {:method_call=>{:name=>"im2", :receiver=>:instance, :scope => ["C"]}}
+        ))
         scanner_events_for("module M; def im1; im2; end end").should(have_tags(
-              {:method_call=>{:name=>"im2", :receiver=>["M", :instance], :scope => ["M"]}}))
+              {:method_call=>{:name=>"im2", :receiver=>:instance, :scope => ["M"]}}
+        ))
       end
 
       specify "class singleton level" do
         scanner_events_for("class C; def self.cm1() cm2; end end").should(have_tags(
-              {:method_call=>{:name=>"cm2", :receiver=>["C"], :scope => ["C"]}}))
+              {:method_call=>{:name=>"cm2", :receiver=>:class, :scope => ["C"]}}
+        ))
         scanner_events_for("module M; def self.cm1() cm2; end end").should(have_tags(
-              {:method_call=>{:name=>"cm2", :receiver=>["M"], :scope => ["M"]}}))
+              {:method_call=>{:name=>"cm2", :receiver=>:class, :scope => ["M"]}}
+        ))
+      end
+
+      specify "class singleton level for methods defined with class << self" do
+        scanner_events_for("class C; class << self; def cm1(); cm2; end end end").should(have_tags(
+              {:method_call=>{:name=>"cm2", :receiver=>:class, :scope => ["C"]}}
+        ))
       end
 
-      pending "nested method calls with constant references" do
+      specify "nested method calls with constant references" do
         src = <<-RUBY
           module M
             class C
-              def self.m
-              end
-            end
-          end
-          class M::C
-            def m
-              c = C.m
             end
+            C.new
           end
         RUBY
+        scanner_events_for(src).should(have_tags(
+              {:method_call=>{:name=>"new", :receiver=>["C"], :scope => ["M"]}}
+        ))
       end
     end
 
@@ -233,6 +244,33 @@ describe Reflexive::ReflexiveRipper do
         ))
 
       end
+
+      specify "from instance methods params" do
+        scanner_events_for("def m(a = C.new(m1), b = D.new(m2)); end").should(have_tags(
+              {:constant_access=>{:name=>"C", :scope=>[]}},
+              {:constant_access=>{:name=>"D", :scope=>[]}}
+        ))
+      end
+
+      specify "for superclass" do
+        scanner_events_for("class C < D; end").should(have_tags(
+              {:constant_access=>{:name=>"D", :scope=>[]}}
+        ))
+      end
+
+      specify "autoload hint" do
+        scanner_events_for("module M; autoload :C; end").should(have_tags(
+              {:constant_access=>{:name=>"C", :scope=>["M"]}}
+        ))
+
+        scanner_events_for("module M; autoload 'C'; end").should(have_tags(
+              {:constant_access=>{:name=>"C", :scope=>["M"]}}
+        ))
+
+        scanner_events_for("module M; autoload('C'); end").should(have_tags(
+              {:constant_access=>{:name=>"C", :scope=>["M"]}}
+        ))
+      end
     end
   end
 

data/spec/reflexive_spec.rb

@@ -26,6 +26,13 @@ end
 
 C2.extend(M2)
 
+module ModuleDescendantBaseModule
+end
+
+module ModuleDescendantModule
+  include ModuleDescendantBaseModule
+end
+
 describe "Reflexive.loaded_features_lookup" do
   before(:all) do
     @native_feature = $LOADED_FEATURES.detect { |f| f =~ /\.so\z/ }
@@ -61,6 +68,10 @@ describe "Reflexive.constant_lookup" do
     Reflexive.constant_lookup("::String", "Some::Ignored::Scope").should == ::String
   end
 
+  it "looks up top-level constants when passed empty scope" do
+    Reflexive.constant_lookup("String", "").should == ::String
+  end
+
   it "returns nil for non existing top-level constant" do
     Reflexive.constant_lookup("::StringAsd", "Some::Ignored::Scope").should == nil
   end
@@ -96,4 +107,8 @@ describe "Reflexive.descendants" do
   it "finds singleton class descendant" do
     Reflexive.descendants(M2).should =~ [C2]
   end
+
+  it "reports modules which include module as descendants" do
+    Reflexive.descendants(ModuleDescendantBaseModule) =~ [ModuleDescendantModule]
+  end
 end

data/views/constants_show.erb

@@ -19,9 +19,26 @@
 <% unless @methods.files.empty? %>
   <div>
     <h4>Defined In Files</h4>
-    <% @methods.files.sort.each do |path| %>
+    
+    <% files = @methods.files.sort %>
+    <% shown, hidden = files[0..5], files[6..-1] %>
+
+    <% shown.each do |path| %>
       <%= link_to_file(path) %><br/>
     <% end %>
+    
+    <% if hidden && !hidden.empty? %>
+      <div class="opener">
+        <a class="trigger" href="#">
+          ... <%= hidden.size %> files more
+        </a>
+        <div class="content">
+          <% hidden.each do |path| %>
+            <%= link_to_file(path) %><br/>
+          <% end %>
+        </div>
+      </div>
+    <% end %> 
   </div>
 <% end %>
 

data/views/dashboard.erb

@@ -1,10 +1,9 @@
-<h1>
-  Reflexive </h1>
+<h1> Reflexive </h1>
 
 <div class="dashboard">
   <% if defined?(ActiveRecord::Base) || defined?(ApplicationController) %>
     <div class="row">
-      <div class="column">
+      <div class="column first">
         <% if defined?(::ActiveRecord::Base) %>
           <h2>Models</h2>
 
@@ -27,7 +26,7 @@
     </div>
   <% end %>
   <div class="row">
-    <div class="column">
+    <div class="column first">
       <h2>Favorites</h2>
       <% favorites = filter_existing_constants(%w(Rails ActiveSupport ActiveResource
         ActiveRecord ActionView ActionController ActionDispatch ActionMailer ActiveModel

data/views/layout.erb

@@ -10,6 +10,16 @@
 </head>
 <body>
 
+<% if Reflexive.class_reloading_active? %>
+  <div style="background-color: #ffc0cb; border: 1px solid gray; padding: 1em 1em; width: 500px">
+    Warning! You're running Reflexive with <code>config.cache_classes = false</code> <br/>
+    Rails setting (which is the default for running server in development environment).<br/>
+    Currently Reflexive isn't compatible with this setting and you may want to<br/>
+    either set <code>config.cache_classes = true</code> in your environment configuration<br/>
+    file or run the server in production mode with <br/><code>rails s --environment=production</code>
+  </div>
+<% end %>
+
 <div class="dashboard-link">
   <%= link_to("Reflexive Dashboard", dashboard_path) unless request.path == dashboard_path %>
 </div>

data/views/methods_apidock.erb

@@ -1,9 +1,17 @@
 <h2>
   <%= @klass.name %>#<%= @method_name %>
 </h2>
+
+<div>
+  Documentation provided by <a href="http://apidock.com/">APIdock</a>
+  <%= link_to apidock_path(@klass.name, @level, @method_name),
+              apidock_path(@klass.name, @level, @method_name) %> :
+  
+</div>
+
 <%= content_tag :iframe,
                 "",
-                :src => apidock_path(@klass.name, @method_name),
+                :src => apidock_path(@klass.name, @level, @method_name),
                 :frameborder => 0,
                 :style => "width: 960px; height: 100%; position: absolute",
                 :id => "apidock" %>

data/views/methods_choose.erb

@@ -0,0 +1,19 @@
+<div>
+  Calling <code><%= @name %></code> <%= @level %> method from
+  <code><%= @klass %></code> can dispatch to following methods 
+</div>
+
+<% if @last_resort_lookup_used %>
+  <div>
+    Note: the list of methods below was generated using last resort lookup
+    algorithm, i.e. by just looking for named method in any class/module
+    currently loaded. 
+  </div>
+<% end %>
+
+<div>
+  <% links = @definitions.
+          sort_by { |klass, _, _| klass.to_s }.
+          map { |d| full_name_link_to_method(*d) } %>
+  <%= content_tag :pre, links.join("\n") %>
+</div>

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: reflexive
 version: !ruby/object:Gem::Version 
-  hash: 19
   prerelease: false
   segments: 
   - 0
+  - 1
   - 0
-  - 6
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors: 
 - Evgeniy Dolzhenko
@@ -15,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-05-17 00:00:00 -07:00
+date: 2010-05-20 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -24,12 +23,13 @@ dependencies:
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
+        - 1
+        - 1
         - 0
-        version: "0"
+        version: 1.1.0
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -38,12 +38,12 @@ dependencies:
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
+        - 1
         - 0
-        version: "0"
+        version: "1.0"
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
@@ -52,12 +52,13 @@ dependencies:
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
-        version: "0"
+        - 3
+        - 40
+        version: 0.3.40
   type: :runtime
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
@@ -66,77 +67,108 @@ dependencies:
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
         - 0
-        version: "0"
+        - 9
+        - 3
+        version: 0.9.3
   type: :runtime
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
-  name: rdiscount
+  name: rails
   prerelease: false
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
+        - 3
         - 0
-        version: "0"
-  type: :runtime
+        - 0
+        - beta3
+        version: 3.0.0.beta3
+  type: :development
   version_requirements: *id005
 - !ruby/object:Gem::Dependency 
-  name: rails
+  name: rspec
   prerelease: false
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: -690468206
         segments: 
-        - 3
+        - 2
         - 0
         - 0
-        - beta3
-        version: 3.0.0.beta3
+        - beta
+        - 8
+        version: 2.0.0.beta.8
   type: :development
   version_requirements: *id006
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: sinatra-reloader
   prerelease: false
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - "="
       - !ruby/object:Gem::Version 
-        hash: -44051750
         segments: 
-        - 2
-        - 0
         - 0
-        - beta
-        - 8
-        version: 2.0.0.beta.8
+        - 4
+        - 1
+        version: 0.4.1
   type: :development
   version_requirements: *id007
 - !ruby/object:Gem::Dependency 
-  name: sinatra-reloader
+  name: thin
   prerelease: false
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - "="
       - !ruby/object:Gem::Version 
-        hash: 3
         segments: 
-        - 0
-        version: "0"
+        - 1
+        - 2
+        - 7
+        version: 1.2.7
   type: :development
   version_requirements: *id008
+- !ruby/object:Gem::Dependency 
+  name: rack-test
+  prerelease: false
+  requirement: &id009 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        - 5
+        - 3
+        version: 0.5.3
+  type: :development
+  version_requirements: *id009
+- !ruby/object:Gem::Dependency 
+  name: webrat
+  prerelease: false
+  requirement: &id010 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - "="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        - 7
+        - 1
+        version: 0.7.1
+  type: :development
+  version_requirements: *id010
 description: 
 email: 
 - dolzenko@gmail.com
@@ -153,10 +185,12 @@ files:
 - lib/reflexive/columnizer.rb
 - lib/reflexive/constantize.rb
 - lib/reflexive/core_ext/kernel/singleton_class.rb
+- lib/reflexive/core_ext/module/reflexive_instance_methods.rb
 - lib/reflexive/descendants.rb
 - lib/reflexive/faster_open_struct.rb
 - lib/reflexive/helpers.rb
 - lib/reflexive/methods.rb
+- lib/reflexive/method_lookup.rb
 - lib/reflexive/parse_tree_top_down_walker.rb
 - lib/reflexive/reflexive_ripper.rb
 - lib/reflexive/routing_helpers.rb
@@ -174,12 +208,16 @@ files:
 - views/files_show.erb
 - views/layout.erb
 - views/methods_apidock.erb
+- views/methods_choose.erb
 - views/methods_definition.erb
 - views/methods_rubydoc.erb
 - spec/coderay_html_encoder_spec.rb
 - spec/coderay_ruby_scanner_spec.rb
+- spec/integration_spec.rb
+- spec/integration_spec_fixture.rb
 - spec/io_interceptor.rb
 - spec/methods_spec.rb
+- spec/method_lookup_spec.rb
 - spec/rails_integration_spec.rb
 - spec/rails_integration_spec_helper.rb
 - spec/reflexive_ripper_spec.rb
@@ -206,7 +244,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 49
       segments: 
       - 1
       - 9
@@ -217,7 +254,6 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
       segments: 
       - 0
       version: "0"