refinerycms-pages 4.0.2 → 4.1.0

data/spec/controllers/refinery/pages_controller_spec.rb

@@ -3,22 +3,39 @@ require "spec_helper"
 module Refinery
   describe PagesController, :type => :controller do
     before do
-      FactoryBot.create(:page, :link_url => "/")
-      FactoryBot.create(:page, :title => "test")
+      FactoryBot.create(:page, { link_url: "/" })
+      FactoryBot.create(:page, title:  "testing")
+      FactoryBot.create(:page, link_url: "/items")
     end
 
     describe "#home" do
-      it "renders home template" do
-        get :home
-        expect(response).to render_template("home")
+      context "when page path set to default ('/')" do
+        it "renders home template" do
+          get :home
+          expect(response).to render_template("home")
+        end
+      end
+
+      context "when home_page_path set to another path" do
+        it "redirects to the specified path" do
+          allow(Refinery::Pages).to receive(:home_page_path).and_return('/items')
+          get :home
+          expect(response).to redirect_to('/items')
+        end
       end
     end
 
     describe "#show" do
       it "renders show template" do
-        get :show, params: {path: "test"}
+        get :show, params: {path: "testing"}
         expect(response).to render_template("show")
       end
     end
+
+    describe "#show" do
+      it "does not interfere with active storage" do
+        expect(:get => "/rails/active_storage").not_to be_routable
+      end
+    end
   end
 end

data/spec/factories/page_parts.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :page_part, class: Refinery::PagePart do
-    title 'Body'
-    slug 'side_body'
+    title { 'Body' }
+    slug { 'side_body' }
   end
 end

data/spec/helpers/refinery/pages/admin/pages_helper_spec.rb

@@ -18,13 +18,13 @@ module Refinery
 
         context "when page layout template is set using symbols" do
           before do
-            allow(Pages.config).to receive(:layout_template_whitelist).and_return [:three, :one, :two]
+            allow(Refinery::Pages.config).to receive(:layout_template_whitelist).and_return [:three, :one, :two]
           end
 
-          it "works as expected" do
-            page = FactoryBot.create(:page, :layout_template => "three")
+          it "page layout template is set correctly" do
+            page = FactoryBot.create(:page, layout_template: "three")
 
-            expect(helper.template_options(:layout_template, page)).to eq(:selected => 'three')
+            expect(helper.template_options(:layout_template, page)).to eq(selected: 'three')
           end
         end
 
@@ -57,9 +57,7 @@ module Refinery
           it "adds 'hidden' label" do
             page.show_in_menu = false
 
-            expect(helper.page_meta_information(page)).to eq(
-              %Q{<span class="label">#{::I18n.t('refinery.admin.pages.page.hidden')}</span>}
-            )
+            expect(helper.page_meta_information(page)).to have_text ::I18n.t('refinery.admin.pages.page.hidden')
           end
         end
 
@@ -67,29 +65,21 @@ module Refinery
           it "adds 'skip to first child' label" do
             page.skip_to_first_child = true
 
-            expect(helper.page_meta_information(page)).to eq(
-              %Q{<span class="label">#{::I18n.t('refinery.admin.pages.page.skip_to_first_child')}</span>}
-            )
+            expect(helper.page_meta_information(page)).to have_text ::I18n.t('refinery.admin.pages.page.skip_to_first_child')
           end
         end
 
         context "when link_url is present" do
           it "adds 'redirected' label" do
             page.link_url = '/redirect'
-
-            expect(helper.page_meta_information(page)).to eq(
-              %Q{<span class="label">#{::I18n.t('refinery.admin.pages.page.redirected')}</span>}
-            )
+            expect(helper.page_meta_information(page)).to have_text ::I18n.t('refinery.admin.pages.page.redirected')
           end
         end
 
         context "when draft is true" do
           it "adds 'draft' label" do
             page.draft = true
-
-            expect(helper.page_meta_information(page)).to eq(
-              %Q{<span class="label notice">#{::I18n.t('refinery.admin.pages.page.draft')}</span>}
-            )
+            expect(helper.page_meta_information(page)).to have_text ::I18n.t('refinery.admin.pages.page.draft')
           end
         end
       end

data/spec/models/refinery/page_menu_spec.rb

@@ -42,7 +42,7 @@ module Refinery
 
       context "with #menu_title" do
         before do
-          page[:menu_title] = "Menu Title"
+          page.menu_title = "Menu Title"
         end
 
         it_should_behave_like "Refinery menu item hash"
@@ -54,7 +54,7 @@ module Refinery
 
       context "with #title" do
         before do
-          page[:title] = "Title"
+          page.title = "Title"
         end
 
         it_should_behave_like "Refinery menu item hash"

data/spec/models/refinery/page_url_spec.rb

@@ -105,7 +105,7 @@ module Refinery
 
       describe '#canonical' do
         let!(:default_canonical) {
-          Globalize.with_locale(Refinery::I18n.default_frontend_locale) {
+          Mobility.with_locale(Refinery::I18n.default_frontend_locale) {
             page.canonical
           }
         }
@@ -121,7 +121,7 @@ module Refinery
         specify "translated page returns its pages's canonical"  do
           allow(Refinery::I18n).to receive(:current_frontend_locale).and_return(:ru)
 
-          Globalize.with_locale(:ru) do
+          Mobility.with_locale(:ru) do
             page.title = ru_page_title
             page.save
 
@@ -133,7 +133,7 @@ module Refinery
 
       describe '#canonical_slug' do
         let!(:default_canonical_slug) {
-          Globalize.with_locale(Refinery::I18n.default_frontend_locale) {
+          Mobility.with_locale(Refinery::I18n.default_frontend_locale) {
             page.canonical_slug
           }
         }
@@ -148,7 +148,7 @@ module Refinery
         specify "translated page returns its page's canonical slug'" do
           allow(Refinery::I18n).to receive(:current_frontend_locale).and_return(:ru)
 
-          Globalize.with_locale(:ru) do
+          Mobility.with_locale(:ru) do
             page.title = ru_page_title
             page.save
 

data/spec/support/refinery/pages/caching_helpers.rb

@@ -15,7 +15,7 @@ module CachingHelpers
 
   RSpec::Matchers.define :be_cached do
     match do |page|
-      File.exists?(cached_file_path(page))
+      File.exist?(cached_file_path(page))
     end
   end
 

data/spec/support/selector_helpers.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+def index_entry
+  'li.record.page'
+end
+
+def index_item(id)
+  [id, '.item'].join(' ')
+end
+
+#  various edit actions selectors: there are several in a single index entry
+#  1. the page title is wrapped in an edit link
+#     <a class="title edit" href="/refinery/pages/.../edit" tooltip="Edit this page">page title</a>
+#  2. if there are several locales there is an edit_in_locale link for each locale
+#     <a id="es" class="edit locale_icon locale" href="/refinery/pages/.../edit?switch_locale=es" tooltip=page_title></a>
+#  3. the actions group has an edit icon with a link to edit the page (equivalent to 1)
+#     <a class="edit_icon edit" href="/refinery/pages/.../edit" tooltip="Edit this page"></a>
+#
+def edit_selector(class_name: nil, locale: nil, slug: nil)
+  class_selector = [class_name, 'edit'].compact.join('.')
+  query_selector = ("?switch_locale=#{locale}" if locale.present?)
+  "a.#{class_selector}[href$='#{slug}/edit#{query_selector}']"
+end
+
+def title_link_selector(slug: '')
+  edit_selector(slug: slug, class_name: :title)
+end
+
+def icon_link_selector(slug: '')
+  edit_selector(slug: slug, class_name: :edit_icon)
+end
+
+def locale_link_selector(locale:, slug: '')
+  edit_selector(slug: slug, class_name: :locale, locale: locale.downcase)
+end
+
+def locales
+  "span.locales"
+end
+
+def locale_picker(locale)
+  ".locales ##{locale}"
+end