refinerycms-page-images 2.0.1 → 2.1.0

data/spec/features/attach_page_images_spec.rb

@@ -0,0 +1,58 @@
+require "spec_helper"
+
+describe "attach page images" do
+  refinery_login_with :refinery_user
+
+  # No-op block : use default configuration by default
+  let(:configure) {}
+  let(:create_page) { FactoryGirl.create(:page) }
+  let(:navigate_to_edit)  { click_link "Edit this page" }
+  let(:page_images_tab_id) { "#custom_#{::I18n.t(:'refinery.plugins.refinery_page_images.tab_name')}_tab"  }
+
+  let(:setup_and_visit) do
+    configure
+    create_page
+    visit refinery.admin_pages_path
+    navigate_to_edit
+  end
+
+  it "shows images tab" do
+    setup_and_visit
+    within page_images_tab_id do
+      page.should have_content("Images")
+    end
+  end
+
+  # This spec actually is broken in a way because Add Image link would
+  # be visible to capybara even if we don't click on Images tab.
+  it "shows add image link" do
+    setup_and_visit
+    within page_images_tab_id do
+      click_link "Images"
+    end
+
+    page.should have_content("Add Image")
+  end
+
+  context "with caption and WYSIWYG disabled" do
+    let(:configure) do
+      Refinery::PageImages.config.wysiwyg  = false
+      Refinery::PageImages.config.captions = true
+    end
+
+    let(:create_page) { FactoryGirl.create(:page_with_image) }
+    let(:navigate_to_edit) { page.find('a[tooltip="Edit this page"]').click }
+
+    it "shows a plain textarea when editing caption", js: true do
+      setup_and_visit
+      page.find("#{page_images_tab_id} a").click
+      image_li_tag = page.find("#page_images li:first-child")
+
+      image_li_tag.hover
+      within(image_li_tag) { page.find('img.caption').click }
+
+      page.find('.ui-dialog textarea').should be_visible
+    end
+  end
+
+end

data/spec/lib/refinery/initializer_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+describe Refinery::PageImages::Engine do
+  before(:all) do
+    class Refinery::PageImages::EnableForMock
+      class Model; end
+      class Tab; end
+    end
+  end
+
+  after(:all) do
+    Refinery::PageImages.instance_eval { remove_const(:EnableForMock) }
+  end
+
+  before(:each) do
+    Refinery::PageImages.config.stub(:enable_for).and_return(enable_for_config)
+  end
+
+  def enable_for_config
+    [{ :model => 'Refinery::PageImages::EnableForMock::Model',
+       :tab => 'Refinery::PageImages::EnableForMock::Tab' }]
+  end
+
+  describe "attach initializer" do
+    it "calls attach on all configured model" do
+      Refinery::PageImages.config.stub(:enable_for).and_return(enable_for_config)
+
+      Refinery::PageImages::EnableForMock::Model.should_receive(:has_many_page_images).once
+      Refinery::Page.should_not_receive(:has_many_page_images)
+      ActionDispatch::Reloader.prepare!
+    end
+  end
+
+  describe "attach_initialize_tabs!" do
+    it "registers tabs for all configured engine" do
+      Refinery::PageImages::EnableForMock::Tab.should_receive(:register).once
+      Refinery::Pages::Tab.should_not_receive(:register)
+      Refinery::PageImages::Engine.initialize_tabs!
+    end
+  end
+
+end

data/spec/models/refinery/blog_spec.rb

@@ -3,13 +3,13 @@ require 'spec_helper'
 module Refinery
   describe BlogPost do
     it "should not have images" do
-      blog = Factory(:blog_post)
+      blog = FactoryGirl.create(:blog_post)
       blog.images.count.should == 0
     end
 
     it "should have images" do
-      blog = Factory(:blog_post_with_image)
+      blog = FactoryGirl.create(:blog_post_with_image)
       blog.images.count.should == 1
     end
-  end 
+  end
 end if defined?(Refinery::Blog::Post)

data/spec/models/refinery/page_spec.rb

@@ -3,17 +3,17 @@ require 'spec_helper'
 module Refinery
   describe Page do
     it "can have images added" do
-      page = Factory(:page)
+      page = FactoryGirl.create(:page)
       page.images.count.should eq(0)
 
-      page.images << Factory(:image)
+      page.images << FactoryGirl.create(:image)
       page.images.count.should eq(1)
     end
 
     describe "#images_attributes=" do
       it "adds images" do
-        page = Factory(:page)
-        image = Factory(:image)
+        page = FactoryGirl.create(:page)
+        image = FactoryGirl.create(:image)
 
         page.images.count.should == 0
         page.update_attributes({:images_attributes => {"0" => {"id" => image.id}}})
@@ -22,14 +22,17 @@ module Refinery
       end
 
       it "deletes specific images" do
-        page = Factory(:page)
-        images = [Factory(:image), Factory(:image)]
+        page = FactoryGirl.create(:page)
+        images = [FactoryGirl.create(:image), FactoryGirl.create(:image)]
         page.images = images
 
+        page_image_to_keep = page.image_pages.find do |image_page|
+          image_page.image_id == images.first.id
+        end
         page.update_attributes(:images_attributes => {
           "0" => {
-            "id" => images.first.id.to_s,
-            "image_page_id" => page.image_pages.first.id,
+            "id" => page_image_to_keep.image_id.to_s,
+            "image_page_id" => page_image_to_keep.id
           },
         })
 
@@ -37,8 +40,8 @@ module Refinery
       end
 
       it "deletes all images" do
-        page = Factory(:page)
-        images = [Factory(:image), Factory(:image)]
+        page = FactoryGirl.create(:page)
+        images = [FactoryGirl.create(:image), FactoryGirl.create(:image)]
         page.images = images
 
         page.update_attributes(:images_attributes => {"0" => {"id"=>""}})
@@ -47,18 +50,25 @@ module Refinery
       end
 
       it "reorders images" do
-        page = Factory(:page)
-        images = [Factory(:image), Factory(:image)]
+        page = FactoryGirl.create(:page)
+        images = [FactoryGirl.create(:image), FactoryGirl.create(:image)]
         page.images = images
 
+        first_page_image = page.image_pages.find do |image_page|
+          image_page.image_id == images.first.id
+        end
+        second_page_image = page.image_pages.find do |image_page|
+          image_page.image_id == images.second.id
+        end
+
         page.update_attributes(:images_attributes => {
           "0" => {
-            "id" => images.second.id,
-            "image_page_id" => page.image_pages.second.id,
+            "id" => second_page_image.image_id,
+            "image_page_id" => second_page_image.id,
           },
           "1" => {
-            "id" => images.first.id,
-            "image_page_id" => page.image_pages.first.id,
+            "id" => first_page_image.image_id,
+            "image_page_id" => first_page_image.id,
           },
         })
 

data/spec/spec_helper.rb

@@ -1,56 +1,31 @@
 require 'rubygems'
 
-def setup_environment
-  # Configure Rails Environment
-  ENV["RAILS_ENV"] ||= 'test'
+# Configure Rails Environment
+ENV["RAILS_ENV"] ||= 'test'
 
-  require File.expand_path("../dummy/config/environment", __FILE__)
+require File.expand_path("../dummy/config/environment", __FILE__)
 
-  require 'rspec/rails'
-  require 'capybara/rspec'
-  require 'factory_girl_rails'
+require 'rspec/rails'
+require 'capybara/rspec'
+require 'factory_girl_rails'
 
-  Rails.backtrace_cleaner.remove_silencers!
+Rails.backtrace_cleaner.remove_silencers!
 
-  RSpec.configure do |config|
-    config.mock_with :rspec
-    config.treat_symbols_as_metadata_keys_with_true_values = true
-    config.filter_run :focus => true
-    config.run_all_when_everything_filtered = true
-  end
-
-  # set javascript driver for capybara
-  Capybara.javascript_driver = :selenium
-end
-
-def each_run
-  ActiveSupport::Dependencies.clear
-
-  FactoryGirl.reload
-
-  # Requires supporting files with custom matchers and macros, etc,
-  # in ./support/ and its subdirectories including factories.
-  ([Rails.root.to_s] | ::Refinery::Plugins.registered.pathnames).map{|p|
-    Dir[File.join(p, 'spec', 'support', '**', '*.rb').to_s]
-  }.flatten.sort.each do |support_file|
-    require support_file
-  end
+RSpec.configure do |config|
+  config.mock_with :rspec
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.filter_run :focus => true
+  config.run_all_when_everything_filtered = true
 end
 
-# If spork is available in the Gemfile it'll be used but we don't force it.
-unless (begin; require 'spork'; rescue LoadError; nil end).nil?
-  Spork.prefork do
-    # Loading more in this block will cause your tests to run faster. However,
-    # if you change any configuration or code from libraries loaded here, you'll
-    # need to restart spork for it take effect.
-    setup_environment
-  end
+# set javascript driver for capybara
+require 'capybara/poltergeist'
+Capybara.javascript_driver = :poltergeist
 
-  Spork.each_run do
-    # This code will be run each time you run your specs.
-    each_run
-  end
-else
-  setup_environment
-  each_run
+# Requires supporting files with custom matchers and macros, etc,
+# in ./support/ and its subdirectories including factories.
+([Rails.root.to_s] | ::Refinery::Plugins.registered.pathnames).map{|p|
+  Dir[File.join(p, 'spec', 'support', '**', '*.rb').to_s]
+}.flatten.sort.each do |support_file|
+  require support_file
 end

metadata

@@ -1,64 +1,36 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: refinerycms-page-images
-version: !ruby/object:Gem::Version 
-  hash: 13
-  prerelease: 
-  segments: 
-  - 2
-  - 0
-  - 1
-  version: 2.0.1
+version: !ruby/object:Gem::Version
+  version: 2.1.0
 platform: ruby
-authors: 
+authors:
 - Philip Arndt
 - David Jones
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-03-19 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2013-09-04 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: refinerycms-pages
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 2
-        - 0
-        - 0
-        version: 2.0.0
+      - !ruby/object:Gem::Version
+        version: 2.1.0
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: refinerycms-testing
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 15
-        segments: 
-        - 2
-        - 0
-        - 0
-        version: 2.0.0
-  type: :development
-  version_requirements: *id002
-description: Page Images Engine for Refinery CMS
-email: dave@resolvedigital.com
+      - !ruby/object:Gem::Version
+        version: 2.1.0
+description: Attach images to pages ins Refinery CMS
+email: info@refinerycms.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .travis.yml
 - Gemfile
@@ -73,7 +45,9 @@ files:
 - config/locales/cs.yml
 - config/locales/de.yml
 - config/locales/en.yml
+- config/locales/es.yml
 - config/locales/fr.yml
+- config/locales/ja.yml
 - config/locales/nl.yml
 - config/locales/pt-BR.yml
 - config/locales/ru.yml
@@ -93,54 +67,41 @@ files:
 - refinerycms-page-images.gemspec
 - script/rails
 - spec/factories/page-images.rb
+- spec/features/attach_page_images_spec.rb
+- spec/lib/refinery/initializer_spec.rb
 - spec/models/refinery/blog_spec.rb
 - spec/models/refinery/page_spec.rb
-- spec/requests/attach_page_images_spec.rb
 - spec/spec_helper.rb
-- spec/support/database_cleaner.rb
-- spec/support/devise.rb
-- spec/support/refinery.rb
 - tasks/rspec.rake
-homepage: http://github.com/resolve/refinerycms-page-images
-licenses: []
-
+homepage: http://github.com/refinery/refinerycms-page-images
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
-summary: Page Images Engine for Refinery CMS
-test_files: 
+specification_version: 4
+summary: Page Images extension for Refinery CMS
+test_files:
 - spec/factories/page-images.rb
+- spec/features/attach_page_images_spec.rb
+- spec/lib/refinery/initializer_spec.rb
 - spec/models/refinery/blog_spec.rb
 - spec/models/refinery/page_spec.rb
-- spec/requests/attach_page_images_spec.rb
 - spec/spec_helper.rb
-- spec/support/database_cleaner.rb
-- spec/support/devise.rb
-- spec/support/refinery.rb
 has_rdoc: