refinerycms-images 4.0.3 → 4.1.0

data/app/views/refinery/admin/images/_form.html.erb

@@ -5,7 +5,7 @@
              object: @image,
              include_object_name: false %>
 
-  <%= render '/refinery/admin/locale_picker', :current_locale => Globalize.locale if @image.persisted? %>
+  <%= render '/refinery/admin/locale_picker', :current_locale => Mobility.locale if @image.persisted? %>
 
   <div class="field">
     <% if action_name =~ /(edit)|(update)/ %>
@@ -17,7 +17,7 @@
         <%= f.file_field :image %>
       </p>
     <% else %>
-      <% # we must only hint at multiple when it's a new record otherwise update fails. %>
+      <%# we must only hint at multiple when it's a new record otherwise update fails. %>
       <%= f.file_field :image, multiple: true %>
     <% end %>
   </div>
@@ -26,7 +26,7 @@
     <label><%= t('.maximum_image_size', bytes: number_to_human_size(Refinery::Images.max_image_size)) %></label>
   </div>
   <div class="field" id="title">
-    <span class='label_with_help'>
+    <span class="label_with_help">
       <%= f.label :image_title, t('.image_title') %>
       <%= refinery_help_tag t('.image_title_help') %>
     </span>
@@ -34,7 +34,7 @@
   </div>
 
   <div class="field" id="alt">
-    <span class='label_with_help'>
+    <span class="label_with_help">
       <%= f.label :image_alt, t('.image_alt') %>
       <%= refinery_help_tag t('.image_alt_help') %>
     </span>
@@ -51,18 +51,66 @@
              cancel_url: refinery.admin_images_path -%>
 
   <% if @app_dialog %>
-    <input type="hidden" name="app_dialog" value="<%= @app_dialog %>" />
-    <input type="hidden" name="field" value="<%= @field %>" />
-    <input type="hidden" name="update_image" value="<%= @update_image %>" />
-    <input type="hidden" name="thumbnail" value="<%= @thumbnail %>" />
-    <input type="hidden" name="callback" value="<%= @callback %>" />
-    <input type="hidden" name="conditions" value="<%= @conditions %>" />
+    <input type="hidden" name="app_dialog" value="<%= @app_dialog %>">
+    <input type="hidden" name="field" value="<%= @field %>">
+    <input type="hidden" name="update_image" value="<%= @update_image %>">
+    <input type="hidden" name="thumbnail" value="<%= @thumbnail %>">
+    <input type="hidden" name="callback" value="<%= @callback %>">
+    <input type="hidden" name="conditions" value="<%= @conditions %>">
   <% end %>
 <% end %>
 
 <% if action_name =~ /(edit)|(update)/ %>
   <div id="existing_image">
-    <label><%=t('.current_image') %></label>
-    <%= image_fu @thumbnail || @image, '225x255>', class: 'brown_border' %>
+    <label><%= t('.current_image') %></label>
+    <div id="original-image">
+      <%= image_tag @image.url, id: 'crop',
+                  data: { mime_type: @image.mime_type,
+                          filename: @image.image_name,
+                          image_id: @image.id } %>
+    </div>
+
+    <section id="ratios" class="clearfix">
+      <%= form_for @image,
+                   url: refinery.admin_image_crop_path(@image),
+                   html: {
+                     multipart: true,
+                     id: "crop_image_#{@image.id}",
+                     class: 'crop_image'
+                   } do |f| %>
+        <div class="field">
+          <span class="label_with_help">
+            <%= f.label :ratio, t('.ratios') %>
+            <%= refinery_help_tag t('.choose_crop') %>
+          </span>
+
+          <% ::Refinery::Images.user_image_ratios.each do |ratio, value| %>
+            <%= f.button value, type: 'button', data: { value: value, ratio: ratio.to_s.parameterize } %>
+          <% end %>
+
+          <%= f.submit t('.save'), id: 'save_crop' %>
+        </div>
+      <% end %>
+    </section>
+
+    <section id="crops">
+      <h2><%= t('.available_crops') %></h2>
+
+      <% if @image.crops.present? %>
+        <ul id="crop-list" class="clearfix">
+          <%= render partial: 'crop', collection: @image.crops %>
+        </ul>
+      <% else %>
+          <p id="no-crops-yet"><strong><%= t('.no_crops_yet') %></strong></p>
+      <% end %>
+    </section>
   </div>
+
+  <% content_for :after_javascript_libraries do %>
+    <%= javascript_include_tag 'cropper' %>
+    <%= javascript_include_tag 'canvas-to-blob' %>
+    <%= javascript_include_tag 'refinery/image_crop' %>
+  <% end %>
+
+  <% content_for :stylesheets, stylesheet_link_tag('cropper') -%>
 <% end %>

data/app/views/refinery/admin/images/_image.html.erb

@@ -0,0 +1,5 @@
+<li class="record image" id='<%= "image_#{image.id}" %>'>
+  <%= image.edit_link %>
+  <%= image.text_elements %>
+  <%= image.actions %>
+</li>

data/app/views/refinery/admin/images/_list_view.html.erb

@@ -1,6 +1,6 @@
 <div id= 'image_list' class="<%= ['clearfix', 'pagination_frame', pagination_css_class].compact.join(' ') %>">
-  <% group_by_date(@images).each do |container| %>
-    <% date_time = (image_group = container.last).first.created_at %>
+  <% group_by_date(@images, :updated_at).each do |container| %>
+    <% date_time = (image_group = container.last).first.updated_at %>
     <% date = Date.parse(date_time.to_s) %>
     <h3><%= l(date, format: :long ) %></h3>
     <ul class='images_list'>

data/app/views/refinery/admin/images/destroy_crop.js.erb

@@ -0,0 +1,18 @@
+let cropList = document.getElementById('crop-list');
+let deletedCrop = document.getElementById('crop_<%= image_id %>');
+
+if(deletedCrop !== null) {
+  deletedCrop.parentNode.removeChild(deletedCrop);
+}
+
+if( cropList.querySelectorAll('li').length == 0) {
+  displayNoCropsYetText();
+}
+
+function displayNoCropsYetText(){
+  const noCropsYetText = document.getElementById('no-crops-yet');
+
+  if(noCropsYetText !== null && noCropsYetText.style.display != 'block')  {
+    noCropsYetText.style.display = 'block';
+  }
+}

data/config/locales/en.yml

@@ -21,6 +21,15 @@ en:
           image_title_help: Extra information about the image
           image_alt: Alt
           image_alt_help: Text to use if the image cannot be displayed.
+          ratios: Ratios
+          choose_crop: To edit a crop, please select a format from the following list
+          available_crops: Available crops
+          save: Save crop
+          format: Format
+          crop_success: Crop has been successfully generated
+          no_crops_yet: There are no image crops yet. Click "Save crop" to add your first image crop.
+        crop:
+          delete_crop: "%{title} - Crop %{id}"
         actions:
           create_new_image: Add new image
         records:
@@ -35,6 +44,7 @@ en:
           button_text: Insert
           resize_image: Resize the image?
           size: Size
+          select_resize: Select resize
         insert:
           existing_image: Library
           new_image: Upload
@@ -46,5 +56,5 @@ en:
         refinery/image:
           blank: You must specify an image for upload
           too_big: Image should be smaller than %{size} bytes in size
-          incorrect_format: 'Your image must be either a JPG, PNG or GIF'
+          incorrect_format: "Your image type is '%{actual}' but must be one of %{valid_types}"
           different_file_name: New image can't have different file name

data/config/locales/fr.yml

@@ -19,6 +19,15 @@ fr:
           image_title_help: Information complémentaire sur l'image
           image_alt: Alt
           image_alt_help: Texte utilise si l'image ne peut pas être affichée.
+          ratios: Ratios
+          choose_crop: Pour éditer un recadrage, veuillez sélectionner un format parmi la liste suivante
+          available_crops: Liste des recadrages disponibles
+          save: Sauvegarder le recadrage
+          format: Format
+          crop_success: Le recadrage a été généré avec succès
+          no_crops_yet: "Il n'y a actuellement aucun recadrage d'image. Cliquez sur 'Sauvegarder le recadrage' pour en ajouter un."
+        crop:
+          delete_crop: "%{title} - Recadrage %{id}"
         actions:
           create_new_image: Ajouter une image
         records:
@@ -33,6 +42,7 @@ fr:
           button_text: Insérer
           resize_image: Redimensionner l'image ?
           size: Taille
+          select_resize: Sélectionnez une taille
         insert:
           existing_image: Image existante
           new_image: Nouvelle image

data/config/locales/sk.yml

@@ -5,6 +5,8 @@ sk:
         title: Obrázky
         description: Spravovať obrázky
     admin:
+      locale_picker:
+        language: Jazyk
       images:
         delete: Zmazať tento obrázok
         edit: Upraviť tento obrázok
@@ -15,6 +17,19 @@ sk:
           replace_image: " nahradiť ho týmto..."
           current_image: Vybraný obrázok
           maximum_image_size: Maximálna veľkosť obrázku je %{bytes}.
+          image_title: Názov
+          image_title_help: Extra informácie o obrázku
+          image_alt: Alt
+          image_alt_help: Text, ktorý sa zobrazí, ak obrázok nemôže byť zobrazený.
+          ratios: Pomer strán
+          choose_crop: Aby ste mohli editovať zmenšeninu, prosím zvoľte formát z nasledovného zoznamu
+          available_crops: Dostupné zmenšeniny
+          save: Uložiť zmenšeninu
+          format: Formát
+          crop_success: Zmenšenina bola úspešne vygenerovaná
+          no_crops_yet: Zatiaľ neboli vytvorené žiadne zmenšeniny. Kliknite  "Uložiť zmenšeninu" ak chcete pridať prvú
+        crop:
+          delete_crop: "%{title} - Zmenšenina %{id}"
         actions:
           create_new_image: Pridať nový obrázok
         records:
@@ -29,6 +44,7 @@ sk:
           button_text: Vložiť
           resize_image: Upraviť veľkosť?
           size: Veľkosť
+          select_resize: Vyberte veľkosť
         insert:
           existing_image: Knižnica
           new_image: Nový obrázok
@@ -41,4 +57,4 @@ sk:
           blank: Musíte zadať obrázok ktorý chcete nahrať.
           too_big: Maximálna veľkosť obrázku %{size}MB in size.
           incorrect_format: 'Obrázok musí byť vo formáte JPG, PNG alebo GIF.'
-          different_file_name: Nový obrázok nesmie mať odlišný názov súboru
+          different_file_name: Nový obrázok nesmie mať odlišný názov súboru

data/config/routes.rb

@@ -1,9 +1,11 @@
 Refinery::Core::Engine.routes.draw do
-  get '/system/images/*dragonfly', :to => Dragonfly.app(:refinery_images)
+  get '/system/images/*dragonfly', to: Dragonfly.app(:refinery_images)
 
-  namespace :admin, :path => Refinery::Core.backend_route do
-    resources :images, :except => :show do
-      get :insert, :on => :collection
+  namespace :admin, path: Refinery::Core.backend_route do
+    resources :images, except: :show do
+      get :insert, on: :collection
+      patch :crop
+      match 'crop', to: 'images#destroy_crop', via: :delete
     end
   end
 end

data/db/migrate/20150430171341_translate_refinery_images.rb

@@ -1,22 +1,18 @@
 class TranslateRefineryImages < ActiveRecord::Migration[4.2]
-  def self.up
-    begin
-      ::Refinery::Image.create_translation_table!({
-        image_alt: :string,
-        image_title: :string
-      }, {
-        :migrate_data => true
-      })
-    rescue NameError
-      warn "Refinery::Image was not defined!"
-    end
-  end
+  def change
+    create_table :refinery_image_translations do |t|
+
+      # Translated attribute(s)
+      t.string :image_alt
+      t.string :image_title
 
-  def self.down
-    begin
-      Refinery::Image.drop_translation_table! migrate_data: true
-    rescue NameError
-      warn "Refinery::Image was not defined!"
+      t.string  :locale, null: false
+      t.integer :refinery_image_id, null: false
+
+      t.timestamps null: false
     end
+
+    add_index :refinery_image_translations, :locale, name: :index_refinery_image_translations_on_locale
+    add_index :refinery_image_translations, [:refinery_image_id, :locale], name: :index_2f245f0c60154d35c851e1df2ffc4c86571726f0, unique: true
   end
 end

data/db/migrate/20180711122352_add_parent_id_to_refinery_images.rb

@@ -0,0 +1,5 @@
+class AddParentIdToRefineryImages < ActiveRecord::Migration[5.1]
+  def change
+    add_column :refinery_images, :parent_id, :integer
+  end
+end

data/lib/generators/refinery/images/templates/config/initializers/refinery/images.rb.erb

@@ -19,8 +19,11 @@ Refinery::Images.configure do |config|
   # Configure image sizes
   # config.user_image_sizes = <%= Refinery::Images.user_image_sizes.inspect %>
 
-  # Configure white-listed mime types for validation
-  # config.whitelisted_mime_types = <%= Refinery::Images.whitelisted_mime_types.inspect %>
+  # Configure image ratios
+  # config.user_image_ratios = <%= Refinery::Images.user_image_ratios.inspect %>
+
+  # Configure allowed mime types for validation
+  # config.allowed_mime_types = <%= Refinery::Images.allowed_mime_types.inspect %>
 
   # Configure image view options
   # config.image_views = <%= Refinery::Images.image_views.inspect %>

data/lib/refinery/images/configuration.rb

@@ -5,20 +5,26 @@ module Refinery
     include ActiveSupport::Configurable
 
     config_accessor :max_image_size, :pages_per_dialog, :pages_per_admin_index,
-                    :pages_per_dialog_that_have_size_options, :user_image_sizes,
+                    :pages_per_dialog_that_have_size_options, :user_image_sizes, :user_image_ratios,
                     :image_views, :preferred_image_view,
-                    :whitelisted_mime_types
+                    :allowed_mime_types, :allowed_mime_types_msg
 
     self.max_image_size = 5_242_880
     self.pages_per_dialog = 18
     self.pages_per_dialog_that_have_size_options = 12
     self.pages_per_admin_index = 20
     self.user_image_sizes = {
-      :small => '110x110>',
-      :medium => '225x255>',
-      :large => '450x450>'
+      small: '110x110>',
+      medium: '225x255>',
+      large: '450x450>'
     }
-    self.whitelisted_mime_types = %w[image/jpeg image/png image/gif image/tiff]
+    self.user_image_ratios = {
+      '16/9': '1.778',
+      '4/3': '1.333',
+      '1:1': 1
+    }
+    self.allowed_mime_types = %w[image/jpeg image/png image/gif image/tiff]
+    self.allowed_mime_types_msg = self.allowed_mime_types.to_sentence(last_word_connector: ' or ')
     self.image_views = [:grid, :list]
     self.preferred_image_view = :grid
 
@@ -31,6 +37,6 @@ module Refinery
       name: :strip,
       block: -> (content) { content.process!(:convert, '-strip') }
     }]
-
   end
+
 end

data/lib/refinery/images/validators/image_size_validator.rb

@@ -1,18 +1,18 @@
+# frozen_string_literal: true
+
 module Refinery
   module Images
     module Validators
       class ImageSizeValidator < ActiveModel::Validator
-
         def validate(record)
-          image = record.image
-
-          if image.respond_to?(:length) && image.length > Images.max_image_size
-            record.errors[:image] << ::I18n.t('too_big',
-                                             :scope => 'activerecord.errors.models.refinery/image',
-                                             :size => Images.max_image_size)
-          end
+          record.errors.add(:image, ::I18n.t('too_big',
+                                             scope: 'activerecord.errors.models.refinery/image',
+                                             size: Images.max_image_size)) if too_big(record.image)
         end
 
+        private def too_big(image)
+          image.respond_to?(:length) && image.length > Images.max_image_size
+        end
       end
     end
   end

data/lib/refinery/images/validators/image_update_validator.rb

@@ -1,16 +1,16 @@
+# frozen_string_literal: true
+
 module Refinery
   module Images
     module Validators
       class ImageUpdateValidator < ActiveModel::Validator
-
         def validate(record)
           if record.image_name_changed?
             record.errors.add :image_name,
               ::I18n.t("different_file_name",
-                       :scope => "activerecord.errors.models.refinery/image")
+                       scope: "activerecord.errors.models.refinery/image")
           end
         end
-
       end
     end
   end

data/lib/refinery/images.rb

@@ -1,5 +1,5 @@
-require 'refinerycms-core'
-require 'refinerycms-dragonfly'
+require 'refinerycms/core'
+require 'refinerycms/dragonfly'
 
 module Refinery
   autoload :ImagesGenerator, 'generators/refinery/images/images_generator'
@@ -24,5 +24,5 @@ module Refinery
 end
 
 ActiveSupport.on_load(:active_record) do
-  require 'globalize'
+  require 'mobility'
 end

data/lib/refinerycms/images.rb

@@ -0,0 +1 @@
+require_relative '../refinery/images'

data/lib/refinerycms-images.rb

@@ -1,2 +1 @@
 require 'refinery/images'
-

data/refinerycms-images.gemspec

@@ -1,33 +1,26 @@
-# Encoding: UTF-8
-require File.expand_path('../../core/lib/refinery/version', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('../core/lib/refinery/version', __dir__)
 
 version = Refinery::Version.to_s
 
 Gem::Specification.new do |s|
   s.platform          = Gem::Platform::RUBY
-  s.name              = %q{refinerycms-images}
+  s.name              = 'refinerycms-images'
   s.version           = version
-  s.summary           = %q{Images extension for Refinery CMS}
-  s.description       = %q{Handles all image upload and processing functionality in Refinery CMS.}
-  s.email             = %q{refinerycms@p.arndt.io}
-  s.homepage          = %q{https://www.refinerycms.com}
-  s.rubyforge_project = %q{refinerycms}
-  s.authors           = ['Philip Arndt', 'Uģis Ozols', 'Rob Yurkowski']
-  s.license           = %q{MIT}
-  s.require_paths     = %w(lib)
+  s.summary           = 'Images extension for Refinery CMS'
+  s.description       = 'Handles all image upload and processing functionality in Refinery CMS.'
+  s.email             = 'gems@p.arndt.io'
+  s.homepage          = 'https://www.refinerycms.com'
+  s.authors           = ['Philip Arndt', 'David Jones', 'Uģis Ozols', 'Brice Sanchez']
+  s.license           = 'MIT'
+  s.require_paths     = %w[lib]
 
   s.files             = `git ls-files`.split("\n")
   s.test_files        = `git ls-files -- spec/*`.split("\n")
 
-  s.add_dependency 'refinerycms-dragonfly',   '~> 1.0'
-  s.add_dependency 'globalize',               ['>= 5.1.0.beta1', '< 5.2']
-  s.add_dependency 'activemodel-serializers-xml', '~> 1.0', '>= 1.0.1'
-  s.add_dependency 'refinerycms-core',        version
+  s.add_dependency 'refinerycms-core', version
+  s.add_dependency 'refinerycms-dragonfly', '~> 1.0'
 
   s.required_ruby_version = Refinery::Version.required_ruby_version
-
-  s.cert_chain  = [File.expand_path("../../certs/parndt.pem", __FILE__)]
-  if $0 =~ /gem\z/ && ARGV.include?("build") && ARGV.include?(__FILE__)
-    s.signing_key = File.expand_path("~/.ssh/gem-private_key.pem")
-  end
 end

data/spec/factories/image.rb

@@ -1,13 +1,13 @@
 FactoryBot.define do
   factory :image, :class => ::Refinery::Image do
-    image Refinery.roots('refinery/images').join("spec/fixtures/beach.jpeg")
+    image { Refinery.roots('refinery/images').join("spec/fixtures/beach.jpeg") }
   end
 
   factory :alternate_image, :class => ::Refinery::Image do
-    image Refinery.roots('refinery/images').join("spec/fixtures/beach-alternate.jpeg")
+    image { Refinery.roots('refinery/images').join("spec/fixtures/beach-alternate.jpeg") }
   end
 
   factory :another_image, :class => ::Refinery::Image do
-    image Refinery.roots('refinery/images').join("spec/fixtures/fathead.png")
+    image { Refinery.roots('refinery/images').join("spec/fixtures/fathead.png") }
   end
 end

data/spec/support/shared_contexts/admin_images_tab.rb

@@ -1,6 +1,6 @@
 shared_context 'admin images tab' do
 
-  let(:open_upload_dialog) { find('a', text: ::I18n.t('create_new_image', scope: 'refinery.admin.images.actions')).trigger(:click) }
+  let(:open_upload_dialog) { find('a', text: ::I18n.t('create_new_image', scope: 'refinery.admin.images.actions')).click }
   let(:select_upload) {}
   let(:initialize_context) {}
   let(:index_in_frame) {false}

data/spec/support/shared_contexts/grid_view.rb

@@ -0,0 +1,8 @@
+shared_context 'grid view' do
+  let(:initial_path) { refinery.admin_images_path + '?view=grid' }
+  let(:img_selector) { '> a img' }
+  let(:alt_selector) { 'span.alt' }
+  let(:title_selector) { 'span.title' }
+  let(:view_selector) {'#image_index.grid'}
+  let(:alt_view) {'list'}
+end

data/spec/support/shared_contexts/list_view.rb

@@ -0,0 +1,12 @@
+shared_context 'list view' do
+  let(:initial_path) { refinery.admin_images_path + '?view=list' }
+  let(:img_selector) { '' }
+  let(:alt_selector) { 'span.alt' }
+  let(:title_selector) { 'a.edit_link' }
+  let(:image_title) { [index_item_selector, title_selector].join(' ') }
+  let(:view_selector) {'#image_index.list'}
+
+  let(:filename_selector) { '.filename' }
+  let(:filename) { [index_item_selector, filename_selector ].join(' ') }
+  let(:alt_view) {'grid'}
+end

data/spec/support/shared_examples/image_deleter.rb

@@ -16,7 +16,7 @@ shared_examples_for 'deletes an image' do
   end
 
   it "removes an image" do
-    expect(deleting_an_image).to change(Refinery::Image, :count).by(-1)
+    expect { deleting_an_image.call }.to change(Refinery::Image, :count).by(-1)
   end
 
   it 'says the image has been removed' do

data/spec/support/shared_examples/image_previewer.rb

@@ -16,7 +16,7 @@ shared_examples 'shows an image preview' do
   end
 
   let(:image_url) {
-    uri = URI(first(:xpath, "//a[@class='preview_icon']")[:href])
+    uri = URI(first(:xpath, "//a[contains(@class, 'preview_icon')]")[:href])
     uri.path << '?' << uri.query
   }
 

data/spec/support/shared_examples/image_translator.rb

@@ -25,7 +25,7 @@ shared_examples 'translates an image' do
       click_button "Save"
 
       expect(page).to have_content("'Titre de la première image' was successfully updated.")
-      expect(Refinery::Image.translation_class.count).to eq(1)
+      expect(Refinery::Image::Translation.count).to eq(1)
     end
   end
 end

data/spec/support/shared_examples/image_uploader.rb

@@ -21,16 +21,19 @@ shared_examples 'uploads images' do
   context 'when the image type is acceptable' do
     let(:image_path) {Refinery.roots('refinery/images').join("spec/fixtures/image-with-dashes.jpg")}
     it 'the image is uploaded', :js => true do
-      expect(uploading_an_image).to change(Refinery::Image, :count).by(1)
+      expect { uploading_an_image.call }.to change(Refinery::Image, :count).by(1)
     end
   end
 
   context 'when the image type is not acceptable' do
     let(:image_path) {Refinery.roots('refinery/images').join("spec/fixtures/cape-town-tide-table.pdf")}
     it 'the image is rejected', :js => true do
-      expect(uploading_an_image).to_not change(Refinery::Image, :count)
+      expect { uploading_an_image.call }.to_not change(Refinery::Image, :count)
       page.within_frame(dialog_frame_id) do
-        expect(page).to have_content(::I18n.t('incorrect_format', :scope => 'activerecord.errors.models.refinery/image'))
+        expect(page).to have_content(::I18n.t('incorrect_format',
+                                              :scope => 'activerecord.errors.models.refinery/image',
+                                              actual: 'application/pdf',
+                                              valid_types: 'image/jpeg, image/png, image/gif or image/tiff'))
       end
     end
   end

data/spec/{features → system}/refinery/admin/dialog_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 module Refinery
-  describe "dialog", :type => :feature do
+  describe "dialog", :type => :system do
     refinery_login
 
     context 'When there are many images' do

data/spec/{features → system}/refinery/admin/images_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 module Refinery
-  describe "the Admin Images Tab", type: :feature do
+  describe "the Admin Images Tab", type: :system do
     refinery_login
     include_context 'admin images tab'
 
@@ -13,6 +13,18 @@ module Refinery
         expect(page).to have_content(::I18n.t('no_images_yet', scope: 'refinery.admin.images.records'))
       end
 
+      it 'shows flash notice after successful upload' do
+        visit refinery.new_admin_image_path
+
+        attach_file 'image_image', Refinery.roots('refinery/images').join("spec/fixtures/beach.jpeg")
+        fill_in 'image_image_title', with: 'Beach Photo'
+        fill_in 'image_image_alt', with: 'A beach'
+        click_button 'Save'
+
+        expect(page).to have_content("'Beach Photo' was successfully added.")
+        expect(page).to have_current_path(refinery.admin_images_path)
+      end
+
       it_has_behaviour 'uploads images'
     end