refinerycms-core 2.0.10 → 2.1.0

data/spec/features/refinery/core_spec.rb

@@ -0,0 +1,14 @@
+module Refinery
+  module Core
+    describe Engine do
+      describe "#refinery_inclusion!" do
+        it "should be idempotent" do
+          expect { visit(refinery.root_path) }.to_not raise_error
+          Engine.refinery_inclusion!
+          Engine.refinery_inclusion!
+          expect { visit(refinery.root_path) }.to_not raise_error
+        end
+      end
+    end
+  end
+end

data/spec/{requests → features}/refinery/site_bar_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 module Refinery
   describe "site bar" do
-    login_refinery_user
+    refinery_login_with :refinery_user
 
     it "have logout link" do
       visit refinery.admin_dashboard_path

data/spec/helpers/refinery/meta_helper_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+module Refinery
+  describe MetaHelper do
+
+    describe '#canonical_id' do
+      context "when page doesn't exist" do
+        let(:page) { nil }
+
+        it 'returns nothing' do
+          helper.canonical_id(page).should be_nil
+        end
+      end
+
+      context 'when page exists' do
+        let(:page) { Page.new :slug => 'testing' }
+
+        it "returns the page's canonical slug with '-page' appended" do
+          helper.canonical_id(page).should == page.canonical_slug << '-page'
+        end
+      end
+    end
+
+  end
+end

data/spec/lib/generators/refinery/cms/cms_generator_spec.rb

@@ -9,6 +9,37 @@ module Refinery
 
     before do
       prepare_destination
+
+      dir = "#{destination_root}/config/environments"
+      FileUtils.mkdir_p(dir)
+      File.open("#{dir}/development.rb", "w") do |file|
+        file.write <<-SPEC
+Dummy::Application.configure do
+  config.action_mailer.test = true
+end
+        SPEC
+      end
+
+      File.open("#{dir}/test.rb", "w") do |file|
+        file.write <<-SPEC
+Dummy::Application.configure do
+  # config.action_mailer.test = true
+end
+        SPEC
+      end
+
+      File.open("#{dir}/production.rb", "w") do |file|
+        file.write <<-SPEC
+Dummy::Application.configure do
+  config.action_mailer.test = true
+  config.action_mailer.check = {
+    :test => true,
+    :check => true
+  }
+end
+        SPEC
+      end
+
       run_generator %w[--skip-db --skip-migrations]
     end
 
@@ -40,5 +71,35 @@ module Refinery
         end
       }
     end
+
+    describe "#ensure_environments_are_sane" do
+      it "wraps single line config.action_mailer setting" do
+        File.open("#{destination_root}/config/environments/development.rb") do |file|
+          file.read.should eq <<-SPEC
+Dummy::Application.configure do
+  if config.respond_to?(:action_mailer)
+    config.action_mailer.test = true
+  end
+end
+          SPEC
+        end
+      end
+
+      it "wraps multi line config.action_mailer settings" do
+        File.open("#{destination_root}/config/environments/production.rb") do |file|
+          file.read.should eq <<-SPEC
+Dummy::Application.configure do
+  if config.respond_to?(:action_mailer)
+    config.action_mailer.test = true
+    config.action_mailer.check = {
+      :test => true,
+      :check => true
+    }
+  end
+end
+          SPEC
+        end
+      end
+    end
   end
 end

data/spec/lib/generators/refinery/engine/engine_generator_multiple_resources_spec.rb

@@ -1,17 +1,44 @@
 require 'spec_helper'
 require 'generator_spec/test_case'
 require 'generators/refinery/engine/engine_generator'
+require 'tmpdir'
 
 module Refinery
   describe EngineGenerator do
     include GeneratorSpec::TestCase
-    destination File.expand_path("../../../../../../tmp", __FILE__)
+    destination Dir.mktmpdir
 
     before do
       prepare_destination
       run_generator %w{ rspec_product_test title:string description:text image:image brochure:resource }
     end
 
+    context "when generating a resource without passing a namespace" do
+      before do
+        run_generator %w{ rspec_item_test title:string --extension rspec_product_tests --skip }
+      end
+
+      it "uses the extension name for the namespace" do
+        destination_root.should have_structure {
+          directory "vendor" do
+            directory "extensions" do
+              directory "rspec_product_tests" do
+                directory "app" do
+                  directory "controllers" do
+                    directory "refinery" do
+                      directory "rspec_product_tests" do
+                        file "rspec_item_tests_controller.rb"
+                      end
+                    end
+                  end
+                end
+              end
+            end
+          end
+        }
+      end
+    end
+
     context "when generating a resource inside existing extensions dir" do
 
       before do

data/spec/lib/generators/refinery/engine/engine_generator_sanity_check_spec.rb

@@ -6,13 +6,13 @@ module Refinery
   describe EngineGenerator do
     include GeneratorSpec::TestCase
 
-    it "exits when reserved word is used for extnesion name" do
+    it "exits when reserved word is used for extension name" do
       clash_keywords = YAML.load_file(File.expand_path("../../../../../../lib/generators/refinery/clash_keywords.yml", __FILE__))
       clash_keywords.each do |word|
         lambda {
           STDERR.should_receive(:puts).with("\nPlease choose a different name. The generated code would fail for class '#{word}' as it conflicts with a reserved keyword.\n\n")
           run_generator [word, "title:string"]
-        }.should raise_error(SystemExit)
+        }.should raise_error
       end
     end
 
@@ -20,28 +20,28 @@ module Refinery
       lambda {
         STDERR.should_receive(:puts).with("\nPlease specify the singular name 'apple' instead of 'apples'.\n\n")
         run_generator %w{ apples title:string }
-      }.should raise_error(SystemExit)
+      }.should raise_error
     end
 
     it "exits when uncountable word is used for extension name" do
       lambda {
         STDERR.should_receive(:puts).with("\nThe extension name you specified will not work as the singular name is equal to the plural name.\n\n")
         run_generator %w{ money title:string }
-      }.should raise_error(SystemExit)
+      }.should raise_error
     end
 
     it "exits when no attribute provided" do
       lambda {
         STDERR.should_receive(:puts).with("\nYou must specify a name and at least one field.\nFor help, run: rails generate refinery:engine\n\n")
         run_generator %w{ car }
-      }.should raise_error(SystemExit)
+      }.should raise_error
     end
 
     it "exits when '--extension' option is used but there is no extension by provided name" do
-      lambda { 
+      lambda {
         STDERR.should_receive(:puts).with("\nYou can't use '--extension nonexistent' option because extension with name nonexistent doesn't exist.\n\n")
         run_generator %w{ car title:string --extension nonexistent }
-      }.should raise_error(SystemExit)
+      }.should raise_error
     end
   end
 end

data/spec/lib/generators/refinery/engine/engine_generator_spec.rb

@@ -40,12 +40,15 @@ module Refinery
                     directory "rspec_product_tests" do
                       directory "admin" do
                         directory "rspec_product_tests" do
+                          file "_actions.html.erb"
                           file "_form.html.erb"
+                          file "_records.html.erb"
+                          file "_rspec_product_test.html.erb"
+                          file "_rspec_product_tests.html.erb"
                           file "_sortable_list.html.erb"
                           file "edit.html.erb"
                           file "index.html.erb"
                           file "new.html.erb"
-                          file "_rspec_product_test.html.erb"
                         end
                       end
                       directory "rspec_product_tests" do
@@ -56,25 +59,83 @@ module Refinery
                   end
                 end
               end
+              directory "config" do
+                directory "locales" do
+                  file "cs.yml"
+                  file "en.yml"
+                  file "es.yml"
+                  file "fr.yml"
+                  file "it.yml"
+                  file "nb.yml"
+                  file "nl.yml"
+                  file "sk.yml"
+                  file "tr.yml"
+                  file "zh-CN.yml"
+                end
+                file "routes.rb"
+              end
+              directory "db" do
+                directory "migrate" do
+                  file "1_create_rspec_product_tests_rspec_product_tests.rb"
+                end
+                file "seeds.rb"
+              end
               directory "lib" do
+                directory "generators" do
+                  directory "refinery" do
+                    file "rspec_product_tests_generator.rb"
+                  end
+                end
+                directory "refinery" do
+                  directory "rspec_product_tests" do
+                    file "engine.rb"
+                  end
+                  file "rspec_product_tests.rb"
+                end
+                directory "tasks" do
+                  directory "refinery" do
+                    file "rspec_product_tests.rake"
+                  end
+                end
                 file "refinerycms-rspec_product_tests.rb"
               end
+              directory "script" do
+                file "rails"
+              end
               directory "spec" do
+                directory "features" do
+                  directory "refinery" do
+                    directory "rspec_product_tests" do
+                      directory "admin" do
+                        file "rspec_product_tests_spec.rb"
+                      end
+                    end
+                  end
+                end
+                directory "models" do
+                  directory "refinery" do
+                    directory "rspec_product_tests" do
+                      file "rspec_product_test_spec.rb"
+                    end
+                  end
+                end
+                directory "support" do
+                  directory "factories" do
+                    directory "refinery" do
+                      file "rspec_product_tests.rb"
+                    end
+                  end
+                end
                 file "spec_helper.rb"
               end
               directory "tasks" do
                 file "testing.rake"
                 file "rspec.rake"
               end
-              directory "config" do
-                directory "locales" do
-                  file "en.yml"
-                end
-                file "routes.rb"
-              end
-              file "Guardfile"
               file "Gemfile"
               file "Rakefile"
+              file "readme.md"
+              file "refinerycms-rspec_product_tests.gemspec"
             end
           end
         end

data/spec/lib/generators/refinery/engine/engine_generator_with_i18n_spec.rb

@@ -41,7 +41,6 @@ module Refinery
                       directory "admin" do
                         directory "rspec_product_tests" do
                           file "_form.html.erb"
-                          file "_locale_picker.html.erb"
                           file "_sortable_list.html.erb"
                           file "edit.html.erb"
                           file "index.html.erb"
@@ -73,7 +72,6 @@ module Refinery
                 end
                 file "routes.rb"
               end
-              file "Guardfile"
               file "Gemfile"
               file "Rakefile"
             end

data/spec/lib/generators/refinery/form/form_generator_spec.rb

@@ -5,13 +5,21 @@ require 'generators/refinery/form/form_generator'
 module Refinery
   describe FormGenerator do
     include GeneratorSpec::TestCase
-    destination File.expand_path("../../../../../../tmp", __FILE__)
+
+    temp_dir = Dir.mktmpdir("refinery_rspec_form_test")
+    let(:temp_dir) { temp_dir }
+
+    destination temp_dir
 
     before do
       prepare_destination
       run_generator %w{ rspec_form_test title:string description:text choice:radio another:dropdown enable:checkbox }
     end
 
+    after do
+      FileUtils.rm_r(temp_dir)
+    end
+
     specify do
       destination_root.should have_structure {
         directory "vendor" do

data/spec/lib/refinery/application_controller_spec.rb

@@ -1,84 +1,69 @@
 require "spec_helper"
 
 module Refinery
-  describe ApplicationController do
-    describe "DummyController", :type => :controller do
-      before do
-        Rails.application.routes.draw { get "anonymous/index" }
-      end
+  describe ApplicationController, :type => :controller do
+    before do
+      Rails.application.routes.draw {
+        mount Refinery::Core::Engine, :at => '/'
+        get "anonymous/index"
+      }
+    end
 
-      after do
-        Rails.application.reload_routes!
-      end
+    after do
+      Rails.application.reload_routes!
+    end
 
-      controller do
-        include ::Refinery::ApplicationController
+    controller do
+      include ::Refinery::ApplicationController
 
-        def index
-          render :nothing => true
-        end
+      def index
+        render :nothing => true
       end
+    end
 
-      describe ".home_page?" do
-        it "matches root url" do
-          controller.stub(:root_path).and_return("/")
-          request.stub(:path).and_return("/")
-          controller.home_page?.should be_true
-        end
-
-        it "matches localised root url" do
-          controller.refinery.stub(:root_path).and_return("/en/")
-          request.stub(:path).and_return("/en")
-          controller.home_page?.should be_true
-        end
-
-        it "escapes regexp" do
-          request.stub(:path).and_return("\/huh)")
-          expect { controller.home_page? }.to_not raise_error(RegexpError)
-        end
+    describe ".home_page?" do
+      it "matches root url" do
+        controller.stub(:root_path).and_return("/")
+        request.stub(:path).and_return("/")
+        controller.home_page?.should be_true
       end
 
-      describe "#presenter_for" do
-        it "returns BasePresenter for nil" do
-          controller.send(:presenter_for, nil).should eq(BasePresenter)
-        end
-
-        it "returns BasePresenter when the instance's class does not have a presenter" do
-          controller.send(:presenter_for, Object.new).should eq(BasePresenter)
-        end
-
-        it "returns the class's presenter when the instance's class has a presenter" do
-          controller.send(:presenter_for, Page.new).should eq(PagePresenter)
-        end
+      it "matches localised root url" do
+        controller.refinery.stub(:root_path).and_return("/en/")
+        request.stub(:path).and_return("/en")
+        controller.home_page?.should be_true
       end
 
-      describe "force_ssl" do
-        before(:each) do
-          controller.stub(:admin?).and_return(true)
-          controller.stub(:refinery_user_required?).and_return(false)
-        end
-
-        it "is false so standard HTTP is used" do
-          Refinery::Core.config.force_ssl = false
-
-          get :index
+      it "matches localised root url with trailing slash" do
+        controller.refinery.stub(:root_path).and_return("/en/")
+        request.stub(:path).and_return("/en/")
+        controller.home_page?.should be_true
+      end
 
-          response.should_not be_redirect
-        end
+      it "escapes regexp" do
+        request.stub(:path).and_return("\/huh)")
+        expect { controller.home_page? }.to_not raise_error
+      end
 
-        it "is true so HTTPS is used" do
-          begin
-            Refinery::Core.config.force_ssl = true
+      it "returns false for non root url" do
+        request.stub(:path).and_return("/foo/")
+        controller.should_not be_home_page
+      end
+    end
 
-            get :index
+    describe "#presenter_for" do
+      it "returns BasePresenter for nil" do
+        controller.send(:presenter_for, nil).should eq(BasePresenter)
+      end
 
-            response.should be_redirect
-          ensure
-            Refinery::Core.config.force_ssl = false
-          end
-        end
+      it "returns BasePresenter when the instance's class does not have a presenter" do
+        controller.send(:presenter_for, Object.new).should eq(BasePresenter)
       end
 
+      it "returns the class's presenter when the instance's class has a presenter" do
+        model = Refinery::Page.new
+        controller.send(:presenter_for, model).should eq(Refinery::PagePresenter)
+      end
     end
   end
 end