refile 0.3.0 → 0.4.0

data/spec/refile/attachment_spec.rb

@@ -1,6 +1,5 @@
 describe Refile::Attachment do
-  let(:options) { { } }
-  let(:post) { Post.new }
+  let(:options) { {} }
   let(:klass) do
     opts = options
     Class.new do
@@ -82,7 +81,7 @@ describe Refile::Attachment do
           expect do
             instance.remote_document_url = "http://www.example.com/loop"
           end.not_to raise_error
-          expect(instance.document_attachment.errors).to eq([:download_failed])
+          expect(instance.document_attacher.errors).to eq([:download_failed])
           expect(instance.document).to be_nil
         end
       end
@@ -98,12 +97,12 @@ describe Refile::Attachment do
     end
   end
 
-  describe ":name_attachment.store!" do
+  describe ":name_attacher.store!" do
     it "puts a cached file into the store" do
       instance.document = Refile::FileDouble.new("hello")
       cache = instance.document
 
-      instance.document_attachment.store!
+      instance.document_attacher.store!
 
       expect(Refile.store.get(instance.document_id).read).to eq("hello")
       expect(Refile.store.get(instance.document.id).read).to eq("hello")
@@ -116,7 +115,7 @@ describe Refile::Attachment do
       file = Refile.store.upload(Refile::FileDouble.new("hello"))
       instance.document_id = file.id
 
-      instance.document_attachment.store!
+      instance.document_attacher.store!
 
       expect(Refile.store.get(instance.document_id).read).to eq("hello")
       expect(Refile.store.get(instance.document.id).read).to eq("hello")
@@ -129,7 +128,7 @@ describe Refile::Attachment do
       instance.document = Refile::FileDouble.new("world")
       cache = instance.document
 
-      instance.document_attachment.store!
+      instance.document_attacher.store!
 
       expect(Refile.store.get(instance.document_id).read).to eq("world")
       expect(Refile.store.get(instance.document.id).read).to eq("world")
@@ -143,20 +142,20 @@ describe Refile::Attachment do
       file = Refile.store.upload(Refile::FileDouble.new("hello"))
       instance.document_id = file.id
 
-      instance.document_attachment.remove = true
-      instance.document_attachment.store!
+      instance.document_attacher.remove = true
+      instance.document_attacher.store!
 
       expect(instance.document_id).to be_nil
       expect(Refile.store.exists?(file.id)).to be_falsy
     end
   end
 
-  describe ":name_attachment.delete!" do
+  describe ":name_attacher.delete!" do
     it "deletes a stored file" do
       file = Refile.store.upload(Refile::FileDouble.new("hello"))
       instance.document_id = file.id
 
-      instance.document_attachment.delete!
+      instance.document_attacher.delete!
 
       expect(instance.document_id).to be_nil
       expect(Refile.store.exists?(file.id)).to be_falsy
@@ -166,7 +165,7 @@ describe Refile::Attachment do
       file = Refile.cache.upload(Refile::FileDouble.new("hello"))
       instance.document_cache_id = file.id
 
-      instance.document_attachment.delete!
+      instance.document_attacher.delete!
 
       expect(instance.document_id).to be_nil
       expect(instance.document_cache_id).to be_nil
@@ -174,74 +173,92 @@ describe Refile::Attachment do
     end
   end
 
-  describe ":name_attachment.remove?" do
+  describe ":name_attacher.remove?" do
     it "should be true when the value is truthy" do
-      instance.document_attachment.remove = true
-      expect(instance.document_attachment.remove?).to be_truthy
+      instance.document_attacher.remove = true
+      expect(instance.document_attacher.remove?).to be_truthy
     end
 
     it "should be false when the value is falsey" do
-      instance.document_attachment.remove = false
-      expect(instance.document_attachment.remove?).to be_falsy
+      instance.document_attacher.remove = false
+      expect(instance.document_attacher.remove?).to be_falsy
     end
 
     it "should be false when the value is ''" do
-      instance.document_attachment.remove = ''
-      expect(instance.document_attachment.remove?).to be_falsy
+      instance.document_attacher.remove = ""
+      expect(instance.document_attacher.remove?).to be_falsy
     end
 
     it "should be false when the value is '0'" do
-      instance.document_attachment.remove = '0'
-      expect(instance.document_attachment.remove?).to be_falsy
+      instance.document_attacher.remove = "0"
+      expect(instance.document_attacher.remove?).to be_falsy
     end
 
     it "should be false when the value is 'false'" do
-      instance.document_attachment.remove = 'false'
-      expect(instance.document_attachment.remove?).to be_falsy
+      instance.document_attacher.remove = "false"
+      expect(instance.document_attacher.remove?).to be_falsy
     end
   end
 
-  describe ":name_attachment.error" do
+  describe ":name_attacher.error" do
     let(:options) { { cache: :limited_cache, raise_errors: false } }
 
     it "is blank when valid file uploaded" do
       file = Refile::FileDouble.new("hello")
       instance.document = file
 
-      expect(instance.document_attachment.errors).to be_empty
+      expect(instance.document_attacher.errors).to be_empty
       expect(Refile.cache.get(instance.document.id).exists?).to be_truthy
     end
 
     it "contains a list of errors when invalid file uploaded" do
-      file = Refile::FileDouble.new("a"*120)
+      file = Refile::FileDouble.new("a" * 120)
       instance.document = file
 
-      expect(instance.document_attachment.errors).to eq([:too_large])
+      expect(instance.document_attacher.errors).to eq([:too_large])
       expect(instance.document).to be_nil
     end
 
     it "is reset when valid file uploaded" do
-      file = Refile::FileDouble.new("a"*120)
+      file = Refile::FileDouble.new("a" * 120)
       instance.document = file
 
       file = Refile::FileDouble.new("hello")
       instance.document = file
 
-      expect(instance.document_attachment.errors).to be_empty
+      expect(instance.document_attacher.errors).to be_empty
       expect(Refile.cache.get(instance.document.id).exists?).to be_truthy
     end
   end
 
+  describe ":name_attacher.accept" do
+    context "with `extension`" do
+      let(:options) { { extension: %w[jpg png] } }
+
+      it "returns an accept string" do
+        expect(instance.document_attacher.accept).to eq(".jpg,.png")
+      end
+    end
+
+    context "with `content_type`" do
+      let(:options) { { content_type: %w[image/jpeg image/png], extension: "zip" } }
+
+      it "returns an accept string" do
+        expect(instance.document_attacher.accept).to eq("image/jpeg,image/png")
+      end
+    end
+  end
+
   describe "with option `raise_errors: true" do
     let(:options) { { cache: :limited_cache, raise_errors: true } }
 
     it "raises an error when invalid file assigned" do
-      file = Refile::FileDouble.new("a"*120)
+      file = Refile::FileDouble.new("a" * 120)
       expect do
         instance.document = file
       end.to raise_error(Refile::Invalid)
 
-      expect(instance.document_attachment.errors).to eq([:too_large])
+      expect(instance.document_attacher.errors).to eq([:too_large])
       expect(instance.document).to be_nil
     end
   end
@@ -250,10 +267,94 @@ describe Refile::Attachment do
     let(:options) { { cache: :limited_cache, raise_errors: false } }
 
     it "does not raise an error when invalid file assigned" do
-      file = Refile::FileDouble.new("a"*120)
+      file = Refile::FileDouble.new("a" * 120)
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to eq([:too_large])
+      expect(instance.document).to be_nil
+    end
+  end
+
+  describe "with option `extension`: %w[txt]`" do
+    let(:options) { { extension: "txt", raise_errors: false } }
+
+    it "allows file with correct extension to be uploaded" do
+      file = Refile::FileDouble.new("hello", "hello.txt")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to be_empty
+      expect(Refile.cache.get(instance.document.id).exists?).to be_truthy
+    end
+
+    it "sets error when file with other extension is uploaded" do
+      file = Refile::FileDouble.new("hello", "hello.php")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to eq([:invalid_extension])
+      expect(instance.document).to be_nil
+    end
+
+    it "sets error when file with no extension is uploaded" do
+      file = Refile::FileDouble.new("hello")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to eq([:invalid_extension])
+      expect(instance.document).to be_nil
+    end
+  end
+
+  describe "with option `content_type: %w[txt]`" do
+    let(:options) { { content_type: "text/plain", raise_errors: false } }
+
+    it "allows file with correct content type to be uploaded" do
+      file = Refile::FileDouble.new("hello", content_type: "text/plain")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to be_empty
+      expect(Refile.cache.get(instance.document.id).exists?).to be_truthy
+    end
+
+    it "sets error when file with other content type is uploaded" do
+      file = Refile::FileDouble.new("hello", content_type: "application/php")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to eq([:invalid_content_type])
+      expect(instance.document).to be_nil
+    end
+
+    it "sets error when file with no content type is uploaded" do
+      file = Refile::FileDouble.new("hello")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to eq([:invalid_content_type])
+      expect(instance.document).to be_nil
+    end
+  end
+
+  describe "with option `type: :image`" do
+    let(:options) { { type: :image, raise_errors: false } }
+
+    it "allows image to be uploaded" do
+      file = Refile::FileDouble.new("hello", content_type: "image/jpeg")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to be_empty
+      expect(Refile.cache.get(instance.document.id).exists?).to be_truthy
+    end
+
+    it "sets error when file with other content type is uploaded" do
+      file = Refile::FileDouble.new("hello", content_type: "application/php")
+      instance.document = file
+
+      expect(instance.document_attacher.errors).to eq([:invalid_content_type])
+      expect(instance.document).to be_nil
+    end
+
+    it "sets error when file with no content type is uploaded" do
+      file = Refile::FileDouble.new("hello")
       instance.document = file
 
-      expect(instance.document_attachment.errors).to eq([:too_large])
+      expect(instance.document_attacher.errors).to eq([:invalid_content_type])
       expect(instance.document).to be_nil
     end
   end

data/spec/refile/backend_examples.rb

@@ -3,10 +3,6 @@ RSpec.shared_examples_for :backend do
     Refile::FileDouble.new(data)
   end
 
-  def open_files
-    ObjectSpace.each_object(File).reject { |f| f.closed? } if defined?(ObjectSpace)
-  end
-
   describe "#upload" do
     it "raises ArgumentError when invalid object is uploaded" do
       expect { backend.upload(double(size: 123)) }.to raise_error(ArgumentError)
@@ -133,16 +129,20 @@ RSpec.shared_examples_for :backend do
     it "complains when called without confirm" do
       file = backend.upload(uploadable)
 
-      expect { backend.clear! }.to raise_error(ArgumentError)
+      expect { backend.clear! }.to raise_error(Refile::Confirm)
 
       expect(backend.get(file.id).exists?).to be_truthy
     end
   end
 
+  describe "#max_size" do
+    it "returns the given max size" do
+      expect(backend.max_size).to eq(100)
+    end
+  end
+
   describe "File" do
     it "is an io-like object" do
-      before = open_files
-
       file = backend.upload(uploadable)
 
       buffer = ""
@@ -159,16 +159,12 @@ RSpec.shared_examples_for :backend do
       file.close
 
       expect { file.read(1, buffer) }.to raise_error
-
-      expect(open_files).to eq(before)
     end
 
     describe "#read" do
       it "can read file contents" do
         file = backend.upload(uploadable)
 
-        buffer = ""
-
         expect(file.read).to eq("hello")
       end
 

data/spec/refile/features/direct_upload_spec.rb

@@ -26,4 +26,3 @@ feature "Direct HTTP post file uploads", :js do
     expect(page).to have_content("Upload failure error")
   end
 end
-

data/spec/refile/features/normal_upload_spec.rb

@@ -22,6 +22,16 @@ feature "Normal HTTP Post file uploads" do
     expect(page).to have_content("Document is too large")
   end
 
+  scenario "Fail to upload a file that has the wrong format" do
+    visit "/normal/posts/new"
+    fill_in "Title", with: "A cool post"
+    attach_file "Image", path("hello.txt")
+    click_button "Create"
+
+    expect(page).to have_selector(".field_with_errors")
+    expect(page).to have_content("Image has an invalid file format")
+  end
+
   scenario "Upload a file via form redisplay" do
     visit "/normal/posts/new"
     attach_file "Document", path("hello.txt")
@@ -61,6 +71,17 @@ feature "Normal HTTP Post file uploads" do
     expect(page).to_not have_selector(:link, "Document")
   end
 
+  scenario "Successfully remove a record with an uploaded file" do
+    visit "/normal/posts/new"
+    fill_in "Title", with: "A cool post about to be deleted"
+    attach_file "Document", path("hello.txt")
+    click_button "Create"
+
+    expect(page).to have_selector("h1", text: "A cool post about to be deleted")
+    click_link("Delete")
+    expect(page).to_not have_content("A cool post about to be deleted")
+  end
+
   scenario "Upload a file from a remote URL" do
     stub_request(:get, "http://www.example.com/some_file").to_return(status: 200, body: "abc", headers: { "Content-Length" => 3 })
 

data/spec/refile/features/presigned_upload_spec.rb

@@ -26,4 +26,3 @@ feature "Direct HTTP post file uploads", :js do
     expect(page).to have_content("Upload failure too large")
   end
 end
-

data/spec/refile/rails/attachment_helper_spec.rb

@@ -0,0 +1,61 @@
+require "refile"
+require "active_support/inflector"
+require "refile/rails/attachment_helper"
+
+describe Refile::AttachmentHelper do
+  describe "#attachment_url" do
+    let(:view) { Struct.new(:main_app, :request).new(main_app, request) }
+    let(:main_app) { double :main_app, refile_app_path: "attachments" }
+    let(:request) { double :request, base_url: "http://www.example.com" }
+    let(:record) { double :record, name: name, image: file }
+    let(:name) { :image }
+    let(:file) { double :file, backend: backend, id: "123abc" }
+    let(:backend) { double :backend }
+    before do
+      view.extend(Refile::AttachmentHelper)
+      Refile.backends["test_backend"] = backend
+    end
+    after do
+      Refile.backends.delete("test_backend")
+    end
+
+    context "with a host passed in" do
+      let(:host) { "//cdn.example.com" }
+
+      it "creates the expected url" do
+        url = view.attachment_url(record, name, "fill", 300, 300, filename: "test", format: "jpg", host: host)
+        expect(url).to eq "//cdn.example.com/attachments/test_backend/fill/300/300/123abc/test.jpg"
+      end
+    end
+
+    context "with no host passed in, but Refile.host set" do
+      before do
+        @original_host = Refile.host
+        Refile.host = "//cdn.example.com"
+      end
+      after do
+        Refile.host = @original_host
+      end
+
+      it "creates the expected url" do
+        url = view.attachment_url(record, name, "fill", 300, 300, filename: "test", format: "jpg")
+        expect(url).to eq "//cdn.example.com/attachments/test_backend/fill/300/300/123abc/test.jpg"
+      end
+    end
+
+    context "with no host passed in, and no Refile.host set" do
+      before do
+        @original_host = Refile.host
+        Refile.host = nil
+      end
+      after do
+        Refile.host = @original_host
+      end
+
+      it "creates the expected url" do
+        url = view.attachment_url(record, name, "fill", 300, 300, filename: "test", format: "jpg")
+        expect(url).to eq "http://www.example.com/attachments/test_backend/fill/300/300/123abc/test.jpg"
+      end
+    end
+  end
+end

data/spec/refile/spec_helper.rb

@@ -22,7 +22,7 @@ end
 
 Refile.backends["limited_cache"] = FakePresignBackend.new(File.expand_path("default_cache", tmp_path), max_size: 100)
 
-Refile.direct_upload = %w(cache limited_cache)
+Refile.direct_upload = %w[cache limited_cache]
 
 Refile.processor(:reverse) do |file|
   StringIO.new(file.read.reverse)
@@ -49,25 +49,30 @@ Refile.processor(:convert_case) do |file, format:|
   end
 end
 
-class Refile::FileDouble
-  def initialize(data)
-    @io = StringIO.new(data)
-  end
-
-  def read(*args)
-    @io.read(*args)
-  end
-
-  def size
-    @io.size
-  end
-
-  def eof?
-    @io.eof?
-  end
-
-  def close
-    @io.close
+module Refile
+  class FileDouble
+    attr_reader :original_filename, :content_type
+    def initialize(data, name = nil, content_type: nil)
+      @io = StringIO.new(data)
+      @original_filename = name
+      @content_type = content_type
+    end
+
+    def read(*args)
+      @io.read(*args)
+    end
+
+    def size
+      @io.size
+    end
+
+    def eof?
+      @io.eof?
+    end
+
+    def close
+      @io.close
+    end
   end
 end
 
@@ -80,6 +85,7 @@ end
 RSpec.configure do |config|
   config.include PathHelper
   config.before(:all) do
+    Refile.logger = Logger.new(nil)
     WebMock.disable_net_connect!(allow_localhost: true)
   end
 end

data/spec/refile/test_app/app/controllers/normal_posts_controller.rb

@@ -1,4 +1,8 @@
 class NormalPostsController < ApplicationController
+  def index
+    @posts = Post.all
+  end
+
   def show
     @post = Post.find(params[:id])
   end
@@ -31,7 +35,12 @@ class NormalPostsController < ApplicationController
     end
   end
 
-  private
+  def destroy
+    Post.find(params[:id]).destroy
+    redirect_to :normal_posts
+  end
+
+private
 
   def post_params
     params.require(:post).permit(:title, :image, :image_cache_id, :document, :document_cache_id, :remove_document, :remote_document_url)

data/spec/refile/test_app/app/controllers/presigned_posts_controller.rb

@@ -13,6 +13,7 @@ class PresignedPostsController < ApplicationController
     end
   end
 
+  # rubocop:disable Metrics/AbcSize
   def upload
     if params[:token] == "xyz123"
       if params[:file].size < 100

data/spec/refile/test_app/app/models/post.rb

@@ -1,5 +1,5 @@
 class Post < ActiveRecord::Base
-  attachment :image
+  attachment :image, type: :image
   attachment :document, cache: :limited_cache
   validates_presence_of :title
 end

data/spec/refile/test_app/app/views/normal_posts/index.html

@@ -0,0 +1,5 @@
+<h1>Posts</h1>
+
+<% @posts.each do |post| %>
+  <h2><%= post.title %></h2>
+<% end %>

data/spec/refile/test_app/app/views/normal_posts/show.html.erb

@@ -13,3 +13,5 @@
 <% end %>
 
 <%= link_to "Edit", edit_normal_post_url(@post) %>
+
+<%= link_to "Delete", normal_post_url(@post), method: :delete %>

data/spec/refile/test_app/config/routes.rb

@@ -2,7 +2,7 @@ Refile::TestApp.routes.draw do
   root to: "home#index"
 
   scope path: "normal", as: "normal" do
-    resources :posts, only: [:show, :new, :edit, :create, :update], controller: "normal_posts"
+    resources :posts, controller: "normal_posts"
   end
 
   scope path: "direct", as: "direct" do

data/spec/refile/test_app.rb

@@ -6,8 +6,8 @@ require "jquery/rails"
 
 module Refile
   class TestApp < Rails::Application
-    config.secret_token = '6805012ab1750f461ef3c531bdce84c0'
-    config.session_store :cookie_store, :key => '_refile_session'
+    config.secret_token = "6805012ab1750f461ef3c531bdce84c0"
+    config.session_store :cookie_store, key: "_refile_session"
     config.active_support.deprecation = :log
     config.eager_load = false
     config.action_dispatch.show_exceptions = false
@@ -21,7 +21,7 @@ end
 
 class TestMigration < ActiveRecord::Migration
   def self.up
-    create_table :posts, :force => true do |t|
+    create_table :posts, force: true do |t|
       t.column :title, :string
       t.column :image_id, :string
       t.column :document_id, :string
@@ -44,13 +44,20 @@ if ENV["SAUCE_BROWSER"]
     url = "http://#{ENV["SAUCE_USERNAME"]}:#{ENV["SAUCE_ACCESS_KEY"]}@localhost:4445/wd/hub"
     capabilities = { browserName: ENV["SAUCE_BROWSER"], version: ENV["SAUCE_VERSION"] }
     driver = Capybara::Selenium::Driver.new(app, browser: :remote, url: url, desired_capabilities: capabilities)
-    driver.browser.file_detector = lambda { |args| args.first if File.exist?(args.first) }
+    driver.browser.file_detector = ->(args) { args.first if File.exist?(args.first) }
     driver
   end
 end
 
 Capybara.configure do |config|
-  config.server_port = 56120
+  config.server_port = 56_120
 end
 
-Refile.host = "//127.0.0.1:56120"
+Refile.allow_origin = "*"
+Refile.host = "//localhost:56120"
+
+RSpec.configure do |config|
+  config.before(:all) do
+    Refile.logger = Rails.logger
+  end
+end

data/spec/refile_spec.rb

@@ -32,4 +32,43 @@ RSpec.describe Refile do
       expect { Refile.verify_uploadable(Refile::FileDouble.new("hello world"), 8) }.to raise_error(Refile::Invalid)
     end
   end
+
+  describe ".extract_filename" do
+    it "extracts filename from original_filename" do
+      name = Refile.extract_filename(double(original_filename: "/foo/bar/baz.png"))
+      expect(name).to eq("baz.png")
+    end
+
+    it "extracts filename from path" do
+      name = Refile.extract_filename(double(path: "/foo/bar/baz.png"))
+      expect(name).to eq("baz.png")
+    end
+
+    it "returns nil if it can't determine filename" do
+      name = Refile.extract_filename(double)
+      expect(name).to be_nil
+    end
+  end
+
+  describe ".extract_content_type" do
+    it "extracts content type" do
+      name = Refile.extract_content_type(double(content_type: "image/jpeg"))
+      expect(name).to eq("image/jpeg")
+    end
+
+    it "extracts content type from extension" do
+      name = Refile.extract_content_type(double(original_filename: "test.png"))
+      expect(name).to eq("image/png")
+    end
+
+    it "returns nil if it can't determine content type" do
+      name = Refile.extract_filename(double)
+      expect(name).to be_nil
+    end
+
+    it "returns nil if it has an unknown content type" do
+      name = Refile.extract_content_type(double(original_filename: "foo.blah"))
+      expect(name).to be_nil
+    end
+  end
 end