refile 0.2.2

data/spec/refile/features/presigned_upload_spec.rb

@@ -0,0 +1,29 @@
+require "refile/test_app"
+
+feature "Direct HTTP post file uploads", :js do
+  scenario "Successfully upload a file" do
+    visit "/presigned/posts/new"
+    fill_in "Title", with: "A cool post"
+    attach_file "Document", path("hello.txt")
+
+    expect(page).to have_content("Upload started")
+    expect(page).to have_content("Upload complete token accepted")
+    expect(page).to have_content("Upload success token accepted")
+
+    click_button "Create"
+
+    expect(page).to have_selector("h1", text: "A cool post")
+    result = Net::HTTP.get_response(URI(find_link("Document")[:href])).body.chomp
+    expect(result).to eq("hello")
+  end
+
+  scenario "Fail to upload a file that is too large" do
+    visit "/presigned/posts/new"
+    fill_in "Title", with: "A cool post"
+    attach_file "Document", path("large.txt")
+
+    expect(page).to have_content("Upload started")
+    expect(page).to have_content("Upload failure too large")
+  end
+end
+

data/spec/refile/fixtures/hello.txt

@@ -0,0 +1 @@
+hello

data/spec/refile/fixtures/large.txt

@@ -0,0 +1,44 @@
+Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec massa arcu,
+convallis a tellus vitae, placerat rhoncus nisi. Nullam molestie volutpat
+turpis vitae viverra. Integer nulla nisl, dictum et rutrum quis, auctor ut dui.
+Nulla imperdiet ante a lorem molestie tempor. Suspendisse pharetra in mauris
+mollis dapibus. Nullam pretium fringilla justo, faucibus condimentum elit
+rutrum ac. Vivamus sem justo, congue id lobortis nec, viverra ac lacus. Donec
+eu vestibulum risus, at efficitur nisl. Maecenas sed elit a dui malesuada
+ultricies at eget est. Duis lobortis tincidunt pellentesque.
+
+Quisque in nisl felis. Quisque a neque nec diam posuere mattis. Donec a nibh
+cursus, tempus est iaculis, gravida odio. Pellentesque eleifend enim eget
+placerat dignissim. Cum sociis natoque penatibus et magnis dis parturient
+montes, nascetur ridiculus mus. In non ex in augue feugiat convallis. Duis
+varius at sapien vitae molestie. Suspendisse sit amet aliquet quam, quis
+condimentum nibh.
+
+Donec a quam quis ipsum imperdiet semper. In ac scelerisque elit, non fermentum
+nisl. Nulla dapibus velit eget ullamcorper blandit. Maecenas justo diam,
+porttitor eget nunc dictum, sollicitudin lacinia lectus. Pellentesque non augue
+urna. In felis ipsum, posuere vitae sapien non, aliquet maximus nibh.
+Suspendisse potenti. Aenean venenatis euismod congue. Praesent quis ullamcorper
+sapien. In hac habitasse platea dictumst. Morbi semper augue dapibus, posuere
+justo sit amet, convallis felis. Vivamus condimentum elementum ex, quis rhoncus
+purus pulvinar et. Nunc vel risus sem. Suspendisse porttitor convallis massa,
+molestie sollicitudin metus semper a. Donec ac cursus tortor. Nam felis nulla,
+pretium eu tempus at, euismod eu erat.
+
+Donec vel tempus augue. Pellentesque sit amet ante in odio malesuada facilisis
+nec sit amet turpis. Donec vitae iaculis mauris. Aenean venenatis interdum
+quam, nec tincidunt mauris aliquam vel. Nunc ultrices arcu euismod velit
+ultricies, id laoreet arcu venenatis. Donec euismod scelerisque magna, nec
+interdum lorem ornare nec. Morbi blandit volutpat velit, consequat maximus
+justo mattis non. In pellentesque malesuada consectetur. Cras convallis mi ut
+nibh rutrum ullamcorper. Nam finibus consequat erat a feugiat. Donec laoreet
+risus eget enim interdum dictum. Duis orci lectus, scelerisque tempus volutpat
+eget, ullamcorper eu felis. Aliquam tempor in dui sit amet dapibus. Nulla sed
+metus vestibulum, dignissim odio et, dapibus eros. Praesent semper arcu ut
+augue suscipit, ac ornare tortor auctor. Suspendisse a velit dui.
+
+Etiam nec est ut ex laoreet iaculis vel id enim. Vivamus ac hendrerit leo.
+Vestibulum auctor nibh nec arcu rhoncus, a condimentum quam accumsan. Ut justo
+augue, laoreet at bibendum vel, aliquet vitae est. Aliquam accumsan ac diam nec
+pretium. Nulla dictum velit nec elementum mollis. Interdum et malesuada fames
+ac ante ipsum primis in faucibus.

data/spec/refile/spec_helper.rb

@@ -0,0 +1,58 @@
+require "pry"
+require "refile"
+require "refile/backend_examples"
+
+tmp_path = Dir.mktmpdir
+
+at_exit do
+  FileUtils.remove_entry_secure(tmp_path)
+end
+
+Refile.store = Refile::Backend::FileSystem.new(File.expand_path("default_store", tmp_path))
+Refile.cache = Refile::Backend::FileSystem.new(File.expand_path("default_cache", tmp_path))
+
+class FakePresignBackend < Refile::Backend::FileSystem
+  Signature = Struct.new(:as, :id, :url, :fields)
+
+  def presign
+    id = Refile::RandomHasher.new.hash
+    Signature.new("file", id, "/presigned/posts/upload", { token: "xyz123", id: id })
+  end
+end
+
+Refile.backends["limited_cache"] = FakePresignBackend.new(File.expand_path("default_cache", tmp_path), max_size: 100)
+
+Refile.direct_upload = ["cache", "limited_cache"]
+
+class Refile::FileDouble
+  def initialize(data)
+    @io = StringIO.new(data)
+  end
+
+  def read(*args)
+    @io.read(*args)
+  end
+
+  def size
+    @io.size
+  end
+
+  def eof?
+    @io.eof?
+  end
+
+  def close
+    @io.close
+  end
+end
+
+module PathHelper
+  def path(filename)
+    File.expand_path(File.join("fixtures", filename), File.dirname(__FILE__))
+  end
+end
+
+RSpec.configure do |config|
+  config.include PathHelper
+end
+

data/spec/refile/test_app.rb

@@ -0,0 +1,46 @@
+require "rails/all"
+
+require "refile"
+require "refile/rails"
+require "jquery/rails"
+
+module Refile
+  class TestApp < Rails::Application
+    config.secret_token = '6805012ab1750f461ef3c531bdce84c0'
+    config.session_store :cookie_store, :key => '_refile_session'
+    config.active_support.deprecation = :log
+    config.eager_load = false
+    config.action_dispatch.show_exceptions = false
+    config.consider_all_requests_local = true
+    config.root = ::File.expand_path("test_app", ::File.dirname(__FILE__))
+  end
+
+  Rails.backtrace_cleaner.remove_silencers!
+  TestApp.initialize!
+end
+
+class TestMigration < ActiveRecord::Migration
+  def self.up
+    create_table :posts, :force => true do |t|
+      t.column :title, :string
+      t.column :image_id, :string
+      t.column :document_id, :string
+    end
+  end
+end
+
+quietly do
+  TestMigration.up
+end
+
+require "rspec"
+require "rspec/rails"
+require "capybara/rails"
+require "capybara/rspec"
+require "refile/spec_helper"
+
+Capybara.configure do |config|
+  config.server_port = 56120
+end
+
+Refile.host = "//127.0.0.1:56120"

data/spec/refile/test_app/app/assets/javascripts/application.js

@@ -0,0 +1,40 @@
+//= require jquery
+//= require refile
+
+"use strict";
+
+document.addEventListener("DOMContentLoaded", function() {
+  var form = document.querySelector("form#direct");
+
+  if(form) {
+    var input = document.querySelector("#post_document");
+
+    form.addEventListener("upload:start", function() {
+      var p = document.createElement("p");
+      p.textContent = "Upload started";
+      form.appendChild(p);
+    });
+
+    form.addEventListener("upload:complete", function(e) {
+      var p = document.createElement("p");
+      p.textContent = "Upload complete " + e.detail;
+      form.appendChild(p);
+    });
+
+    form.addEventListener("upload:progress", function(e) {
+      var p = document.createElement("p");
+      p.textContent = "Upload progress " + e.detail.loaded + " " + e.detail.total;
+      form.appendChild(p);
+    });
+
+    form.addEventListener("upload:failure", function(e) {
+      var p = document.createElement("p");
+      p.textContent = "Upload failure " + e.detail
+      form.appendChild(p);
+    });
+  }
+});
+
+$(document).on("upload:success", "form#direct", function(e) {
+  $("<p></p>").text("Upload success " + e.originalEvent.detail).appendTo(this);
+});

data/spec/refile/test_app/app/controllers/application_controller.rb

@@ -0,0 +1,2 @@
+class ApplicationController < ActionController::Base
+end

data/spec/refile/test_app/app/controllers/direct_posts_controller.rb

@@ -0,0 +1,15 @@
+class DirectPostsController < ApplicationController
+  def new
+    @post = Post.new
+  end
+
+  def create
+    @post = Post.new(params.require(:post).permit(:title, :document_cache_id))
+
+    if @post.save
+      redirect_to [:normal, @post]
+    else
+      render :new
+    end
+  end
+end

data/spec/refile/test_app/app/controllers/home_controller.rb

@@ -0,0 +1,4 @@
+class HomeController < ApplicationController
+  def index
+  end
+end

data/spec/refile/test_app/app/controllers/normal_posts_controller.rb

@@ -0,0 +1,19 @@
+class NormalPostsController < ApplicationController
+  def new
+    @post = Post.new
+  end
+
+  def show
+    @post = Post.find(params[:id])
+  end
+
+  def create
+    @post = Post.new(params.require(:post).permit(:title, :image, :image_cache_id, :document, :document_cache_id))
+
+    if @post.save
+      redirect_to [:normal, @post]
+    else
+      render :new
+    end
+  end
+end

data/spec/refile/test_app/app/controllers/presigned_posts_controller.rb

@@ -0,0 +1,30 @@
+class PresignedPostsController < ApplicationController
+  def new
+    @post = Post.new
+  end
+
+  def create
+    @post = Post.new(params.require(:post).permit(:title, :document_cache_id))
+
+    if @post.save
+      redirect_to [:normal, @post]
+    else
+      render :new
+    end
+  end
+
+  def upload
+    if params[:token] == "xyz123"
+      if params[:file].size < 100
+        File.open(File.join(Refile.backends["limited_cache"].directory, params[:id]), "wb") do |file|
+          file.write(params[:file].read)
+        end
+        render text: "token accepted"
+      else
+        render text: "too large", status: 413
+      end
+    else
+      render text: "token rejected", status: 403
+    end
+  end
+end

data/spec/refile/test_app/app/models/post.rb

@@ -0,0 +1,5 @@
+class Post < ActiveRecord::Base
+  attachment :image
+  attachment :document, cache: :limited_cache
+  validates_presence_of :title
+end

data/spec/refile/test_app/app/views/direct_posts/new.html.erb

@@ -0,0 +1,16 @@
+<%= form_for [:direct, @post], html: { id: "direct" } do |form| %>
+  <p>
+    <%= @post.errors.full_messages.to_sentence %>
+  </p>
+  <p>
+    <%= form.label :title %>
+    <%= form.text_field :title %>
+  </p>
+  <p>
+    <%= form.label :document %>
+    <%= form.attachment_field :document, direct: true %>
+  </p>
+  <p>
+    <%= form.submit "Create" %>
+  </p>
+<% end %>

data/spec/refile/test_app/app/views/home/index.html.erb

@@ -0,0 +1 @@
+<h1>Hello world</h1>

data/spec/refile/test_app/app/views/layouts/application.html.erb

@@ -0,0 +1,14 @@
+<!doctype html>
+
+<html>
+  <head>
+    <%= javascript_include_tag "application" %>
+
+  </head>
+
+  <body>
+    <h1>Refile Test App</h1>
+
+    <%= yield %>
+  </body>
+</html>

data/spec/refile/test_app/app/views/normal_posts/new.html.erb

@@ -0,0 +1,20 @@
+<%= form_for [:normal, @post] do |form| %>
+  <p>
+    <%= @post.errors.full_messages.to_sentence %>
+  </p>
+  <p>
+    <%= form.label :title %>
+    <%= form.text_field :title %>
+  </p>
+  <p>
+    <%= form.label :image %>
+    <%= form.attachment_field :image %>
+  </p>
+  <p>
+    <%= form.label :document %>
+    <%= form.attachment_field :document %>
+  </p>
+  <p>
+    <%= form.submit "Create" %>
+  </p>
+<% end %>

data/spec/refile/test_app/app/views/normal_posts/show.html.erb

@@ -0,0 +1,9 @@
+<h1><%= @post.title %></h1<>
+
+<% if @post.image %>
+  <%= attachment_image_tag(@post, :image) %>
+<% end %>
+
+<% if @post.document %>
+  <%= link_to "Document", attachment_url(@post, :document) %>
+<% end %>

data/spec/refile/test_app/app/views/presigned_posts/new.html.erb

@@ -0,0 +1,16 @@
+<%= form_for [:presigned, @post], html: { id: "direct" } do |form| %>
+  <p>
+    <%= @post.errors.full_messages.to_sentence %>
+  </p>
+  <p>
+    <%= form.label :title %>
+    <%= form.text_field :title %>
+  </p>
+  <p>
+    <%= form.label :document %>
+    <%= form.attachment_field :document, presigned: true %>
+  </p>
+  <p>
+    <%= form.submit "Create" %>
+  </p>
+<% end %>

data/spec/refile/test_app/config/database.yml

@@ -0,0 +1,7 @@
+development: &default
+  adapter: "sqlite3"
+  database: "db/db.sqlite"
+  verbosity: "quiet"
+
+test:
+  <<: *default

data/spec/refile/test_app/config/routes.rb

@@ -0,0 +1,17 @@
+Refile::TestApp.routes.draw do
+  root to: "home#index"
+
+  scope path: "normal", as: "normal" do
+    resources :posts, only: [:new, :create, :show], controller: "normal_posts"
+  end
+
+  scope path: "direct", as: "direct" do
+    resources :posts, only: [:new, :create], controller: "direct_posts"
+  end
+
+  scope path: "presigned", as: "presigned" do
+    resources :posts, only: [:new, :create], controller: "presigned_posts" do
+      post :upload, on: :collection
+    end
+  end
+end

data/spec/refile_spec.rb

@@ -0,0 +1,35 @@
+require "refile"
+
+RSpec.describe Refile do
+  let(:io) { StringIO.new("hello") }
+
+  describe ".verify_uploadable" do
+    it "works if it conforms to required API" do
+      expect(Refile.verify_uploadable(double(size: 444, read: io, eof?: true, close: nil), nil)).to be_truthy
+    end
+
+    it "raises ArgumentError if argument does not respond to `size`" do
+      expect { Refile.verify_uploadable(double(read: io, eof?: true, close: nil), nil) }.to raise_error(ArgumentError)
+    end
+
+    it "raises ArgumentError if argument does not respond to `read`" do
+      expect { Refile.verify_uploadable(double(size: 444, eof?: true, close: nil), nil) }.to raise_error(ArgumentError)
+    end
+
+    it "raises ArgumentError if argument does not respond to `eof?`" do
+      expect { Refile.verify_uploadable(double(size: 444, read: true, close: nil), nil) }.to raise_error(ArgumentError)
+    end
+
+    it "raises ArgumentError if argument does not respond to `close`" do
+      expect { Refile.verify_uploadable(double(size: 444, read: true, eof?: true), nil) }.to raise_error(ArgumentError)
+    end
+
+    it "returns true if size is respeced" do
+      expect(Refile.verify_uploadable(Refile::FileDouble.new("hello"), 8)).to be_truthy
+    end
+
+    it "raises Refile::Invalid if size is exceeded" do
+      expect { Refile.verify_uploadable(Refile::FileDouble.new("hello world"), 8) }.to raise_error(Refile::Invalid)
+    end
+  end
+end