refile-postgres 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcbf870ad7c94880999b64a72c48264070344114
-  data.tar.gz: e9015db34ee5fcc3e39963894d9b1fe2c3bc4827
+  metadata.gz: 3750ff6ae5e70ecd23b619f28d6a3c9a12150d09
+  data.tar.gz: ccaf3d9739e3b80e7c4ebbf76de3b124c33064ae
 SHA512:
-  metadata.gz: 8164bf9a9cd8dc25d88c809490ba28ed3dd9b1b997da8a892a9a30022c39cfe0dba14ecbc574f2744392b5950a0f9b095308d10cd4e163e102f62d0c855522a7
-  data.tar.gz: 0a84dff267e690011f4a219042b6e674409fa1249555671ca248e8dd52c8f073afc0bdd2e92afc1111d711266cf828619386316088cf4188550b35ec1fc2a7dc
+  metadata.gz: 2983f0299c9d796c8ba4a1b1831612b4bf2633ee410c7897aa4ad3da5b4f9b6acb1276fc576b8e7dd819504ab4b383fe00de5264b90b5df7339cf0398f0fc173
+  data.tar.gz: 16d74a9439671ae6ffd5a3970dad6b987619d56c8941bd8586673344d6ef44c33410cef0415aa5754b53014cf24d8d9b66f28dc59deb0be93589a2f20dae1e21

data/README.md

@@ -4,6 +4,7 @@ A PostgreSQL backend for [Refile](https://github.com/elabs/refile).
 
 [![Build Status](https://travis-ci.org/krists/refile-postgres.svg?branch=master)](https://travis-ci.org/krists/refile-postgres)
 [![Code Climate](https://codeclimate.com/github/krists/refile-postgres/badges/gpa.svg)](https://codeclimate.com/github/krists/refile-postgres)
+[![Test Coverage](https://codeclimate.com/github/krists/refile-postgres/badges/coverage.svg)](https://codeclimate.com/github/krists/refile-postgres/coverage)
 
 ## Why?
 

data/lib/refile/postgres/backend.rb

@@ -23,7 +23,7 @@ module Refile
         unless @registry_table_validated
           with_connection do |connection|
             connection.exec_params("SELECT * FROM pg_catalog.pg_tables WHERE tablename = $1::varchar;", [@registry_table]) do |result|
-              if result.count != 1
+              if result.count == 0
                 raise RegistryTableDoesNotExistError.new(%{Please create a table "#{@registry_table}" where backend could store list of attachments})
               end
             end

data/lib/refile/postgres/version.rb

@@ -1,5 +1,5 @@
 module Refile
   module Postgres
-    VERSION = "1.2.0"
+    VERSION = "1.2.1"
   end
 end

data/spec/refile/postgres/backend_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe Refile::Postgres::Backend do
-  let(:connection) { PG.connect(dbname: 'refile_test') }
+  let(:connection) { test_connection }
   let(:backend) { Refile::Postgres::Backend.new(connection_or_proc, max_size: 100) }
 
   context "Connection tests" do
@@ -21,6 +21,7 @@ describe Refile::Postgres::Backend do
           }.to raise_error(ArgumentError, "When initializing new Refile::Postgres::Backend first argument should be an instance of PG::Connection or a lambda/proc that yields it.")
         end
       end
+
       context "when lambda does yield a PG::Connection" do
         let(:connection_or_proc) { lambda { |&blk| blk.call(connection) } }
         it "is usable in queries" do
@@ -30,6 +31,39 @@ describe Refile::Postgres::Backend do
     end
   end
 
+  describe "#registry_table" do
+    context "when no registry table is present" do
+      it "raises an exception" do
+        drop_registry_table
+        expect {
+          Refile::Postgres::Backend.new(test_connection, max_size: 100).registry_table
+        }.to raise_error Refile::Postgres::Backend::RegistryTableDoesNotExistError
+      end
+    end
+
+    context "when registry tables exist in multiple schemas" do
+      before do
+        test_connection.exec %{
+          CREATE SCHEMA other_schema;
+          CREATE TABLE IF NOT EXISTS other_schema.#{Refile::Postgres::Backend::DEFAULT_REGISTRY_TABLE}
+          ( id serial NOT NULL );
+        }
+      end
+
+      after do
+        test_connection.exec %{
+          DROP SCHEMA other_schema CASCADE;
+        }
+      end
+
+      it "does not raise an exception" do
+        expect {
+          Refile::Postgres::Backend.new(test_connection, max_size: 100).registry_table
+        }.not_to raise_error
+      end
+    end
+  end
+
   context "Refile Provided tests" do
     let(:connection_or_proc) { connection }
     it_behaves_like :backend

data/spec/spec_helper.rb

@@ -11,11 +11,13 @@ require "refile/postgres"
 
 WebMock.disable!(:except => [:codeclimate_test_reporter])
 
-RSpec.configure do |config|
-  config.before(:all) do
-    connection = PG.connect(host: 'localhost', dbname: 'refile_test', user: 'refile_postgres_test_user', password: 'refilepostgres')
-    connection.exec %{ DROP TABLE IF EXISTS #{Refile::Postgres::Backend::DEFAULT_REGISTRY_TABLE} CASCADE; }
-    connection.exec %{
+module DatabaseHelpers
+  def test_connection
+    @@connection ||= PG.connect(host: 'localhost', dbname: 'refile_test', user: 'refile_postgres_test_user', password: 'refilepostgres')
+  end
+
+  def create_registy_table
+    test_connection.exec %{
       CREATE TABLE IF NOT EXISTS #{Refile::Postgres::Backend::DEFAULT_REGISTRY_TABLE}
       (
         id serial NOT NULL,
@@ -27,4 +29,18 @@ RSpec.configure do |config|
       );
     }
   end
+
+  def drop_registry_table
+    test_connection.exec %{ DROP TABLE IF EXISTS #{Refile::Postgres::Backend::DEFAULT_REGISTRY_TABLE} CASCADE; }
+  end
+end
+
+RSpec.configure do |config|
+  config.include DatabaseHelpers
+
+  config.around(:each) do |example|
+    create_registy_table
+    example.run
+    drop_registry_table
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: refile-postgres
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Krists Ozols
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-01 00:00:00.000000000 Z
+date: 2016-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: refile
@@ -209,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Postgres database as a backend for Refile