refacebook 0.4.1 → 0.4.2

data/README.txt

@@ -10,15 +10,9 @@ ReFacebook is a facebook library and Sinatra extension.
 
 * Need to document the code.
 * Need helpers to make life easier.
-* Abstract the session store so it's not reliant on the set and get. Also,
-  remove the :store option eventually since that seems like a copout method
-  and doesn't add simplicity. 
-* Make the api spit out an exception if call returns error.
 * Have a better example application with fbml, api, and all that good stuff.
-* Write unit tests
 * Test with ruby 1.9, remove json dep if 1.9 since json is included.
 
-
 == SYNOPSIS:
 
 To see how to use the library please look at examples/example.rb
@@ -26,7 +20,7 @@ To see how to use the library please look at examples/example.rb
 == REQUIREMENTS:
 
 RubyGems
-* json
+* json or json-jruby
 * memcache-client
 
 == INSTALL:

data/Rakefile

@@ -3,6 +3,14 @@
 require 'rubygems'
 require './lib/refacebook.rb'
 
+begin
+  require 'spec/rake/spectask'
+rescue LoadError
+  puts 'To use rspec for testing you must install rspec gem:'
+  puts '$ sudo gem install rspec'
+  exit
+end
+
 begin
   require 'jeweler'
   Jeweler::Tasks.new do |gemspec|
@@ -14,12 +22,9 @@ begin
     gemspec.authors = ["Abhi Yerra"]
     gemspec.rubyforge_project = "refacebook"
 
-    if defined?(JRUBY_VERSION)
-      gemspec.add_dependency("json-jruby", [">= 1.1.3"])
-    else
-      gemspec.add_dependency("json", [">= 1.1.4"])
-    end
-
+    # Should use json-jruby if using JRuby
+    gemspec.add_dependency("json-jruby", [">= 1.1.3"])
+    gemspec.add_dependency("json", [">= 1.1.4"])
     gemspec.add_dependency("memcache-client", [">= 1.7.1"])
   end
 rescue LoadError
@@ -52,4 +57,10 @@ rescue LoadError
   puts "Rake SshDirPublisher is unavailable or your rubyforge environment is not configured."
 end
 
+desc "Runnings the specs"
+Spec::Rake::SpecTask.new do |t|
+  t.spec_files = FileList['spec/**/*_spec.rb']
+end
+
+task :default => :spec
 # vim: syntax=Ruby

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
 :minor: 4
 :major: 0
-:patch: 1
+:patch: 2

data/lib/refacebook.rb

@@ -63,24 +63,34 @@ module ReFacebook
       @session_key = nil
     end
 
+    # FIXME: Implement.
+    def batch_run *args
+      raise 
+    end
+
     def method_missing method, *args
       request = {}
 
-      args[0].each {|k,v| request[k.to_s] = v } if args[0]
+      args[0].each do |k,v| 
+        request[k.to_s] = v.kind_of?(Array) ? v.to_json : v
+      end if args[0]
 
       request['api_key'] = @api_key
-      request['format'] = 'json' unless request['json']
+      request['format'] = 'json' unless request['format']
       request['method'] = method.to_s.gsub(/_/, '.')
-      request['session_key'] = @session_key if @session
+      request['session_key'] = @session_key if @session_key
       request['v'] = '1.0' unless request['v']
 
       request['sig'] = generate_sig(request.sort)
 
-      # FIXME: Implement.
-      return if request['method'].eql? 'batch.run'
-  
       req = Net::HTTP.post_form(URI.parse(APIRestServer), request)
-      JSON.parse("[#{req.body}]")
+      ret = JSON.parse("[#{req.body}]")[0]
+
+      if ret.class == Hash && ret.has_key?('error_code')
+        raise APIError.new(ret), ret['error_msg']
+      end
+
+      ret
     end
 
     private
@@ -93,4 +103,13 @@ module ReFacebook
         MD5.hexdigest(request_str.concat(@secret));
       end
   end
+
+  class APIError < StandardError
+    attr_reader :error_code, :error_msg
+
+    def initialize(response)
+      @error_code = response['error_code']
+      @error_msg = response['error_msg']
+    end
+  end
 end

data/spec/api_spec.rb

@@ -0,0 +1,62 @@
+$:.push('lib/')
+
+require 'rubygems'
+require 'json'
+require "refacebook"
+
+describe ReFacebook::API do
+  before(:each) do
+    @api = ReFacebook::API.new('2a7a86cd4ea39bb7ea4eaabb938acb86', '662361041ddcb4b3f7df0f4b092249ee')
+
+    violated "api was not created" unless @api
+  end
+
+  it "does a sample call without parameter" do
+    begin
+      token = @api.auth_createToken
+      token.class.should == String
+    rescue ReFacebook::APIError => e
+      violated "failed with #{e.error_code}: #{e.error_msg}"
+    end
+  end
+
+  it "does a sample call with parameter" do
+    begin
+      app_properties = @api.admin_getAppProperties :properties => ['application_name','callback_url']
+      app_properties = JSON.parse(app_properties)
+      app_properties['application_name'].should == 'traytwo'
+    rescue ReFacebook::APIError => e
+      violated "failed with #{e.error_code}: #{e.error_msg}"
+    end
+  end
+
+  it "does a call with an incorrect api key" do
+    # Bad secret key
+    @api = ReFacebook::API.new('2a7a86cd4ea39bb7ea4eaabb938acb8', '662361041ddcb4b3f7df0f4b092249ee')
+    begin
+      token = @api.auth_createToken
+      violated "api did not throw error"
+    rescue ReFacebook::APIError => e
+      e.error_code.should == 101
+    end
+  end
+
+  it "does a call with an incorrect secret key" do
+    # Bad secret key
+    @api = ReFacebook::API.new('2a7a86cd4ea39bb7ea4eaabb938acb86', '662361041ddcb4b3f7df0f4b092249e')
+    begin
+      token = @api.auth_createToken
+      violated "api did not throw error"
+    rescue ReFacebook::APIError => e
+      e.error_code.should == 104
+    end
+  end
+
+  it "does a batch.run" do
+    # violated "not implemented yet"
+  end 
+
+  it "creates a session" do
+    # violated "not implemented yet"
+  end 
+end

metadata

@@ -34,7 +34,7 @@ files:
 - examples/example.rb
 - lib/refacebook.rb
 - lib/refacebook/sinatra.rb
-- test/test_refacebook.rb
+- spec/api_spec.rb
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - '>='
@@ -48,13 +48,13 @@ requirements: []
 
 authors: 
 - Abhi Yerra
-date: 2009-04-13 00:00:00 Z
+date: 2009-04-14 00:00:00 Z
 platform: ruby
 test_files: 
-- test/test_refacebook.rb
+- spec/api_spec.rb
 - examples/example.rb
 version: !ruby/object:Gem::Version 
-  version: 0.4.1
+  version: 0.4.2
 require_paths: 
 - lib
 dependencies: 
@@ -68,6 +68,16 @@ dependencies:
   type: :runtime
   version_requirement: 
   name: json-jruby
+- !ruby/object:Gem::Dependency 
+  version_requirements: !ruby/object:Gem::Requirement 
+    requirements: 
+    - - '>='
+      - !ruby/object:Gem::Version 
+        version: 1.1.4
+    version: 
+  type: :runtime
+  version_requirement: 
+  name: json
 - !ruby/object:Gem::Dependency 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 

data/test/test_refacebook.rb

@@ -1,8 +0,0 @@
-require "test/unit"
-require "refacebook"
-
-class TestRefacebook < Test::Unit::TestCase
-  def test_sanity
-    flunk "write tests or I will kneecap you"
-  end
-end