ref2bibtex 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c7a6d2f188260ac456c771d9ec65929e9ab7ec5c
-  data.tar.gz: d6f2310879d26fd8624abb4249d995180b25b7dc
+  metadata.gz: d7757e8fcfbfeccc415e91c00e4f2302b0ce37c4
+  data.tar.gz: 1bf31207bbc840f4ac1cd0617eb06713d47b1340
 SHA512:
-  metadata.gz: 46c5683d946d88659da4f14178f53e1bd276887a4701d84e4541b40321f3d0d1faf3d3bf4b83aaba11c9ff01821a1f3ed0b8cc0b59102b3e84bd6f3adbf4113f
-  data.tar.gz: 899c78be357a1b5e85bdc462a7ccda12f94d9a3050f1c0758cecd36db8a16f34b62a5d77443572205da531382304674a97a94d556128b70ee2cfc914e04f9b3b
+  metadata.gz: 09316afcae92969335e4c421860aa5a2ac56f816039b58e581ba1afd34169b4f1b57cfc317db1e178ea2be35446955b6c46e35d59717bf02dbc5eecef1c82258
+  data.tar.gz: 4dcafb5dca149065d4c9e71921fff3f26dc0a8f004609fd25ca31ae4e11f9464b926a78bcf5e84c60f0edbff7974e19b0d3c3e2878c07030b2553faf7fd495b7

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    ref2bibtex (0.0.1)
+    ref2bibtex (0.0.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -44,10 +44,10 @@ The code is dumb, it takes the first.
 acknowledgements
 ================
 
-The Crossref API, and John Hill for his Python version.
+The Crossref API, and Jon Hill, University of York, for his Python version and bringing up the approach.
 
 license
 =======
 
-NCSA, UI flavour.
+NCSA, UI flavor. [http://opensource.org/licenses/NCSA]
 

data/lib/ref2bibtex/version.rb

@@ -1,3 +1,3 @@
 module Ref2bibtex
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/ref2bibtex.rb

@@ -22,7 +22,9 @@ module Ref2bibtex
   # Pass a String doi get a bibtex formatted string back 
   def self.get_bibtex(doi)
     return false if !doi
-    response = Ref2bibtex.request(URI(doi), headers: {'Accept' => 'application/x-bibtex' }, protocol: 'GET', process_response_as: 'text') 
+    uri = URI(doi)
+    return false if uri.class == URI::Generic
+    response = Ref2bibtex.request(uri, headers: {'Accept' => 'application/x-bibtex' }, protocol: 'GET', process_response_as: 'text') 
   end
 
   # Pass a String citation, get a doi back

data/ref2bibtex.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Matt Yoder"]
   spec.email         = ["diapriid@gmail.com"]
   spec.summary       = %q{Pass a full citation, get the bibtex back, that's all.}
-  spec.description   = %q{Ok, maybe a bit more, you can have the DOI too.}
+  spec.description   = %q{Ok, maybe a bit more, you can pass a DOI and get the bibtex string back too.}
   spec.homepage      = "http://github.com/SpeciesFileGroup/ref2bibtex"
   spec.license       = "MIT"
 

data/spec/ref2bibtex_spec.rb

@@ -34,6 +34,10 @@ describe Ref2bibtex do
     specify 'a citation that can not be resolved returns false' do
       expect(Ref2bibtex.get_doi(CITATIONS[:fifth])).to eq(false)
     end
+
+    specify 'a badly formed DOI returns false' do
+      expect(Ref2bibtex.get_doi('asfas')).to eq(false)
+    end
   end
 
   context '#get_bibtex' do
@@ -43,6 +47,10 @@ describe Ref2bibtex do
       expect(response).to match(/title\s=/)
       expect(response).to match(/year\s=\s2009/)
     end
+
+    specify 'a bad doi returns false' do
+      expect(Ref2bibtex.get_bibtex('asfasf')).to eq(false)
+    end
   end
 
   specify "a citation that can not be resolved returns false" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ref2bibtex
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Matt Yoder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,7 +66,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Ok, maybe a bit more, you can have the DOI too.
+description: Ok, maybe a bit more, you can pass a DOI and get the bibtex string back
+  too.
 email:
 - diapriid@gmail.com
 executables: []