reek 4.6.1 → 4.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a703ee92e2eee612e747e83dd8f7262cc889a347
-  data.tar.gz: 2cd0f17e74826fabc001c770a96f7cc24545ced3
+  metadata.gz: 621c25e4d095d1164a97aea57967dcf79f1961ec
+  data.tar.gz: 4e9dbb2eee9bec1ac8616811b1895631206cd394
 SHA512:
-  metadata.gz: 3bc0fe4ede8578d81c431bda322171cc240daaa3502da110fe98ecd6cd927fd7d336b83a813df6dff2acfd7d685fc70248e490f51cce4ede9ade528b80ff0e34
-  data.tar.gz: 8387daed0291caee16f71bd78c9dd3477d1cad1220e7998618039d937b5c017f5ca5fc95182268e7793d4ea975ac88a50a4d8fbd1b494fd02ad32a4c8f908095
+  metadata.gz: d5c4bf0e5c8f2b344b5bec3c386599e1a2d2eadc6e70c484146d771190fcc6fba24986a7747654962caaac5f27c625a49d2f11a5f9f0c8f375b34b309945178b
+  data.tar.gz: a98dab6abcd0ffdc95695ba0883ca078ae9fa3b50d0493bf1d89f3677947d7056d5a3e7529eb9611ad5a50d1ab1efb682f2611247cd0d7225e3d4fcc12396ccb

data/.rubocop.yml

@@ -8,6 +8,10 @@ AllCops:
     - 'vendor/**/*'
   TargetRubyVersion: 2.1
 
+# Assume the programmer knows how bracketed block syntax works
+Lint/AmbiguousBlockAssociation:
+  Enabled: false
+
 Lint/HandleExceptions:
   Exclude:
     - 'spec/reek/configuration/configuration_file_finder_spec.rb'
@@ -106,6 +110,10 @@ Style/FrozenStringLiteralComment:
     - 'lib/**/*'
   EnforcedStyle: always
 
+# Use active_support's strip_heredoc to indent heredocs
+Style/IndentHeredoc:
+  EnforcedStyle: active_support
+
 # Allow multiline block chains
 Style/MultilineBlockChain:
   Enabled: false
@@ -126,6 +134,14 @@ Style/MultilineOperationIndentation:
 Style/ParallelAssignment:
   Enabled: false
 
+Style/PercentLiteralDelimiters:
+  PreferredDelimiters:
+    default: ()
+    '%W': ()
+    '%I': ()
+    '%w': ()
+    '%i': ()
+
 # Allow Perl-style references to regex matches
 Style/PerlBackrefs:
   Enabled: false
@@ -134,6 +150,10 @@ Style/PerlBackrefs:
 Style/SingleLineMethods:
   Enabled: false
 
+# Prefer symbols to look like symbols
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
 # Allow small arrays of words with quotes
 Style/WordArray:
   MinSize: 4

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change log
 
+## 4.6.2 (2017-04-27)
+
+* (pocke) Prevent from breaking on a string with escape sequence incompatible with UTF-8
+* (pocke) Use Ruby 2.4 parser for parsing code
+
 ## 4.6.1 (2017-04-05)
 
 * (IanWhitney) Properly handle absolute paths.

data/Gemfile

@@ -16,8 +16,8 @@ group :development do
   gem 'yard',          '~> 0.9.5'
 
   if RUBY_VERSION >= '2.3'
-    gem 'rubocop',       '~> 0.47.1'
-    gem 'rubocop-rspec', '~> 1.13.0'
+    gem 'rubocop',       '~> 0.48.1'
+    gem 'rubocop-rspec', '~> 1.15.0'
   end
 
   platforms :mri do

data/README.md

@@ -100,6 +100,7 @@ Reek is officially running on the following MRI rubies:
   - 2.1
   - 2.2
   - 2.3
+  - 2.4
 
 Other rubies like Rubinius or JRuby are not officially supported but should work as well.
 
@@ -475,7 +476,7 @@ Or just run the whole test suite:
 bundle exec rake
 ```
 
-This will run the RSpec tests, RuboCop and Reek itself.
+This will run the tests (RSpec and Cucumber), RuboCop and Reek itself.
 
 You can also run:
 
@@ -484,7 +485,7 @@ bundle exec rake ci
 ```
 
 This will run everything the default task runs and also
-our Cucumber features and [Ataru](https://github.com/CodePadawans/ataru). This is the task that we run on
+[Ataru](https://github.com/CodePadawans/ataru). This is the task that we run on
 Travis as well and that determines if your pull request is green or red.
 
 Another useful Rake task is the `console` task. This will throw you right into an environment where you can play around with Reeks modules and classes:

data/bin/code_climate_reek

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # Wrapper for the CodeClimate integration.
 

data/bin/reek

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 #
 # Reek examines Ruby source code for smells.
 # Visit https://wiki.github.com/troessner/reek for docs etc.

data/lib/reek.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 #
 # Reek's core functionality
 #

data/lib/reek/ast/ast_node_class_map.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'node'
 require_relative 'sexp_extensions'
 

data/lib/reek/ast/builder.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Reek
+  module AST
+    #
+    # An AST Builder for ruby parser.
+    #
+    class Builder < ::Parser::Builders::Default
+      # This is a work around for parsing ruby code that has a string with invliad sequence as UTF-8.
+      # See. https://github.com/whitequark/parser/issues/283
+      def string_value(token)
+        value(token)
+      end
+    end
+  end
+end

data/lib/reek/ast/node.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../cli/silencer'
 
 Reek::CLI::Silencer.silently do

data/lib/reek/ast/object_refs.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   # Represents functionality related to an Abstract Syntax Tree.
   module AST

data/lib/reek/ast/reference_collector.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     #

data/lib/reek/ast/sexp_extensions.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'reference_collector'
 
 require_relative 'sexp_extensions/arguments'

data/lib/reek/ast/sexp_extensions/arguments.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/attribute_assignments.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/block.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/case.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/constant.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/if.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/lambda.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/literal.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/logical_operators.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/methods.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/module.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/nested_assignables.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/self.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/send.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/super.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/symbols.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/variables.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/when.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/ast/sexp_extensions/yield.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module AST
     module SexpExtensions

data/lib/reek/cli/application.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'options'
 require_relative 'status'
 require_relative '../configuration/app_configuration'

data/lib/reek/cli/command/base_command.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module CLI
     module Command

data/lib/reek/cli/command/report_command.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'base_command'
 require_relative '../../examiner'
 require_relative '../../logging_error_handler'

data/lib/reek/cli/command/todo_list_command.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'base_command'
 require_relative '../../examiner'
 

data/lib/reek/cli/options.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'optparse'
 require 'rainbow'
 require_relative '../version'

data/lib/reek/cli/silencer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'stringio'
 
 module Reek

data/lib/reek/cli/status.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module CLI
     module Status

data/lib/reek/configuration/app_configuration.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'pathname'
 require_relative './configuration_file_finder'
 require_relative './configuration_validator'

data/lib/reek/configuration/configuration_file_finder.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'pathname'
 
 module Reek

data/lib/reek/configuration/configuration_validator.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module Configuration
     #

data/lib/reek/configuration/default_directive.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module Reek
   module Configuration
     #

data/lib/reek/configuration/directory_directives.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative './configuration_validator'
 
 module Reek

data/lib/reek/configuration/excluded_paths.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative './configuration_validator'
 
 module Reek

data/lib/reek/context/attribute_context.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'code_context'
 
 module Reek

data/lib/reek/context/class_context.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'module_context'
 
 module Reek

data/lib/reek/context/code_context.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative '../code_comment'
 require_relative '../ast/object_refs'
 require_relative 'statement_counter'
@@ -19,7 +20,7 @@ module Reek
       include Enumerable
       extend Forwardable
       delegate each_node: :exp
-      delegate %i(name type) => :exp
+      delegate [:name, :type] => :exp
 
       attr_reader :children, :parent, :exp, :statement_counter
 

data/lib/reek/context/ghost_context.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'code_context'
 require_relative 'singleton_method_context'
 

data/lib/reek/context/method_context.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require_relative 'code_context'
 
 module Reek
@@ -40,10 +41,10 @@ module Reek
 
       # :reek:FeatureEnvy
       def unused_params
-        exp.arguments.select do |param|
-          next if param.anonymous_splat?
-          next if param.marked_unused?
-          !uses_param? param.plain_name
+        exp.arguments.reject do |param|
+          param.anonymous_splat? ||
+            param.marked_unused? ||
+            uses_param?(param.plain_name)
         end
       end