reek 4.6.1 → 4.6.2
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.rubocop.yml +20 -0
- data/CHANGELOG.md +5 -0
- data/Gemfile +2 -2
- data/README.md +3 -2
- data/bin/code_climate_reek +1 -0
- data/bin/reek +1 -0
- data/lib/reek.rb +1 -0
- data/lib/reek/ast/ast_node_class_map.rb +1 -0
- data/lib/reek/ast/builder.rb +16 -0
- data/lib/reek/ast/node.rb +1 -0
- data/lib/reek/ast/object_refs.rb +1 -0
- data/lib/reek/ast/reference_collector.rb +1 -0
- data/lib/reek/ast/sexp_extensions.rb +1 -0
- data/lib/reek/ast/sexp_extensions/arguments.rb +1 -0
- data/lib/reek/ast/sexp_extensions/attribute_assignments.rb +1 -0
- data/lib/reek/ast/sexp_extensions/block.rb +1 -0
- data/lib/reek/ast/sexp_extensions/case.rb +1 -0
- data/lib/reek/ast/sexp_extensions/constant.rb +1 -0
- data/lib/reek/ast/sexp_extensions/if.rb +1 -0
- data/lib/reek/ast/sexp_extensions/lambda.rb +1 -0
- data/lib/reek/ast/sexp_extensions/literal.rb +1 -0
- data/lib/reek/ast/sexp_extensions/logical_operators.rb +1 -0
- data/lib/reek/ast/sexp_extensions/methods.rb +1 -0
- data/lib/reek/ast/sexp_extensions/module.rb +1 -0
- data/lib/reek/ast/sexp_extensions/nested_assignables.rb +1 -0
- data/lib/reek/ast/sexp_extensions/self.rb +1 -0
- data/lib/reek/ast/sexp_extensions/send.rb +1 -0
- data/lib/reek/ast/sexp_extensions/super.rb +1 -0
- data/lib/reek/ast/sexp_extensions/symbols.rb +1 -0
- data/lib/reek/ast/sexp_extensions/variables.rb +1 -0
- data/lib/reek/ast/sexp_extensions/when.rb +1 -0
- data/lib/reek/ast/sexp_extensions/yield.rb +1 -0
- data/lib/reek/cli/application.rb +1 -0
- data/lib/reek/cli/command/base_command.rb +1 -0
- data/lib/reek/cli/command/report_command.rb +1 -0
- data/lib/reek/cli/command/todo_list_command.rb +1 -0
- data/lib/reek/cli/options.rb +1 -0
- data/lib/reek/cli/silencer.rb +1 -0
- data/lib/reek/cli/status.rb +1 -0
- data/lib/reek/configuration/app_configuration.rb +1 -0
- data/lib/reek/configuration/configuration_file_finder.rb +1 -0
- data/lib/reek/configuration/configuration_validator.rb +1 -0
- data/lib/reek/configuration/default_directive.rb +1 -0
- data/lib/reek/configuration/directory_directives.rb +1 -0
- data/lib/reek/configuration/excluded_paths.rb +1 -0
- data/lib/reek/context/attribute_context.rb +1 -0
- data/lib/reek/context/class_context.rb +1 -0
- data/lib/reek/context/code_context.rb +2 -1
- data/lib/reek/context/ghost_context.rb +1 -0
- data/lib/reek/context/method_context.rb +5 -4
- data/lib/reek/context/module_context.rb +1 -0
- data/lib/reek/context/root_context.rb +1 -0
- data/lib/reek/context/send_context.rb +1 -0
- data/lib/reek/context/singleton_attribute_context.rb +1 -0
- data/lib/reek/context/singleton_method_context.rb +1 -0
- data/lib/reek/context/statement_counter.rb +1 -0
- data/lib/reek/context/visibility_tracker.rb +1 -0
- data/lib/reek/context_builder.rb +1 -0
- data/lib/reek/detector_repository.rb +1 -0
- data/lib/reek/errors/bad_detector_configuration_key_in_comment_error.rb +1 -0
- data/lib/reek/errors/bad_detector_in_comment_error.rb +1 -0
- data/lib/reek/errors/garbage_detector_configuration_in_comment_error.rb +1 -0
- data/lib/reek/errors/incomprehensible_source_error.rb +1 -0
- data/lib/reek/errors/parse_error.rb +1 -0
- data/lib/reek/examiner.rb +1 -0
- data/lib/reek/logging_error_handler.rb +1 -0
- data/lib/reek/report.rb +1 -0
- data/lib/reek/report/base_report.rb +1 -0
- data/lib/reek/report/code_climate.rb +1 -0
- data/lib/reek/report/code_climate/code_climate_configuration.rb +1 -0
- data/lib/reek/report/code_climate/code_climate_fingerprint.rb +1 -0
- data/lib/reek/report/code_climate/code_climate_formatter.rb +1 -0
- data/lib/reek/report/code_climate/code_climate_report.rb +1 -0
- data/lib/reek/report/formatter.rb +1 -0
- data/lib/reek/report/formatter/heading_formatter.rb +1 -0
- data/lib/reek/report/formatter/location_formatter.rb +1 -0
- data/lib/reek/report/formatter/progress_formatter.rb +1 -0
- data/lib/reek/report/formatter/wiki_link_warning_formatter.rb +1 -0
- data/lib/reek/report/html_report.rb +1 -0
- data/lib/reek/report/json_report.rb +1 -0
- data/lib/reek/report/text_report.rb +1 -0
- data/lib/reek/report/xml_report.rb +1 -0
- data/lib/reek/report/yaml_report.rb +1 -0
- data/lib/reek/smell_configuration.rb +1 -0
- data/lib/reek/smell_detectors.rb +1 -0
- data/lib/reek/smell_detectors/attribute.rb +1 -0
- data/lib/reek/smell_detectors/base_detector.rb +1 -0
- data/lib/reek/smell_detectors/boolean_parameter.rb +1 -0
- data/lib/reek/smell_detectors/class_variable.rb +1 -0
- data/lib/reek/smell_detectors/control_parameter.rb +1 -0
- data/lib/reek/smell_detectors/data_clump.rb +1 -0
- data/lib/reek/smell_detectors/duplicate_method_call.rb +1 -0
- data/lib/reek/smell_detectors/feature_envy.rb +1 -0
- data/lib/reek/smell_detectors/instance_variable_assumption.rb +1 -0
- data/lib/reek/smell_detectors/irresponsible_module.rb +1 -0
- data/lib/reek/smell_detectors/long_parameter_list.rb +1 -0
- data/lib/reek/smell_detectors/long_yield_list.rb +1 -0
- data/lib/reek/smell_detectors/manual_dispatch.rb +1 -0
- data/lib/reek/smell_detectors/module_initialize.rb +1 -0
- data/lib/reek/smell_detectors/nested_iterators.rb +1 -0
- data/lib/reek/smell_detectors/nil_check.rb +1 -0
- data/lib/reek/smell_detectors/prima_donna_method.rb +1 -0
- data/lib/reek/smell_detectors/repeated_conditional.rb +1 -0
- data/lib/reek/smell_detectors/subclassed_from_core_class.rb +1 -0
- data/lib/reek/smell_detectors/too_many_constants.rb +1 -0
- data/lib/reek/smell_detectors/too_many_instance_variables.rb +1 -0
- data/lib/reek/smell_detectors/too_many_methods.rb +1 -0
- data/lib/reek/smell_detectors/too_many_statements.rb +1 -0
- data/lib/reek/smell_detectors/uncommunicative_method_name.rb +1 -0
- data/lib/reek/smell_detectors/uncommunicative_module_name.rb +1 -0
- data/lib/reek/smell_detectors/uncommunicative_parameter_name.rb +1 -0
- data/lib/reek/smell_detectors/uncommunicative_variable_name.rb +1 -0
- data/lib/reek/smell_detectors/unused_parameters.rb +1 -0
- data/lib/reek/smell_detectors/unused_private_method.rb +3 -2
- data/lib/reek/smell_detectors/utility_function.rb +1 -0
- data/lib/reek/smell_warning.rb +1 -0
- data/lib/reek/source/source_code.rb +17 -3
- data/lib/reek/source/source_locator.rb +1 -0
- data/lib/reek/spec.rb +1 -0
- data/lib/reek/spec/should_reek.rb +1 -0
- data/lib/reek/spec/should_reek_of.rb +1 -0
- data/lib/reek/spec/should_reek_only_of.rb +1 -0
- data/lib/reek/spec/smell_matcher.rb +2 -1
- data/lib/reek/tree_dresser.rb +1 -0
- data/lib/reek/version.rb +2 -1
- data/reek.gemspec +2 -1
- data/spec/reek/ast/sexp_extensions_spec.rb +1 -0
- data/spec/reek/context/statement_counter_spec.rb +1 -0
- data/spec/reek/examiner_spec.rb +1 -0
- data/spec/reek/report/code_climate/code_climate_fingerprint_spec.rb +2 -0
- data/spec/reek/report/code_climate/code_climate_report_spec.rb +22 -22
- data/spec/reek/report/yaml_report_spec.rb +32 -32
- data/spec/reek/source/source_code_spec.rb +8 -1
- metadata +5 -4
data/lib/reek/context_builder.rb
CHANGED
data/lib/reek/examiner.rb
CHANGED
data/lib/reek/report.rb
CHANGED
data/lib/reek/smell_detectors.rb
CHANGED
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
# frozen_string_literal: true
|
|
2
|
+
|
|
2
3
|
require_relative 'base_detector'
|
|
3
4
|
|
|
4
5
|
module Reek
|
|
@@ -67,8 +68,8 @@ module Reek
|
|
|
67
68
|
defined_private_methods = ctx.defined_instance_methods(visibility: :private)
|
|
68
69
|
called_method_names = ctx.instance_method_calls.map(&:name)
|
|
69
70
|
|
|
70
|
-
defined_private_methods.
|
|
71
|
-
|
|
71
|
+
defined_private_methods.reject do |defined_method|
|
|
72
|
+
called_method_names.include?(defined_method.name)
|
|
72
73
|
end
|
|
73
74
|
end
|
|
74
75
|
|