reek 4.2.3 → 4.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: febd828ee14c493e88c62e3676181d9aed38cda2
-  data.tar.gz: a7d7d7a5dc1e964a21466b4c94d5e1c7ad5a1550
+  metadata.gz: 7756b10a94b5df5b45c50b6cdaa6577146dbbf15
+  data.tar.gz: d1e67defd358f1ce5f60affaa2c33e45aa09d744
 SHA512:
-  metadata.gz: f43c2262139ad0bfc26ed4fdc200480b4cdc228f7480ea65d62df34ec01339ce0feb9c1187c4be6a00be6199602ac638c44ae1fcffe3aaa1bcd31a4994243564
-  data.tar.gz: d6e90ce2c090073d73e9abe81fd95a430a56dc6aa07490e064383669a4e9bf7fc1be36393f545a83659f751ba1445705ccc5c0d607e6962456f1dc11c04a7617
+  metadata.gz: f2cbb1aacb409e57504ab7206b917648ad9e5db97a98302179a5902ab8a8b83335fcc674580f380f2314ec055f9c8be35156c1bab5d7b5ba6384429a8b42fdf9
+  data.tar.gz: 7476f5a7ce8dc2a0ab1f4791c1d5d0a4688b2462761f50775dd8404928faced642dfeedbbacbb2d3525e673003889fe3e7c643305bb92658ea397ad5fcdc4368

data/.rubocop.yml

@@ -1,6 +1,6 @@
 AllCops:
   Exclude:
-    - 'spec/samples/**/*'
+    - 'samples/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
   TargetRubyVersion: 2.1

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change log
 
+## 4.2.4 (2016-08-15)
+
+* (troessner) Make Reek more resilient on incomprehensible source.
+* (troessner) Make our parameter handling consistent in smell detectors.
+* (Drenmi) Rename `#inspect` method to `#sniff`
+
 ## 4.2.3 (2016-08-05)
 
 * (soutaro) Add SexpExtensions::CSendNode for safe navigation operator

data/CONTRIBUTING.md

@@ -10,8 +10,6 @@ only to find us suggesting large parts should be rewritten.
 Don’t hesitate to offer trivial fixes (spelling, better naming
 ideas, etc.) – we’ll let you know if you’re overdoing it. :)
 
-
-
 ## Reporting Issues
 
 Search [all existing (open _and_ closed)
@@ -29,8 +27,6 @@ version, Ruby platform (MRI, JRuby, etc.), operating system.
 Try to provide a minimal example that reproduces the issue.
 Extra kudos if you can write it as a failing test. :)
 
-
-
 ## Setup and Pull Request Basics
 
 Fork Reek, then clone it, make sure you have
@@ -55,8 +51,13 @@ Make sure you have read our [style guide](docs/style-guide.md) before you
 start contributing.
 
 Then start hacking and add new tests which make sure that your new feature works or
-demonstrate that your fix was needed; please also [write good commit
-messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
+demonstrate that your fix was needed.
+Reek is using [Rspec](http://rspec.info/) for unit and functional testing and [cucumber]() for integration tests.
+
+When it comes to Rspec we're trying to follow [betterspecs](http://betterspecs.org/).
+Additonally you can find an excellent cheat sheet on how to write idiomatic Rspec [here](http://www.rubypigeon.com/posts/rspec-core-cheat-sheet).
+
+We also care a lot about [good commit messages](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
 
 Once you’re happy with your feature / fix – or want to
 share it as a work-in-progress and request comments – once

data/Gemfile

@@ -10,9 +10,9 @@ group :development do
   gem 'mutant-rspec',  '~> 0.8.8'
   gem 'rake',          '~> 11.1'
   gem 'rspec',         '~> 3.0'
-  gem 'rubocop',       '~> 0.41.1'
+  gem 'rubocop',       '~> 0.42.0'
   gem 'simplecov',     '~> 0.12.0'
-  gem 'yard',          '~> 0.8.7'
+  gem 'yard',          '~> 0.9.5'
   gem 'activesupport', '~> 4.2'
 
   platforms :mri do

data/README.md

@@ -71,12 +71,11 @@ reek [options] [dir_or_source_file]*
 Imagine a source file `demo.rb` containing:
 
 ```Ruby
-class Dirty
-  # This method smells of :reek:NestedIterators but ignores them
-  def awful(x, y, offset = 0, log = false)
-    puts @screen.title
-    @screen = widgets.map { |w| w.each { |key| key += 3 * x } }
-    puts @screen.contents
+# Smelly class
+class Smelly
+  # This will reek of UncommunicativeMethodName
+  def x
+    y = 10 # This will reek of UncommunicativeVariableName
   end
 end
 ```
@@ -85,15 +84,9 @@ Reek will report the following code smells in this file:
 
 ```
 $ reek demo.rb
-demo.rb -- 8 warnings:
-  [1]:Dirty has no descriptive comment (IrresponsibleModule)
-  [3]:Dirty#awful has 4 parameters (LongParameterList)
-  [3]:Dirty#awful has boolean parameter 'log' (BooleanParameter)
-  [3]:Dirty#awful has the parameter name 'x' (UncommunicativeParameterName)
-  [5]:Dirty#awful has the variable name 'w' (UncommunicativeVariableName)
-  [3]:Dirty#awful has unused parameter 'log' (UnusedParameters)
-  [3]:Dirty#awful has unused parameter 'offset' (UnusedParameters)
-  [3]:Dirty#awful has unused parameter 'y' (UnusedParameters)
+demo.rb -- 2 warnings:
+  [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+  [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
 ```
 
 ## Supported rubies

data/Rakefile

@@ -4,5 +4,5 @@ require 'rake/clean'
 Dir['tasks/**/*.rake'].each { |t| load t }
 
 task local_test_run: [:test, :rubocop, 'test:quality']
-task ci: [:test, :rubocop, 'test:quality', :ataru, :mutant]
+task ci: [:test, :rubocop, 'test:quality', :ataru]
 task default: :local_test_run

data/defaults.reek

@@ -119,3 +119,4 @@ UnusedPrivateMethod:
 UtilityFunction:
   enabled: true
   exclude: []
+  public_methods_only: false

data/features/command_line_interface/basic_usage.feature

@@ -3,19 +3,13 @@ Feature: The Reek CLI maintains backwards compatibility
   As a developer
   I want to have a stable basic command line interface
 
-  Scenario: the demo example reports as expected
-    Given the smelly file 'demo.rb' from the example in the README
-    When I run reek demo.rb
+  Scenario: the example from README reports as expected
+    Given the smelly file 'smelly.rb'
+    When I run reek smelly.rb
     Then the exit status indicates smells
     And it reports:
-      """
-      demo.rb -- 8 warnings:
-        [3]:BooleanParameter: Dirty#awful has boolean parameter 'log' [https://github.com/troessner/reek/blob/master/docs/Boolean-Parameter.md]
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [3]:LongParameterList: Dirty#awful has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
-        [3]:UncommunicativeParameterName: Dirty#awful has the parameter name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Parameter-Name.md]
-        [5]:UncommunicativeVariableName: Dirty#awful has the variable name 'w' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
-        [3]:UnusedParameters: Dirty#awful has unused parameter 'log' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-        [3]:UnusedParameters: Dirty#awful has unused parameter 'offset' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-        [3]:UnusedParameters: Dirty#awful has unused parameter 'y' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-      """
+    """
+    smelly.rb -- 2 warnings:
+      [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+    """

data/features/command_line_interface/smell_selection.feature

@@ -4,12 +4,12 @@ Feature: Smell selection
   I want to be able to selectively activate smell detectors
 
   Scenario: --smell selects a smell to detect
-    Given a smelly file called 'smelly.rb'
-    And a configuration file masking some duplication smells called 'config.reek'
-    When I run reek --no-line-numbers --smell UncommunicativeMethodName smelly.rb
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'partial_mask.reek'
+    When I run reek --no-line-numbers --smell UncommunicativeVariableName smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
       smelly.rb -- 1 warning:
-        UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """

data/features/command_line_interface/smells_count.feature

@@ -3,15 +3,14 @@ Feature: Reports total number of code smells
   Reek outputs the total number of smells among all files inspected.
 
   Scenario: Does not output total number of smells when inspecting single file
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: Output total number of smells when inspecting multiple files
@@ -21,18 +20,17 @@ Feature: Reports total number of code smells
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      smelly/dirty_two.rb -- 3 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [3]:UncommunicativeMethodName: Dirty#b has the name 'b' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      5 total warnings
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      smelly/dirty_two.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      4 total warnings
       """
 
   Scenario: Output total number of smells even if total equals 0
-    Given a directory called 'clean_files' containing some clean files
-    When I run reek clean_files
+    Given a directory called 'clean' containing two clean files
+    When I run reek clean
     Then it succeeds
     And it reports:
       """

data/features/configuration_files/masking_smells.feature

@@ -4,8 +4,8 @@ Feature: Masking smells using config files
   I want to mask some smells using config files
 
   Scenario: corrupt config file prevents normal output
-    Given a smelly file called 'smelly.rb'
-    And a corrupt configuration file called 'corrupt.reek'
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'corrupt.reek'
     When I run reek -c corrupt.reek smelly.rb
     Then it reports the error 'Error: Invalid configuration file "corrupt.reek" -- Not a hash'
     And the exit status indicates an error
@@ -16,44 +16,51 @@ Feature: Masking smells using config files
     Then it reports the error "Error: No such file - not_here.rb"
 
   Scenario: masking smells in the configuration file
-    Given a smelly file called 'smelly.rb'
-    And a masking configuration file called 'config.reek'
-    When I run reek -c config.reek smelly.rb
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'full_mask.reek'
+    When I run reek -c full_mask.reek smelly.rb
     Then it succeeds
     And it reports nothing
 
   Scenario: allow masking some calls for duplication smell
-    Given a smelly file called 'smelly.rb'
-    And a configuration file masking some duplication smells called 'config.reek'
-    When I run reek -c config.reek smelly.rb
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'partial_mask.reek'
+    When I run reek -c partial_mask.reek smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 2 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 1 warning:
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: provide extra masking inline in comments
-    Given a smelly file with inline masking called 'inline.rb'
-    And a masking configuration file called 'config.reek'
-    When I run reek -c config.reek inline.rb
+    Given the smelly file 'smelly_with_inline_mask.rb'
+    And a configuration file 'partial_mask.reek'
+    When I run reek -c partial_mask.reek smelly_with_inline_mask.rb
+    Then it succeeds
+    And it reports nothing
+
+  Scenario: empty config file outputs normally
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'empty.reek'
+    When I run reek -c empty.reek smelly.rb
     Then the exit status indicates smells
     And it reports:
-      """
-      inline.rb -- 2 warnings:
-        [5]:UncommunicativeVariableName: Dirty has the variable name '@s' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
-        [5]:UncommunicativeVariableName: Dirty#a has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
-      """
+    """
+    smelly.rb -- 2 warnings:
+      [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+    """
+
 
   Scenario: Disable UtilityFunction for non-public methods
-    Given a smelly file called 'smelly.rb' with private, protected and public UtilityFunction methods
-    And a configuration file disabling UtilityFunction for non-public methods called 'config.reek'
-    When I run reek -c config.reek smelly.rb
+    Given the smelly file 'smelly_with_modifiers.rb'
+    And a configuration file 'non_public_modifiers_mask.reek'
+    When I run reek -c non_public_modifiers_mask.reek smelly_with_modifiers.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 1 warning:
-        [3]:UtilityFunction: Klass#public_method doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
+      smelly_with_modifiers.rb -- 1 warning:
+        [7]:UtilityFunction: Klass#public_method doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       """
     But it does not report private or protected methods

data/features/configuration_loading.feature

@@ -11,41 +11,38 @@ Feature: Offer different ways how to load configuration
     Reek will check these in order and stop after the first file found.
 
   Scenario: Default configuration
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: Configuration via CLI
-    Given a smelly file called 'smelly.rb'
-    And a masking configuration file called 'config.reek'
-    When I run reek -c config.reek smelly.rb
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'full_mask.reek'
+    When I run reek -c full_mask.reek smelly.rb
     Then it reports no errors
     And it succeeds
 
   Scenario: Configuration file in working directory
-    Given a smelly file called 'smelly.rb'
-    And a masking configuration file called 'config.reek'
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'full_mask.reek'
     When I run reek smelly.rb
     Then it reports no errors
     And it succeeds
 
   Scenario: Two opposing configuration files and we stop after the first one
-    Given a smelly file called 'smelly.rb' in a subdirectory
-    And an enabling configuration file in the subdirectory
-    And a masking configuration file called 'config.reek'
-    When I run "reek smelly.rb" in the subdirectory
+    Given the smelly file 'smelly.rb' in a subdirectory
+    And a configuration file 'partial_mask.reek' in a subdirectory
+    And a configuration file 'full_mask.reek'
+    When I run "reek smelly.rb" in a subdirectory
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 1 warning:
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """

data/features/programmatic_access.feature

@@ -4,7 +4,7 @@ Feature: Using Reek programmatically
   I want to be able to use its classes
 
   Scenario: Accessing smells found by an examiner
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     And a file named "examine.rb" with:
       """
       require 'reek'
@@ -17,13 +17,12 @@ Feature: Using Reek programmatically
     Then it reports no errors
     And it reports:
       """
-      calls @foo.bar 2 times
-      calls puts @foo.bar 2 times
-      has the name 'm'
+      has the name 'x'
+      has the variable name 'y'
       """
 
   Scenario: Using Reek's built-in report classes
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     And a file named "examine.rb" with:
       """
       require 'reek'
@@ -36,8 +35,7 @@ Feature: Using Reek programmatically
     Then it reports no errors
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        DuplicateMethodCall: Smelly#m calls @foo.bar 2 times
-        DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times
-        UncommunicativeMethodName: Smelly#m has the name 'm'
+      smelly.rb -- 2 warnings:
+        UncommunicativeMethodName: Smelly#x has the name 'x'
+        UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """

data/features/rake_task/rake_task.feature

@@ -3,7 +3,7 @@ Feature: Reek can be driven through its Task
   via the Task class. These scenarios test its various options.
 
   Scenario: source_files points at the desired files
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
@@ -14,14 +14,13 @@ Feature: Reek can be driven through its Task
     Then the exit status indicates an error
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: source_files using a FileList instead of a String
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
@@ -32,14 +31,13 @@ Feature: Reek can be driven through its Task
     Then the exit status indicates an error
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: name changes the task name
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run rake silky with:
       """
       Reek::Rake::Task.new('silky') do |t|
@@ -50,14 +48,13 @@ Feature: Reek can be driven through its Task
     Then the exit status indicates an error
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: verbose prints the reek command
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
@@ -69,7 +66,7 @@ Feature: Reek can be driven through its Task
     And stdout includes "Running 'reek' rake command"
 
   Scenario: fail_on_error can hide the error status
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
@@ -82,19 +79,18 @@ Feature: Reek can be driven through its Task
     And it succeeds
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
   Scenario: can be configured with config_file
-    Given a smelly file called 'smelly.rb'
-    And a masking configuration file called 'config.reek'
+    Given the smelly file 'smelly.rb'
+    And a configuration file 'full_mask.reek'
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
-        t.config_file  = 'config.reek'
+        t.config_file  = 'full_mask.reek'
         t.source_files = 'smelly.rb'
       end
       """