reek 4.2.3 → 4.2.4

data/features/reports/json.feature

@@ -3,8 +3,8 @@ Feature: Report smells using simple JSON layout
   output a list of smells in JSON.
 
   Scenario: output is empty when there are no smells
-    Given a directory called 'clean_files' containing some clean files
-    When I run reek --format json clean_files
+    Given a directory called 'clean' containing two clean files
+    When I run reek --format json clean
     Then it succeeds
     And it reports this JSON:
     """
@@ -12,40 +12,29 @@ Feature: Report smells using simple JSON layout
     """
 
   Scenario: Indicate smells and print them as JSON when using files
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek --format json smelly.rb
     Then the exit status indicates smells
     And it reports this JSON:
       """
       [
           {
-              "smell_type": "DuplicateMethodCall",
-              "source": "smelly.rb",
-              "context": "Smelly#m",
-              "lines": [ 4, 5 ],
-              "message": "calls @foo.bar 2 times",
-              "name": "@foo.bar",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md",
-              "count": 2
-          },
-          {
-              "smell_type": "DuplicateMethodCall",
+              "smell_type": "UncommunicativeMethodName",
               "source": "smelly.rb",
-              "context": "Smelly#m",
-              "lines": [ 4, 5 ],
-              "message": "calls puts @foo.bar 2 times",
-              "name": "puts @foo.bar",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md",
-              "count": 2
+              "context": "Smelly#x",
+              "lines": [ 4 ],
+              "message": "has the name 'x'",
+              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md",
+              "name": "x"
           },
           {
-              "smell_type": "UncommunicativeMethodName",
+              "smell_type": "UncommunicativeVariableName",
               "source": "smelly.rb",
-              "context": "Smelly#m",
-              "lines": [ 3 ],
-              "message": "has the name 'm'",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md",
-              "name": "m"
+              "context": "Smelly#x",
+              "lines": [ 5 ],
+              "message": "has the variable name 'y'",
+              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md",
+              "name": "y"
           }
       ]
       """
@@ -64,8 +53,7 @@ Feature: Report smells using simple JSON layout
                   1
               ],
               "message": "has no descriptive comment",
-              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md",
-              "name": "Turn"
+              "wiki_link": "https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md"
           }
       ]
       """

data/features/reports/reports.feature

@@ -10,13 +10,12 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      smelly/dirty_two.rb -- 3 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [3]:UncommunicativeMethodName: Dirty#b has the name 'b' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      5 total warnings
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      smelly/dirty_two.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      4 total warnings
       """
 
     Examples:
@@ -31,13 +30,12 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      smelly/dirty_two.rb -- 3 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [3]:UncommunicativeMethodName: Dirty#b has the name 'b' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      5 total warnings
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      smelly/dirty_two.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      4 total warnings
       """
 
     Examples:
@@ -52,14 +50,13 @@ Feature: Correctly formatted reports
     Then the exit status indicates smells
     And it reports:
       """
-      smelly/dirty_two.rb -- 3 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [3]:UncommunicativeMethodName: Dirty#b has the name 'b' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly/dirty_two.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       smelly/dirty_one.rb -- 2 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      5 total warnings
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      4 total warnings
       """
 
     Examples:
@@ -68,8 +65,8 @@ Feature: Correctly formatted reports
       | --sort-by s          |
 
   Scenario: good files show no headings by default
-    Given a directory called 'clean_files' containing some clean files
-    When I run reek clean_files
+    Given a directory called 'clean' containing two clean files
+    When I run reek clean
     Then it succeeds
     And it reports:
       """
@@ -77,14 +74,13 @@ Feature: Correctly formatted reports
       """
 
   Scenario Outline: --empty-headings turns on headings for fragrant files
-    Given a directory called 'clean_files' containing some clean files
-    When I run reek <option> clean_files
+    Given a directory called 'clean' containing two clean files
+    When I run reek <option> clean
     Then it succeeds
     And it reports:
       """
-      clean_files/clean_one.rb -- 0 warnings
-      clean_files/clean_three.rb -- 0 warnings
-      clean_files/clean_two.rb -- 0 warnings
+      clean/clean_one.rb -- 0 warnings
+      clean/clean_two.rb -- 0 warnings
       0 total warnings
       """
 
@@ -94,8 +90,8 @@ Feature: Correctly formatted reports
       | -V                |
 
   Scenario Outline: --no-empty-headings turns off headings for fragrant files
-    Given a directory called 'clean_files' containing some clean files
-    When I run reek <option> clean_files
+    Given a directory called 'clean' containing two clean files
+    When I run reek <option> clean
     Then it succeeds
     And it reports:
       """
@@ -108,15 +104,14 @@ Feature: Correctly formatted reports
       | -V --no-empty-headings |
 
   Scenario Outline: --no-line-numbers turns off line numbers
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
@@ -126,15 +121,14 @@ Feature: Correctly formatted reports
       | -V --no-line-numbers |
 
   Scenario Outline: --line-numbers turns on line numbers
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
@@ -144,15 +138,14 @@ Feature: Correctly formatted reports
       | --no-line-numbers -n             |
 
   Scenario Outline: --single-line shows filename and one line number
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        smelly.rb:4: DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        smelly.rb:4: DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        smelly.rb:3: UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        smelly.rb:4: UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        smelly.rb:5: UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
@@ -169,13 +162,12 @@ Feature: Correctly formatted reports
     And it reports:
       """
       smelly/dirty_one.rb -- 2 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      smelly/dirty_two.rb -- 3 warnings:
-        [1]:IrresponsibleModule: Dirty has no descriptive comment [https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md]
-        [2]:UncommunicativeMethodName: Dirty#a has the name 'a' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-        [3]:UncommunicativeMethodName: Dirty#b has the name 'b' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
-      5 total warnings
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      smelly/dirty_two.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
+      4 total warnings
       """
 
     Examples:
@@ -184,15 +176,14 @@ Feature: Correctly formatted reports
       | smelly  |
 
   Scenario Outline: -U or --wiki-links adds helpful links to smell warnings
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:
@@ -201,27 +192,25 @@ Feature: Correctly formatted reports
       | --wiki-links  |
 
   Scenario: --no-wiki-links drops links from smell warnings
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek --no-wiki-links smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        [4, 5]:DuplicateMethodCall: Smelly#m calls @foo.bar 2 times
-        [4, 5]:DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times
-        [3]:UncommunicativeMethodName: Smelly#m has the name 'm'
+      smelly.rb -- 2 warnings:
+        [4]:UncommunicativeMethodName: Smelly#x has the name 'x'
+        [5]:UncommunicativeVariableName: Smelly#x has the variable name 'y'
       """
 
   Scenario Outline: --wiki-links is independent of --line-numbers
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek <option> smelly.rb
     Then the exit status indicates smells
     And it reports:
       """
-      smelly.rb -- 3 warnings:
-        DuplicateMethodCall: Smelly#m calls @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        DuplicateMethodCall: Smelly#m calls puts @foo.bar 2 times [https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md]
-        UncommunicativeMethodName: Smelly#m has the name 'm' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+      smelly.rb -- 2 warnings:
+        UncommunicativeMethodName: Smelly#x has the name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md]
+        UncommunicativeVariableName: Smelly#x has the variable name 'y' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       """
 
     Examples:

data/features/reports/yaml.feature

@@ -3,8 +3,8 @@ Feature: Report smells using simple YAML layout
   output a list of smells in Yaml.
 
   Scenario: output is empty when there are no smells
-    Given a directory called 'clean_files' containing some clean files
-    When I run reek --format yaml clean_files
+    Given a directory called 'clean' containing two clean files
+    When I run reek --format yaml clean
     Then it succeeds
     And it reports this yaml:
     """
@@ -12,40 +12,28 @@ Feature: Report smells using simple YAML layout
     """
 
   Scenario: Indicate smells and print them as yaml when using files
-    Given a smelly file called 'smelly.rb'
+    Given the smelly file 'smelly.rb'
     When I run reek --format yaml smelly.rb
     Then the exit status indicates smells
     And it reports this yaml:
       """
       ---
-      - smell_type: DuplicateMethodCall
-        source: smelly.rb
-        context: Smelly#m
+      - context: Smelly#x
         lines:
         - 4
-        - 5
-        message: calls @foo.bar 2 times
-        name: "@foo.bar"
-        count: 2
-        wiki_link: https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md
-      - smell_type: DuplicateMethodCall
+        message: has the name 'x'
+        smell_type: UncommunicativeMethodName
         source: smelly.rb
-        context: Smelly#m
+        name: x
+        wiki_link: https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md
+      - context: Smelly#x
         lines:
-        - 4
         - 5
-        message: calls puts @foo.bar 2 times
-        name: puts @foo.bar
-        count: 2
-        wiki_link: https://github.com/troessner/reek/blob/master/docs/Duplicate-Method-Call.md
-      - smell_type: UncommunicativeMethodName
+        message: has the variable name 'y'
+        smell_type: UncommunicativeVariableName
         source: smelly.rb
-        context: Smelly#m
-        lines:
-        - 3
-        message: has the name 'm'
-        name: m
-        wiki_link: https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Method-Name.md
+        name: y
+        wiki_link: https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md
       """
 
   Scenario: Indicate smells and print them as yaml when using STDIN
@@ -60,6 +48,5 @@ Feature: Report smells using simple YAML layout
         lines:
         - 1
         message: has no descriptive comment
-        name: Turn
         wiki_link: https://github.com/troessner/reek/blob/master/docs/Irresponsible-Module.md
       """

data/features/samples.feature

@@ -4,9 +4,9 @@ Feature: Basic smell detection
   I want to detect the smells in my Ruby code
 
   Scenario: Correct smells from inline.rb
-    Given the "inline.rb" sample file exists
-    And the "optparse.rb" sample file exists
-    And the "redcloth.rb" sample file exists
+    Given the smelly file 'inline.rb'
+    And the smelly file 'optparse.rb'
+    And the smelly file 'redcloth.rb'
     When I run reek --no-line-numbers inline.rb optparse.rb redcloth.rb
     Then the exit status indicates smells
     And it reports:

data/features/step_definitions/sample_file_steps.rb

@@ -1,181 +1,47 @@
-Given(/^the smelly file 'smelly.rb'$/) do
-  contents = <<-EOS.strip_heredoc
-    class Smelly
-      def x; end
-    end
-  EOS
-  write_file('smelly.rb', contents)
+require_relative '../../samples/paths'
+
+Given(/^the smelly file '(.+)'$/) do |filename|
+  write_file(filename, SAMPLES_PATH.join(filename).read)
 end
 
 Given(/^the clean file 'clean.rb'$/) do
-  contents = <<-EOS.strip_heredoc
-    # Explanatory comment
-    class Clean
-      def foo; end
-    end
-  EOS
-  write_file('clean.rb', contents)
+  write_file('clean.rb', CLEAN_FILE.read)
 end
 
-Given(/^the smelly file 'demo.rb' from the example in the README$/) do
-  contents = <<-EOS.strip_heredoc
-    class Dirty
-      # This method smells of :reek:NestedIterators but ignores them
-      def awful(x, y, offset = 0, log = false)
-        puts @screen.title
-        @screen = widgets.map {|w| w.each {|key| key += 3 * x}}
-        puts @screen.contents
-      end
-    end
-  EOS
-  write_file('demo.rb', contents)
-end
+Given(/^a directory called 'clean' containing two clean files$/) do
+  contents = CLEAN_FILE.read
 
-Given(/^a smelly file with inline masking called 'inline.rb'$/) do
-  write_file 'inline.rb', <<-EOS.strip_heredoc
-    # smells of :reek:NestedIterators but ignores them
-    class Dirty
-      def a
-        puts @s.title
-        @s = foo.map {|x| x.each {|key| key += 3}}
-        puts @s.title
-      end
-    end
-  EOS
-end
-
-Given(/^the "(.*?)" sample file exists$/) do |file_name|
-  full_path = Pathname.new("#{__dir__}/../../spec/samples/#{file_name}")
-  cd('.') { FileUtils.cp full_path, file_name }
-end
-
-Given(/^a directory called 'clean_files' containing some clean files$/) do
-  contents = <<-EOS.strip_heredoc
-    # clean class for testing purposes
-    class Clean
-      def assign
-        puts @sub.title
-        @sub.map {|para| para.name }
-      end
-    end
-  EOS
-  write_file 'clean_files/clean_one.rb', contents
-  write_file 'clean_files/clean_two.rb', contents
-  write_file 'clean_files/clean_three.rb', contents
+  write_file('clean/clean_one.rb', contents)
+  write_file('clean/clean_two.rb', contents)
 end
 
 Given(/^a directory called 'smelly' containing two smelly files$/) do
-  write_file('smelly/dirty_one.rb', <<-EOS.strip_heredoc)
-    class Dirty
-      def a; end
-    end
-  EOS
-  write_file('smelly/dirty_two.rb', <<-EOS.strip_heredoc)
-    class Dirty
-      def a; end
-      def b; end
-    end
-  EOS
-end
-
-Given(/^a smelly file called 'smelly.rb'( in a subdirectory)?$/) do |in_subdir|
-  file_name = in_subdir ? 'subdir/smelly.rb' : 'smelly.rb'
-  write_file file_name, <<-EOS.strip_heredoc
-    # smelly class for testing purposes
-    class Smelly
-      def m
-        puts @foo.bar
-        puts @foo.bar
-      end
-    end
-  EOS
-end
+  contents = SMELLY_FILE.read
 
-Given(/^an empty configuration file called 'empty.reek'$/) do
-  write_file('empty.reek', '')
+  write_file('smelly/dirty_one.rb', contents)
+  write_file('smelly/dirty_two.rb', contents)
 end
 
-Given(/^a corrupt configuration file called 'corrupt.reek'$/) do
-  write_file('corrupt.reek', 'This is not a configuration file')
-end
-
-Given(/^a masking configuration file called 'config.reek'$/) do
-  write_file('config.reek', <<-EOS.strip_heredoc)
-    ---
-    DuplicateMethodCall:
-      enabled: false
-    UncommunicativeMethodName:
-      enabled: false
-  EOS
-end
+Given(/^the smelly file '(.+)' in a subdirectory$/) do |filename|
+  contents = SAMPLES_PATH.join(filename).read
 
-Given(/^a configuration file masking some duplication smells called 'config.reek'$/) do
-  write_file('config.reek', <<-EOS.strip_heredoc)
-    ---
-    DuplicateMethodCall:
-      allow_calls:
-        - puts @foo.bar
-  EOS
+  write_file("subdir/#{filename}", contents)
 end
 
-Given(/^a configuration file disabling DuplicateMethodCall called 'config.reek'$/) do
-  write_file('config.reek', <<-EOS.strip_heredoc)
-    ---
-    DuplicateMethodCall:
-      enabled: false
-  EOS
+Given(/^a configuration file '(.+)'$/) do |filename|
+  write_file(filename, CONFIG_PATH.join(filename).read)
 end
 
-When(/^I run "reek (.*?)" in the subdirectory$/) do |args|
+When(/^I run "reek (.*?)" in a subdirectory$/) do |args|
   cd 'subdir'
-  reek(args)
-end
 
-Given(/^a masking configuration file in the HOME directory$/) do
-  set_environment_variable 'HOME', Pathname.new("#{expand_path('.')}/home")
-  write_file('home/config.reek', <<-EOS.strip_heredoc)
-    ---
-    DuplicateMethodCall:
-      enabled: false
-    UncommunicativeMethodName:
-      enabled: false
-  EOS
-end
-
-Given(/^an enabling configuration file in the subdirectory$/) do
-  write_file('subdir/config.reek', <<-EOS.strip_heredoc)
-    ---
-    IrresponsibleModule:
-      enabled: true
-    UncommunicativeModuleName:
-      enabled: true
-    UncommunicativeMethodName:
-      enabled: true
-  EOS
+  reek(args)
 end
 
-Given(/^a smelly file called 'smelly.rb' with private, protected and public UtilityFunction methods$/) do
-  write_file 'smelly.rb', <<-EOS.strip_heredoc
-    # smelly class for testing purposes
-    class Klass
-      def public_method(arg) arg.to_s; end
-      protected
-      def protected_method(arg) arg.to_s; end
-      private
-      def private_method(arg) arg.to_s; end
-    end
-  EOS
-end
+Given(/^a configuration file '(.+)' in a subdirectory$/) do |filename|
+  contents = CONFIG_PATH.join(filename).read
 
-Given(/^a configuration file disabling UtilityFunction for non-public methods called 'config.reek'$/) do
-  write_file('config.reek', <<-EOS.strip_heredoc)
-    ---
-    UtilityFunction:
-      public_methods_only: true
-    # Not necessary for the feature per se but for removing distracting output.
-    UnusedPrivateMethod:
-      enabled: false
-  EOS
+  write_file("subdir/#{filename}", contents)
 end
 
 Then(/^it does not report private or protected methods$/) do