reek 1.5.1 → 1.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c45202c174ceb4196695ec6f2a5b6a823c14d06
-  data.tar.gz: 34ec72fa7a3dc9cb07d40258e178ee8ab066e3b8
+  metadata.gz: b1a9764f875a3808e5f529ed5a9ec7491fb4056b
+  data.tar.gz: 756f9677be1f8bb5f4cd435662d6265d935ff1ca
 SHA512:
-  metadata.gz: b2b8bf4eee7cba82e33ce1f2dbc6768c786829599d64d175d3eb232d82b3d9e6c605111ae0723e9164697ae9718194a4f91078cc4a6e130341b4bac1f178ed60
-  data.tar.gz: 52242fe4f536bb3d2bb2de1777b4cd77232307047392ad308542d0f1f62d4ecf337a8e7f78f892e6de95459accbbf17e7a1a1732fbce3bce924f82bb80e4d81f
+  metadata.gz: 9d8f6a8beb542047a0da14b1624020ba3e1cbabccedca54c7d210f893771ac69811c202ccbce6db942e682fe95483c89e050cab1360428ef46cc13ccf4c9766e
+  data.tar.gz: f081828271bc3311fb38409fd8cdf69f081e1e552cb848dabfc9232d5b910bdfbdfbe279d9b5faf5c88aa60651f1a54e2c9a36c17ab83f9b98dce66d422f687c

data/CHANGELOG

@@ -1,3 +1,12 @@
+== 1.6.0
+
+* (troessner) Revise configuration handling:
+  Now there are 3 ways of passing reek a configuration file:
+  - Using the cli "-c" switch
+  - Having a file ending with .reek either in your current working directory or in a parent directory (more on that later)
+  - Having a file ending with .reek in your HOME directory
+  The order in which reek tries to find such a configuration file is exactly like above: First reek checks if we have given it a configuration file explicitly via CLI. Then it checks the current working directory for a file and if it can't find one, it traverses up the directories until it hits the root directory. And lastly, it checks your HOME directory.
+  As soon as reek detects a configuration file it stops searching immediately, meaning that from reek's point of view there exists one configuration file and one configuration only regardless of how many ".reek" files you might have on your filesystem.
 * (chastell) Add keyword arguments support after switching to 'parser'
 * (mvz) Handle nil-block in iterators
 

data/README.md

@@ -60,6 +60,8 @@ spec/samples/demo/demo.rb -- 6 warnings:
 
 ## Configuration
 
+### Command line interface
+
 For a basic overview, run
 
 ```Ruby
@@ -68,11 +70,58 @@ reek --help
 
 For a summary of those CLI options see [Command-Line Options](https://github.com/troessner/reek/wiki/Command-Line-Options).
 
-Apart from that, `reek` offers quite a few ways for configuring it:
+### Configuration files
+
+#### Configuration loading
+
+Configuring `reek` via configuration file is by far the most powerful way.
+
+There are 3 ways of passing `reek` a configuration file:
+
+1. Using the cli "-c" switch (see "Command line interface" above)
+2. Having a file ending with .reek either in your current working directory or in a parent directory (more on that later)
+3. Having a file ending with .reek in your HOME directory
+
+The order in which `reek` tries to find such a configuration file is exactly like above: First `reek` checks if we have given it a configuration file explicitly via CLI. Then it checks the current working directory for a file and if it can't find one, it traverses up the directories until it hits the root directory. And lastly, it checks your HOME directory.
+
+As soon as `reek` detects a configuration file it stops searching immediately, meaning that from `reek`'s point of view there exists one configuration file and one configuration only regardless of how many ".reek" files you might have on your filesystem.
+
+#### Configuration options
+
+The first thing you probably want to check out are the [Basic Smell Options](https://github.com/troessner/reek/wiki/Basic-Smell-Options) which are supported by every smell type.
+Certain smell types offer a configuration that goes beyond that of the basic smell options - for instance [Data Clump](https://github.com/troessner/reek/wiki/Data-Clump).
+All options that go beyond the [Basic Smell Options](https://github.com/troessner/reek/wiki/Basic-Smell-Options) should be documented in the corresponding smell type wiki page but if you want to get a quick and full overview over all possible configurations you can always check out [the default.reek file in this repository](https://github.com/troessner/reek/blob/master/config/defaults.reek).
+
+Here's an excerpt of a `reek` configuration file from a commercial project:
+
+```yaml
+---
+IrresponsibleModule:
+  enabled: false
+NestedIterators:
+  exclude:
+    - "ActiveModelErrorAdder#self.run" # should be refactored
+    - "BookingRequests::Transfer#remote_validation"
+    - "BookingRequestsController#vehicle_options" # respond_to block
+    - "Content::Base#self.expose_fields" # unavoidable due to metaprogramming
+DataClump:
+  max_copies: 3
+  min_clump_size: 3
+```
+
+### Source code comments
+
+`reek` is not the police. In case you need to suppress a smell warning and you can't or don't want to use configuration files for whatever reasons you can also use source code comments like this:
+
+```Ruby
+# This method smells of :reek:NestedIterators
+def smelly_method foo
+  foo.each {|bar| bar.each {|baz| baz.qux}}
+end
+```
+
+This is further explained [here](https://github.com/troessner/reek/wiki/Smell-Suppression)
 
-* The first thing you probably want to check out are the [Basic Smell Options](https://github.com/troessner/reek/wiki/Basic-Smell-Options)
-* `reek` is not the police. In case you need to suppress a smell warning for whatever reasons have a look at [Smell Suppression](https://github.com/troessner/reek/wiki/Smell-Suppression)
-* Lastly there are a couple of ways to configure `reek` via [Configuration Files](https://github.com/troessner/reek/wiki/Configuration-Files)
 
 ## Integration
 
@@ -113,7 +162,7 @@ bundle exec rake
 
 From then on continue by following the establish [pull request workflow](https://help.github.com/articles/using-pull-requests/).
 
-If you don't feel like getting your hands dirty with code there a still other ways you can help us:
+If you don't feel like getting your hands dirty with code there are still other ways you can help us:
 
 * Work on the [wiki](https://github.com/troessner/reek/wiki)
 * Open up an [issue](https://github.com/troessner/reek/issues) and report bugs or suggest other improvements

data/Rakefile

@@ -3,4 +3,4 @@ require 'bundler/gem_tasks'
 
 Dir['tasks/**/*.rake'].each { |t| load t }
 
-task default: [:test]
+task default: [:test, :rubocop]

data/features/command_line_interface/smell_selection.feature

@@ -9,11 +9,11 @@ Feature: Smell selection
     And it reports:
       """
       spec/samples/two_smelly_files/dirty_one.rb -- 2 warnings:
-        Dirty#a calls @s.title twice (DuplicateMethodCall)
-        Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
       spec/samples/two_smelly_files/dirty_two.rb -- 2 warnings:
-        Dirty#a calls @s.title twice (DuplicateMethodCall)
-        Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
       4 total warnings
 
       """

data/features/command_line_interface/smells_count.feature

@@ -4,16 +4,17 @@ Feature: Reports total number of code smells
   Reek outputs the total number of smells among all files inspected.
 
   Scenario: Does not output total number of smells when inspecting single file
-    When I run reek spec/samples/not_quite_masked/dirty.rb
+    When I run reek spec/samples/standard_smelly/dirty.rb
     Then the exit status indicates smells
     And it reports:
     """
-    spec/samples/not_quite_masked/dirty.rb -- 5 warnings:
+    spec/samples/standard_smelly/dirty.rb -- 6 warnings:
       [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-      [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-      [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+      [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+      [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
       [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
       [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
+      [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
     """
 
   Scenario: Output total number of smells when inspecting multiple files
@@ -23,15 +24,15 @@ Feature: Reports total number of code smells
     """
     spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings:
       [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-      [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-      [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+      [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+      [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
       [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
       [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
       [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
     spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings:
       [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-      [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-      [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+      [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+      [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
       [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
       [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
       [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)

data/features/configuration_files/masking_smells.feature

@@ -5,22 +5,22 @@ Feature: Masking smells using config files
   I want to mask some smells using config files
 
   Scenario: empty config file is ignored
-    When I run reek spec/samples/empty_config_file/dirty.rb
+    When I run reek -c spec/samples/empty_config_file/empty.reek spec/samples/empty_config_file/dirty.rb
     Then it reports the error 'Warning: Invalid configuration file "empty.reek" -- Empty file'
     And the exit status indicates smells
     And it reports:
       """
       spec/samples/empty_config_file/dirty.rb -- 6 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
       """
 
   Scenario: corrupt config file prevents normal output
-    When I run reek spec/samples/corrupt_config_file
+    When I run reek -c spec/samples/corrupt_config_file/corrupt.reek spec/samples/corrupt_config_file
     Then it reports the error 'Error: Invalid configuration file "corrupt.reek" -- Not a hash'
     And the exit status indicates an error
     And it reports:
@@ -28,84 +28,49 @@ Feature: Masking smells using config files
       """
 
   Scenario: missing source file is an error
-    When I run reek no_such_file.rb spec/samples/masked/dirty.rb
-    Then the exit status indicates smells
-    And it reports:
-      """
-      spec/samples/masked/dirty.rb -- 3 warnings:
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-      """
-    And it reports the error "Error: No such file - no_such_file.rb"
+    When I run reek spec/samples/missing_source_file/dirty.rb
+    Then it reports the error "Error: No such file - spec/samples/missing_source_file/dirty.rb"
 
   Scenario: switch off one smell
-    When I run reek spec/samples/masked/dirty.rb
+    When I run reek -c spec/samples/masked/masked.reek spec/samples/masked/dirty.rb
     Then the exit status indicates smells
     And it reports:
       """
       spec/samples/masked/dirty.rb -- 3 warnings:
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
       """
 
   Scenario: non-masked smells are only counted once
-    When I run reek spec/samples/not_quite_masked/dirty.rb
+    When I run reek -c spec/samples/not_quite_masked/masked.reek spec/samples/not_quite_masked/dirty.rb
     Then the exit status indicates smells
     And it reports:
       """
       spec/samples/not_quite_masked/dirty.rb -- 5 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
       """
 
-  @overrides
-  Scenario: lower overrides upper
-    When I run reek spec/samples/overrides
-    Then the exit status indicates smells
-    And it reports:
-      """
-      spec/samples/overrides/masked/dirty.rb -- 2 warnings:
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
-      """
-
   Scenario: allow masking some calls for duplication smell
-    When I run reek spec/samples/mask_some/dirty.rb
+    When I run reek -c spec/samples/mask_some/some.reek spec/samples/mask_some/dirty.rb
     Then the exit status indicates smells
     And it reports:
       """
       spec/samples/mask_some/dirty.rb -- 2 warnings:
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
       """
 
   @comments
   Scenario: provide extra masking inline in comments
-    When I run reek spec/samples/inline_config
+    When I run reek -c spec/samples/inline_config/masked.reek spec/samples/inline_config
     Then the exit status indicates smells
     And it reports:
       """
       spec/samples/inline_config/dirty.rb -- 1 warning:
-        [5, 7]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-      """
-
-  Scenario: supports a config file
-    When I run reek -c spec/samples/config/allow_duplication.reek spec/samples/masked/dirty.rb
-    Then the exit status indicates smells
-    And it reports:
-      """
-      spec/samples/masked/dirty.rb -- 1 warning:
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
-      """
-
-  Scenario: supports multiple config files
-    When I run reek -c spec/samples/config/allow_duplication.reek -c spec/samples/config/deeper_nested_iterators.reek spec/samples/masked/dirty.rb
-    Then it succeeds
-    And it reports:
-      """
+        [5, 7]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
       """

data/features/configuration_files/overrides_defaults.feature

@@ -5,7 +5,7 @@ Feature: Overriding current rules by specifying new configuration values
   I want to be able to override the default configuration values
 
   Scenario: List of configuration values is overridden by a lower config file
-    When I run reek spec/samples/overrides_defaults/camel_case.rb
+    When I run reek -c spec/samples/overrides_defaults/config.reek spec/samples/overrides_defaults/camel_case.rb
     Then the exit status indicates smells
     And it reports:
       """

data/features/rake_task/rake_task.feature

@@ -7,34 +7,34 @@ Feature: Reek can be driven through its Task
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
-        t.source_files = 'spec/samples/masked/dirty.rb'
+        t.source_files = 'spec/samples/standard_smelly/minimal_dirty.rb'
         t.reek_opts = '--no-color'
       end
       """
     Then the exit status indicates an error
     And it reports:
       """
-      spec/samples/masked/dirty.rb -- 3 warnings:
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
+      spec/samples/standard_smelly/minimal_dirty.rb -- 3 warnings:
+        [1]:C has no descriptive comment (IrresponsibleModule)
+        [1]:C has the name 'C' (UncommunicativeModuleName)
+        [2]:C#m has the name 'm' (UncommunicativeMethodName)
       """
 
   Scenario: name changes the task name
     When I run rake silky with:
       """
       Reek::Rake::Task.new('silky') do |t|
-        t.source_files = 'spec/samples/masked/dirty.rb'
+        t.source_files = 'spec/samples/standard_smelly/minimal_dirty.rb'
         t.reek_opts = '--no-color'
       end
       """
     Then the exit status indicates an error
     And it reports:
       """
-      spec/samples/masked/dirty.rb -- 3 warnings:
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
-        [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
+      spec/samples/standard_smelly/minimal_dirty.rb -- 3 warnings:
+        [1]:C has no descriptive comment (IrresponsibleModule)
+        [1]:C has the name 'C' (UncommunicativeModuleName)
+        [2]:C#m has the name 'm' (UncommunicativeMethodName)
       """
 
   Scenario: verbose prints the reek command
@@ -63,8 +63,8 @@ Feature: Reek can be driven through its Task
       """
       spec/samples/no_config_file/dirty.rb -- 6 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
@@ -74,8 +74,8 @@ Feature: Reek can be driven through its Task
     When I run rake reek with:
       """
       Reek::Rake::Task.new do |t|
-        t.config_files = 'spec/samples/config/**/*.reek'
-        t.source_files = 'spec/samples/masked/dirty.rb'
+        t.config_file  = 'spec/samples/minimal_smelly_and_masked/config.reek'
+        t.source_files = 'spec/samples/minimal_smelly_and_masked/minimal_dirty.rb'
       end
       """
     Then it succeeds

data/features/reports/reports.feature

@@ -11,15 +11,15 @@ Feature: Correctly formatted reports
       """
       spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
       spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
@@ -122,16 +122,17 @@ Feature: Correctly formatted reports
       | -V --quiet    |
 
   Scenario Outline: --line-number turns off line numbers
-    When I run reek <option> spec/samples/not_quite_masked/dirty.rb
+    When I run reek <option> spec/samples/standard_smelly/dirty.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/not_quite_masked/dirty.rb -- 5 warnings:
+      spec/samples/standard_smelly/dirty.rb -- 6 warnings:
         Dirty has the variable name '@s' (UncommunicativeVariableName)
-        Dirty#a calls @s.title twice (DuplicateMethodCall)
-        Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         Dirty#a contains iterators nested 2 deep (NestedIterators)
         Dirty#a has the name 'a' (UncommunicativeMethodName)
+        Dirty#a has the variable name 'x' (UncommunicativeVariableName)
       """
 
     Examples:
@@ -142,16 +143,17 @@ Feature: Correctly formatted reports
       | -V -n             |
 
   Scenario Outline: --single-line shows filename and one line number
-    When I run reek <option> spec/samples/not_quite_masked/dirty.rb
+    When I run reek <option> spec/samples/standard_smelly/dirty.rb
     Then the exit status indicates smells
     And it reports:
       """
-      spec/samples/not_quite_masked/dirty.rb -- 5 warnings:
-        spec/samples/not_quite_masked/dirty.rb:5: Dirty has the variable name '@s' (UncommunicativeVariableName)
-        spec/samples/not_quite_masked/dirty.rb:4: Dirty#a calls @s.title twice (DuplicateMethodCall)
-        spec/samples/not_quite_masked/dirty.rb:4: Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
-        spec/samples/not_quite_masked/dirty.rb:5: Dirty#a contains iterators nested 2 deep (NestedIterators)
-        spec/samples/not_quite_masked/dirty.rb:3: Dirty#a has the name 'a' (UncommunicativeMethodName)
+      spec/samples/standard_smelly/dirty.rb -- 6 warnings:
+        spec/samples/standard_smelly/dirty.rb:5: Dirty has the variable name '@s' (UncommunicativeVariableName)
+        spec/samples/standard_smelly/dirty.rb:4: Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        spec/samples/standard_smelly/dirty.rb:4: Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
+        spec/samples/standard_smelly/dirty.rb:5: Dirty#a contains iterators nested 2 deep (NestedIterators)
+        spec/samples/standard_smelly/dirty.rb:3: Dirty#a has the name 'a' (UncommunicativeMethodName)
+        spec/samples/standard_smelly/dirty.rb:5: Dirty#a has the variable name 'x' (UncommunicativeVariableName)
       """
 
     Examples:
@@ -168,15 +170,15 @@ Feature: Correctly formatted reports
       """
       spec/samples/two_smelly_files/dirty_one.rb -- 6 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)
       spec/samples/two_smelly_files/dirty_two.rb -- 6 warnings:
         [5]:Dirty has the variable name '@s' (UncommunicativeVariableName)
-        [4, 6]:Dirty#a calls @s.title twice (DuplicateMethodCall)
-        [4, 6]:Dirty#a calls puts(@s.title) twice (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls @s.title 2 times (DuplicateMethodCall)
+        [4, 6]:Dirty#a calls puts(@s.title) 2 times (DuplicateMethodCall)
         [5]:Dirty#a contains iterators nested 2 deep (NestedIterators)
         [3]:Dirty#a has the name 'a' (UncommunicativeMethodName)
         [5]:Dirty#a has the variable name 'x' (UncommunicativeVariableName)